1. 14 Nov, 2022 1 commit
    • Marko Mäkelä's avatar
      Clean up file load.in in a test · 1895c769
      Marko Mäkelä authored
      This fixes the following test invocation:
      ./mtr --no-reorder parts.partition_special_myisam parts.partition_debug
      
      This was broken ever since afd4b25d
      a.k.a. mysql/mysql-server@bde21e58108a1f311d15088c50414bb43ab45d62
      1895c769
  2. 11 Nov, 2022 1 commit
  3. 10 Nov, 2022 1 commit
    • Daniel Black's avatar
      MDEV-27882 Innodb - recognise MySQL-8.0 innodb flags and give a specific error message · dc6a0171
      Daniel Black authored
      Per fsp0types.h, SDI is on tablespace flags position 14 where MariaDB
      stores its pagesize. Flag at position 13, also in MariaDB pagesize
      flags, is a MySQL encryption flag.
      
      These are checked only if fsp_flags_is_valid fails, so valid MariaDB
      pages sizes don't become errors.
      
      The error message "Cannot reset LSNs in table" was rather specific and
      not always true to replaced with more generic error.
      
      ALTER TABLE tbl IMPORT TABLESPACE now reports Unsupported on MySQL
      tablespace (rather than index corrupted) along with a server error
      message.
      
      MySQL innodb Errors are with with UNSUPPORTED rather than CORRUPTED
      to avoid user anxiety.
      
      Reviewer: Marko Mäkelä
      dc6a0171
  4. 09 Nov, 2022 3 commits
    • Vlad Lesin's avatar
      MDEV-10087 mysqld_update()/mysql_delete() continues execution even after... · 0235a528
      Vlad Lesin authored
      MDEV-10087 mysqld_update()/mysql_delete() continues execution even after subquery with JOIN gets error from storage engine
      
      The issue is that record_should_be_deleted() returns true in
      mysql_delete() even if sub-select with join gets error from storage
      engine when DELETE FROM ... WHERE ... IN (SELECT ...) statement is
      executed.
      
      The same is true for mysql_update() where select->skip_record() returns
      true even if sub-select with join gets error from storage engine.
      
      In the test case if sub-select is chosen as deadlock victim the whole
      transaction is rolled back during sub-select execution, but
      mysql_delete()/mysql_update() continues transaction execution and invokes
      table->delete_row() as record_should_be_deleted() wrongly returns true
      in mysql_delete() and table->update_row() as select->skip_record(thd)
      wrongly returns 1 for mysql_update().
      
      record_should_be_deleted() wrogly returns true because thd->is_error()
      returns false SQL_SELECT::skip_record() invoked from
      record_should_be_deleted().
      
      It's supposed that THD error should be set in rr_handle_error() called
      from rr_sequential() during sub-select JOIN::exec_inner() execution.
      
      But rr_handle_error() does not set THD error because
      READ_RECORD::print_error is not set in JOIN_TAB::read_record.
      
      READ_RECORD::print_error should be initialized in
      init_read_record()/init_read_record_idx(). But make_join_readinfo() does
      not invoke init_read_record()/init_read_record_idx() for
      JOIN_TAB::read_record.
      
      The fix is to set JOIN_TAB::read_record.print_error in
      make_join_readinfo(), i.e. in the same place where
      JOIN_TAB::read_record.table is set.
      
      Reviewed by Sergey Petrunya.
      0235a528
    • asklavou's avatar
    • Marko Mäkelä's avatar
      MDEV-29883 Deadlock between InnoDB statistics update and BLOB insert · 6b91792a
      Marko Mäkelä authored
      This is a backport of commit 8b6a308e
      from MariaDB Server 10.6.11. No attempt to reproduce the hang
      in earlier an earlier version of MariaDB Server than 10.6 was made.
      
      In each caller of fseg_n_reserved_pages() except ibuf_init_at_db_start()
      which is a special case for ibuf.index at database startup, we must hold
      an index latch that prevents concurrent allocation or freeing of index
      pages.
      
      Any operation that allocates or free pages that belong to an index tree
      must first acquire an index latch in non-shared mode, and while
      holding that, acquire an index root page latch in non-shared mode.
      
      btr_get_size(), btr_get_size_and_reserved(): Assert that a strong enough
      index latch is being held.
      
      dict_stats_update_transient_for_index(),
      dict_stats_analyze_index(): Acquire a strong enough index latch.
      
      These operations had followed the same order of acquiring latches in
      every InnoDB version since the very beginning
      (commit c533308a).
      
      The hang was introduced in
      commit 2e814d47 which imported
      mysql/mysql-server@ac74632293bea967b352d1b472abedeeaa921b98
      which failed to strengthen the locking requirements of the function
      btr_get_size().
      6b91792a
  5. 08 Nov, 2022 9 commits
  6. 07 Nov, 2022 3 commits
  7. 05 Nov, 2022 1 commit
    • Vladislav Vaintroub's avatar
      MDEV-29951 server hang in crash handler · 92be8d20
      Vladislav Vaintroub authored
      When trying to output stacktrace, and addr2line is not installed, the
      child process forked by start_addr2line_fork() will fail to do exec(),
      and finish with exit(1).
      
      There is a problem with exit() though - it runs exit handlers,
      and for the forked copy of crashing process, it is a bad idea.
      
      In 10.5+ code for example, exit handlers include
      tpool::task_group static destructors, and it will hang infinitely
      waiting for completion of the outstanding tasks.
      
      The fix is to use _exit() instead, which skips the execution of exit
      handlers
      92be8d20
  8. 03 Nov, 2022 1 commit
  9. 02 Nov, 2022 1 commit
  10. 30 Oct, 2022 1 commit
    • Brad Smith's avatar
      Fix warning with signal typedef for *BSD · 7d96cb47
      Brad Smith authored
      /usr/ports/pobj/mariadb-10.9.3/mariadb-10.9.3/mysys/my_lock.c:183:7: warning: incompatible function pointer types assigning to 'sig_return' (aka 'void (*)(void)') from 'void (*)(int)' [-Wincompatible-function-pointer-types]
            ALARM_INIT;
            ^~~~~~~~~~
      /usr/ports/pobj/mariadb-10.9.3/mariadb-10.9.3/include/my_alarm.h:43:16: note: expanded from macro 'ALARM_INIT'
                              alarm_signal=signal(SIGALRM,my_set_alarm_variable);
                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      /usr/ports/pobj/mariadb-10.9.3/mariadb-10.9.3/mysys/my_lock.c:189:7: warning: incompatible function pointer types passing 'sig_return' (aka 'void (*)(void)') to parameter of type 'void (*)(int)' [-Wincompatible-function-pointer-types]
            ALARM_END;
            ^~~~~~~~~
      /usr/ports/pobj/mariadb-10.9.3/mariadb-10.9.3/include/my_alarm.h:44:41: note: expanded from macro 'ALARM_END'
                                                    ^~~~~~~~~~~~
      /usr/include/sys/signal.h:199:27: note: passing argument to parameter here
      void    (*signal(int, void (*)(int)))(int);
                                   ^
      2 warnings generated.
      
      The prototype is the same for all of the *BSD's.
      
      void
      (*signal(int sigcatch, void (*func)(int sigraised)))(int);
      7d96cb47
  11. 28 Oct, 2022 1 commit
  12. 27 Oct, 2022 1 commit
  13. 26 Oct, 2022 3 commits
  14. 25 Oct, 2022 5 commits
  15. 24 Oct, 2022 4 commits
  16. 22 Oct, 2022 4 commits