1. 02 Apr, 2004 1 commit
    • unknown's avatar
      made some optimization of last patch for · 18a7a4be
      unknown authored
      Bug #2385 "CREATE TABLE LIKE lacks locking on source and destination table" 
      (in sql_table.cc and mysql-test/t/synchronization.test)
      
      
      mysql-test/t/synchronization.test:
        added sleep to more reliable work
      sql/sql_table.cc:
        made some optimization of last patch for 
        Bug #2385 "CREATE TABLE LIKE lacks locking on source and destination table" 
        in mysql_create_like_table
      18a7a4be
  2. 01 Apr, 2004 1 commit
    • unknown's avatar
      added synchronization in mysql_create_like_table · 10b0ae0c
      unknown authored
      (
      fixed BUG #2385 CREATE TABLE LIKE lacks locking on source and destination table
      and added tests for it
      )
      
      
      sql/mysql_priv.h:
        added code TEST_SYNCHRONIZATION for --exit-info option
      sql/mysqld.cc:
        fixed -debug prefix
      sql/sql_table.cc:
        added synchronization in mysql_create_like_table
        (fixed BUG #2385 CREATE TABLE LIKE lacks locking on source and destination table)
      10b0ae0c
  3. 30 Mar, 2004 2 commits
    • unknown's avatar
      resolving conflicts · 518c3c83
      unknown authored
      518c3c83
    • unknown's avatar
      An improvement of · 928a6d13
      unknown authored
      ChangeSet
        1.1707 04/03/19 12:36:55 ram@gw.mysql.r18.ru +4 -0
        Fix for the bug #2976: NATURAL JOIN produces duplicate columns.
      
      928a6d13
  4. 29 Mar, 2004 14 commits
    • unknown's avatar
      false/true -> FALSE/TRUE · a0354729
      unknown authored
      Fixes after last merge
      
      
      mysql-test/r/bdb-crash.result:
        fixed bad merge
      mysql-test/r/myisam.result:
        after merge fix
      mysql-test/r/order_by.result:
        fixed bad merge
      mysql-test/t/order_by.test:
        after merge fix
      sql/field_conv.cc:
        false/true -> FALSE/TRUE
      sql/handler.cc:
        false/true -> FALSE/TRUE
      sql/item.cc:
        false/true -> FALSE/TRUE
      sql/item_cmpfunc.cc:
        false/true -> FALSE/TRUE
      sql/item_sum.cc:
        false/true -> FALSE/TRUE
      sql/slave.cc:
        false/true -> FALSE/TRUE
      sql/sql_acl.cc:
        false/true -> FALSE/TRUE
      sql/sql_cache.cc:
        after merge fix
      sql/sql_help.cc:
        false/true -> FALSE/TRUE
      sql/sql_olap.cc:
        false/true -> FALSE/TRUE
      sql/sql_parse.cc:
        false/true -> FALSE/TRUE
      sql/sql_select.cc:
        fix after bad merge
      sql/sql_table.cc:
        fix after bad merge
      sql/sql_test.cc:
        false/true -> FALSE/TRUE
      a0354729
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 5161094a
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      5161094a
    • unknown's avatar
      Better comment. · 7ce716e3
      unknown authored
      
      sql/sql_prepare.cc:
        While reviewing Sanja's patch finally understood what is going one here
        (previously marked as 'safety - nasty init' :-) ).
      7ce716e3
    • unknown's avatar
      Merge mysql.com:/home/my/mysql-4.0 into mysql.com:/home/my/mysql-4.1 · 3264eb22
      unknown authored
      
      mysql-test/t/timezone.test:
        Auto merged
      3264eb22
    • unknown's avatar
      Fix test results when you are in daylight saving time · c8164922
      unknown authored
      
      mysql-test/t/timezone.test:
        Fix results when you are in daylight saving time
      c8164922
    • unknown's avatar
      Merge with 4.0 to get lastest bug fixes · 8fa4af59
      unknown authored
      
      include/m_string.h:
        Auto merged
      myisam/mi_create.c:
        Auto merged
      mysql-test/r/bdb-crash.result:
        Auto merged
      sql/handler.h:
        Auto merged
      mysql-test/r/grant_cache.result:
        Auto merged
      mysql-test/t/grant_cache.test:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      innobase/mem/mem0dbg.c:
        Merge with 4.0
      mysql-test/r/myisam.result:
        Merge with 4.0
      mysql-test/r/order_by.result:
        Merge with 4.0
      mysql-test/t/bdb-crash.test:
        Merge with 4.0
      mysql-test/t/myisam.test:
        Merge with 4.0
      mysql-test/t/order_by.test:
        Merge with 4.0
      sql/ha_berkeley.cc:
        Merge with 4.0 (use local code)
      sql/sql_select.cc:
        Merge with 4.0 to get fix for FORCE INDEX ... ORDER BY
      8fa4af59
    • unknown's avatar
      Fixed wrong assert (Got failure in ctype_tis620) · 68e2aa13
      unknown authored
      68e2aa13
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 501312e3
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      
      sql/sql_insert.cc:
        Auto merged
      501312e3
    • unknown's avatar
      Disable INSERT DELAYED for embedded library · 33c669fd
      unknown authored
      
      sql-bench/crash-me.sh:
        Fixed typo
      sql/mysql_priv.h:
        Moved things for embedded library into one section
      sql/sql_string.cc:
        Simple optimization
      33c669fd
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · 6548e332
      unknown authored
      into mysql.com:/home/my/mysql-4.0
      
      6548e332
    • unknown's avatar
      Better error messages for not nullable · 345a0e5a
      unknown authored
      SET character_set_xxx=NULL
      and
      SET collation_xxx=NULL
      
      345a0e5a
    • unknown's avatar
      Better tests for BINARY · f8d9645d
      unknown authored
      f8d9645d
    • unknown's avatar
      d282feee
    • unknown's avatar
      sql_db.cc: · 4caccf38
      unknown authored
        More clear error message.
      
      
      sql/sql_db.cc:
        More clear error message.
      4caccf38
  5. 28 Mar, 2004 1 commit
    • unknown's avatar
      Simplification: MYSQL_RES *result replaced with MYSQL_DATA result; · e1b45818
      unknown authored
      No need to check for result existence any more, store_result functions
      now are shorter.
      cli_read_binary_rows rewritten to handle MYSQL_DATA directly.
      
      
      include/mysql.h:
        MYSQL_RES * pointer replaced with MYSQL_DATA: it saves us at least 2 mallocs
        per store_result and simplifies stored result handling.
        Plus it's done with cursor fetch in mind: cursor fetch will use this
        structure to buffer fetched rows.
      libmysql/client_settings.h:
        signature of cli_read_binary_rows changed
      libmysql/libmysql.c:
        MYSQL_DATA is now used to handle result.
        cli_read_binary_rows rewritten to use MYSQL_DATA directly.
      libmysql/libmysql.def:
        declarations of new calls in the library
      libmysqld/lib_sql.cc:
        MYSQL_DATA is now used to handle result.
        cli_read_binary_rows rewritten to use MYSQL_DATA directly.
      e1b45818
  6. 27 Mar, 2004 4 commits
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · e0f0ccf1
      unknown authored
      into deer.(none):/home/hf/work/mysql-4.1.clean
      
      e0f0ccf1
    • unknown's avatar
      Small fix to embedded library · ef47b7f0
      unknown authored
      we should call check_user in NO_EMBEDDED_ACCESS_CHECKS case
      to do necessary initializations
      
      
      libmysqld/lib_sql.cc:
        call of check_user added
      ef47b7f0
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.1 · ff908552
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.1
      
      ff908552
    • unknown's avatar
      A previous changeset by me today about SQL_LOG_BIN had the problem · dcb14d22
      unknown authored
      that it tested the privilege in ::update() whereas it should be
      in ::check() (see email from Serg, subject
      "Re: bk commit - 4.1 tree (guilhem:1.1706)").
      So I add instead a check_func function to sys_var_thd_bit.
      I do the same addition to sys_var_thd_ulong, to unify handling
      of PSEUDO_THREAD_ID with the one of SQL_LOG_BIN. So class
      sys_var_pseudo_thread_id is not needed anymore, removing it.
      
      
      mysql-test/r/rpl_temporary.result:
        result update
      mysql-test/t/rpl_temporary.test:
        tests after new way of fixing; verify that when second variable
        assignment is refused then first is not done.
      sql/set_var.cc:
        a check_func (check_log_update) when setting SQL_LOG_BIN,
        and one when setting PSEUDO_THREAD_ID.
        Removing class sys_var_pseudo_thread_id.
        Updates for new prototypes of constructor in sys_var_thd_bit
        and sys_var_thd_ulong.
      sql/set_var.h:
        Adding check_func to sys_var_thd_bit.
        Adding check_func to sys_var_thd_ulong, so class sys_var_pseudo_thread_id
        is not needed anymore, removing it.
      dcb14d22
  7. 26 Mar, 2004 17 commits
    • unknown's avatar
      some cleanup of last patch for BUG #2342 · 1079578f
      unknown authored
      
      mysql-test/t/bdb-crash.test:
        added newline
      sql/ha_berkeley.cc:
        added a commet
      1079578f
    • unknown's avatar
      fixed bug #2342 · ddcf90e1
      unknown authored
      "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
      
      
      mysql-test/r/bdb-crash.result:
        added test for bug #2342 
        "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
      mysql-test/t/bdb-crash.test:
        added test for bug #2342 
        "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
      sql/handler.h:
        added constant HA_ADMIN_REJECT
      sql/sql_table.cc:
        added processing of HA_ADMIN_REJECT in ha_berkley::analyze
      ddcf90e1
    • unknown's avatar
      Merge vvagin@bk-internal.mysql.com:/home/bk/mysql-4.0 · 5352db05
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2342/mysql-4.0
      
      5352db05
    • unknown's avatar
      fixed bug #2342 · 9ac942dc
      unknown authored
      "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
      
      1. added new status HA_ADMIN_REJECT and processing of it in mysql_admin_table
      2. got ha_berkley::analyze to return HA_ADMIN_REJECT if there are any 
       transactions with the table.. 
      
      
      mysql-test/r/bdb-crash.result:
        added test for bug #2342 
        "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
      mysql-test/t/bdb-crash.test:
        added test for bug #2342 
        "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
      sql/ha_berkeley.cc:
        fixed bug #2342 
        "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
        
        we have to return new status "HA_ADMIN_REJECT" for ha_berkley::analyze 
        if there are any transaction for this table 
        so as bdb documentation says:
        "The DB->stat method cannot be transaction protected"
      sql/handler.h:
        added new status of table info "HA_ADMIN_REJECT"
        
        We have to return this status for bdb tables which 
        have any active transactions so as bdb-documentation says:
        "The DB->stat method cannot be transaction-protected"
      sql/sql_table.cc:
        added processing of the new status HA_ADMIN_REJECT in mysql_admin_table
        (reason to add this status is explained in comment 
        for commit on sql/handler.h)
      9ac942dc
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.1 · a066472a
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.1
      
      
      mysql-test/r/rpl_temporary.result:
        Auto merged
      mysql-test/t/rpl_temporary.test:
        Auto merged
      sql/set_var.cc:
        Auto merged
      a066472a
    • unknown's avatar
      Changing SET SQL_LOG_BIN so that it explicitely throws an error if · 9b450d44
      unknown authored
      user is not SUPER, instead of setting the value but ignoring it
      silently internally.
      
      
      mysql-test/r/rpl_temporary.result:
        result update
      mysql-test/t/rpl_temporary.test:
        adding test for privileges for SET SQL_LOG_BIN
      sql/log.cc:
        don't need to check SUPER
      sql/set_var.cc:
        refuse SET SQL_LOG_BIN if not SUPER
      sql/sql_insert.cc:
        Don't need to check SUPER
      9b450d44
    • unknown's avatar
      To save 32KB memory per thread when --log-bin is not used, we do not · f2546fdb
      unknown authored
      init the binlog_cache (THD::transaction.trans_log).
      I have checked all places where trans_log is used, because as now
      it may not be inited in some cases, we have to be cautious
      (will forward this commit mail to Heikki).
      
      
      sql/handler.cc:
        Do not use the transaction binlog cache if binlog is not open
      sql/sql_class.cc:
        We do not init the transaction binlog cache if binlog is not open.
        This saves 32 KB memory per thread, if --log-bin is not used.
      sql/sql_class.h:
        warning comment
      f2546fdb
    • unknown's avatar
      Merge sinisa@bk-internal.mysql.com:/home/bk/mysql-4.0 · 98392565
      unknown authored
      into sinisa.nasamreza.org:/mnt/work/mysql-4.0
      
      98392565
    • unknown's avatar
      Merge heikki@build.mysql.com:/home/bk/mysql-4.0 · 60630d8d
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-4.0
      
      60630d8d
    • unknown's avatar
      mem0dbg.c: · cdc7a28e
      unknown authored
        Backport from 4.1: make mem_current_allocated_memory global variable
      
      
      innobase/mem/mem0dbg.c:
        Backport from 4.1: make mem_current_allocated_memory global variable
      cdc7a28e
    • unknown's avatar
      mem0dbg.c: · 53b6d6ea
      unknown authored
        Let mem_current_allocated_memory be a global variable, because it is used in an .ic file if UNIV_MEM_DEBUG is defined
      
      
      innobase/mem/mem0dbg.c:
        Let mem_current_allocated_memory be a global variable, because it is used in an .ic file if UNIV_MEM_DEBUG is defined
      53b6d6ea
    • unknown's avatar
      Merge sinisa@bk-internal.mysql.com:/home/bk/mysql-4.0 · 478bc8ab
      unknown authored
      into sinisa.nasamreza.org:/mnt/work/mysql-4.0
      
      478bc8ab
    • unknown's avatar
      order_by.result: · 1aa24cf2
      unknown authored
        result of the test case for FORCE INDEX on ORDER BY
      order_by.test:
        test case for FORCE INDEX on ORDER BY
      sql_select.cc:
        Changing behaviour that MySQL server takes FORCE INDEX clause into account when optimising ORDER BY clause
      
      
      sql/sql_select.cc:
        Changing behaviour that MySQL server takes FORCE INDEX clause into account when optimising ORDER BY clause
      mysql-test/t/order_by.test:
        test case for FORCE INDEX on ORDER BY
      mysql-test/r/order_by.result:
        result of the test case for FORCE INDEX on ORDER BY
      1aa24cf2
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · eb023e70
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-4.1
      
      
      sql/sql_base.cc:
        Auto merged
      eb023e70
    • unknown's avatar
      3148981d
    • unknown's avatar
      typo in comment fixed · 8b09ba82
      unknown authored
      8b09ba82
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · 433cd158
      unknown authored
      into mysql.com:/home/my/mysql-4.0
      
      433cd158