1. 23 Aug, 2004 1 commit
    • unknown's avatar
      Changed %lx -> 0x%lx (for easier comparison of debug files) · 19984dae
      unknown authored
      Cosmetic cleanups
      Don't call 'delete_elements' on copy_funcs as this causes elements to be freed twice
      
      
      mysys/hash.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/list.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/mf_iocache.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/mf_keycache.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
        Changed debug messages to be more consistent with other mysys files.
      mysys/mf_keycaches.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_alloc.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_fopen.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_fstream.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_getwd.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_lib.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_lwrite.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_malloc.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_pread.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_read.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_realloc.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_write.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/safemalloc.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/thr_alarm.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/thr_lock.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/thr_mutex.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/tree.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/typelib.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      sql/examples/ha_archive.cc:
        Changed to return error number for some functions (instead of -1)
        Updated function comments & some other minor cleanups
        Ensure that free_share() and gzclose() are always called
        Use 'TRUE' and 'FALSE' instead of 'true' and 'false'
        Removed some compiler warnings
      sql/examples/ha_archive.h:
        Fixed to use new prototypes for records_in_range
      sql/sql_select.cc:
        Don't call 'delete_elements' on copy_funcs
      19984dae
  2. 20 Jul, 2004 8 commits
  3. 19 Jul, 2004 6 commits
    • unknown's avatar
      manual merged (blame me!) · c81e414e
      unknown authored
      
      Build-tools/Do-compile:
        Auto merged
      Docs/Makefile.am:
        Auto merged
      innobase/btr/btr0cur.c:
        Auto merged
      innobase/include/lock0lock.h:
        Auto merged
      innobase/include/row0mysql.h:
        Auto merged
      innobase/include/srv0srv.h:
        Auto merged
      innobase/include/sync0arr.h:
        Auto merged
      innobase/include/trx0trx.h:
        Auto merged
      innobase/lock/lock0lock.c:
        Auto merged
      innobase/srv/srv0srv.c:
        Auto merged
      innobase/srv/srv0start.c:
        Auto merged
      innobase/sync/sync0arr.c:
        Auto merged
      innobase/trx/trx0trx.c:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      mysql-test/r/innodb.result:
        to be fixed after the merge
      c81e414e
    • unknown's avatar
      Compilation failure on Windows fixed. · b610b061
      unknown authored
      b610b061
    • unknown's avatar
      merged with 'ul' · 67454e05
      unknown authored
      67454e05
    • unknown's avatar
      handler.cc: · ffabd0ec
      unknown authored
        Revise output of SHOW ENGINES.
      
      
      sql/handler.cc:
        Revise output of SHOW ENGINES.
      ffabd0ec
    • unknown's avatar
      make acl_init() more robust - · 716161cb
      unknown authored
        don't be confused if  new privilege - ENUM ('N','Y') - columns are added (mostly because of downgrade)
        don't expect NOT NULL fields to never contain a NULL :) - somebody may've changed table definition, or we may be reading the wrong column
      
      716161cb
    • unknown's avatar
      - only include the GPL license in the LICENSE text, not the FOSS · 2a174188
      unknown authored
         exception (it only applies to 4.0 and above)
      
      2a174188
  4. 18 Jul, 2004 1 commit
    • unknown's avatar
      Fix for BUG#4551 "Temporary InnoDB tables not replicated properly with CREATE TABLE .. SELECT" · fc488787
      unknown authored
      The problem was that (for any storage engine), the created temporary table was not removed if CREATE SELECT failed (because
      of a constraint violation for example). This was not consistent with the manual and with CREATE SELECT (no TEMPORARY).
      
      
      sql/sql_insert.cc:
        Fix for BUG#4551 "Temporary InnoDB tables not replicated properly with CREATE TABLE .. SELECT"
        The problem was that (for any storage engine), the created temporary table was not removed if CREATE SELECT failed (because
        of a constraint violation for example). This was not consistent with the manual and with CREATE SELECT (no TEMPORARY).
        And it led to the above bug, because the binlogging of CREATE SELECT is done by select_insert::send_eof() (same function
        as INSERT SELECT) and so, if the table is transactional and there is a failure, the statement is considered as rolled
        back and so nothing is written in the binlog. So temp table MUST be deleted.
      fc488787
  5. 17 Jul, 2004 2 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 301e972a
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      301e972a
    • unknown's avatar
      Fixes for · fe3e2470
      unknown authored
      BUG#4506 "mysqlbinlog --position --read-from-remote-server has wrong "# at" lines",
      BUG#4553 "Multi-table DROP TABLE replicates improperly for nonexistent table" with a test file.
      It was not possible to add a test for BUG#4506 as in the test suite we must use --short-form
      which does not display the "# at" lines.
      
      
      client/mysqlbinlog.cc:
        Fix for BUG#4506 "mysqlbinlog --position --read-from-remote-server has wrong "# at" lines"
        when reading a remote binlog, the start position is not always BIN_LOG_HEADER_SIZE (4).
      sql/sql_table.cc:
        Fix for BUG#4553 "Multi-table DROP TABLE replicates improperly for nonexistent table"
        we must my_error() _before_ we write to the binlog, so that a meaningful error code is available
        in thd->net.last_errno for storage of the DROP TABLE statement into the binlog.
      fe3e2470
  6. 16 Jul, 2004 8 commits
  7. 15 Jul, 2004 6 commits
    • unknown's avatar
      Merge lgrimmer@build.mysql.com:/home/bk/mysql-4.1 · 95135e18
      unknown authored
      into mysql.com:/space/my/mysql-4.1
      
      95135e18
    • unknown's avatar
      Merge mysql.com:/space/my/mysql-4.1 · 66db4c0e
      unknown authored
      into mysql.com:/space/my/mysql-4.1-build
      
      66db4c0e
    • unknown's avatar
      - Avoid the error message "Can't read index header from..." · 5793176b
      unknown authored
         when copying a small index file because the value returned
         for $length is < 1024. This can happen if the filehandle
         was open()ed as an UTF-8 encoded file with Unicode characters
         (In this case read() returns characters not bytes)
         (Thanks to Mike Bethune) for this hint)
      
      5793176b
    • unknown's avatar
      InnoDB: limit the recursion depth for ON (UPDATE|DELETE) CASCADE · 95fb41b2
      unknown authored
      (Bug #4446)
      
      
      innobase/row/row0ins.c:
        row_ins_foreign_check_on_constraint(): limit recursion for UPDATE too
      mysql-test/r/innodb.result:
        Add test for recursion depth limit
      mysql-test/t/innodb.test:
        Add test for recursion depth limit
      95fb41b2
    • unknown's avatar
      check that all system tables deleted added · 8fb915f8
      unknown authored
      8fb915f8
    • unknown's avatar
      btr0cur.c: · 90aa7d70
      unknown authored
        Do not add + 1 to the InnoDB index cardinality estimate if the B-tree just contains one page; the fix made in March 2004 caused InnoDB systematically to overestimate the cardinality of empty or small tables by 1
      
      
      innobase/btr/btr0cur.c:
        Do not add + 1 to the InnoDB index cardinality estimate if the B-tree just contains one page; the fix made in March 2004 caused InnoDB systematically to overestimate the cardinality of empty or small tables by 1
      90aa7d70
  8. 14 Jul, 2004 3 commits
  9. 13 Jul, 2004 5 commits
    • unknown's avatar
      - Fixed a previous modification to the MySQL Startup Item for · 72fae360
      unknown authored
         Mac OS X: the name of the startup script itself must match the
         name of the subdirectory it's located in. Changed MySQL->MySQLCOM 
         in the Do-pkg script and renamed the file in BK. (Thanks to Bryan
         McCormack for reporting this)
      
      
      Build-tools/Do-pkg:
         - renamed script from MySQL to MySQLCOM to match the name of the
           directory it's installed in
      support-files/MacOSX/MySQLCOM:
         - Fixed the file and directory name to match the actual location
      72fae360
    • unknown's avatar
      Merge lgrimmer@build.mysql.com:/home/bk/mysql-4.0 · f81de431
      unknown authored
      into mysql.com:/space/my/mysql-4.0
      
      f81de431
    • unknown's avatar
      - Move checking of the MD5 checksumming to the correct place · c254f844
      unknown authored
       - fix calling of my_md5sum
      
      c254f844
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.1 · 86b41675
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.1-874
      
      86b41675
    • unknown's avatar
      WL#1900 "When CHECK TABLE or ANALYZE TABLE of a MyISAM table is killed · 724c5236
      unknown authored
      by KILL or shutdown, do not mark the table as corrupted".
      It is indeed more logical to leave the corruption flag unchanged.
      This cannot be extended to REPAIR/OPTIMIZE as they make no backup copy
      of the MYI. This patch was tested with KILL and mysqladmin shutdown
      while a CHECK TABLE was running. Without the patch, the table becomes
      unusable (can't INSERT to it, error 145). With the patch, no.
      
      
      sql/ha_myisam.cc:
        When CHECK TABLE or ANALYZE TABLE is killed by KILL,
        do not mark the table corrupted; leave its corruption flag
        unchanged.
      724c5236