1. 27 Oct, 2021 9 commits
  2. 26 Oct, 2021 3 commits
    • Eugene Kosov's avatar
      MDEV-18543 IMPORT TABLESPACE fails after instant DROP COLUMN · d74d9596
      Eugene Kosov authored
      ALTER TABLE IMPORT doesn't properly handle instant alter metadata.
      This patch makes IMPORT read, parse and apply instant alter metadata at the
      very beginning of operation. So, cases when source table has some metadata
      and destination table doesn't have it now works fine.
      
      DISCARD already removes instant metadata so importing normal table into
      instant table worked fine before this patch.
      
      decrypt_decompress(): decrypts and decompresses page if needed
      
      handle_instant_metadata(): this should be the first thing to read source
      table. Basically, it applies instant metadata to a destination
      dict_table_t object. This is the first thing to read FSP flags so
      all possible checks of it were moved to this function.
      
      PageConverter::update_index_page(): it doesn't now read instant metadata.
      This logic were moved into handle_instant_metadata()
      
      row_import::match_flags(): this is a first part row_import::match_schema().
      As a separate function it's used by handle_instant_metadata().
      
      fil_space_t::is_full_crc32_compressed(): added convenient function
      
      ha_innobase::discard_or_import_tablespace(): do not reload table definition
      to read instant metadata because handle_instant_metadata() does it better.
      The reverted code was originally added in
      4e7ee166
      
      ANONYMOUS_VAR: this is a handy thing to use along with make_scope_exit()
      
      full_crc32_import.test shows different results, because no
      dict_table_close() and dict_table_open_on_id() happens.
      Thus, SHOW CREATE TABLE shows a little bit older table definition.
      d74d9596
    • Alexander Barkov's avatar
      MDEV-26732 Assertion `0' failed in Item::val_native · 49098bfd
      Alexander Barkov authored
      Also fixes MDEV-24619 Wrong result or Assertion `0' in Item::val_native / Type_handler_inet6::Item_val_native_with_conversion
      
      Type_handler_inet6::create_item_copy() created a generic Item_copy_string,
      which does not implement val_native() - it has a dummy implementation
      with DBUG_ASSERT(0), which made the server crash.
      
      Fix:
      
      - Adding a new class Type_handler_inet6
        which implements val_native().
      - Fixing Type_handler_inet6::create_item_copy()
        to make Item_copy_inet6 instead of Item_copy_string.
      49098bfd
    • Marko Mäkelä's avatar
      MDEV-26903: Assertion ctx->trx->state == TRX_STATE_ACTIVE on DROP INDEX · 58fe6b47
      Marko Mäkelä authored
      rollback_inplace_alter_table(): Tolerate a case where the transaction
      is not in an active state. If ha_innobase::commit_inplace_alter_table()
      failed with a deadlock, the transaction would already have been
      rolled back. This omission of error handling was introduced in
      commit 1bd681c8 (MDEV-25506 part 3).
      
      After commit c3c53926 (MDEV-26554)
      it became easier to trigger DB_DEADLOCK during exclusive table lock
      acquisition in ha_innobase::commit_inplace_alter_table().
      
      lock_table_low(): Add DBUG injection "innodb_table_deadlock".
      58fe6b47
  3. 25 Oct, 2021 3 commits
    • Anel Husakovic's avatar
      MDEV-22552: mytop packaging · 395a0332
      Anel Husakovic authored
      `mytop` and `my_print_defaults` for RPM
      
      - Add `mytop` to client package
      - Add man page of `my_print_defaults` to client package
      - Add dependencies for RPMs
      - Remove old comment
      - Remove dead link
      
      Reviewed by: serg@mariadb.com
      395a0332
    • Bernard Spil's avatar
      MDEV-22552: mytop packaging · 2011fcf8
      Bernard Spil authored
      Make `my_print_defaults` a client app (required by `mytop`).
      
      Closes #1566
      
      Reviewed by: serg@mariadb.com, anel@mariadb.org
      2011fcf8
    • Marko Mäkelä's avatar
      MDEV-26674: Set innodb_use_native_aio=OFF when using io_uring on a potentially affected kernel · 1193a793
      Marko Mäkelä authored
      We have observed hangs of the io_uring subsystem when using a
      Linux kernel newer than 5.10. Also 5.15-rc6 is affected by this.
      
      The exact cause of the hangs has not been diagnosed yet.
      As a safety measure, we will disable innodb_use_native_aio by default
      when the server has been configured with io_uring and the kernel
      version is between 5.11 and 5.15.
      
      If the start-up parameter innodb_use_native_aio=ON is set, then
      we will issue a warning to the server error log.
      1193a793
  4. 22 Oct, 2021 4 commits
    • Marko Mäkelä's avatar
      MDEV-26769 InnoDB does not support hardware lock elision · 1f022809
      Marko Mäkelä authored
      This implements memory transaction support for:
      
      * Intel Restricted Transactional Memory (RTM), also known as TSX-NI
      (Transactional Synchronization Extensions New Instructions)
      * POWER v2.09 Hardware Trace Monitor (HTM) on GNU/Linux
      
      transactional_lock_guard, transactional_shared_lock_guard:
      RAII lock guards that try to elide the lock acquisition
      when transactional memory is available.
      
      buf_pool.page_hash: Try to elide latches whenever feasible.
      Related to the InnoDB change buffer and ROW_FORMAT=COMPRESSED
      tables, this is not always possible.
      In buf_page_get_low(), memory transactions only work reasonably
      well for validating a guessed block address.
      
      TMLockGuard, TMLockTrxGuard, TMLockMutexGuard: RAII lock guards
      that try to elide lock_sys.latch and related latches.
      1f022809
    • Marko Mäkelä's avatar
      MDEV-26826 Duplicated computations of buf_pool.page_hash addresses · c091a0bc
      Marko Mäkelä authored
      Since commit bd5a6403 (MDEV-26033)
      we can actually calculate the buf_pool.page_hash cell and latch
      addresses while not holding buf_pool.mutex.
      
      buf_page_alloc_descriptor(): Remove the MEM_UNDEFINED.
      We now expect buf_page_t::hash to be zero-initialized.
      
      buf_pool_t::hash_chain: Dedicated data type for buf_pool.page_hash.array.
      
      buf_LRU_free_one_page(): Merged to the only caller
      buf_pool_t::corrupted_evict().
      c091a0bc
    • Marko Mäkelä's avatar
      MDEV-26828 Spinning on buf_pool.page_hash is wasting CPU cycles · fdae71f8
      Marko Mäkelä authored
      page_hash_latch: Only use the spinlock implementation on
      SUX_LOCK_GENERIC platforms (those for which we do not implement
      a futex-like interface). Use srw_spin_mutex on 32-bit systems
      (except Microsoft Windows) to satisfy the size constraints.
      
      rw_lock::is_read_locked(): Remove. We will use the slightly
      broader assertion is_locked().
      
      srw_lock_: Implement is_locked(), is_write_locked() in a hacky
      way for the Microsoft Windows SRWLOCK. This should be acceptable,
      because we are only using these predicates in debug assertions
      (or later, in lock elision), and false positives should not matter.
      fdae71f8
    • Marko Mäkelä's avatar
      MDEV-26883 InnoDB hang due to table lock conflict · 5caff202
      Marko Mäkelä authored
      In a stress test campaign of a 10.6-based branch by Matthias Leich,
      a deadlock between two InnoDB threads occurred, involving
      lock_sys.wait_mutex and a dict_table_t::lock_mutex.
      
      The cause of the hang is a latching order violation in
      lock_sys_t::cancel(). That function and the latching order
      violation were originally introduced in
      commit 8d16da14 (MDEV-24789).
      
      lock_sys_t::cancel(): Invoke table->lock_mutex_trylock() in order
      to avoid a deadlock. If that fails, release lock_sys.wait_mutex,
      and acquire both latches. In that way, we will be obeying the
      latching order and no hangs will occur.
      
      This hang should mostly affect DDL operations. DML operations will
      acquire only IX or IS table locks, which are compatible with each other.
      5caff202
  5. 21 Oct, 2021 20 commits
  6. 20 Oct, 2021 1 commit