1. 15 Jun, 2007 1 commit
  2. 14 Jun, 2007 5 commits
  3. 13 Jun, 2007 1 commit
    • unknown's avatar
      Fixed bug #28980: the result of ROUND(<decimal expr>,<int column>) · 16d45603
      unknown authored
      was erroneously converted to double, while the result of
      ROUND(<decimal expr>, <int literal>) was preserved as decimal.
      As a result of such a conversion the value of ROUND(D,A) could
      differ from the value of ROUND(D,val(A)) if D was a decimal expression.
      
      Now the result of the ROUND function is never converted to 
      double if the first argument is decimal.  
      
      
      mysql-test/r/type_decimal.result:
        Added a test case for bug #28980.
      mysql-test/t/type_decimal.test:
        Added a test case for bug #28980.
      16d45603
  4. 12 Jun, 2007 5 commits
    • unknown's avatar
      removed compilation warning · c5b42cb3
      unknown authored
      c5b42cb3
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-opt · 9bb186b9
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28992-5.0-opt
      
      9bb186b9
    • unknown's avatar
      Bug #28992: trigger fails in pushbuild · d62f99f8
      unknown authored
       - fixed wrong test case for bug 20903
       - closed the dangling connections in trigger.test
       - GET_LOCK() and RELEASE_LOCK() now produce more detailed log
       - fixed an omission in GET_LOCK() : assign the thread_id when
          acquiring the lock.
      
      
      mysql-test/r/trigger.result:
        Bug #28992: test case updated
      mysql-test/t/trigger.test:
        Bug #28992: test case updated. dangling connections closed.
      sql/item_func.cc:
        Bug #28992: 
         - GET_LOCK() and RELEASE_LOCK() now produce more detailed log
         - fixed an omission in GET_LOCK() : assign the thread_id when
            acquiring the lock.
      d62f99f8
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · a0c123d7
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28934-5.0-opt
      
      a0c123d7
    • unknown's avatar
      Bug #28934: server crash when receiving malformed com_execute packets · bf9b57fd
      unknown authored
       Sometimes a parameter slot may not get a value because of the protocol
       data being plain wrong.
       Such cases should be detected and handled by returning an error.
       Fixed by checking data stream constraints where possible (like maximum
       length) and reacting to the case where a value cannot be constructed.
      
      
      sql/sql_prepare.cc:
        Bug #28934: 
         - check for a parameter slot not being set because 
            of wrong data
         - check if the length read from the stream is not
            greater than the maximum length of the field
      tests/mysql_client_test.c:
        Bug #28934: test case
      bf9b57fd
  5. 11 Jun, 2007 2 commits
    • unknown's avatar
      Bug#28904: INSERT .. ON DUPLICATE was silently updating rows when it shouldn't. · 506a5698
      unknown authored
      When the INSERT .. ON DUPLICATE KEY UPDATE has to update a matched row but
      the new data is the same as in the record then it returns as if
      no rows were inserted or updated. Nevertheless the row is silently
      updated. This leads to a situation when zero updated rows are reported 
      in the case when data has actually been changed.
      
      Now the write_record function updates a row only if new data differs from
      that in the record.
      
      
      sql/sql_insert.cc:
        Bug#28904: INSERT .. ON DUPLICATE was silently updating rows when it shouldn't.
        Now the write_record function updates a row only if new data differs from
        that in the record.
      mysql-test/r/insert_update.result:
        Added a test case for the bug#28904: INSERT .. ON DUPLICATE was silently
        updating rows when it shouldn't.
      mysql-test/t/insert_update.test:
        Added a test case for the bug#28904: INSERT .. ON DUPLICATE was silently
        updating rows when it shouldn't.
      506a5698
    • unknown's avatar
      Merge weblab.(none):/home/marcsql/TREE/mysql-5.0-base · 315277ac
      unknown authored
      into  weblab.(none):/home/marcsql/TREE/mysql-5.0-rt-merge
      
      
      sql/field.cc:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      315277ac
  6. 09 Jun, 2007 7 commits
  7. 08 Jun, 2007 5 commits
    • unknown's avatar
      Bug #28333 Test "flush" tries to create a new thread - on only one platform · cbe888a4
      unknown authored
      on PPC/Debian Linux default stack size for a thread is too big.
      As we use default thread settings in mysqltest, the
      thread creation fails if we create lots of threads (as it
      happens in flush.test). So now stack size is explicitly specified
      for the mysqltest
      
      
      client/mysqltest.c:
        Bug #28333 Test "flush" tries to create a new thread - on only one platform
        
        specify appropriate stack size for the 'query' thread
      cbe888a4
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 6f73cc11
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug28811
      
      6f73cc11
    • unknown's avatar
      Bug #28754: RPM builds differ from tar.gz in "ALTER ... RENAME" on views · 0f6f9b8e
      unknown authored
       When constructing the path to the original .frm file ALTER .. RENAME
       was unnecessary (and incorrectly) lowercasing the whole path when not 
       on a case-insensitive filesystem.
       This path should not be modified because of lower_case_table_names
       as it is already in the correct case according to that setting.
       Fixed by removing the lowercasing.
       Unfortunately testing this would require running the tests on a case
       sensitive filesystem in a directory that has uppercase letters.
       This cannot be guaranteed in all setups so no test case added.
      
      
      sql/sql_table.cc:
        Bug #28754: don't downcase the .frm path
      0f6f9b8e
    • unknown's avatar
      Bug#18660 Can't grant any privileges on single table in database with underscore char · 443ab08d
      unknown authored
      In case of database level grant the database name may be a pattern,
      in case of table|column level grant the database name can not be a pattern.
      We use 'dont_check_global_grants' as a flag to determine
      if it's database level grant command 
      (see SQLCOM_GRANT case, mysql_execute_command() function) and
      set db_is_pattern according to 'dont_check_global_grants' value.
      
      
      mysql-test/r/grant2.result:
        test result
      mysql-test/t/grant2.test:
        test case
      sql/sql_parse.cc:
        In case of database level grant the database name may be a pattern,
        in case of table|column level grant the database name can not be a pattern.
        We use 'dont_check_global_grants' as a flag to determine
        if it's database level grant command 
        (see SQLCOM_GRANT case, mysql_execute_command() function) and
        set db_is_pattern according to 'dont_check_global_grants' value.
      443ab08d
    • unknown's avatar
      Fixed bug #28811: crash for a query containing a subquery with · 00162a46
      unknown authored
      ORDER BY and LIMIT 1. 
      The bug was introduced by the patch for bug 21727. The patch
      erroneously skipped initialization of the array of headers
      for sorted records for non-first evaluations of the subquery.
      
      To fix the problem a new parameter has been added to the
      function make_char_array that performs the initialization.
      Now this function is called for any invocation of the 
      filesort procedure. Yet it allocates the buffer for sorted
      records only if this parameter is NULL.
      
      
      mysql-test/r/subselect.result:
        Added a test case for bug #28811.
      mysql-test/t/subselect.test:
        Added a test case for bug #28811.
      00162a46
  8. 07 Jun, 2007 14 commits
    • unknown's avatar
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 80cbbcea
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/28763-bug-5.0-opt-mysql
      
      80cbbcea
    • unknown's avatar
      Bug#28763: Selecting geometry fields in UNION caused server crash. · 6e308347
      unknown authored
      This bug was introduced by the fix for the bug#27300. In this fix a section
      of code was added to the Item::tmp_table_field_from_field_type method.
      This section intended to create Field_geom fields for the Item_geometry_func
      class and its descendants. In order to get the geometry type of the current
      item it casted "this" to the Item_geometry_func* type. But the
      Item::tmp_table_field_from_field_type method is also used for creation of
      fields for UNION and in this case this method is called for an object of the
      Item_type_holder class and the cast to the Item_geometry_func* type causes 
      a server crash.
      
      Now the Item::tmp_table_field_from_field_type method correctly works when it's
      called for both the Item_type_holder and the Item_geometry_func classes.
      The new geometry_type variable is added to the Item_type_holder class.
      The new method called get_geometry_type is added to the Item_field
      and the Field classes. It returns geometry type from the field for the
      Item_field and the Field_geom classes and fails an assert for other Field
      descendants.
      
      
      sql/field.h:
        Bug#28763: Selecting geometry fields in UNION caused server crash.
        The new method called get_geometry_type is added to the Field class.
        It returns geometry type of the field for the Field_geom class
        and fails an assert for other Field descendants.
      sql/item.cc:
        Bug#28763: Selecting geometry fields in UNION caused server crash.
        Now the Item::tmp_table_field_from_field_type method correctly works when it's
        called for both the Item_type_holder and the Item_geometry_func classes.
      mysql-test/r/gis.result:
        Added a test case for the bug#28763: Selecting geometry fields in UNION caused server crash.
      mysql-test/t/gis.test:
        Added a test case for the bug#28763: Selecting geometry fields in UNION caused server crash.
      sql/item.h:
        Bug#28763: Selecting geometry fields in UNION caused server crash.
        The new method called get_geometry_type is added to the Item_field class.
        It returns geometry type from the field.
        The new geometry_type variable is added to the Item_type_holder class.
      6e308347
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 0fb85362
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug28449
      
      0fb85362
    • unknown's avatar
      Fix Windows failure. · 53f8b855
      unknown authored
      53f8b855
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-runtime · d2fb9329
      unknown authored
      into  ibm.:/home/alik/Documents/MySQL/devel/5.0-rt-bug275920-2
      
      d2fb9329
    • unknown's avatar
      Add test case for BUG#27592: stack overrun when storing datetime · 19fa4753
      unknown authored
      value using prepared statements.
      
      
      tests/mysql_client_test.c:
        Test case.
      19fa4753
    • unknown's avatar
      Merge trift2.:/MySQL/M41/bug23504-4.1 · eabbf72f
      unknown authored
      into  trift2.:/MySQL/M41/push-4.1
      
      eabbf72f
    • unknown's avatar
      Merge trift2.:/MySQL/M41/bug23504-4.1 · c06e3435
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      netware/comp_err.def:
        Auto merged
      netware/isamchk.def:
        Auto merged
      netware/isamlog.def:
        Auto merged
      netware/libmysql.def:
        Auto merged
      netware/myisam_ftdump.def:
        Auto merged
      netware/myisamchk.def:
        Auto merged
      netware/myisamlog.def:
        Auto merged
      netware/myisampack.def:
        Auto merged
      netware/mysql.def:
        Auto merged
      netware/mysql_install_db.def:
        Auto merged
      netware/mysql_test_run.def:
        Auto merged
      netware/mysql_waitpid.def:
        Auto merged
      netware/mysqladmin.def:
        Auto merged
      netware/mysqlbinlog.def:
        Auto merged
      netware/mysqlcheck.def:
        Auto merged
      netware/mysqld.def:
        Auto merged
      netware/mysqld_safe.def:
        Auto merged
      netware/mysqldump.def:
        Auto merged
      netware/mysqlimport.def:
        Auto merged
      netware/mysqlshow.def:
        Auto merged
      netware/mysqltest.def:
        Auto merged
      netware/pack_isam.def:
        Auto merged
      netware/perror.def:
        Auto merged
      netware/replace.def:
        Auto merged
      netware/resolve_stack_dump.def:
        Auto merged
      netware/resolveip.def:
        Auto merged
      netware/my_print_defaults.def:
        Use 5.0 version
      c06e3435
    • unknown's avatar
      netware/*.def : Allocate 128K stack for all executables (bug#23504) · 71516c02
      unknown authored
      
      netware/comp_err.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/isamchk.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/isamlog.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/libmysql.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/my_print_defaults.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/myisam_ftdump.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/myisamchk.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/myisamlog.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/myisampack.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysql.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysql_install_db.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysql_test_run.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysql_waitpid.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqladmin.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqlbinlog.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqlcheck.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqld.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqld_safe.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqldump.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqlimport.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqlshow.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqltest.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/pack_isam.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/perror.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/replace.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/resolve_stack_dump.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/resolveip.def:
        Allocate 128K stack for all executables (bug#23504)
      71516c02
    • unknown's avatar
      Fix for BUG#27592: stack overrun when storing datetime value · 272ac17b
      unknown authored
      using prepared statements.
      
      
      sql/field.cc:
        Using MAX_DATETIME_WIDTH or MAX_DATETIME_COMPRESSED_WIDTH
        constants for the length of DATETIME fields.
        
        Using MAX_DATE_STRING_REP_LENGTH for allocating buffers
        for date/time/... string representation.
      sql/item_timefunc.cc:
        Using MAX_DATETIME_WIDTH or MAX_DATETIME_COMPRESSED_WIDTH
        constants for the length of DATETIME fields.
        
        Using MAX_DATE_STRING_REP_LENGTH for allocating buffers
        for date/time/... string representation.
      sql/unireg.h:
        Introduce a constant for length of datetime compressed
        format (YYYYMMDDHHMMSS).
      272ac17b
    • unknown's avatar
      Fixed bug #28449: a crash may happen at some rare conditions when · 80cac2a2
      unknown authored
      a temporary table has grown out of heap memory reserved for it and 
      the remaining disk space is not big enough to store the table as
      a MyISAM table.
      
      The crash happens because the function create_myisam_from_heap
      does not handle safely the mem_root structure associated 
      with the converted table in the case when an error has occurred.
      
      
      sql/sql_select.cc:
        Fixed bug #28449: a crash may happen at some rare conditions when
        a temporary table has grown out of heap memory reserved for it and 
        the remaining disk space is not big enough to store the table as
        a MyISAM table.
        
        The crash happens because the function create_myisam_from_heap
        does not handle safely the mem_root structure associated 
        with the converted table in the case when an error has occurred.
        
        As it's hard to create a sitiation that would throw an error 
        a special code has been added that raises an error for a newly 
        created test called error_simulation.
      mysql-test/r/error_simulation.result:
        New BitKeeper file ``mysql-test/r/error_simulation.result''
        
        Added a test case for bug #28449.
      mysql-test/t/error_simulation-master.opt:
        New BitKeeper file ``mysql-test/t/error_simulation-master.opt''
      mysql-test/t/error_simulation.test:
        New BitKeeper file ``mysql-test/t/error_simulation.test''
        
        Added a test case for bug #28449.
      80cac2a2
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · eeab724f
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28878-5.0-opt
      
      eeab724f
    • unknown's avatar
      Bug#28878: InnoDB tables with UTF8 character set and indexes cause · a3957693
      unknown authored
      wrong result for DML
      When making key reference buffers over CHAR fields whitespace (0x20) 
      must be used to fill in the remaining space in the field's buffer.
      This is what Field_string::store() does.
      Fixed Field_string::get_key_image() to do the same.
      
      
      mysql-test/r/innodb_mysql.result:
        Bug#28878: test case
      mysql-test/t/innodb_mysql.test:
        Bug#28878: test case
      sql/field.cc:
        Bug#28878: Fill with space instead of binary zeros.
      a3957693