1. 26 Apr, 2023 4 commits
    • Rucha Deodhar's avatar
      MDEV-30977: Additional key values are not validating properly when using · 1c25b5c0
      Rucha Deodhar authored
      unevaluatedProperties with properties declared in subschemas
      
      Analysis:
      When a key fails to validate for "properties" when "properties" is being
      treated as alternate schema, it needs to fall back on alternate schema
      for "properites" itself ("unevaluatedProperties" in context of the bug).
      But that doesn't happen and we end up returning false (=validated)
      Fix:
      When "properties" fails to validate as an alternate schema, fall back on
      alternate schema for "properties" itself.
      1c25b5c0
    • Rucha Deodhar's avatar
      MDEV-30995: JSON_SCHEMA_VALID is not validating case sensitive when using · ee41fa38
      Rucha Deodhar authored
      regex
      
      Analysis:
      When initializing Regexp_processor_pcre object, we set the PCRE2_CASELESS
      flag which is responsible for case insensitive comparison.
      Fix:
      Unset the flag after initializing.
      ee41fa38
    • Rucha Deodhar's avatar
      MDEV-30795: JSON_SCHEMA_VALID bugs mentioned in comment · 8939e21d
      Rucha Deodhar authored
      comment 2)
      Analysis:
      flag to check unique gets reset every time. Hence unique values cannot be
      correctly checked
      Fix:
      do not reset the flag that checks unique for null, true and false
      values.
      
      comment 3)
      Analysis:
      current implementation checks for appropriate value but does not
      return true.
      Fix:
      return true on error
      
      comment 4)
      Analysis:
      Current implementation did not check for value type for values
      inside required array.
      Fix:
      Check values inside required array
      8939e21d
    • Rucha Deodhar's avatar
      MDEV-27128: Implement JSON Schema Validation FUNCTION · 358b8495
      Rucha Deodhar authored
      Implementation:
      Implementation is made according to json schema validation draft 2020
      
      JSON schema basically has same structure as that of json object, consisting
      of key-value pairs. So it can be parsed in the same manner as
      any json object.
      
      However, none of the keywords are mandatory, so making guess about the
      json value type based only on the keywords would be incorrect.
      Hence we need separate objects denoting each keyword.
      
      So during create_object_and_handle_keyword() we create appropriate objects
      based on the keywords and validate each of them individually on the json
      document by calling respective validate() function if the type matches.
      If any of them fails, return false, else return true.
      358b8495
  2. 25 Apr, 2023 3 commits
  3. 14 Apr, 2023 1 commit
  4. 12 Apr, 2023 1 commit
    • Junqi Xie's avatar
      MDEV-21921 Make transaction_isolation and transaction_read_only into system variables · d20a96f9
      Junqi Xie authored
      In MariaDB, we have a confusing problem where:
      * The transaction_isolation option can be set in a configuration file, but it cannot be set dynamically.
      * The tx_isolation system variable can be set dynamically, but it cannot be set in a configuration file.
      
      Therefore, we have two different names for the same thing in different contexts. This is needlessly confusing, and it complicates the documentation. The same thing applys for transaction_read_only.
      
      MySQL 5.7 solved this problem by making them into system variables. https://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-20.html
      
      This commit takes a similar approach by adding new system variables and marking the original ones as deprecated. This commit also resolves some legacy problems related to SET STATEMENT and transaction_isolation.
      d20a96f9
  5. 11 Apr, 2023 1 commit
  6. 10 Apr, 2023 1 commit
  7. 29 Mar, 2023 6 commits
  8. 28 Mar, 2023 5 commits
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 0760ad33
      Marko Mäkelä authored
      0760ad33
    • Marko Mäkelä's avatar
      MDEV-30936 fixup · 402f36dd
      Marko Mäkelä authored
      fil_space_t::~fil_space_t(): Invoke ut_free(name) because
      doing so in the callers would trip MSAN_OPTIONS=poison_in_dtor=1
      402f36dd
    • Marko Mäkelä's avatar
      MDEV-30936 clang 15.0.7 -fsanitize=memory fails massively · dfa90257
      Marko Mäkelä authored
      handle_slave_io(), handle_slave_sql(), os_thread_exit():
      Remove a redundant pthread_exit(nullptr) call, because it
      would cause SIGSEGV.
      
      mysql_print_status(): Add MEM_MAKE_DEFINED() to work around
      some missing instrumentation around mallinfo2().
      
      que_graph_free_stat_list(): Invoke que_node_get_next(node) before
      que_graph_free_recursive(node). That is the logical and
      MSAN_OPTIONS=poison_in_dtor=1 compatible way of freeing memory.
      
      ins_node_t::~ins_node_t(): Invoke mem_heap_free(entry_sys_heap).
      
      que_graph_free_recursive(): Rely on ins_node_t::~ins_node_t().
      
      fts_t::~fts_t(): Invoke mem_heap_free(fts_heap).
      
      fts_free(): Replace with direct calls to fts_t::~fts_t().
      
      The failures in free_root() due to MSAN_OPTIONS=poison_in_dtor=1
      will be covered in MDEV-30942.
      dfa90257
    • Shivam Choudhary's avatar
      Fixed some typos in optimizer_costs.txt · 6c3b1dce
      Shivam Choudhary authored
      6c3b1dce
    • Yuchen Pei's avatar
      MDEV-30920 Remove need_lock and table from spider_close_sys_table() · 7bd225e1
      Yuchen Pei authored
      They became obsolete after commit cfd145fa:
      
      commit cfd145fa
      Author: Nayuta Yanagisawa <nayuta.yanagisawa@hey.com>
      Date:   Fri Jan 28 01:03:06 2022 +0900
      
          MDEV-27641 Spider: remove #if MYSQL_VERSION_ID < ${VERSION}
      7bd225e1
  9. 27 Mar, 2023 6 commits
    • Sergei Golubchik's avatar
      MDEV-19629 post-merge fixes · c2b69163
      Sergei Golubchik authored
      * it isn't "pfs" function, don't call it Item_func_pfs,
        don't use item_pfsfunc.*
      * tests don't depend on performance schema, put in the main suite
      * inherit from Item_str_ascii_func
      * use connection collation, not utf8mb3_general_ci
      * set result length in fix_length_and_dec
      * do not set maybe_null
      * use my_snprintf() where possible
      * don't set m_value.ptr on every invocation
      * update sys schema to use the format_pico_time()
      * len must be size_t (compilation error on Windows)
      * the correct function name for double->double is fabs()
      * drop volatile hack
      c2b69163
    • Ahmed Ibrahim's avatar
      d9808f79
    • Marko Mäkelä's avatar
      Fix ColumnStore again · 5a1f7522
      Marko Mäkelä authored
      This fixes up commit e371b1e2
      that accidentally reverted d77aaa69.
      5a1f7522
    • Marko Mäkelä's avatar
      Merge 11.0 into 11.1 · f6c5e917
      Marko Mäkelä authored
      f6c5e917
    • Tuukka Pasanen's avatar
      MDEV-30837: Remove usage of AWK in autobake-debs.sh · 31487f4b
      Tuukka Pasanen authored
      AWK is used in autobake-debs.sh for printing information
      about created DEB packages.
      
      This can be rewrite with bash inner commands read and echo.
      31487f4b
    • Tuukka Pasanen's avatar
      MDEV-30837: Remove usage of AWK from Debian init and postinst scripts · fe32a4a5
      Tuukka Pasanen authored
      AWK in used in Debian SysV-init and postinst scripts to determine
      is there enough space starting MariaDB database or create new
      database to target destination.
      
      These AWK scripts can be rewrited to use pure SH or help
      using Coreutils which is mandatory for usage of MariaDB currently.
      
      Reasoning behind this is to get rid of one very less used dependency
      fe32a4a5
  10. 24 Mar, 2023 7 commits
    • Andrei's avatar
      MDEV-26071: rpl.rpl_perfschema_applier_status_by_worker failed in bb … · 216d99bb
      Andrei authored
      …with: Test assertion failed
      
      Problem:
      =======
      Assertion text: 'Value returned by SSS and PS table for Last_Error_Number
      should be same.'
      Assertion condition: '"1146" = "0"'
      Assertion condition, interpolated: '"1146" = "0"'
      Assertion result: '0'
      
      Analysis:
      ========
      In parallel replication when slave is started the worker pool gets
      activated and it gets cleared when slave stops. Each time the worker pool
      gets activated a backup worker pool also gets created to store worker
      specific perforance schema information in case of errors. On error, all
      relevant information is copied from rpl_parallel_thread to rli and it gets
      cleared from thread.  Then server waits for all workers to complete their
      work, during this stage performance schema table specific worker info is
      stored into the backup pool and finally the actual pool gets cleared. If
      users query the performance schema table to know the status of workers the
      information from backup pool will be used. The test simulates
      ER_NO_SUCH_TABLE error and verifies the worker information in pfs table.
      Test works fine if execution occurs in following order.
      
      Step 1. Error occurred 'worker information is copied to backup pool'.
      Step 2. handle_slave_sql invokes 'rpl_parallel_resize_pool_if_no_slaves' to
      deactivate worker pool, it marks the pool->count=0
      Step 3. PFS table is queried, since actual pool is deactivated backup pool
      information is read.
      
      If the Step 3 happens prior to Step2 the pool is yet to be deactivated and
      the actual pool is read, which doesn't have any error details as they were
      cleared. Hence test ocasionally fails.
      
      Fix:
      ===
      Upon error mark the back pool as being active so that if PFS table is
      quried since the backup pool is flagged as valid its information will be
      read, in case it is not flagged regular pool will be read.
      
      This work is one of the last pieces created by the late Sujatha Sivakumar.
      216d99bb
    • Marko Mäkelä's avatar
      e371b1e2
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-29545 InnoDB: Can't find record during replace stmt · e06c6046
      Thirunarayanan Balathandayuthapani authored
      Problem:
      ========
      - InnoDB replace statement returns can't find record as result during
      bulk insert operation. InnoDB returns DB_END_OF_INDEX blindly when
      bulk transaction is visible to current transaction even though
      the search tuple is inserted as a part of current replace statement.
      
      Solution:
      =========
      row_search_mvcc(): InnoDB should allow the transaction to read
      all the rows when innodb intends to do any locking on the
      record even though bulk insert transaction changes are
      visible to the current transaction
      e06c6046
    • Marko Mäkelä's avatar
      MDEV-30900 Crash on macOS due to zero-initialized buf_dblwr.write_cond · 07460c31
      Marko Mäkelä authored
      buf_dblwr_t::init(), buf_dblwr_t::close(): Cover also write_cond,
      which was added in commit a55b951e
      without explicit initialization. On GNU/Linux, PTHREAD_COND_INITIALIZER
      is a zero-initializer. That is why the default zero initialization
      happened to work on that platform.
      07460c31
    • Tuukka Pasanen's avatar
      MDEV-30778: Remove Awk from mysql_install_db · a79abb65
      Tuukka Pasanen authored
      Commit reduces need of AWK-command at least
      for Debian mariadb-server-compat package.
      
      Commit removes need of AWK-command from
      scripts/mysql_install_db.sh script.
      
      AWK command is replace by purely Posix sh compiliant version.
      a79abb65
    • Otto Kekalainen's avatar
      Fix trivial spelling errors · 50c8ef01
      Otto Kekalainen authored
      - agressively -> aggressively
      - exising -> existing
      - occured -> occurred
      - releated -> related
      - seperated -> separated
      - sucess -> success
      - use use -> use
      
      All new code of the whole pull request, including one or several files
      that are either new files or modified ones, are contributed under the
      BSD-new license. I am contributing on behalf of my employer Amazon Web
      Services, Inc.
      50c8ef01
    • Daniel Black's avatar
      rpl_reporting: sprintf -> snprintf · 15ca6c5a
      Daniel Black authored
      This was failing to compile with AppleClang 14.0.0.14000029.
      
      Thanks to Arunesh Choudhary for noticing.
      15ca6c5a
  11. 23 Mar, 2023 3 commits
    • Aleksey Midenkov's avatar
      MDEV-30421 rpl_parallel_*.test cleanup · a8b616d1
      Aleksey Midenkov authored
      Moved rpl_parallel_*.inc to rpl_parallel_*.test
      a8b616d1
    • Marko Mäkelä's avatar
      Merge 11.0 into 11.1 · 9aa098c4
      Marko Mäkelä authored
      9aa098c4
    • Marko Mäkelä's avatar
      MDEV-30911 Multi-batch recovery of ROW_FORMAT=COMPRESSED table hangs · 92772485
      Marko Mäkelä authored
      In commit d6aed216 a condition at
      the start of buf_read_ahead_random() was refactored. Only the caller
      buf_read_recv_pages() was adjusted for this. We must in fact adjust
      every caller and make sure that spare blocks will be allocated
      while crash recovery is in progress. This is the simplest fix;
      ideally recovery would operate on the compressed page frame.
      
      The observed recovery hang occurred because pages 0 and 3 of a
      tablespace were being read due to buf_page_get_gen() calls by
      trx_resurrect_table_locks() before the log records for these pages
      had been applied. In buf_page_t::read_complete() we would skip
      the call to recv_recover_page() because no uncompressed page frame
      had been allocated for the block.
      92772485
  12. 22 Mar, 2023 2 commits