1. 01 Feb, 2023 1 commit
  2. 31 Jan, 2023 2 commits
  3. 30 Jan, 2023 4 commits
  4. 28 Jan, 2023 4 commits
  5. 27 Jan, 2023 1 commit
  6. 26 Jan, 2023 4 commits
  7. 25 Jan, 2023 7 commits
    • Marko Mäkelä's avatar
      e02ed04d
    • Marko Mäkelä's avatar
      82b18a83
    • Jan Lindström's avatar
      MDEV-30465 : Galera test galera_sr.MDEV-27615 takes 5mins · 8bccba1d
      Jan Lindström authored
      After d7d3ad69 we should use KILL_CONNECTION_HARD to interrupt
      debug_sync waits. Test case uses debug_sync and then disconnects
      connection from cluster.
      8bccba1d
    • Jan Lindström's avatar
      MDEV-27977 : galera.galera_UK_conflict fails with wrong result · 509c7f66
      Jan Lindström authored
      Add wait_condition so that all rows expected are really
      replicated before we check it.
      509c7f66
    • Heiko Becker's avatar
      Add missing include for std::runtime_error · 15226a28
      Heiko Becker authored
      Fixes the following error when building with gcc 13:
      
      "tpool/aio_liburing.cc:64:18: error: 'runtime_error' is not a member of 'std'
         64 |       throw std::runtime_error("aio_uring()");"
      15226a28
    • Daniel Black's avatar
      CREDITS: re-instate Tencent Cloud · 765291d6
      Daniel Black authored
      This was an accidential deletion looking at an outdated list.
      765291d6
    • Yuchen Pei's avatar
      MDEV-30370 Fixing spider hang when server aborts · 284810b3
      Yuchen Pei authored
      This is Kentoku's patch for MDEV-22979 (e6e41f04 + 22a00977),
      which fixes 30370.
      
      It changes the wait to a timed wait for the first sts thread, which
      waits on server start to execute the init queries for spider. It also
      flips the flag init_command to false when the sts thread is being
      freed. With these changes the sts thread can check the flag regularly
      and abort the init_queries when it finds out the init_command is
      false. This avoids the deadlock that causes the problem in MDEV-30370.
      
      It also fixes MDEV-22979 for 10.4, but not 10.5. I have not tested
      higher versions for MDEV-22979.
      
      A test has also been done on MDEV-29904 to avoid regression, given
      MDEV-27233 is a similar problem and its patch caused the
      regression. The test passes for 10.4-11.0.
      
      However, this adhoc test only works consistently when placed in the
      main testsuite. We should not place spider tests in the main suite, so
      we do not include it in this commit. A patch for MDEV-27912 should fix
      this problem and allow a proper test for MDEV-29904. See comments in
      the jira ticket MDEV-30370/29904 for the adhoc testcase used for this
      commit.
      284810b3
  8. 24 Jan, 2023 12 commits
    • Vladislav Vaintroub's avatar
      MDEV-30457 Windows, signtool error "No file digest algorithm specified." · 2279ddda
      Vladislav Vaintroub authored
      Add /fd parameter. It is now mandatory for the recent versions of
      signtool
      2279ddda
    • Andrei's avatar
      MDEV-30323 Some DDLs like ANALYZE can complete on parallel slave out of order · 7fe93244
      Andrei authored
      ANALYZE was observed to race over a preceding in binlog order DML
      in updating the binlog and slave gtid states.
      
      Tagging ANALYZE and other admin class commands in binlog by the fixes
      of MDEV-17515 left a flaw allowing such race leading to
      the gtid mode out-of-order error.
      This is fixed now to observe by ADMIN commands the ordered access to
      the slave gtid status variables and binlog.
      7fe93244
    • Andrei's avatar
      MDEV-30010 Slave (additional info): Commit failed due to failure of an earlier... · 3aa04c0d
      Andrei authored
      MDEV-30010 Slave (additional info): Commit failed due to failure of an earlier commit on which this one depends Error_code: 1964
      
      This commit merely adds is a Read-Committed version MDEV-30225 test
      solely to prove the RC isolation yields ROW binlog format as it is
      supposed to per docs.
      3aa04c0d
    • Igor Babaev's avatar
      MDEV-30081 Crash with splitting from constant mergeable derived table · f513d715
      Igor Babaev authored
      This bug manifested itself in very rare situations when splitting
      optimization was applied to a materialized derived table with group clause
      by key over a constant meargeable derived table that was in inner part of
      an outer join. In this case the used tables for the key to access the
      split table incorrectly was evaluated to a not empty table map.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      f513d715
    • Brandon Nesterenko's avatar
      MDEV-29639: Seconds_Behind_Master is incorrect for Delayed, Parallel Replicas · d69e8357
      Brandon Nesterenko authored
      Problem
      ========
      On a parallel, delayed replica, Seconds_Behind_Master will not be
      calculated until after MASTER_DELAY seconds have passed and the
      event has finished executing, resulting in potentially very large
      values of Seconds_Behind_Master (which could be much larger than the
      MASTER_DELAY parameter) for the entire duration the event is
      delayed. This contradicts the documented MASTER_DELAY behavior,
      which specifies how many seconds to withhold replicated events from
      execution.
      
      Solution
      ========
      After a parallel replica idles, the first event after idling should
      immediately update last_master_timestamp with the time that it began
      execution on the primary.
      
      Reviewed By
      ===========
      Andrei Elkin <andrei.elkin@mariadb.com>
      d69e8357
    • Marko Mäkelä's avatar
      MDEV-30400 Assertion height == btr_page_get_level(...) on INSERT · de4030e4
      Marko Mäkelä authored
      This also fixes part of MDEV-29835 Partial server freeze
      which is caused by violations of the latching order that was
      defined in https://dev.mysql.com/worklog/task/?id=6326
      (WL#6326: InnoDB: fix index->lock contention). Unless the
      current thread is holding an exclusive dict_index_t::lock,
      it must acquire page latches in a strict parent-to-child,
      left-to-right order. Not all cases of MDEV-29835 are fixed yet.
      Failure to follow the correct latching order will cause deadlocks
      of threads due to lock order inversion.
      
      As part of these changes, the BTR_MODIFY_TREE mode is modified
      so that an Update latch (U a.k.a. SX) will be acquired on the
      root page, and eXclusive latches (X) will be acquired on all pages
      leading to the leaf page, as well as any left and right siblings
      of the pages along the path. The DEBUG_SYNC test innodb.innodb_wl6326
      will be removed, because at the time the DEBUG_SYNC point is hit,
      the thread is actually holding several page latches that will be
      blocking a concurrent SELECT statement.
      
      We also remove double bookkeeping that was caused due to excessive
      information hiding in mtr_t::m_memo. We simply let mtr_t::m_memo
      store information of latched pages, and ensure that
      mtr_memo_slot_t::object is never a null pointer.
      The tree_blocks[] and tree_savepoints[] were redundant.
      
      buf_page_get_low(): If innodb_change_buffering_debug=1, to avoid
      a hang, do not try to evict blocks if we are holding a latch on
      a modified page. The test innodb.innodb-change-buffer-recovery
      will be removed, because change buffering may no longer be forced
      by debug injection when the change buffer comprises multiple pages.
      Remove a debug assertion that could fail when
      innodb_change_buffering_debug=1 fails to evict a page.
      For other cases, the assertion is redundant, because we already
      checked that right after the got_block: label. The test
      innodb.innodb-change-buffering-recovery will be removed, because
      due to this change, we will be unable to evict the desired page.
      
      mtr_t::lock_register(): Register a change of a page latch
      on an unmodified buffer-fixed block.
      
      mtr_t::x_latch_at_savepoint(), mtr_t::sx_latch_at_savepoint():
      Replaced by the use of mtr_t::upgrade_buffer_fix(), which now
      also handles RW_S_LATCH.
      
      mtr_t::set_modified(): For temporary tables, invoke
      buf_page_t::set_modified() here and not in mtr_t::commit().
      We will never set the MTR_MEMO_MODIFY flag on other than
      persistent data pages, nor set mtr_t::m_modifications when
      temporary data pages are modified.
      
      mtr_t::commit(): Only invoke the buf_flush_note_modification() loop
      if persistent data pages were modified.
      
      mtr_t::get_already_latched(): Look up a latched page in mtr_t::m_memo.
      This avoids many redundant entries in mtr_t::m_memo, as well as
      redundant calls to buf_page_get_gen() for blocks that had already
      been looked up in a mini-transaction.
      
      btr_get_latched_root(): Return a pointer to an already latched root page.
      This replaces btr_root_block_get() in cases where the mini-transaction
      has already latched the root page.
      
      btr_page_get_parent(): Fetch a parent page that was already latched
      in BTR_MODIFY_TREE, by invoking mtr_t::get_already_latched().
      If needed, upgrade the root page U latch to X.
      This avoids bloating mtr_t::m_memo as well as performing redundant
      buf_pool.page_hash lookups. For non-QUICK CHECK TABLE as well as for
      B-tree defragmentation, we will invoke btr_cur_search_to_nth_level().
      
      btr_cur_search_to_nth_level(): This will only be used for non-leaf
      (level>0) B-tree searches that were formerly named BTR_CONT_SEARCH_TREE
      or BTR_CONT_MODIFY_TREE. In MDEV-29835, this function could be
      removed altogether, or retained for the case of
      CHECK TABLE without QUICK.
      
      btr_cur_t::left_block: Remove. btr_pcur_move_backward_from_page()
      can retrieve the left sibling from the end of mtr_t::m_memo.
      
      btr_cur_t::open_leaf(): Some clean-up.
      
      btr_cur_t::search_leaf(): Replaces btr_cur_search_to_nth_level()
      for searches to level=0 (the leaf level). We will never release
      parent page latches before acquiring leaf page latches. If we need to
      temporarily release the level=1 page latch in the BTR_SEARCH_PREV or
      BTR_MODIFY_PREV latch_mode, we will reposition the cursor on the
      child node pointer so that we will land on the correct leaf page.
      
      btr_cur_t::pessimistic_search_leaf(): Implement new BTR_MODIFY_TREE
      latching logic in the case that page splits or merges will be needed.
      The parent pages (and their siblings) should already be latched on
      the first dive to the leaf and be present in mtr_t::m_memo; there
      should be no need for BTR_CONT_MODIFY_TREE. This pre-latching almost
      suffices; it must be revised in MDEV-29835 and work-arounds removed
      for cases where mtr_t::get_already_latched() fails to find a block.
      
      rtr_search_to_nth_level(): A SPATIAL INDEX version of
      btr_search_to_nth_level() that can search to any level
      (including the leaf level).
      
      rtr_search_leaf(), rtr_insert_leaf(): Wrappers for
      rtr_search_to_nth_level().
      
      rtr_search(): Replaces rtr_pcur_open().
      
      rtr_latch_leaves(): Replaces btr_cur_latch_leaves(). Note that unlike
      in the B-tree code, there is no error handling in case the sibling
      pages are corrupted.
      
      rtr_cur_restore_position(): Remove an unused constant parameter.
      
      btr_pcur_open_on_user_rec(): Remove the constant parameter
      mode=PAGE_CUR_GE.
      
      row_ins_clust_index_entry_low(): Use a new
      mode=BTR_MODIFY_ROOT_AND_LEAF to gain access to the root page
      when mode!=BTR_MODIFY_TREE, to write the PAGE_ROOT_AUTO_INC.
      
      BTR_SEARCH_TREE, BTR_CONT_SEARCH_TREE: Remove.
      
      BTR_CONT_MODIFY_TREE: Note that this is only used by
      rtr_search_to_nth_level().
      
      btr_pcur_optimistic_latch_leaves(): Replaces
      btr_cur_optimistic_latch_leaves().
      
      ibuf_delete_rec(): Acquire exclusive ibuf.index->lock in order
      to avoid a deadlock with ibuf_insert_low(BTR_MODIFY_PREV).
      
      btr_blob_log_check_t(): Acquire a U latch on the root page,
      so that btr_page_alloc() in btr_store_big_rec_extern_fields()
      will avoid a deadlock.
      
      btr_store_big_rec_extern_fields(): Assert that the root page latch
      is being held.
      
      Tested by: Matthias Leich
      Reviewed by: Vladislav Lesin
      de4030e4
    • Sergei Petrunia's avatar
      2ed598ea
    • Denis Protivensky's avatar
      MDEV-24623 Replicate bulk insert as table-level exclusive key · 39f46745
      Denis Protivensky authored
      - introduce table key construction function in wsrep service interface
      - don't add row keys when replicating bulk insert
      - don't start bulk insert on applier or when transaction is not active
      - don't start bulk insert on system versioned tables
      - implement actual bulk insert table-level key replication
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      39f46745
    • Daniel Black's avatar
      rpm: ignore man3 · a10003bd
      Daniel Black authored
      During testing of RPM packages in MDEV-30203:
        file /usr/share/man/man3 from install of
        MariaDB-devel-11.0.1-1.el7_9.x86_64 conflicts with file from
        package filesystem-3.2-25.el7.x86_64
      
      MariaDB is the first libmariadb to include man3 man pages
      so make the changes here like what is done for man1 and man8.
      a10003bd
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-30393 InnoDB: Assertion failure in dict0dict.cc upon ADD FULLTEXT INDEX · ef6b3806
      Thirunarayanan Balathandayuthapani authored
      Problem:
      ========
      - InnoDB fails to remove the newly created table or index from
      data dictionary and table cache if the alter fails in commit phase
      
      Solution:
      ========
      - InnoDB should restart the transaction to remove the newly
      created table and index when it fails in commit phase of an alter
      operation. innodb_fts.misc_debug tests the scenario with the
      help of debug point "stats_lock_fail"
      ef6b3806
    • Ian Gilfillan's avatar
      Update 10.5 HELP tables · 2ba6f3d4
      Ian Gilfillan authored
      2ba6f3d4
    • Ian Gilfillan's avatar
      Update 10.3 HELP tables · c4563032
      Ian Gilfillan authored
      c4563032
  9. 23 Jan, 2023 5 commits
    • Ian Gilfillan's avatar
      Update 10.4 HELP tables · 801c0b4b
      Ian Gilfillan authored
      801c0b4b
    • Igor Babaev's avatar
      MDEV-30248 Infinite sequence of recursive calls when processing embedded CTE · 074bef4d
      Igor Babaev authored
      This patch fixes the patch for bug MDEV-30248 that unsatisfactorily
      resolved the problem of resolution of references to CTE. In some cases
      when such a reference has the same table name as the name of one of
      CTEs containing this reference the reference could be resolved incorrectly
      that led to an invalid select tree where units could be mutually dependent.
      This in its turn could lead to an infinite sequence of recursive calls or
      to falls into infinite loops.
      
      The patch also removes LEX::resolve_references_to_cte_in_hanging_cte() as
      with the new code for resolution of CTE references the call of this
      function is not needed anymore.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      074bef4d
    • Andrei's avatar
      MDEV-30423 Deadlock on Replica during BACKUP STAGE BLOCK_COMMIT on XA transactions · dc646c23
      Andrei authored
      The user XA commit execution branch was caught not have been covered
      with MDEV-21953 fixes.
      
      The XA involved deadlock is resolved now to apply the former fixes
      pattern.
      Along the fixes the following changes have been implemented.
      - MDL lock attribute correction
      - dissociation of the externally completed XA from the current
        thread's xid_state in the error branches
      - cleanup_context() preseves the prepared XA
      - wait_for_prior_commit() is relocated to satisfy both
        the binlog ON (log-slave-updates and skip-log-bin)
        and OFF slave execution branches.
      dc646c23
    • Sergei Petrunia's avatar
      MDEV-15178: Filesort::make_sortorder: Assertion `pos->field != __null | · f18c2b6c
      Sergei Petrunia authored
      (Initial patch by Varun Gupta. Amended and added comments).
      
      When the query has both
      1. Aggregate functions that require sorting data by group, and
      2. Window functions
      
      we need to use two temporary tables. The first temp.table will hold the
      join output.  Then it is passed to filesort(). Reading it in sorted
      order allows to compute the aggregate functions.
      
      Then, we need to write their values into the second temp. table. Then,
      Window Function computation step can pass that to filesort() and read
      them in the order it needs.
      
      Failure to create the second temp. table would cause an assertion
      failure: window function could would not find where to get the values
      of the aggregate functions.
      f18c2b6c
    • Ian Gilfillan's avatar
      Update 10.6 HELP tables · 8c2dcfab
      Ian Gilfillan authored
      8c2dcfab