1. 14 Jul, 2006 2 commits
    • unknown's avatar
      Correction for test tesults after pushing the fix for bug 19714. · 1cf79688
      unknown authored
      
      mysql-test/r/ps_7ndb.result:
        Correction for test results after pushing the fix for bug 19714.
      1cf79688
    • unknown's avatar
      Fixed bug #19714. · 31ace3a8
      unknown authored
      DESCRIBE returned the type BIGINT for a column of a view if the column
      was specified by an expression over values of the type INT.
          
      E.g. for the view defined as follows:
        CREATE VIEW v1 SELECT COALESCE(f1,f2) FROM t1
      DESCRIBE returned type BIGINT for the only column of the view if f1,f2 are
      columns of the INT type.
      At the same time DESCRIBE returned type INT for the only column of the table
      defined by the statement:
        CREATE TABLE t2 SELECT COALESCE(f1,f2) FROM t1.
          
      This inconsistency was removed by the patch.
      
      Now the code chooses between INT/BIGINT depending on the
      precision of the aggregated column type.
       
      Thus both DESCRIBE commands above returns type INT for v1 and t2.
       
      
      
      mysql-test/r/analyse.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/bigint.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/create.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/olap.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/ps_2myisam.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/ps_3innodb.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/ps_4heap.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/ps_5merge.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/ps_6bdb.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/ps_7ndb.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/sp.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/subselect.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/type_ranges.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/view.result:
        Added a test case for bug #19714.
      mysql-test/t/view.test:
        Added a test case for bug #19714.
      31ace3a8
  2. 13 Jul, 2006 3 commits
    • unknown's avatar
      Merge moonbone.local:/work/16302-bug-4.1-opt-mysql · 20e4fca6
      unknown authored
      into  moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      sql/item_subselect.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Manual merge
      mysql-test/t/subselect.test:
        Manual merge
      20e4fca6
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 71a94a5b
      unknown authored
      into  moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      mysql-test/r/rpl_insert_id.result:
        Auto merged
      mysql-test/t/rpl_insert_id.test:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      71a94a5b
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e7c6468b
      unknown authored
      into  moonbone.local:/home/evgen/bk-trees/mysql-5.0-opt
      
      
      sql/item.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      e7c6468b
  3. 12 Jul, 2006 3 commits
    • unknown's avatar
      Fix a valgrind warning in type_date test. · b3180c89
      unknown authored
      
      sql/item_timefunc.cc:
        Fix a valgrind warning in type_date test.	
      b3180c89
    • unknown's avatar
      Merge dl145k.mysql.com:/data0/mkindahl/bkroot/mysql-5.0 · 4136cfc3
      unknown authored
      into  dl145k.mysql.com:/data0/mkindahl/bk/mysql-5.0-rpl
      
      
      ndb/include/kernel/GlobalSignalNumbers.h:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      ndb/src/ndbapi/ndberror.c:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      4136cfc3
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · c00cabe9
      unknown authored
      into  moonbone.local:/work/16302-bug-4.1-opt-mysql
      
      
      mysql-test/r/subselect.result:
        SCCS merged
      mysql-test/t/subselect.test:
        SCCS merged
      c00cabe9
  4. 11 Jul, 2006 10 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 9b909022
      unknown authored
      into  moonbone.local:/work/18503-bug-4.1-mysql
      
      
      sql/sql_select.cc:
        Auto merged
      9b909022
    • unknown's avatar
      Fixed bug#18503: Queries with a quantified subquery returning empty set · 6cb398a5
      unknown authored
      may return a wrong result.
      
      An Item_sum_hybrid object has the was_values flag which indicates whether any
      values were added to the sum function. By default it is set to true and reset
      to false on any no_rows_in_result() call. This method is called only in
      return_zero_rows() function. An ALL/ANY subquery can be optimized by MIN/MAX
      optimization. The was_values flag is used to indicate whether the subquery
      has returned at least one row. This bug occurs because return_zero_rows() is
      called only when we know that the select will return zero rows before
      starting any scans but often such information is not known.
      In the reported case the return_zero_rows() function is not called and
      the was_values flag is not reset to false and yet the subquery return no rows
      Item_func_not_all and Item_func_nop_all functions return a wrong
      comparison result.
      
      The end_send_group() function now calls no_rows_in_result() for each item
      in the fields_list if there is no rows were found for the (sub)query.
      
      
      mysql-test/t/subselect.test:
        Added test case for bug#18503: Queries with a quantified subquery returning empty set may return a wrong result.
      mysql-test/r/subselect.result:
        Added test case for bug#18503: Queries with a quantified subquery returning empty set may return a wrong result.
      sql/sql_select.cc:
        Fixed bug#18503: Queries with a quantified subquery returning empty set may return a wrong result.
        
        The end_send_group() function now calls no_rows_in_result() for each item
        in the fields_list if there is no matching rows were found.
      6cb398a5
    • unknown's avatar
      Merge moonbone.local:/work/allany-4.1-mysql · 2f365f04
      unknown authored
      into  moonbone.local:/work/16302-bug-4.1-opt-mysql
      
      2f365f04
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 7ad3c5bf
      unknown authored
      into  moonbone.local:/home/evgen/bk-trees/mysql-4.1-opt
      
      
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      7ad3c5bf
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 9a06032b
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime-merge-41
      
      
      sql/sql_table.cc:
        Auto merged
      9a06032b
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-release · edbc99d9
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-amerge
      
      
      sql/handler.h:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      edbc99d9
    • unknown's avatar
      Raise the version number. · 3d5d9e0b
      unknown authored
      3d5d9e0b
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.0 · cf7a380b
      unknown authored
      into  trift2.:/M50/mysql-5.0
      
      cf7a380b
    • unknown's avatar
      Merge dl145k.mysql.com:/data0/mkindahl/bkroot/mysql-5.0-rpl · 94342039
      unknown authored
      into  dl145k.mysql.com:/data0/mkindahl/bk/MERGE/mysql-5.0-merge
      
      
      ndb/include/kernel/GlobalSignalNumbers.h:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      ndb/src/ndbapi/ndberror.c:
        Auto merged
      94342039
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 0bb02ba4
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime-merge-41
      
      
      sql/opt_range.cc:
        Auto merged
      support-files/mysql.spec.sh:
        Auto merged
      mysql-test/Makefile.am:
        Manual merge.
      0bb02ba4
  5. 10 Jul, 2006 22 commits
    • unknown's avatar
      Fix yet another Windows build failure: "true" -> TRUE · 79c44420
      unknown authored
      
      sql/sql_locale.cc:
        "true" -> TRUE
      79c44420
    • unknown's avatar
      Merge trift2.:/M50/clone-5.0 · b6e3a53a
      unknown authored
      into  trift2.:/M50/mysql-5.0
      
      
      configure.in:
        Auto merged
      b6e3a53a
    • unknown's avatar
      Raise the version number. · 6362eafe
      unknown authored
      6362eafe
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 46db366f
      unknown authored
      into  moonbone.local:/work/allany-4.1-mysql
      
      46db366f
    • unknown's avatar
      Fixed bug#16302: Quantified subquery without any tables gives wrong results · b25d6158
      unknown authored
      The ALL/ANY subqueries are the subject of MIN/MAX optimization. The matter
      of this optimization is to embed MIN() or MAX() function into the subquery
      in order to get only one row by which we can tell whether the expression
      with ALL/ANY subquery is true or false.
      But when it is applied to a subquery like 'select a_constant' the reported bug
      occurs. As no tables are specified in the subquery the do_select() function 
      isn't called for the optimized subquery and thus no values have been added 
      to a MIN()/MAX() function and it returns NULL instead of a_constant.
      This leads to a wrong query result.
      
      For the subquery like 'select a_constant' there is no reason to apply
      MIN/MAX optimization because the subquery anyway will return at most one row.
      Thus the Item_maxmin_subselect class is more appropriate for handling such
      subqueries.
      
      The Item_in_subselect::single_value_transformer() function now checks
      whether tables are specified for the subquery. If no then this subselect is
      handled like a UNION using an Item_maxmin_subselect object.
      
      
      mysql-test/t/subselect.test:
        Added test case for bug#16302: Quantified subquery without any tables gives wrong results
      mysql-test/r/subselect.result:
        Added test case for bug#16302: Quantified subquery without any tables gives wrong results
      sql/item_subselect.cc:
        Fixed bug#16302: Quantified subquery without any tables gives wrong results
         
        The Item_in_subselect::single_value_transformer() function now checks
        whether tables are specified for the subquery. If no then this subselect is
        handled like a UNION using an Item_maxmin_subselect object.
      b25d6158
    • unknown's avatar
      Fix a Windows build failure. · fdbe0141
      unknown authored
      
      sql/sql_locale.cc:
        Fix Windows compilation failure "cannot convert from 'const char [6]' 
        to 'const BOOL'" and an apparent bug (use of "FALSE" instead of FALSE
        for initialization of is_ascii member of MY_LOCALE)
      fdbe0141
    • unknown's avatar
      Revoking patch for Bug#10952 on behalf of Brian. · 2c3fd953
      unknown authored
      2c3fd953
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · 9d85551a
      unknown authored
      into  gbichot3.local:/home/mysql_src/mysql-5.0
      
      9d85551a
    • unknown's avatar
      more 4.1->5.0 merge fixes for bug#14553 · be148b34
      unknown authored
      
      mysql-test/r/rpl_insert_id.result:
        more merge fixes for bug#14553
      mysql-test/t/rpl_insert_id.test:
        more merge fixes for bug#14553
      be148b34
    • unknown's avatar
      Merge macbook.gmz:/Users/kgeorge/mysql/work/B14553-4.1-opt · 4a723e73
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B14553-5.0-opt
      
      
      mysql-test/r/odbc.result:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/rpl_insert_id.result:
        merge the test at the end of 4.1 test
      mysql-test/t/rpl_insert_id.test:
        merge the test at the end of 4.1 test
      sql/sql_class.cc:
        merged
      sql/sql_class.h:
        merged
      4a723e73
    • unknown's avatar
      Merge rakia:mysql/4.1/B14553 · 3cb187a8
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B14553-4.1-opt
      
      
      sql/sql_class.cc:
        SCCS merged
      sql/sql_select.cc:
        SCCS merged
      3cb187a8
    • unknown's avatar
      BUG#14553: NULL in WHERE resets LAST_INSERT_ID · cc6a70e7
      unknown authored
      To make MySQL compatible with some ODBC applications, you can find
      the AUTO_INCREMENT value for the last inserted row with the following query:
       SELECT * FROM tbl_name WHERE auto_col IS NULL.
      This is done with a special code that replaces 'auto_col IS NULL' with
      'auto_col = LAST_INSERT_ID'.
      However this also resets the LAST_INSERT_ID to 0 as it uses it for a flag
      so as to ensure that only the first SELECT ... WHERE auto_col IS NULL
      after an INSERT has this special behaviour.
      In order to avoid resetting the LAST_INSERT_ID a special flag is introduced
      in the THD class. This flag is used to restrict the second and subsequent
      SELECTs instead of LAST_INSERT_ID.
      
      
      mysql-test/r/odbc.result:
        test suite for the bug
      mysql-test/r/rpl_insert_id.result:
        test for the fix in replication
      mysql-test/t/odbc.test:
        test suite for the bug
      mysql-test/t/rpl_insert_id.test:
        test for the fix in replication
      sql/sql_class.cc:
        initialize the flag
      sql/sql_class.h:
        flag's declaration and set code when setting the last_insert_id
      sql/sql_select.cc:
        the special flag is used instead of last_insert_id
      cc6a70e7
    • unknown's avatar
      Fix test results to be vardir-independent. · 889f1b3d
      unknown authored
      
      mysql-test/r/myisam.result:
        Fix test results.
      mysql-test/t/myisam.test:
        In 5.0 show create table also outputs data directory.
        For the test for Bug#8706 it's MYSQLTEST_VARDIR, and there is no way
        to replace it with anything else in test output.
      889f1b3d
    • unknown's avatar
      Merge orca.ndb.mysql.com:/space_old/pekka/ndb/version/my50 · 49ce58f4
      unknown authored
      into  orca.ndb.mysql.com:/space_old/pekka/ndb/version/my50-1.2167.1.2
      
      
      ndb/include/kernel/GlobalSignalNumbers.h:
        Auto merged
      ndb/src/common/debugger/signaldata/SignalNames.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        Auto merged
      ndb/test/run-test/daily-basic-tests.txt:
        Auto merged
      49ce58f4
    • unknown's avatar
      ndb - bug#18781: close a tiny window (re-commit, try to by-pass merge jam) · 7bb7cd45
      unknown authored
      
      ndb/src/kernel/blocks/dbdict/DictLock.txt:
        wait until SL_STARTED before sending DICT_UNLOCK_ORD
      ndb/src/kernel/blocks/dbdih/Dbdih.hpp:
        wait until SL_STARTED before sending DICT_UNLOCK_ORD
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        wait until SL_STARTED before sending DICT_UNLOCK_ORD
      ndb/src/kernel/vm/SimulatedBlock.cpp:
        wait until SL_STARTED before sending DICT_UNLOCK_ORD
      ndb/src/kernel/vm/SimulatedBlock.hpp:
        wait until SL_STARTED before sending DICT_UNLOCK_ORD
      ndb/test/run-test/daily-basic-tests.txt:
        wait until SL_STARTED before sending DICT_UNLOCK_ORD
      7bb7cd45
    • unknown's avatar
      ndb - bug#18781 : 5.0 : add NODE_START_REP from 5.1 (re-commit, try to by-pass merge jam) · ae7f89a6
      unknown authored
      
      ndb/include/kernel/GlobalSignalNumbers.h:
        5.0 : add NODE_START_REP from 5.1
      ndb/src/common/debugger/signaldata/SignalNames.cpp:
        5.0 : add NODE_START_REP from 5.1
      ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        5.0 : add NODE_START_REP from 5.1
      ndb/src/kernel/vm/SimulatedBlock.cpp:
        5.0 : add NODE_START_REP from 5.1
      ndb/src/kernel/vm/SimulatedBlock.hpp:
        5.0 : add NODE_START_REP from 5.1
      ae7f89a6
    • unknown's avatar
      A post-merge fix (Bug#8706 "temporary table with data directory option · f7e1cd34
      unknown authored
      fails"
      
      
      mysql-test/t/myisam.test:
        Fix myisam.test to work with non-default mysqltest var directory.
      f7e1cd34
    • unknown's avatar
      Add sql_locale.cpp to our windows build scripts. · bb8e0660
      unknown authored
      
      VC++Files/libmysqld/libmysqld.dsp:
        Add sql_locale.cpp
      VC++Files/libmysqld/libmysqld.vcproj:
        Add sql_locale.cpp
      VC++Files/sql/mysqld.dsp:
        Add sql_locale.cpp
      VC++Files/sql/mysqld.vcproj:
        Add sql_locale.cpp
      bb8e0660
    • unknown's avatar
      Merge pnousiainen@bk-internal.mysql.com:/home/bk/mysql-5.0 · af691276
      unknown authored
      into  orca.ndb.mysql.com:/space_old/pekka/ndb/version/my50
      
      af691276
    • unknown's avatar
      ndb - bug#20847: non-debug compile fix (repeat since cannot merge 4.1->5.0) · 7b153bb5
      unknown authored
      
      ndb/src/kernel/blocks/dbtup/DbtupMeta.cpp:
        non-debug compile fix
      7b153bb5
    • unknown's avatar
      Merge dsl-hkigw8-feb1fb00-100.dhcp.inet.fi:/usr_rh9/home/elkin.rh9/MySQL/TEAM/BARE/4.1 · 2adcbfc4
      unknown authored
      into  dsl-hkigw8-feb1fb00-100.dhcp.inet.fi:/usr_rh9/home/elkin.rh9/MySQL/TEAM/FIXES/5.0/20919_temp_nlog
      
      
      sql/sql_base.cc:
        Manual merge
      2adcbfc4
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.0 · 0f9a1427
      unknown authored
      into  trift2.:/M50/mysql-5.0
      
      0f9a1427