- 13 Dec, 2022 5 commits
-
-
Marko Mäkelä authored
-
Sergei Golubchik authored
-
Marko Mäkelä authored
-
Jan Lindström authored
galera.galera_bf_abort_at_after_statement disabled by Daniel Black
-
Daniel Black authored
-
- 12 Dec, 2022 3 commits
-
-
Daniel Black authored
-
Daniel Black authored
Hide the errors related to missing innodb stats tables in bootstrap mode on the assumption that because we are in bootstrap mode they are going to be created.
-
Daniel Black authored
-
- 10 Dec, 2022 1 commit
-
-
Julius Goryavsky authored
This commit fixes the test system hanging due to the galera_var_notify_ssl_ipv6 test and also brings the wsrep_notify[_ssl].sh files in line with each other between the user template and the mtr suite. Quotes are also added here to avoid problems if the user specifies the value of one of the variables at the beginning of the file containing shell-specific characters, for example, if the password or username specified in the PSWD and USER variables will contain the "$" character. Also fixed an issue with automatic --ssl-verify-server-cert option substitution when the corresponding value is set by the user to "1" or "on". Also fixed some tests here to avoid joining one of the nodes to another cluster when the nodes are restarted from the mtr side, which can lead to random failures when testing with buildbot.
-
- 09 Dec, 2022 2 commits
-
-
Julius Goryavsky authored
This commit fixes the test system hanging due to the galera_var_notify_ssl_ipv6 test and also brings the wsrep_notify[_ssl].sh files in line with each other between the user template and the mtr suite. Quotes are also added here to avoid problems if the user specifies the value of one of the variables at the beginning of the file containing shell-specific characters, for example, if the password or username specified in the PSWD and USER variables will contain the "$" character. Also fixed an issue with automatic --ssl-verify-server-cert option substitution when the corresponding value is set by the user to "1" or "on". Also fixed some tests here to avoid joining one of the nodes to another cluster when the nodes are restarted from the mtr side, which can lead to random failures when testing with buildbot.
-
Marko Mäkelä authored
mysql_discard_or_import_tablespace(): On successful ALTER TABLE...DISCARD TABLESPACE, evict the table handle from the table definition cache, so that ha_innobase::close() will be invoked, like InnoDB expects to be the case. This will avoid an assertion failure ut_a(table->get_ref_count() == 0) during IMPORT TABLESPACE. ha_innobase::open(): Do not issue any ER_TABLESPACE_DISCARDED warning. Member functions for DML will do that. ha_innobase::truncate(), ha_innobase::check_if_supported_inplace_alter(): Issue ER_TABLESPACE_DISCARDED warnings, to compensate for the removal of the warning in ha_innobase::open(). row_quiesce_write_indexes(): Only write information about committed indexes. The ALTER TABLE t NOWAIT ADD INDEX(c) in the nondeterministic test case will most of the time fail due to a metadata lock (MDL) timeout and leave behind an uncommitted index. Reviewed by: Sergei Golubchik
-
- 08 Dec, 2022 2 commits
-
-
Daniel Black authored
The geometry type requires Type:"Feature" but the feature need not be first in the JSON structure. Adjust code to return an error if geometry isn't a JSON object, but continue parsing searching for Type: "Feature" to trigger the geometry parsing. Thanks Derick Magnusen for the bug report.
-
Tuukka Pasanen authored
Convert minimal amount of Lintian overrides to make Lintian test pass also with Debian Sid latest Lintian 2.115 version. Old style overrides are kept so they can be used with older versions of Lintian. Introduce minimal Lintian overrides which are common from MariaDB version 10.5 up-to to 10.8. Overrides added files: * debian/mariadb-test-data.lintian-overrides - MariaDB installs some shared objects to test-suite directory and not in '/usr/lib' or similar. Share objects is pam_mariadb_mtr.so. Tags are arch-dependent-file-in-usr-share and arch-independent-package-contains-binary-or-object Lintia * debian/mariadb-test.lintian-overrides - MariaDB installs some some binaries to test-sute directory and in mariadb-test package they are my_safe_process and wsrep_check_version. Tags is arch-dependent-file-in-usr-share * debian/source/lintian-overrides - In source there is some source files missing which should be addressed sql/share/charsets/languages.html and and storage/rocksdb/rocksdb/docs/_includes/footer.html. Tags is source-is-missing - Add Lintian override for missing: storage/columnstore/columnstore/utils/jemalloc/libjemalloc.so.2 - Add Lintian override for substvar external resources: ${source:Version} libmariadb-dev -> libmysqlclient-dev [debian/control:66] ${source:Version} libmariadb-dev -> libmysqld-dev [debian/control:66] ${source:Version} libmariadbd-dev -> libmariadbclient-dev [debian/control:216]
-
- 07 Dec, 2022 3 commits
-
-
Vladislav Vaintroub authored
Add retry logic for CreateFile, DeleteFile, or MoveFile when GetLastError() is ERROR_SHARING_VIOLATION.
-
Nayuta Yanagisawa authored
MDEV-29636 Assertion `part_share->auto_inc_initialized || !can_use_for_auto_inc_init()' failed in ha_partition::set_auto_increment_if_higher upon REPLACE with partition pruning The bug is caused by a similar mechanism as MDEV-21027. The function, check_insert_or_replace_autoincrement, failed to open all the partitions on REPLACE SELECT statements and it results in the assertion error.
-
Jan Lindström authored
* Delete tests that are not supported and not going to be supported any time soon * Fix result set on tests that are not run on bb * Fix tests that fail because of auto increment offset * Make sure that disabled tests have open bug report
-
- 05 Dec, 2022 2 commits
-
-
Anel Husakovic authored
- Regression introduced 7baf24a0 for multidigit gcc dump. There is no dot in `dumpversion`. ``` $ gcc -dumpversion 10 ``` Otherwise it will fail and not produce the output ``` Running dgcov Name "IO::Uncompress::Gunzip::GunzipError" used only once: possible typo at ./dgcov.pl line 197. Cannot parse gcc -dumpversion: 9 ``` - The warning `once` is always generated: ``` Running dgcov Name "IO::Uncompress::Gunzip::GunzipError" used only once: possible typo at ./dgcov.pl line 197. <number> ``` Suppresing the line `Name "IO::Uncompress::Gunzip::GunzipError" used only once: possible typo at ./dgcov.pl line 197.` with the patch. - Reviewed by: <>
-
Monty authored
This could happen if one did a DML with a moved table that one had done an external zerofill on. The crash happend because a message that was supposed to be sent to a repair report was instead sent to the result, which caused an ASSERT
-
- 03 Dec, 2022 1 commit
-
-
Sergei Golubchik authored
and enable option bundling
-
- 02 Dec, 2022 17 commits
-
-
Sergei Golubchik authored
* update README * fix version regex to support versions with two digits * die if the version cannot be parsed * support gcc versions 11+ * require JSON::PP not use, to avoid introducing new rpm dependency into MariaDB-test
-
Anel Husakovic authored
- Script covers situation for gcov (gcc) < 9 with non-json format of generated files as well as for gcov (gcc) >=8 with json generated format Reviewed by: serg@mariadb.com
-
Sergei Golubchik authored
sometimes `KILL QUERY ID @id` was executed before the previous `send SELECT SLEEP(1000)` has reached the parser. As the statement resets the kill status before execution, the effect of the KILL was ignored.
-
Sergei Golubchik authored
Item_func_not_all::print() either uses Item_func::print() or directly invokes args[0]->print(). Thus the precedence should be either the one of Item_func or of args[0]. Item_allany_subselect::print() prints args[0], then a comparison op, then a subquery. That is, the precedence should be the one of a comparison.
-
Sergei Golubchik authored
detect non-determinism in vcol of vcol, like: create table t1 (a int, b real as (rand()), c real as (b) stored);
-
Sergei Golubchik authored
change vcol_upgrade test to use stored gcols
-
Sergei Golubchik authored
rename to stress that is a specific hack for Item_func_nextval and should not be used for other items. If a vcol uses Item_func_nextval, a corresponding table for the sequence should be added to the prelocking list (in that sense NEXTVAL is not simply a function, but more like a subquery), see add_internal_tables() in DML_prelocking_strategy::handle_table(). At the moment it is only implemented for DEFAULT, not for GENERATED ALWAYS AS, thus the VCOL_NEXTVAL hack.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
remove dead code
-
Sergei Golubchik authored
&fake_argv cannot be cast to char*** this causes a crash when resolving
-
Sergei Golubchik authored
select_union_direct::send_data() only sends a record when the LIMIT ... OFFSET clause of the individual select won't skip it. Thus, select_union_direct::send_data() should not do any actions related to a sending a record if the offset of a select isn't reached yet
-
Sergei Golubchik authored
-
Sergei Golubchik authored
protect shared dict_table_t::vc_templ with a mutex, same as in ha_innobase::open
-
Sergei Golubchik authored
-
Oleksandr Byelkin authored
Decent name given to the column.
-
Thirunarayanan Balathandayuthapani authored
- Mariabackup fails to open the undo tablespaces while applying delta files to the corresponding data file. Mariabackup opens the undo tablespaces first time in srv_undo_tablespaces_init() and does tries to open the undo tablespaces in xtrabackup_apply_deltas() with conflicting mode and leads to the failure. - Mariabackup should close the undo tablespaces before applying the incremental delta files.
-
Alexander Barkov authored
MDEV-28696 View created as "select b''; " references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them
-
- 01 Dec, 2022 2 commits
-
-
Aleksey Midenkov authored
Like in MDEV-16110 we must release items allocated on thd->mem_root by reopening the table. MDEV-16290 relocated MDEV-16110 fix in 10.5 so it works for MDEV-28576 as well. 10.3 without MDEV-16290 now duplicates this fix.
-
Marko Mäkelä authored
This fixes up 4eb8e51c which missed a second parent.
-
- 30 Nov, 2022 2 commits
-
-
Vicențiu Ciorbaru authored
The change from MDEV-29465 exposed a flaw in replace_column_table where again we were not properly updating the column-level bits. replace_table_table was changed in MDEV-29465 to properly update grant_table->init_cols, however replace_column_table still only modified grant_column->rights when the GRANT_COLUMN already existed. This lead to a missmatch between GRANT_COLUMN::init_rights and GRANT_COLUMN::rights, *if* the GRANT_COLUMN already existed. As an example: GRANT SELECT (col1) ... Here: For col1 GRANT_COLUMN::init_rights and GRANT_COLUMN::rights are set to 1 (SELECT) in replace_column_table. GRANT INSERT (col1) ... Here, without this patch GRANT_COLUMN::init_rights is still 1 and GRANT_COLUMN::rights is 3 (SELECT_PRIV | INSERT_PRIV) Finally, if before this patch, one does: REVOKE SELECT (col1) ... replace_table_table will see that init_rights loses bit 1 thus it considers there are no more rights granted on that particular table. This prompts the whole GRANT_TABLE to be removed via the first revoke, when the GRANT_COLUMN corresponding to it should still have init_rights == 2. By also updating replace_column_table to keep init_rights in sync properly, the issue is resolved. Reviewed by <serg@mariadb.com>
-
Jan Lindström authored
-