1. 04 May, 2021 1 commit
  2. 03 May, 2021 1 commit
  3. 02 May, 2021 1 commit
  4. 01 May, 2021 1 commit
  5. 30 Apr, 2021 6 commits
  6. 29 Apr, 2021 7 commits
    • Marko Mäkelä's avatar
      MDEV-25524 fixup for Windows · db078224
      Marko Mäkelä authored
      In commit 54e2e701
      we relaxed a debug assertion in the POSIX version of
      os_file_rename_func() only. Let us relax it also on Windows,
      so that the test innodb.truncate_crash will pass.
      db078224
    • Marko Mäkelä's avatar
      MDEV-25524 heap-use-after-free in fil_space_t::rename() · 54e2e701
      Marko Mäkelä authored
      In commit 91599701 (MDEV-25312)
      some recovery code for TRUNCATE TABLE was broken
      causing a regression in a case where undo log for a RENAME TABLE
      operation had been durably written but the tablespace had not been
      renamed yet.
      
      row_rename_table_for_mysql(): Add a DEBUG_SYNC point for the
      test case, and simplify the logic and trim the error messages.
      
      fil_space_t::rename(): Simplify the operation. Merge the necessary
      part of fil_rename_tablespace_check(). If there is no change to
      the file name, do nothing.
      
      dict_table_t::rename_tablespace(): Refactored from
      dict_table_rename_in_cache().
      
      row_undo_ins_parse_undo_rec(): On rolling back TRX_UNDO_RENAME_TABLE,
      invoke dict_table_t::rename_tablespace() even if the table name matches.
      
      os_file_rename_func(): Temporarily relax an assertion that would
      fail during the recovery in the test innodb.truncate_crash.
      54e2e701
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 55e0ce14
      Marko Mäkelä authored
      55e0ce14
    • Sergei Golubchik's avatar
      MDEV-25530 Error 1451 on slave: Cannot delete or update a parent row: a... · e8b9d8d3
      Sergei Golubchik authored
      MDEV-25530 Error 1451 on slave: Cannot delete or update a parent row: a foreign key constraint fails
      
      after dfb41fdd tables that failed to drop are excluded from the
      binlogged DROP TABLE statement. It means that the slave should not
      expect any errors when executing DROP TABLE, and the binlog should
      report that no error has happened, even if it was.
      
      Do not write error code into the binlogged DROP TABLE,
      and remove all code that was needed to compute it.
      e8b9d8d3
    • Kentoku SHIBA's avatar
      MDEV-22265 Connect string character limit too small for full 64 character... · cec8ea3a
      Kentoku SHIBA authored
      MDEV-22265 Connect string character limit too small for full 64 character InnoDB table-name limit when using ad-hoc Spider server definitions.
      
      Fix length for getting default table name.
      cec8ea3a
    • Jan Lindström's avatar
      Update wsrep-lib · aed8605d
      Jan Lindström authored
      aed8605d
    • mkaruza's avatar
      MDEV-22131 allow transition from unencrypted to TLS cluster communication without cluster downtime · c409dd42
      mkaruza authored
      Cluster communication should be possible even when:
      
      1. Node 2 is TCP
      2. Node 1/3 is dynamic with SSL enabled
      
      During test we shutdown Node 2 and enable SSL on it. It should connect
      back to cluster successfully.
      c409dd42
  7. 28 Apr, 2021 10 commits
    • Vladislav Vaintroub's avatar
      MDEV-24382 Assertion in tdc_remove_table · 65e73b56
      Vladislav Vaintroub authored
      The assert is no more reproducible in the lastest 10.5-10.6
      
      The patch only adds testcase from MDEV-24382.
      65e73b56
    • Marko Mäkelä's avatar
      MDEV-25534 Assertion lock_table_has...LOCK_IX · 98e3034e
      Marko Mäkelä authored
      ha_innobase::start_stmt(): Always set m_prebuilt->sql_stat_start.
      
      row_search_mvcc(): Cleanup: Simplify debug assertions.
      98e3034e
    • Marko Mäkelä's avatar
      MDEV-25522: Purge of aborted ADD INDEX leaves orphan locks behind · a29618f3
      Marko Mäkelä authored
      lock_discard_for_index(): New function, to discard locks for an
      index whose index tree has been purged. By definition, such indexes
      must be ones for which the MDL upgrade failed in inplace ALTER TABLE
      and the ADD INDEX operation was never committed.
      Note: Because we do not support online ADD SPATIAL INDEX, we only
      have to traverse the lock_sys.rec_hash for B-trees and not the
      hash tables for R-trees.
      
      row_purge_remove_clust_if_poss_low(): Invoke lock_discard_for_index()
      if necessary before dropping a B-tree for a SYS_INDEXES record.
      a29618f3
    • Marko Mäkelä's avatar
      5abb505a
    • Marko Mäkelä's avatar
      MDEV-25491: Race condition between DROP TABLE and purge of SYS_INDEXES record · f619d79b
      Marko Mäkelä authored
      btr_free_if_exists(): Always use the BUF_GET_POSSIBLY_FREED mode
      when accessing pages, because due to MDEV-24589 the function
      fil_space_t::set_stopping(true) can be called at any time during
      the execution of this function.
      
      mtr_t::m_freeing_tree: New data member for debugging purposes.
      
      buf_page_get_low(): Assert that the BUF_GET mode is not being used
      anywhere during the execution of btr_free_if_exists().
      
      In all code related to freeing or allocating pages, we will add some
      robustness, by making more use of BUF_GET_POSSIBLY_FREED and by
      reporting an error instead of crashing in some cases of corruption.
      f619d79b
    • Marko Mäkelä's avatar
      MDEV-25491 preparation: Clean up tablespace destruction · a81aec15
      Marko Mäkelä authored
      fil_check_pending_ops(), fil_check_pending_io(): Remove.
      These functions were actually duplicating each other ever since
      commit 118e258a (MDEV-23855).
      
      fil_space_t::check_pending_operations(): Replaces
      fil_check_pending_operations() and incorporates the logic of
      fil_check_pending_ops(). Avoid unnecessary lookups for the tablespace.
      Just wait for the reference count to drop to zero.
      
      fil_space_t::io(): Remove an unnecessary condition. We can (and
      probably better should) refuse asynchronous reads of undo tablespaces
      that are being truncated.
      
      fil_truncate_prepare(): Remove.
      
      trx_purge_truncate_history(): Implement the necessary steps that used
      to be in fil_truncate_prepare().
      a81aec15
    • Krunal Bauskar's avatar
      MDEV-25093: Adaptive flushing fails to kick in even if · 3f4b7ed9
      Krunal Bauskar authored
                  innodb_adaptive_flushing_lwm is hit. (possible regression)
      
      adaptive flushing should kick in if
      a. dirty_pct (dirty pages in buffer pool) > innodb_max_dirty_pages_pct_lwm
      OR
      b. innodb_adaptive_flushing_lwm limit is reached (default to 10%)
      
      both conditions are mutually exclusive and whichever is first to evaluate
      true should kick-start the adaptive flushing.
      
      After recent changes to simplify the flushing algorithm logic, (b) got ignored
      that introduced the said regression.
      3f4b7ed9
    • Daniele Sciascia's avatar
      MDEV-25553 : Avoid unnecessary rollbacks with SR · b1b2689f
      Daniele Sciascia authored
      This patch changes statement rollback for streaming replication.
      Previously, a statement rollback was turned into full transaction
      rollback in the case where the transaction had already replicated a
      fragment. This was introduced in the initial implementation of
      streaming replication due to the fact that we do not have a mechanism
      to perform a statement rollback on the applying side.
      This policy is however overly pessimistic, causing full rollbacks even
      in cases where a local statement rollback, would not require a
      statement rollback on the applying side. This happens to be case when
      the statement itself has not replicated any fragments.
      So the patch changes the condition that determines if a statement
      rollback should be turned into a full rollback accordingly.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      b1b2689f
    • mkaruza's avatar
      MDEV-22227 Assertion `state_ == s_exec' failed in wsrep::client_state::start_transaction · 206d630e
      mkaruza authored
      Removed redundant code for BF abort transaction in `thr_lock.cc`.
      
      TOI operations will ignore provided lock_wait_timeout and use `LONG_TIMEOUT`
      until operation is finished.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      206d630e
    • Kentoku SHIBA's avatar
      MDEV-22265 Connect string character limit too small for full 64 character... · b3d963fe
      Kentoku SHIBA authored
      MDEV-22265 Connect string character limit too small for full 64 character InnoDB table-name limit when using ad-hoc Spider server definitions.
      
      Fix length for getting default table name.
      b3d963fe
  8. 27 Apr, 2021 6 commits
  9. 26 Apr, 2021 7 commits
    • Daniel Black's avatar
      MDEV-25513: raise systemd LimitNOFILE limits to match server defaults · a35cde8c
      Daniel Black authored
      Quoting MDEV reporter Daniel Lewart:
      
      Starting MariaDB with default configuration causes the following problems:
      
          "[Warning] Could not increase number of max_open_files to more than 16384 (request: 32186)"
          silently reduces table_open_cache_instances from 8 (default) to 4
      
      Default Server System Variables:
      
          extra_max_connections = 1
          max_connections = 151
          table_open_cache = 2000
          table_open_cache_instances = 8
          thread_pool_size = 4
      
      LimitNOFILE=16834 is in the following files:
      
          support-files/mariadb.service.in
          support-files/mariadb@.service.in
      
      Looking at sql/mysqld.cc lines 3837-3917:
      wanted_files= (extra_files + max_connections + extra_max_connections +
      tc_size * 2 * tc_instances);
      wanted_files+= threadpool_size;
      
      Plugging in the default values:
      wanted_files = (30 + 151 + 1 + 2000 * 2 * 8 + 4) = 32186
      
      However, systemd configuration has LimitNOFILE = 16384, which is far smaller.
      
      I suggest increasing LimitNOFILE to 32768.
      a35cde8c
    • Marko Mäkelä's avatar
      MDEV-24758 heap-use-after-poison in innobase_add_instant_try/rec_copy · 4d412e98
      Marko Mäkelä authored
      This is a backport of
      commit fd9ca2a7 (MDEV-23295) and
      commit 9a156e1a (MDEV-23345) to 10.3.
      
      An instant ADD/DROP/reorder column could create a dummy table
      object with the wrong ROW_FORMAT when innodb_default_row_format
      was changed between CREATE TABLE and ALTER TABLE.
      
      prepare_inplace_alter_table_dict(): If we had promised that
      ALGORITHM=INPLACE is supported, we must preserve the ROW_FORMAT.
      
      The rest of the changes are related to adding
      Alter_inplace_info::inplace_supported to cache the return value of
      handler::check_if_supported_inplace_alter().
      4d412e98
    • Daniel Bartholomew's avatar
      bump the VERSION · 9db14e93
      Daniel Bartholomew authored
      9db14e93
    • Marko Mäkelä's avatar
      MDEV-15756: Remove some garbage output · dd07cfce
      Marko Mäkelä authored
      os_aio_print(): Remove output that should have been removed in
      commit 5e62b6a5 (MDEV-16264).
      dd07cfce
    • Daniele Sciascia's avatar
      Fix MTR test wsrep.variables_debug · 9e6310e3
      Daniele Sciascia authored
      The test was changing variable wsrep_provider dynamically,
      but wsrep_provider was recently made read-only.
      
      followup for ce3a2a68
      9e6310e3
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · ed4b2b3f
      Marko Mäkelä authored
      ed4b2b3f
    • Sujatha's avatar
      MDEV-24773: slave_compressed_protocol doesn't work properly with semi-sync replication · 391f1aa6
      Sujatha authored
      Back port upstream fix
      
      commit 1800b015a1d487330f7b15f2020b887be348a66b
      Author: Venkatesh Duggirala <venkatesh.duggirala@oracle.com>
      Date:   Fri Sep 8 20:29:22 2017 +0530
      
      Bug#26027024    SLAVE_COMPRESSED_PROTOCOL DOESN'T WORK WITH
      SEMI-SYNC REPLICATION IN MYSQL-5.7
      
      Analysis: In mysql-5.6, dump thread (the thread that is created
      on Master after Slave requested for a binlog dump) is also used
      to receive acknowledgements from the Slave and act on them accordingly.
      For performance reasons, a special thread called Ack Receiver thread
      is added in mysql-5.7 Semi synchronous replication plugin.
      This thread does not have special handling to receive acknowledgements
      if Slave has enabled compression in the protocol. Hence Master is
      unable to handle any slave if Slave_compressed_protocol is enabled
      on it.
      
      Fix: Enable compress flag on the communication channels if the Slave
      has Slave_compressed_protocol ON.
      391f1aa6