1. 17 Jun, 2008 4 commits
    • Mattias Jonsson's avatar
      Bug#35931 Index search of partitioned MyISAM table · 202212fa
      Mattias Jonsson authored
      returns erroneous results
      
      Used the wrong function when fixing 30480 which lead to
      no stop on end_key resulting in duplicate results from index scan
      
      Includes test cases for the duplicates 37327 and 37329,
      Duplicate rows and bad performance/High Handler_read_next values
      
      Recommit after merge issues
      
      mysql-test/r/partition.result:
        Bug#35931 List partition MyISAM table returns erroneous results
        
        added test results.
      mysql-test/t/partition.test:
        Bug#35931 List partition MyISAM table returns erroneous results
        
        added test for 35931, 37327 and 37329.
      sql/ha_partition.cc:
        Bug#35931 List partition MyISAM table returns erroneous results
        
        HA_READ_ORDER is a index_flag, not a table_flag.
        Error made in 30480.
      202212fa
    • Tatiana A. Nurnberg's avatar
      Fix for Bug#16902. · 42aef642
      Tatiana A. Nurnberg authored
      42aef642
    • Tatiana A. Nurnberg's avatar
      Bug#36492: make dist and make install fails · be3d3826
      Tatiana A. Nurnberg authored
      Ignore BitKeeper SCCS folders in make-dist
      be3d3826
    • Tatiana A. Nurnberg's avatar
      Bug#36492: make dist and make install fails · 5129d9c1
      Tatiana A. Nurnberg authored
      Ignore BitKeeper SCCS folders in make-dist
      
      mysql-test/Makefile.am:
        Ignore BitKeeper SCCS folders in make-dist
        (copy only .txt files).
      5129d9c1
  2. 16 Jun, 2008 1 commit
  3. 13 Jun, 2008 2 commits
  4. 09 Jun, 2008 1 commit
  5. 04 Jun, 2008 1 commit
  6. 03 Jun, 2008 3 commits
    • Davi Arnaut's avatar
      Bug#33362: Query cache invalidation (truncate) may hang · 9fca54f7
      Davi Arnaut authored
                 if cached query uses many tables
      
      The problem was that query cache would not properly cache
      queries which used 256 or more tables but yet would leave
      behind query cache blocks pointing to freed (destroyed)
      data. Later when invalidating (due to a truncate) query cache
      would attempt to grab a lock which resided in the freed data,
      leading to hangs or undefined behavior.
      
      This was happening due to a improper return value from the
      function responsible for registering the tables used in the
      query (so the cache can be invalidated later if one of the
      tables is modified). The function expected a return value of
      type boolean (char, 8 bits) indicating success (1) or failure
      (0) but the number of tables registered (unsigned int, 32 bits)
      was being returned instead. This caused the function to return
      failure for cases where it had actually succeed because when
      a type (unsigned int) is converted to a narrower type (char),
      the excess bits on the left are discarded. Thus if the 8
      rightmost bits are zero, the return value will be 0 (failure).
      
      The solution is to simply return true (1) only if the number of
      registered table is greater than zero and false (0) otherwise.
      
      mysql-test/r/query_cache_merge.result:
        Add test case result for Bug#33362
      mysql-test/t/query_cache_merge.test:
        Add test case for Bug#33362
      sql/sql_cache.cc:
        Return 1 or 0 depending on the number of registered tables.
      9fca54f7
    • Mattias Jonsson's avatar
      Bug#31210: INSERT DELAYED crashes server when used on partitioned tables · 4eace597
      Mattias Jonsson authored
        
      Problem was an unclear error message since it could suggest that
      MyISAM did not support INSERT DELAYED.
      Changed the error message to say that DELAYED is not supported by the
      table, instead of the table's storage engine.
      The confusion is that a partitioned table is in somewhat sense using
      the partitioning storage engine, which in turn uses the ordinary
      storage engine. By saying that the table does not support DELAYED we
      do not give any extra informantion about the storage engine or if it
      is partitioned.
      
      mysql-test/r/innodb-replace.result:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      mysql-test/t/innodb-replace.test:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      mysql-test/t/merge.test:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      mysql-test/t/partition_hash.test:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      sql/share/errmsg.txt:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        added error message for tables not supporting DELAYED
      sql/sql_insert.cc:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      4eace597
    • Matthias Leich mleich@mysql.com's avatar
      Upmerge of fix for · 5891c6c1
      Matthias Leich mleich@mysql.com authored
      Bug 36788 Multiple funcs_1 'trig' tests are failing on vanilla builds
      5891c6c1
  7. 02 Jun, 2008 1 commit
    • Matthias Leich mleich@mysql.com's avatar
      Bug#36788 Multiple funcs_1 'trig' tests are failing on vanilla builds · c21508a6
      Matthias Leich mleich@mysql.com authored
      Fix for this bug and additional improvements/fixes
      In detail:
      - Remove unicode attribute from several columns
        (unicode properties were nowhere needed/tested)
        of the table tb3
        -> The runnability of these tests depends no more on
           the availibility of some optional collations.
      - Use a table tb3 with the same layout for all
        engines to be tested and unify the engine name
        within the protocols.
        -> <engine>_trig_<abc>.result have the same content
      - Do not load data into tb3 if these rows have no
        impact on result sets
      - Add tests for NDB (they exist already in 5.1)
      - "--replace_result" at various places because
        NDB variants of tests failed with "random" row
        order in results
        This fixes a till now unknown weakness within the
        funcs_1 NDB tests existing in 5.1 and 6.0
      - Fix the expected result of ndb_trig_1011ext
        which suffered from Bug 32656
        + disable this test
      - funcs_1 could be executed with the mysql-test-run.pl
        option "--reorder", which saves some runtime by
        optimizing server restarts.
        Runtimes on tmpfs (one attempt only):
        with    reorder 132 seconds
        without reorder 183 seconds
      - Adjust two "check" statements within func_misc.test
        which were incorrect (We had one run with result set
        difference though the server worked good.)
      - minor fixes in comments
      c21508a6
  8. 30 May, 2008 2 commits
  9. 29 May, 2008 2 commits
  10. 28 May, 2008 4 commits
  11. 27 May, 2008 4 commits
    • Patrick Crews's avatar
      Bug#36721 - Test funcs1.<engine>_func_view failing for multiple engines · bbc66ccd
      Patrick Crews authored
      Bug#36724 - Test funcs_1.<engine>_storedproc_02 needs to be updated
      Bug#36726 - Test funcs_1.<engine>_storedproc failing - Needs to be updated on 5.1+
      
      func_view bug:  re-records .result files to account for addition of charset and collation data 
                      to SHOW CREATE VIEW output
      storedproc bugs:  Added expected errors for those storedprocs that use SQLSTATE:00000
                        in their handlers.  re-recorded .result files to account for these
                        expected errors.
      
      mysql-test/suite/funcs_1/r/innodb_func_view.result:
        Update result set for changes to SHOW CREATE VIEW output
      mysql-test/suite/funcs_1/r/memory_func_view.result:
        Updated result set due to changes in SHOW CREATE VIEW output
      mysql-test/suite/funcs_1/r/myisam_func_view.result:
        Updated result set due to changes in SHOW CREATE VIEW output
      bbc66ccd
    • Davi Arnaut's avatar
      Merge. · e141ea9b
      Davi Arnaut authored
      e141ea9b
    • Davi Arnaut's avatar
      Add variation of compile-pentium-valgrind-max which does not build ndb. · bc77229c
      Davi Arnaut authored
      BUILD/compile-pentium-valgrind-max-no-ndb:
        Disable ndb.
      bc77229c
    • Georgi Kodinov's avatar
      Bug #36887: Typo in mysql_client_test.c uses bind instead of my_bind · fe928624
      Georgi Kodinov authored
      There was a typo in a error check causing wrong thing to be ckecked 
      and a possible error not being caught.
      Fixed by using the correct variable to test for malloc() errors. 
      
      tests/mysql_client_test.c:
        Bug #36887: fixed a typo
      fe928624
  12. 26 May, 2008 1 commit
    • Sven Sandberg's avatar
      BUG#36826: rpl_slave_status fails sporadically in pushbuild · a1b2a1e1
      Sven Sandberg authored
      rpl_slave_status failed on pushbuild. The slave stopped with an
      error. Adding sync_slave_with_master fixes the problem. Updated
      test case. 
      
      mysql-test/suite/rpl/r/rpl_slave_status.result:
        Updated result file.
      mysql-test/suite/rpl/t/rpl_slave_status.test:
        - Added comment explaining what the test does.
        - Added sync_slave_with_master in two places where it was missing. This
          caused sporadic pushbuild errors.
        - Added wait_for_slave_to_{start,stop} after {START,STOP} SLAVE queries.
        - Removed 'drop table if exists' from setup code.
        - Replaced save_master_pos;connection slave;sync_with_master by
          sync_slave_with_master.
        - Replaced 'delete from mysql.user' by 'drop user'.
        - Wrapped 'show slave status' inside query_get_value(), so that only what
          we test is in the output.
      a1b2a1e1
  13. 25 May, 2008 1 commit
  14. 23 May, 2008 5 commits
  15. 22 May, 2008 2 commits
  16. 21 May, 2008 5 commits
    • Chad MILLER's avatar
      Add branch metainfo for mailer plugin. · 703da338
      Chad MILLER authored
      703da338
    • Kristofer Pettersson's avatar
      Reverted merging misstake. · e2ff8580
      Kristofer Pettersson authored
      mysql-test/r/status.result:
        reverted merging misstake
      mysql-test/t/status.test:
        reverted merging misstake
      e2ff8580
    • Kristofer Pettersson's avatar
      Bug#34417 Assertion failure in Diagnostics_area::set_error_status() · 7ebf3c80
      Kristofer Pettersson authored
        
      The Diagnostic_area caused an assertion failure in debug mode when
      the disk was full.
        
      By setting the internal error handler to ignore errors caused by
      underlying logging methods, the error is avoided.
      
      
      sql/log.cc:
        MYSQL_QUERY_LOG::write uses IOCACHE for writing data. If writing fails 
        an error is pushed by the procedure my_error which in turn invokes
        the default error handler my_message_sql. When the error is set the
        Diagnostic_area status changes and later trigger an assertion on the
        next consecutive status change which happens by for example the 
        function my_ok(). By intercepting the error handler from the logger
        interface this error can be silenced.
      7ebf3c80
    • unknown's avatar
      Raise version number after cloning 5.1.25-rc · 7cccb0f8
      unknown authored
      7cccb0f8
    • Kristofer Pettersson's avatar
      Bug#32966 main.status fails · b1043ae1
      Kristofer Pettersson authored
      The failing test case is depending on unnecessary status variable output
      which changes based on build configuration. By reducing the output the test
      becomes more stable.
      
      mysql-test/r/status.result:
        Modified test case
      mysql-test/t/disabled.def:
        Enabled status.test
      mysql-test/t/status.test:
        Modified test case.
      b1043ae1
  17. 20 May, 2008 1 commit
    • unknown's avatar
      Update test coverage for Bug#27430 "Crash in subquery code when in PS · 26cd7c85
      unknown authored
      and table DDL changed after PREPARE" to pass in embedded mode.
      
      
      mysql-test/r/ps.result:
        Update results (Bug#27430)
      mysql-test/r/ps_ddl.result:
        Update results (Bug#27430)
      mysql-test/t/ps.test:
        Add a test case for Bug#27430. ps.test is not run in --embedded-server,
        thus it now contains the part of the test for Bug#27430 that
        doesn't work in embedded server.
      mysql-test/t/ps_ddl.test:
        Move a part of the test for Bug#27430 that doesn't work
        in embedded server to ps.test, that includes not_embedded.inc.
      26cd7c85