1. 19 Jul, 2007 2 commits
  2. 16 Jul, 2007 1 commit
    • unknown's avatar
      Bug #29687 mysql_stmt_store_result memory leak in libmysqld · 9917ce26
      unknown authored
      In embedded server we use result->alloc to store field data for the
      result, but we didn't clean the result->alloc if the query returned
      an empty recordset. Cleaning for the empty recordset enabled
      
      
      libmysql/libmysql.c:
        Bug #29687 mysql_stmt_store_result memory leak in libmysqld
        
        we should clean result->alloc even if we have nothin in 'data' field
      9917ce26
  3. 14 Jul, 2007 1 commit
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.1-rpl · 1d0749b8
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.1-opt-merge
      
      
      mysql-test/suite/binlog/r/binlog_row_ctype_cp932.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_ctype_cp932.result:
        Auto merged
      mysql-test/t/disabled.def:
        SCCS merged
      1d0749b8
  4. 13 Jul, 2007 7 commits
  5. 12 Jul, 2007 4 commits
    • unknown's avatar
      Bug#29739: Incorrect time comparison in BETWEEN. · e08e63b1
      unknown authored
      Time values were compared by the BETWEEN function as strings. This led to a
      wrong result in cases when some of arguments are less than 100 hours and other
      are greater.
      
      Now if all 3 arguments of the BETWEEN function are of the TIME type then
      they are compared as integers.
      
      
      mysql-test/t/type_time.test:
        Added a tes tcase for the bug#29739: Incorrect time comparison in BETWEEN.
      mysql-test/r/type_time.result:
        Added a tes tcase for the bug#29739: Incorrect time comparison in BETWEEN.
      sql/item_cmpfunc.cc:
        Bug#29739: Incorrect time comparison in BETWEEN.
        Now if all 3 arguments of the BETWEEN function are of the TIME type then
        they are compared as integers.
      e08e63b1
    • unknown's avatar
      ad492a6d
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 18159958
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug29604
      
      
      18159958
    • unknown's avatar
      Fixed bug #29604. · b1e55680
      unknown authored
      A bug in the restore_prev_nj_state function allowed interleaving 
      inner tables of outer join operations with outer tables. With the
      current implementation of the nested loops algorithm it could lead
      to wrong result sets for queries with nested outer joins.
      Another bug in this procedure effectively blocked evaluation of some
      valid execution plans for queries with nested outer joins. 
      
      
      mysql-test/r/join_nested.result:
        Added a test case for bug #29604.
      mysql-test/t/join_nested.test:
        Added a test case for bug #29604.
      b1e55680
  6. 11 Jul, 2007 16 commits
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · f1ae9c39
      unknown authored
      into  mysql.com:/home/psergey/mysql-5.1-bug29610
      
      
      f1ae9c39
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · db84ffa3
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      db84ffa3
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 95a526b8
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt-29360
      
      
      95a526b8
    • unknown's avatar
      field_conv.cc: · b6e01cbb
      unknown authored
        Additional fix for bug #29360.
      
      
      sql/field_conv.cc:
        Additional fix for bug #29360.
      b6e01cbb
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 2b481003
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29555-bug-5.0-opt-mysql
      
      
      2b481003
    • unknown's avatar
      Bug#29555: Comparing time values as strings may lead to a wrong result. · 25e28d4d
      unknown authored
      Time values were compared as strings. This led to a wrong comparison
      result when comparing values one of which is under 100 hours and another is
      over 100 hours.
      
      Now when the Arg_comparator::set_cmp_func function sees that both items to
      compare are of the TIME type it sets the comparator to the
      Arg_comparator::compare_e_int or the Arg_comparator::compare_int_unsigned
      functions.
      
      
      sql/item_cmpfunc.cc:
        Bug#29555: Comparing time values as strings may lead to a wrong result.
        Now when the Arg_comparator::set_cmp_func function sees that both items to
        compare are of the TIME type it sets the comparator to the
        Arg_comparator::compare_e_int or the Arg_comparator::compare_int_unsigned
        functions.
      mysql-test/r/type_time.result:
        Added a test case for the bug#29555: Comparing time values as strings may
        lead to a wrong result.
      mysql-test/t/type_time.test:
        Added a test case for the bug#29555: Comparing time values as strings may
        lead to a wrong result.
      25e28d4d
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29360 · ad1190ec
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      ad1190ec
    • unknown's avatar
      Fixed bug #29360. · 0920c75b
      unknown authored
      The special `zero' enum value was coerced to the normal
      empty string enum value during a field-to-field copy.
      This bug affected CREATE ... SELECT statements and
      SELECT aggregate GROUP BY enum field statements.
      
      Also this bug made unnecessary warnings during
      the execution of CREATE ... SELECT statements:
      Warning       1265    Data truncated for column...
      
      
      sql/field_conv.cc:
        Fixed bug #29360.
        The field_conv function has been modified to properly convert
        the special `zero' enum value between enum fields.
      mysql-test/t/type_enum.test:
        Updated test case for bug #29360.
      mysql-test/r/type_enum.result:
        Updated test case for bug #29360.
      mysql-test/r/type_ranges.result:
        Updated test case for bug #29360.
      0920c75b
    • unknown's avatar
      Addendum to bug 29325: · 2f0e0017
      unknown authored
      test if TRUNCATE TABLE works with keep_files_on_create
      
      
      2f0e0017
    • unknown's avatar
      BUG#29610: crash in func_group on 64bit platform: · 70dc2448
      unknown authored
      - make merge_buffers():sort_length have type size_t as this type is 
        expected by, e.g. ptr_compare_1, which will receive pointer to 
        sort_length as comparison parameter.
      
      
      sql/filesort.cc:
        BUG#29610: crash in func_group on 64bit platform:
        - make sort_length have type size_t as this type is expected by, e.g.
          ptr_compare_1, which will receive pointer to sort_length as comparison
          parameter.
      70dc2448
    • unknown's avatar
      porting 29070 to 5.1-opt · 6a1fda7a
      unknown authored
      6a1fda7a
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/autopush/B29325-5.0-opt · ecbd9efe
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B29325-merge-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      include/my_base.h:
        Auto merged
      mysql-test/r/ctype_collate.result:
        Auto merged
      mysql-test/r/gis-rtree.result:
        Auto merged
      mysql-test/t/gis-rtree.test:
        Auto merged
      storage/myisam/mi_create.c:
        Auto merged
      strings/ctype-simple.c:
        Auto merged
      mysys/my_conio.c:
        5.0-opt -> 5.1.-opt merge
      storage/myisam/sp_key.c:
        5.0-opt -> 5.1.-opt merge
      ecbd9efe
    • unknown's avatar
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 2b1fb350
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B29325-5.0-opt
      
      
      include/my_base.h:
        Auto merged
      2b1fb350
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B29325-5.0-opt · 2ca32b76
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B29325-5.1-opt
      
      
      include/my_base.h:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      storage/myisam/mi_create.c:
        Auto merged
      mysql-test/r/create.result:
        5.0-opt -> 5.1-opt merge
      sql/set_var.cc:
        5.0-opt -> 5.1-opt merge
      sql/sql_class.h:
        5.0-opt -> 5.1-opt merge
      sql/sql_table.cc:
        5.0-opt -> 5.1-opt merge
      sql/unireg.cc:
        5.0-opt -> 5.1-opt merge
      2ca32b76
    • unknown's avatar
      Bug #29325: · 1abab6c7
      unknown authored
      By default MyISAM overwrites .MYD and .MYI files no 
      DATA DIRECTORY option is used. This can lead to two tables
      using the same .MYD and .MYI files (that can't be dropped).
      
      To prevent CREATE TABLE from overwriting a file a new option
      is introduced : keep_files_on_create
      When this is on the CREATE TABLE throws an error if either
      the .MYD or .MYI exists for a MyISAM table.
      The option is off by default (resulting in compatible behavior).
      
      
      include/my_base.h:
        Bug #29325: introduce keep_files_on_create
      myisam/mi_create.c:
        Bug #29325: introduce keep_files_on_create
      mysql-test/r/create.result:
        Bug #29325: test case
      mysql-test/t/create.test:
        Bug #29325: test case
      sql/ha_myisam.cc:
        Bug #29325: introduce keep_files_on_create
      sql/set_var.cc:
        Bug #29325: introduce keep_files_on_create
      sql/sql_class.h:
        Bug #29325: introduce keep_files_on_create
      sql/sql_table.cc:
        Bug #29325: introduce keep_files_on_create
      sql/unireg.cc:
        Bug #29325: introduce keep_files_on_create
      1abab6c7
  7. 10 Jul, 2007 7 commits
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.1-maint · 22531a8e
      unknown authored
      into  mysql.com:/home/ram/work/mysql-5.1-maint
      
      
      22531a8e
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 3295d449
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B29070-5.0-opt
      
      
      3295d449
    • unknown's avatar
      Fix for bug #29652: csv.test failure: two changes conflict after merge · 29ca25a6
      unknown authored
      Problem: we don't take into account the length of the data written
      to the temporary data file during update on a CSV table.
      
      Fix: properly calculate the data file length during update.
      
      
      mysql-test/r/csv.result:
        Fix for bug #29652: csv.test failure: two changes conflict after merge
          - test result adjusted.
      storage/csv/ha_tina.cc:
        Fix for bug #29652: csv.test failure: two changes conflict after merge
          - adjust local_saved_data_file_length in case of update as well.
      storage/csv/ha_tina.h:
        Fix for bug #29652: csv.test failure: two changes conflict after merge
          - adjust local_saved_data_file_length in case of update as well.
      29ca25a6
    • unknown's avatar
      Bug #29469: Client dies if a query is issued after hitting Ctrl + C · 21474cd1
      unknown authored
      The Ctrl-C handler in mysql closes the console while ReadConsole()
      waits for console input.
      But the main thread was detecting that ReadConsole() haven't read 
      anything and was processing as if there're data in the buffer.
      Fixed to handle correctly this error condition.
      No test case added as the test relies on Ctrl-C sent to the client
      from its console.
      
      
      client/mysql.cc:
        Bug #29469: handle correctly console read error
      mysys/my_conio.c:
        Bug #29469: 
         1. handle correctly console read error
         2. add boundry checks for console buffer.
      21474cd1
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 4f4764cd
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B29070-5.0-opt
      
      
      4f4764cd
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.1-new-maint · c9e01795
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-maint
      
      
      mysql-test/suite/rpl/r/rpl_row_tabledefs_2myisam.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_row_tabledefs_3innodb.result:
        Auto merged
      c9e01795
    • unknown's avatar
      Bug #29570 · 20beacc9
      unknown authored
      - correct result files
      
      
      20beacc9
  8. 09 Jul, 2007 2 commits