1. 12 Mar, 2019 6 commits
  2. 11 Mar, 2019 4 commits
  3. 09 Mar, 2019 6 commits
  4. 08 Mar, 2019 2 commits
  5. 07 Mar, 2019 5 commits
  6. 06 Mar, 2019 7 commits
    • Sergei Golubchik's avatar
      ASAN loves stack, give it some · 84645366
      Sergei Golubchik authored
      fixes these test failures in ASAN builds (in 10.1 and 10.4):
      * main.signal_demo3
      * main.sp
      * sys_vars.max_sp_recursion_depth_func
      * mroonga/storage.foreign_key_delete_existent
      * mroonga/storage.foreign_key_delete_nonexistent
      * mroonga/storage.foreign_key_insert_existent
      * mroonga/storage.foreign_key_update_existent
      * mroonga/storage.foreign_key_update_nonexistent
      * mroonga/storage.function_command_auto-escape
      * mroonga/storage.function_command_select
      * mroonga/storage.variable_enable_operations_recording_insert
      84645366
    • Sergei Golubchik's avatar
      5ce6fb59
    • Alexander Barkov's avatar
      A cleanup for MDEV-18333 Slow_queries count doesn't increase when slow_query_log is turned off · 26f0d72a
      Alexander Barkov authored
      thd->lex->m_sql_cmd was not cleared between queries.
      log_slow_query() could crash (when running mtr --ps) because of this.
      26f0d72a
    • Marko Mäkelä's avatar
      MDEV-18637 Assertion `cache' failed in fts_init_recover_doc · 485dcb07
      Marko Mäkelä authored
      I know no test case for this bug in 10.1. So a test case will be
      committed separately in 10.2
      
      fts_reset_get_doc(): properly initialize fts_get_doc_t::cache
      485dcb07
    • Marko Mäkelä's avatar
      MDEV-18659: Revert a non-functional change · 4b5dc47f
      Marko Mäkelä authored
      fts_fetch_index_words(): Restore the initialization len=0.
      The test innodb_fts.create in 10.2 would end up in an infinite loop
      if this assignment is removed, because a following iteration of the
      while() loop would assign zip->zp->avail_in=len with the original value
      instead of the 0 that was reset in the previous iteration.
      4b5dc47f
    • Marko Mäkelä's avatar
      MDEV-18659: Fix string truncation/overflow in InnoDB and XtraDB · b7612116
      Marko Mäkelä authored
      Fix the warnings issued by GCC 8 -Wstringop-truncation
      and -Wstringop-overflow in InnoDB and XtraDB.
      
      This work is motivated by Jan Lindström. The patch mainly differs
      from his original one as follows:
      
      (1) We remove explicit initialization of stack-allocated string buffers.
      The minimum amount of initialization that is needed is a terminating
      NUL character.
      (2) GCC issues a warning for invoking strncpy(dest, src, sizeof dest)
      because if strlen(src) >= sizeof dest, there would be no terminating
      NUL byte in dest. We avoid this problem by invoking strncpy() with
      a limit that is 1 less than the buffer size, and by always writing
      NUL to the last byte of the buffer.
      (3) We replace strncpy() with memcpy() or strcpy() in those cases
      when the result is functionally equivalent.
      
      Note: fts_fetch_index_words() never deals with len==UNIV_SQL_NULL.
      This was enforced by an assertion that limits the maximum length
      to FTS_MAX_WORD_LEN. Also, the encoding that InnoDB uses for
      the compressed fulltext index is not byte-order agnostic, that is,
      InnoDB data files that use FULLTEXT INDEX are not portable between
      big-endian and little-endian systems.
      b7612116
    • Marko Mäkelä's avatar
      MDEV-18749: Uninitialized value upon ADD FULLTEXT INDEX · b21930fb
      Marko Mäkelä authored
      row_merge_create_fts_sort_index(): Initialize dict_col_t.
      
      This fixes an access to uninitialized dict_col_t::ind when a debug
      assertion in MariaDB 10.4 invokes is_dropped() in
      rec_get_converted_size_comp_prefix_low(). Older MariaDB versions
      seem to be unaffected by the uninitialized values, but it should
      not hurt to initialize everything.
      b21930fb
  7. 04 Mar, 2019 2 commits
  8. 01 Mar, 2019 1 commit
  9. 28 Feb, 2019 7 commits