1. 18 Nov, 2023 1 commit
    • Marko Mäkelä's avatar
      MDEV-31953 madvise(..., MADV_FREE) is causing a performance regression · 23234835
      Marko Mäkelä authored
      buf_page_t::set_os_unused(): Remove the system call that had been added in
      commit 16c97187 and revised in
      commit c1fd082e for Microsoft Windows.
      
      buf_pool_t::garbage_collect(): A new function to collect any garbage
      from the InnoDB buffer pool that can be removed without writing any
      log or data files. This will also invoke madvise() for all of buf_pool.free.
      
      To trigger this the following MDEV is implemented:
      MDEV-24670 avoid OOM by linux kernel co-operative memory management
      
      To avoid frequent triggers that caused the MDEV-31953 regression, while
      still preserving the 10.11 functionality of non-greedy kernel memory
      usage, memory triggers are used.
      
      On the triggering of memory pressure, if supported in the Linux kernel,
      trigger the garbage collection of the innodb buffer pool.
      
      The hard coded triggers occur where there is:
      * some memory pressure in 5 of the last 10 seconds
      * a full stall on memory pressure for 10ms in the last 2 seconds
      
      The kernel will trigger only one in each of these time windows. To avoid
      mariadb being in a constant state of memory garbage collection, this has
      been limited to once per minute.
      
      For a small set of kernels in 2023 (6.5, 6.6), there was a limit requiring
      CAP_SYS_RESOURCE that was lifted[1] to support the use case of user
      memory pressure. It not currently possible to set CAP_SYS_RESOURCES in
      a systemd service as its setting a capability inside a usernamespace.
      
      Running under systemd v254+ requires the default MemoryPressureWatch=auto
      (or alternately "on").
      
      Functionality was tested in a 6.4 kernel Fedora successfully under a
      systemd service.
      
      Running in a container requires that (unmask=)/sys/fs/cgroup be writable
      by the mariadbd process.
      
      To aid testing, the buf_pool_resize was a convient trigger point on
      which to trigger garbage collection.
      
      ref [1]: https://lore.kernel.org/all/CAMw=ZnQ56cm4Txgy5EhGYvR+Jt4s-KVgoA9_65HKWVMOXp7a9A@mail.gmail.com/T/#m3bd2a73c5ee49965cb73a830b1ccaa37ccf4e427
      
      Co-Author: Daniel Black (on memory pressure trigger)
      
      Reviewed by: Marko Mäkelä, Vladislav Vaintroub, Vladislav Lesin,
         Thirunarayanan Balathandayuthapani
      
      Tested by: Matthias Leich
      23234835
  2. 16 Nov, 2023 1 commit
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-32811 Potentially broken crash recovery if a mini-transaction frees a... · 6c342459
      Thirunarayanan Balathandayuthapani authored
      MDEV-32811 Potentially broken crash recovery if a mini-transaction frees a page, not modifying previously clean pages
      
      - The 11.2 test innodb.sys_truncate_debug fails while executing insert statement.
      Reason for the failure is that same mini-transaction does freeing, allocating
      and freeing the same page. Page initialization clears the FIL_PAGE_LSN
      on the page, fails to set the FIL_PAGE_LSN after freeing the same page.
      This issue is caused by commit f46efb44
      
      mtr_t::commit(): Should set the FIL_PAGE_LSN even though page is freed
      6c342459
  3. 14 Nov, 2023 2 commits
  4. 13 Nov, 2023 1 commit
  5. 08 Nov, 2023 8 commits
  6. 07 Nov, 2023 1 commit
  7. 06 Nov, 2023 1 commit
  8. 04 Nov, 2023 1 commit
  9. 01 Nov, 2023 1 commit
  10. 31 Oct, 2023 1 commit
  11. 30 Oct, 2023 4 commits
  12. 28 Oct, 2023 3 commits
  13. 27 Oct, 2023 7 commits
    • Oleksandr Byelkin's avatar
      1cd8a5ef
    • Sergei Petrunia's avatar
      MDEV-32351: Significant slowdown with outer joins: Test coverage · 9bf2e5e3
      Sergei Petrunia authored
      Make ANALYZE FORMAT=JSON print block-nl-join.r_unpack_ops when
      analyze_print_r_unpack_ops debug flag is set.
      
      Then, add a testcase.
      9bf2e5e3
    • Sergei Petrunia's avatar
      ANALYZE FORMAT=JSON: Backport block-nl-join.r_unpack_time_ms from 11.0 +fix MDEV-30830. · 4ed59006
      Sergei Petrunia authored
      Also fix it to work with hashed join (MDEV-30830).
      
      Reviewed by: Monty <monty@mariadb.org>
      4ed59006
    • Igor Babaev's avatar
      MDEV-32351 Significant slowdown for query with many outer joins · 954a6dec
      Igor Babaev authored
      This patch fixes a performance regression introduced in the patch for the
      bug MDEV-21104. The performance regression could affect queries for which
      join buffer was used for an outer join such that its on expression from
      which a conjunctive condition depended only on outer tables can be
      extracted. If the number of records in the join buffer for which this
      condition was false greatly exceeded the number of other records the
      slowdown could be significant.
      
      If there is a conjunctive condition extracted from the ON expression
      depending only on outer tables this condition is evaluated when interesting
      fields of each survived record of outer tables are put into the join buffer.
      Each such set of fields for any join operation is supplied with a match
      flag field used to generate null complemented rows. If the result of the
      evaluation of the condition is false the flag is set to MATCH_IMPOSSIBLE.
      When looking in the join buffer for records matching a record of the
      right operand of the outer join operation the records with such flags
      are not needed to be unpacked into record buffers for evaluation of on
      expressions.
      
      The patch for MDEV-21104 fixing some problem of wrong results when
      'not exists' optimization by mistake broke the code that allowed to
      ignore records with the match flag set to MATCH_IMPOSSIBLE when looking
      for matching records. As a result such records were unpacked for each
      record of the right operand of the outer join operation. This caused
      significant execution penalty in some cases.
      
      One of the test cases added in the patch can be used only for demonstration
      of the restored performance for the reported query. The second test case is
      needed to demonstrate the validity of the fix.
      954a6dec
    • Oleksandr Byelkin's avatar
      fixed typo · 11abc219
      Oleksandr Byelkin authored
      11abc219
    • Marko Mäkelä's avatar
      MDEV-32578 row_merge_fts_doc_tokenize() handles parser plugin inconsistently · 15ae97b1
      Marko Mäkelä authored
      When mysql/mysql-server@0c954c2289a75d90d1088356b1092437ebf45a1d
      added a plugin interface for FULLTEXT INDEX tokenization to MySQL 5.7,
      fts_tokenize_ctx::processed_len got a second meaning, which is only
      partly implemented in row_merge_fts_doc_tokenize().
      
      This inconsistency could cause a crash when using FULLTEXT...WITH PARSER.
      A test case that would crash MySQL 8.0 when using an n-gram parser and
      single-character words would fail to crash in MySQL 5.7, because the
      buf_full condition in row_merge_fts_doc_tokenize() was not met.
      
      This change is inspired by
      mysql/mysql-server@38e9a0779aeea2d197c727e306a910c56b26a47c
      that appeared in MySQL 5.7.44.
      15ae97b1
    • Andrei's avatar
      MDEV-32593 Assertion failure upon CREATE SEQUENCE · 728bca44
      Andrei authored
      A recently added by MDEV-32593 assert conditions are corrected.
      728bca44
  14. 26 Oct, 2023 6 commits
    • Teemu Ollakka's avatar
      MDEV-32282: Galera node remains paused after interleaving FTWRLs · ef7fc586
      Teemu Ollakka authored
      After two concurrent FTWRL/UNLOCK TABLES, the node stays in paused state
      and the following CREATE TABLE fails with
      
        ER_UNKNOWN_COM_ERROR (1047): Aborting TOI: Replication paused on
        node for FTWRL/BACKUP STAGE.
      
      The cause is the use of global `wsrep_locked_seqno` to determine
      if the node should be resumed on UNLOCK TABLES. In some executions
      the `wsrep_locked_seqno` is cleared by the first UNLOCK TABLES
      after the second FTWRL gets past `make_global_read_lock_block_commit()`.
      
      As a fix, use `thd->wsrep_desynced_backup_stage` to determine
      if the thread should resume the node on UNLOCK TABLES.
      
      Add MTR test galera.galera_ftwrl_concurrent to reproduce the
      race. The test contains also cases for BACKUP STAGE which
      uses similar mechanism for desyncing and pausing the node.
      Signed-off-by: default avatarJulius Goryavsky <julius.goryavsky@mariadb.com>
      ef7fc586
    • Sergei Golubchik's avatar
      MDEV-32586 incorrect error about cyclic reference about JSON type virtual column · c9f87b88
      Sergei Golubchik authored
      remove the hack where NO_DEFAULT_VALUE_FLAG was temporarily removed
      from a field to initialize DEFAULT() functions in CHECK constraints
      while disabling self-reference field checks.
      
      Instead, initialize DEFAULT() functions in CHECK explicitly,
      don't call check_field_expression_processor() for CHECK at all.
      c9f87b88
    • Andrei's avatar
      MDEV-32365 detailize the semisync replication magic number error · 9c433432
      Andrei authored
      Semisync ack (master side) receiver thread is made to report
      details of faced errors.
      In case of 'magic byte' error, a hexdump of the received packet
      is always (level) NOTEd into the error log.
      In other cases an exact server level error is print out
      as a warning (as it may not be critical) under log_warnings > 2.
      
      An MTR test added for the magic byte error. For others existing mtr
      tests cover that, provided log_warnings > 2 is set.
      9c433432
    • Marko Mäkelä's avatar
      MDEV-32588 InnoDB may hang when running out of buffer pool · 5b53342a
      Marko Mäkelä authored
      buf_flush_LRU_list_batch(): Do not skip pages that are actually clean
      but in buf_pool.flush_list due to the "lazy removal" optimization of
      commit 22b62eda, but try to evict them.
      After acquiring buf_pool.flush_list_mutex, reread oldest_modification
      to ensure that the block still remains in buf_pool.flush_list.
      
      In addition to server hangs, this bug could also cause
      InnoDB: Failing assertion: list.count > 0
      in invocations of UT_LIST_REMOVE(flush_list, ...).
      
      This fixes a regression that was caused by
      commit a55b951e
      and possibly made more likely to hit due to
      commit aa719b50.
      5b53342a
    • Marko Mäkelä's avatar
      MDEV-31826 InnoDB may fail to recover after being killed in fil_delete_tablespace() · 39e3ca8b
      Marko Mäkelä authored
      InnoDB was violating the write-ahead-logging protocol when a file
      was being deleted, like this:
      
      1. fil_delete_tablespace() set the fil_space_t::STOPPING flag
      2. The buf_flush_page_cleaner() thread discards some changed pages for
      this tablespace advances the log checkpoint a little.
      3. The server process is killed before fil_delete_tablespace() wrote
      a FILE_DELETE record.
      4. Recovery will try to apply log to pages of the tablespace, because
      there was no FILE_DELETE record. This will fail, because some pages
      that had been modified since the latest checkpoint had not been written
      by the page cleaner.
      
      Page writes must not be stopped before a FILE_DELETE record has been
      durably written.
      
      fil_space_t::drop(): Replaces fil_space_t::check_pending_operations().
      Add the parameter detached_handle, and return a tablespace pointer
      if this thread was the first one to stop I/O on the tablespace.
      
      mtr_t::commit_file(): Remove the parameter detached_handle, and
      move some handling to fil_space_t::drop().
      
      fil_space_t: STOPPING_READS, STOPPING_WRITES: Separate flags for STOPPING.
      We want to stop reads (and encryption) before stopping page writes.
      
      fil_space_t::is_stopping_writes(), fil_space_t::get_for_write():
      Special accessors for the write path.
      
      fil_space_t::flush_low(): Ignore the STOPPING_READS flag and only
      stop if STOPPING_WRITES is set, to avoid an infinite loop in
      fil_flush_file_spaces(), which was occasionally repeated by
      running the test encryption.create_or_replace.
      
      Reviewed by: Vladislav Lesin
      Tested by: Matthias Leich
      39e3ca8b
    • Oleksandr Byelkin's avatar
      Fix --view-protocol failures · cb4c2713
      Oleksandr Byelkin authored
      cb4c2713
  15. 25 Oct, 2023 2 commits
    • Rex's avatar
      MDEV-31983 jointable materialization subquery optimization ignoring · ec2574fd
      Rex authored
      ...errors, then failing ASSERT.
      
      UPDATE queries treat warnings as errors. In this case, an invalid
      condition "datetime_key_col >= '2012-01'" caused warning-as-error inside
      SQL_SELECT::test_quick_select().
      
      The code that called test_quick_select() ignored this error and continued
      join optimization. Then it eventually reached a thd->is_error() check
      and failed to setup SJ-Materialization which failed an assert.
      
      Fixed this by making SQL_SELECT::test_quick_select() return error in
      its return value, and making any code that calls it to check for error
      condition and abort the query if the error is returned.
      
      Places in the code that didn't check for errors from
      SQL_SELECT::test_quick_select but now do:
      - get_quick_record_count() call in make_join_statistics(),
      - test_if_skip_sort_order(),
      - "Range checked for each record" code.
      
      Extra error handling fixes and commit text wording by Sergei Petrunia,
      
      Reviewed-by: Sergei Petrunia, Oleg Smirnov
      ec2574fd
    • Vladislav Vaintroub's avatar
      MDEV-32574 main.winservice_basic sporadically fails on buildbot · 818a9f38
      Vladislav Vaintroub authored
      This commits only adds  --verbose-bootstrap to mysql_install_db.exe
      call to have more error information dumped in case of an error.
      818a9f38