1. 28 Mar, 2008 1 commit
  2. 27 Mar, 2008 5 commits
  3. 26 Mar, 2008 2 commits
    • unknown's avatar
      Merge kaamos.(none):/data/src/bugteam/bug34928/my51 · 93344569
      unknown authored
      into  kaamos.(none):/data/src/bugteam/mysql-5.1-bugteam
      
      93344569
    • unknown's avatar
      Fix for bug #34928: Confusion by having Primary Key and Index · 044dfd03
      unknown authored
      The bug is a regression introduced in 5.1 by the patch for bug28404.
      
      Under some circumstances test_if_skip_sort_order() could leave some
      data structures in an inconsistent state so that some parts of code
      could assume the selected execution strategy for GROUP BY/DISTINCT as
      a loose index scan (e.g. JOIN_TAB::is_using_loose_index_scan()), while
      the actual strategy chosen was an ordered index scan, which led to
      wrong data being returned.
      
      Fixed test_if_skip_sort_order() so that when changing the type for a
      join table, select->quick is reset not only for EXPLAIN, but for the 
      actual join execution as well, to not confuse code that depends on its
      value to determine the chosen GROUP BY/DISTINCT strategy.
      
      
      mysql-test/r/distinct.result:
        Added a test case for bug #34928.
      mysql-test/t/distinct.test:
        Added a test case for bug #34928.
      sql/sql_select.cc:
        When changing the table's join type to JT_NEXT in 
        test_if_skip_sort_order(), also reset select->quick because other
        code may depend on its value to determine the GROUP BY/DISTINCT
        execution strategy.
      044dfd03
  4. 25 Mar, 2008 2 commits
    • unknown's avatar
      Bug#35272: @@global.key_buffer_size = 4294967295 let the server crash · 0861bcb4
      unknown authored
      When trying to get the requested amount of memory for the keybuffer,
      the out of memory could be signaled if one of the tentative allocations
      fail. Later the server would crash (debug assert) when trying to send
      a ok packet with a error set.
      
      The solution is only to signal the error if all tentative allocations
      for the keybuffer fail.
      
      
      mysql-test/r/key_cache.result:
        Add test case result for Bug#35272
      mysql-test/t/key_cache.test:
        Add test case for Bug#35272
      mysys/mf_keycache.c:
        Don't set error on my_large_malloc if allocation fails.
        Set the error if all tentative allocations failed.
      0861bcb4
    • unknown's avatar
      Fix for Bug #27944 Filtering THD::client capabilities · 6402d91b
      unknown authored
      The server used to trust blindly information from the client about
      its capabilities. During the connection handshake the server sends
      information about what it supports and then the client sends back a
      set of capabilities which cover all of the server's or less.
      Before this changeset the server didn't check whether the flags sent
      by the client were valid for the server. For example, if the server
      doesn't support compressed protocol but the client does and sends that
      bit turned on, the server didn't check it. The change make the server code
      less error prone to problems related to the value of THD::client_capabilities.
      
      Clearly there is no vulnerability being fixed but this is a maintainenance
      fix to prevent misusage in the future.
      
      
      include/mysql_com.h:
        List all CLIENT flags in a common defition. Add also a definition
        which excludes flags, which are optoinal.
      sql/sql_connect.cc:
        Renamed client_flags to server_capabilities to reflect what
        the server supports. Only allow from the client the flags the
        server supports.
      6402d91b
  5. 14 Mar, 2008 5 commits
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl · c03988c8
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      sql/slave.cc:
        Auto merged
      sql/sql_repl.h:
        Auto merged
      c03988c8
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1 · 8ae02505
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      mysql-test/include/commit.inc:
        Auto merged
      mysql-test/lib/mtr_report.pl:
        Auto merged
      mysql-test/r/commit_1innodb.result:
        Auto merged
      mysql-test/r/variables.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_ctype_ucs.result:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/rpl_rli.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      8ae02505
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0 · 90628f25
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl
      
      90628f25
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 6309c2c3
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        Auto merged
      mysql-test/suite/binlog/t/binlog_unsafe.test:
        Auto merged
      6309c2c3
    • unknown's avatar
      Post-merge fixes. · c41299b1
      unknown authored
      
      mysql-test/extra/rpl_tests/rpl_loaddata.test:
        Removing SHOW MASTER STATUS that does not seem to make sense.
      mysql-test/extra/rpl_tests/rpl_log.test:
        Correcting test case to sync slave with master.
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        Result change.
      mysql-test/suite/binlog/t/binlog_unsafe.test:
        Removing unsafe variable from list of safe variables.
      mysql-test/suite/rpl/r/rpl_loaddata.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_skip_error.result:
        Result change.
      mysql-test/suite/rpl/t/rpl_skip_error.test:
        Correcting bad manual+automatic merge. Test is now only relevant for statement-
        based replication.
      sql/rpl_rli.cc:
        Correcting automerge undoing previous change of return value.
        Relay_log_info::wait_for_pos() should return -2 when not initialized to work
        correctly.
      c41299b1
  6. 13 Mar, 2008 2 commits
  7. 12 Mar, 2008 11 commits
    • unknown's avatar
      eefc19c5
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl · d2a1af31
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      mysql-test/suite/rpl/r/rpl_loaddata.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_master_pos_wait.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_slave_status.result:
        Auto merged
      mysql-test/suite/rpl/t/rpl_master_pos_wait.test:
        Auto merged
      mysql-test/suite/rpl/t/rpl_temporary.test:
        Auto merged
      mysql-test/suite/rpl/t/rpl_loaddata.test:
        Manual merge. The rpl_loaddata.test file was moved on 5.1 by editing
        the file to include the file at the new location. This causes conflicts
        when merging, since the changes will not propagate to the moved file.
      sql/slave.cc:
        Manual merge.
      mysql-test/suite/rpl/t/rpl_skip_error.test:
        Manual merge.
      mysql-test/suite/rpl/t/rpl_slave_status.test:
        Manual merge.
      d2a1af31
    • unknown's avatar
      Merge ssh://bk-internal.mysql.com//home/bk/mysql-5.1-opt · 0d35eafc
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      sql/sql_show.cc:
        Auto merged
      sql/table.h:
        Auto merged
      0d35eafc
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · df7268dc
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      tests/mysql_client_test.c:
        Manual merge.
      df7268dc
    • unknown's avatar
      Post-merge fix. · 821d164b
      unknown authored
      821d164b
    • unknown's avatar
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 2d91ad60
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      scripts/mysql_config.sh:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      2d91ad60
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-5.1 · e38a0de2
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      client/mysqldump.c:
        Auto merged
      configure.in:
        Auto merged
      include/my_global.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      mysql-test/include/mix1.inc:
        Auto merged
      mysql-test/r/create.result:
        Auto merged
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      mysql-test/t/disabled.def:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_plugin.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      storage/ndb/src/kernel/blocks/backup/Backup.hpp:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/r/func_time.result:
        Manual merge.
      mysql-test/r/view.result:
        Manual merge.
      mysql-test/t/view.test:
        Manual merge.
      scripts/mysql_config.sh:
        Manual merge.
      sql-common/client.c:
        Manual merge.
      sql/sql_parse.cc:
        Manual merge.
      e38a0de2
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-4.1-opt · ddfd9942
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.0-opt
      
      ddfd9942
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-5.0 · 242078d0
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.0-opt
      
      
      client/mysql.cc:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/r/view.result:
        Manual merge.
      mysql-test/t/view.test:
        Manual merge.
      scripts/mysql_config.sh:
        Manual merge.
      242078d0
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-4.1 · 70cc07cf
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-4.1-opt
      
      70cc07cf
  8. 11 Mar, 2008 5 commits
    • unknown's avatar
      Removed pushbuild errors. · 6f7695d5
      unknown authored
      Problem: rpl_variables_stm.test used a character set and a collation which
      are not included on all platforms.
      Fix: replace the character set and collation by ones that are included on
      all platforms. (rpl_variables_stm does not rely on which character set is
      used, the only important aspect is the fact that it changes.)
      
      
      mysql-test/suite/rpl/r/rpl_variables_stm.result:
        Updated result file.
      mysql-test/suite/rpl/t/rpl_variables_stm.test:
        Changed test to get rid of pushbuild errors.
      6f7695d5
    • unknown's avatar
      BUG#31024: STOP SLAVE does not stop attempted connect()s · d6c738c0
      unknown authored
      Problem: if the IO slave thread is attempting to connect,
      STOP SLAVE waits for the attempt to finish. 
      It may take a long time.
      Fix: don't wait, stop the slave immediately.
      
      
      sql/slave.cc:
        Send a SIGALRM signal to the slave thread when stopping it (using
        pthread_kill()). This breaks current socket(), connect(), poll() etc.
        calls, and makes the subsequent thd->awake() call effective.
        
        Also, move the definition of KICK_SLAVE to slave.cc.
      sql/sql_repl.h:
        Removed KICK_SLAVE and inlined it in slave.cc because:
         - it was only called once, so better to make it local to where it is used
         - it needed to include a preprocessor conditional in the middle
      d6c738c0
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 6189a1d3
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/r/null_key.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/sql_select.cc:
        Manual merge.
      6189a1d3
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.1-opt · ee87eaa4
      unknown authored
      into  riffraff.(none):/data0/martin/bug34367/my51-bug34367-pushee
      
      ee87eaa4
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 64549fed
      unknown authored
      into  mysql.com:/home/hf/work/32801/my51-32801
      
      64549fed
  9. 10 Mar, 2008 7 commits
    • unknown's avatar
      Problem: sporadic pushbuild errors in rpl_ndb_basic. · 71665ea0
      unknown authored
      The reason is that we are using a sleep to wait for slave to reach the
      slave_transaction_retries limit.
      Fix: wait for the slave to stop instead. This is what we want to do, since
      the slave stops when the limit is reached.
      
      71665ea0
    • unknown's avatar
      Problem: Pushbuild errors because sql_mode is unsafe but test thinks it is · c05c52fe
      unknown authored
      safe.
      Fix: Move sql_mode: from the section of the test where safe variables are
      tested, to the section where unsafe variables are tested.
      
      
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        Updated result file of modified test.
      c05c52fe
    • unknown's avatar
      Bug#34731: highest possible value for INT erroneously filtered by WHERE · 13e6025b
      unknown authored
      WHERE f1 < n ignored row if f1 was indexed integer column and
      f1 = TYPE_MAX ^ n = TYPE_MAX+1. The latter value when treated
      as TYPE overflowed (obviously). This was not handled, it is now.
      
      
      mysql-test/r/range.result:
        show that on an index int column, we no longer disregard
        a field val of TYPE_MAX in SELECT ... WHERE ... < TYPE_MAX+1
      mysql-test/t/range.test:
        show that on an index int column, we no longer disregard
        a field val of TYPE_MAX in SELECT ... WHERE ... < TYPE_MAX+1
      sql/opt_range.cc:
        Handle overflowing of int-types in range-optimizer.
        Unfortunately requires re-indentation of entire block.
        Overflow (err == 1) was handled, but only if
        field->cmp_type() != value->result_type(), which it
        just wasn't in our case.
      13e6025b
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · ec893324
      unknown authored
      into  mysql.com:/misc/mysql/34749/51-34749
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.h:
        Auto merged
      ec893324
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 2c9fe71c
      unknown authored
      into  mysql.com:/misc/mysql/34749/50-34749
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      2c9fe71c
    • unknown's avatar
      Merge mysql.com:/misc/mysql/34749/50-34749 · 955be183
      unknown authored
      into  mysql.com:/misc/mysql/34749/51-34749
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      sql/ha_ndbcluster_cond.cc:
        Auto merged
      sql/ha_ndbcluster_cond.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.h:
        Auto merged
      955be183
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · c0340d6b
      unknown authored
      into  mysql.com:/misc/mysql/29645/51-29645
      
      c0340d6b