1. 30 Nov, 2007 1 commit
  2. 29 Nov, 2007 9 commits
    • vasil's avatar
      branches/zip: · a3417d90
      vasil authored
      * Change terminology:
        wait lock -> requested lock
        waited lock -> blocking lock
        new: requesting transaction (the trx what owns the requested lock)
        new: blocking transaction (the trx that owns the blocking lock)
      
      * Add transaction ids to INFORMATION_SCHEMA.INNODB_LOCK_WAITS. This is
        somewhat redundant because transaction ids can be found in INNODB_LOCKS
        (which can be joined with INNODB_LOCK_WAITS) but would help users to
        write shorter joins (one table less) in some cases where they want to
        find which transaction is blocking which.
      
      Suggested by:	Ken
      Approved by:	Heikki
      a3417d90
    • marko's avatar
      445924b5
    • marko's avatar
      branches/zip: row_ext_create(): Remove the UNIV_INLINE that should · c15cbd7d
      marko authored
      have been removed in r2131.
      c15cbd7d
    • marko's avatar
      branches/zip: row_ext: Fetch the BLOB prefixes already at row_ext_create(). · ab7b4937
      marko authored
      Only add indexed BLOBs to row_ext.
      
      trx_undo_rec_get_partial_row(): Move the BLOB fetching to row_ext_create().
      
      row_build(): Pass only those BLOBs to row_ext_create() that are referenced by
      ordering columns of some indexes, similar to trx_undo_rec_get_partial_row().
      
      row_ext_create(): Add the parameter "tuple".  Move the implementation
      from row0ext.ic to row0ext.c.
      
      row_ext_lookup_ith(), row_ext_lookup(): Return a const pointer.  Remove
      the parameters "field" and "f_len".  Make the row_ext_t* parameter const.
      
      row_ext_t: Remove the field zip_size.
      
      field_ref_zero[]: Declare in btr0types.h instead of btr0cur.h.
      
      row_ext_lookup_low(): Rename to row_ext_cache_fill() and change the
      signature.
      ab7b4937
    • marko's avatar
      branches/zip: Clean up after r2129: · a5bd2496
      marko authored
      univ.i: Do not define UNIV_DEBUG, UNIV_ZIP_DEBUG.
      
      btr_cur_del_unmark_for_ibuf(): Use the same comment in both btr0cur.c and
      btr0cur.h.  Wrap long lines.
      a5bd2496
    • sunny's avatar
      branches/zip: Fix a bug where the zipped page and the uncompressed page · 5cab01e9
      sunny authored
      contents end up with conflicting versions of a record's state. The zipped
      page record was not being marked as "(un)deleted" because we were not
      passing the zipped page contents to the (un)delete function, which first
      (un)delete marks the uncompressed version and then based on whether
      page_zip is NULL or not (un)delete marks the record in the compressed page.
      5cab01e9
    • marko's avatar
      branches/zip: ha_innobase::final_drop_index(): Allocate a separate transaction · d5c04aae
      marko authored
      for dropping the index trees, and set the dictionary operation flag, similar
      to what ha_innobase::add_index() does.  This should ensure correct crash
      recovery.
      d5c04aae
    • marko's avatar
      branches/zip: trx_undo_rec_get_partial_row(): Set up the row_ext cache · 27f78180
      marko authored
      only for those externally stored columns that occur in the ordering columns
      of indexes.  Prefetch the prefixes of those columns, because the clustered
      index record and the BLOBs may have been deleted by the time when the
      purge thread needs to read the BLOB prefixes.
      
      row_ext_create(): Add the debug assertion ut_ad(ut_is_2pow(zip_size)).
      27f78180
    • marko's avatar
      branches/zip: Remove the warnings about pointer targets differing · 0eb1f4f6
      marko authored
      in signedness that were introduced in r2114.
      
      row_upd_index_replace_new_col_vals_index_pos(),
      row_upd_index_replace_new_col_vals(): Declare "data" as const byte*
      instead of const char*, and add casts to the dtype_get_at_most_n_mbchars()
      calls.
      0eb1f4f6
  3. 28 Nov, 2007 5 commits
    • marko's avatar
      branches/zip: Fix a bug that was introduced in r2123. · 7a1d5d91
      marko authored
      buf_block_is_uncompressed(): Check that the pointer is aligned.  Use the
      C modulus operator % instead of ut_align_offset(), because sizeof(buf_block_t)
      is not guaranteed to be a power of 2.
      7a1d5d91
    • marko's avatar
      branches/zip: row_vers_impl_x_locked_off_kernel(): In follow-up to r2119, · 0ef4026b
      marko authored
      assert ut_a(entry) instead of playing it safe.
      0ef4026b
    • marko's avatar
      branches/zip: buf_page_get_gen(): Note that the guessed block may also · f6a5cc1d
      marko authored
      point to a buffer pool chunk that has been released when resizing the
      buffer pool.
      
      buf_block_is_uncompressed(): Check that the pointer is aligned.  Thanks
      to this check, it is safe to pass an arbitrary pointer as a guess
      to buf_page_get_gen().
      f6a5cc1d
    • marko's avatar
      branches/zip: Minor cleanup. · 247d1449
      marko authored
      buf_page_get_release_on_io(): Removed this unused function.
      
      ibuf_build_entry_from_ibuf_rec(): Justify why it is not necessary to
      add system columns to the dummy table pointed to by the dummy secondary index.
      
      page_zip_rec_set_deleted(): Add a page_zip_validate() assertion.
      247d1449
    • vasil's avatar
      branches/zip: · 69a8cc07
      vasil authored
      Add the transaction's weight to information_schema.innodb_trx table.
      
      Suggested by:	Ken
      Approved by:	Heikki
      69a8cc07
  4. 27 Nov, 2007 3 commits
    • marko's avatar
      branches/zip: lock_sec_rec_some_has_impl_off_kernel(): Make the function · 95f1b15a
      marko authored
      static.  It is only called from lock0lock.c.
      95f1b15a
    • marko's avatar
      branches/zip: In purge, avoid dereferencing unset BLOB pointers of freshly · ab8f5e79
      marko authored
      inserted, uncommitted clustered index records when determining if a
      secondary index record that contains a column prefix of an externally
      stored column is referencing the clustered index record.
      
      field_ref_zero[]: A BLOB pointer full of zero, for use in comparisons.
      
      btr_copy_externally_stored_field_prefix(): Assert that the BLOB pointer is set.
      
      row_ext_lookup_ith(), row_ext_lookup(), row_ext_lookup_low(): Document
      that field_ref_zero is returned when the BLOB cannot be fetched.
      
      row_ext_lookup_low(): Return field_ref_zero and *len = 0 when the
      BLOB pointer is unset.
      
      row_build_index_entry(): Return NULL when a needed BLOB pointer cannot
      be dereferenced (row_ext_lookup returns field_ref_zero).  Check the
      return value for NULL in callers.
      
      row_vers_impl_x_locked_off_kernel(): Avoid comparisons when
      row_build_index_entry() returns NULL.
      
      row_vers_old_has_index_entry(): Ignore records for which
      row_build_index_entry() returns NULL.  The entry should never be NULL
      in rollback, but it may be NULL in purge.
      
      row_merge_buf_add(): Assert that row_ext_lookup() does not return
      field_ref_zero.  The table will be locked during index creation.
      ab8f5e79
    • marko's avatar
      branches/zip: btr_cur_pessimistic_insert(): When calling · d08281b6
      marko authored
      btr_cur_optimistic_insert(), pass big_rec to it, so that
      the field references of externally stored columns (BLOB pointers)
      will not be left uninitialized after a successful optimistic insert.
      This bug was spotted by Sunny.
      d08281b6
  5. 23 Nov, 2007 3 commits
    • vasil's avatar
      branches/zip: Merge 2093:2116 from trunk. · 7750d0e8
      vasil authored
      7750d0e8
    • marko's avatar
      branches/zip: Correct mistakes made in r2114. · 855ccbd4
      marko authored
      row_upd_index_replace_new_col_vals(): Declare fetch_ext.
      
      row_upd_index_replace_new_col_vals_index_pos(): Add a type conversion
      to the initialization expression of fetch_ext, to avoid a warning about
      comparison between signed and unsigned.
      855ccbd4
    • marko's avatar
      branches/zip: Fix a bug in the updates of index records that contain a · a7135ea3
      marko authored
      column prefix of an externally stored column.
      
      row_upd_ext_fetch(): New function.
      
      row_upd_index_replace_new_col_vals(),
      row_upd_index_replace_new_col_vals_index_pos(): Fetch prefixes of
      externally stored columns when they are needed for column prefix
      indexes.  For memory allocation, add the parameter ext_heap.  Avoid
      repeating the inner loop after finding a  matching upd_field->field_no.
      a7135ea3
  6. 22 Nov, 2007 4 commits
  7. 21 Nov, 2007 12 commits
    • vasil's avatar
      branches/zip: · 860bc112
      vasil authored
      Fix the size of the static buffer for lock_table and lock_index.
      I was not realizing that NAME_LEN contains the mbmaxlen multiplier and thus
      a quote, when converted to 2 quotes, will take 2 bytes while there are 3
      bytes reserved.
      
      Spotted by:	Marko
      Pointyhat to:	Vasil
      860bc112
    • vasil's avatar
      branches/zip: · 193d01e3
      vasil authored
      Add C test for innobase_convert_name() in addition to the mysql-test one.
      193d01e3
    • marko's avatar
      branches/zip: When writing an externally stored column to the undo log, · a05f34d3
      marko authored
      set the "external storage" flag.  When parsing the undo log, do not
      misinterpret a SQL NULL column for externally stored.
      
      These bugs were spotted by Heikki and Sunny.
      
      trx_undo_page_report_modify(): Set the UNIV_EXTERN_STORAGE_FIELD flag
      when needed.
      
      trx_undo_rec_get_partial_row(): Check for len == UNIV_SQL_NULL.
      a05f34d3
    • vasil's avatar
      branches/zip: · 28383dde
      vasil authored
      Fix a bug where the static buffer for innodb_locks.lock_table may not
      have enough space.
      
      Pointyhat to:	Marko
      28383dde
    • vasil's avatar
      branches/zip: · 84979e43
      vasil authored
      Bugfix1: Set innodb_locks.lock_index to NOT NULL.
      If a column in INFORMATION_SCHEMA table has the flag
      MY_I_S_MAYBE_NULL and it is not explicitly marked as NOT NULL
      with the method ::set_notnull() then it is always rendered as
      NULL by MySQL.
      
      Bugfix2: Avoid crashes if lock_index is NULL. It is NULL for table
      level locks.
      
      Pointyhat to:	Marko
      84979e43
    • vasil's avatar
      branches/zip: · f268295c
      vasil authored
      Non-functional change:
      Fix consistency of the sizeof() operator with the rest of i_s.cc
      
      Pointyhat to:	Marko
      f268295c
    • vasil's avatar
      branches/zip: · 2140d595
      vasil authored
      Move test that depends on ucs2 to a separate file that is disabled if
      ucs2 is not compiled in.
      2140d595
    • vasil's avatar
      branches/zip: · a5f81a60
      vasil authored
      Move common SQL commands to an .inc file.
      a5f81a60
    • vasil's avatar
      branches/zip: · f5ff7acb
      vasil authored
      Synchronize the utf8 and ucs2 tests.
      f5ff7acb
    • marko's avatar
      branches/zip: INFORMATION_SCHEMA.INNODB_LOCKS: Quote lock_table, lock_index. · afccd4af
      marko authored
      innodb_information_schema.test. Add tests that display most columns from
      INFORMATION_SCHEMA.INNODB_LOCKS.  Test that quoting of table names works
      and respects SQL_MODE='ANSI_QUOTES'.
      
      innobase_print_identifier(): Remove.
      
      innobase_convert_identifier(): New function,
      based on innobase_print_identifier().
      
      innobase_convert_name(): New function, similar to ut_print_namel(), but
      using a memory buffer.
      
      ut_print_namel(): Use innobase_convert_name().
      
      fill_innodb_locks_from_cache(): Convert lock_table and lock_index by
      calling innobase_convert_name().
      afccd4af
    • marko's avatar
      3e2b5b65
    • vasil's avatar
      branches/zip: · bda6490d
      vasil authored
      Convert INFORMATION_SCHEMA tables' names to upper case so that they are
      consistent with other INFORMATION_SCHEMA tables.
      
       mysql> show tables;
       +---------------------------------------+
       | Tables_in_information_schema          |
       +---------------------------------------+
       | CHARACTER_SETS                        | 
       | COLLATIONS                            | 
       | COLLATION_CHARACTER_SET_APPLICABILITY | 
       | COLUMNS                               | 
       | COLUMN_PRIVILEGES                     | 
       | ENGINES                               | 
       | EVENTS                                | 
       | FILES                                 | 
       | GLOBAL_STATUS                         | 
       | GLOBAL_VARIABLES                      | 
       | KEY_COLUMN_USAGE                      | 
       | PARTITIONS                            | 
       | PLUGINS                               | 
       | PROCESSLIST                           | 
       | REFERENTIAL_CONSTRAINTS               | 
       | ROUTINES                              | 
       | SCHEMATA                              | 
       | SCHEMA_PRIVILEGES                     | 
       | SESSION_STATUS                        | 
       | SESSION_VARIABLES                     | 
       | STATISTICS                            | 
       | TABLES                                | 
       | TABLE_CONSTRAINTS                     | 
       | TABLE_PRIVILEGES                      | 
       | TRIGGERS                              | 
       | USER_PRIVILEGES                       | 
       | VIEWS                                 | 
       | innodb_zip_reset                      | 
       | innodb_trx                            | 
       | innodb_locks                          | 
       | innodb_lock_waits                     | 
       | innodb_zip                            | 
       +---------------------------------------+
      bda6490d
  8. 16 Nov, 2007 3 commits