1. 04 Sep, 2004 3 commits
    • unknown's avatar
      memory leaks fixed · 2452489c
      unknown authored
      
      sql/sql_derived.cc:
        memory leak fixed
      sql/sql_view.cc:
        memory leak fixed
      2452489c
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 64c00385
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-5.0
      
      
      mysql-test/r/view.result:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/table.h:
        Auto merged
      64c00385
    • unknown's avatar
      Print value of Item_param if it has a value (when debugging) · 7e49a21c
      unknown authored
      
      libmysql/libmysql.c:
        More debug
      sql/item.h:
        Print value of param if it has a value (when debugging)
      sql/log.cc:
        Better variable name
      sql/sql_insert.cc:
        Fix bug casused by merge
      sql/sql_parse.cc:
        Added missing command names (caused crash when running with --debug)
      sql/sql_select.cc:
        More debugging
      sql/sql_yacc.yy:
        Fixed typo
      tests/client_test.c:
        More debugging
      7e49a21c
  2. 03 Sep, 2004 3 commits
    • unknown's avatar
      Merge with pulled code · 22aa4739
      unknown authored
      
      mysql-test/r/view.result:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_subselect.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/table.h:
        Auto merged
      tests/client_test.c:
        Auto merged
      sql/sql_base.cc:
        Merge
      sql/sql_insert.cc:
        Merge
      sql/sql_select.cc:
        Merge
      sql/sql_view.cc:
        Merge
      sql/table.cc:
        Merge
      22aa4739
    • unknown's avatar
      Cleanup of new code pushed into 5.0 since last pull · 4f219919
      unknown authored
      Merged the different find_xxxx_table_in_list functions to one + some inline functions
      
      
      mysql-test/r/view.result:
        Fix result (remove not used view from show tables)
      sql/item_subselect.cc:
        Remove not used functions
      sql/item_subselect.h:
        Remove not used functions
      sql/mysql_priv.h:
        Merged the different find_xxxx_table_in_list functions to one + some inline functions
      sql/sql_acl.cc:
        More debugging + simple cleanups
      sql/sql_base.cc:
        Merged the different find_xxxx_table_in_list functions to one + some inline functions
        Indentation cleanups & more comments
      sql/sql_delete.cc:
        Namechange
      sql/sql_insert.cc:
        Simple optimizations & Style cleanups
        Merged common code (in mysql_prepare_insert_check_table)
      sql/sql_lex.cc:
        function name changes
        More comments
      sql/sql_parse.cc:
        Function name changes
        Made check_one_table_access returning bool
        More debugging in 'check_access'
        Added function 'check_some_access', which is used when creating a view
      sql/sql_prepare.cc:
        Resetting flag directly after test makes code easier to read
      sql/sql_select.cc:
        Code simplifications
      sql/sql_show.cc:
        Indentation cleanups.
        Fixed typo in name
      sql/sql_update.cc:
        Function name change
      sql/sql_view.cc:
        Simple optimizations.
        Style fixes.
        Remove view_field_names[]
        Simplified 'check_key_in_view()'
      sql/table.cc:
        Simplified new code in openfrm()
        variable name change i -> item
        Indentation changes
      sql/table.h:
        Fixed typo in variable name
        Method name change in field iterator: end() -> end_of_fields()
      tests/client_test.c:
        Changed number to macro
      4f219919
    • unknown's avatar
      ufter review fix · f5485925
      unknown authored
      
      sql/sql_view.cc:
        name of variable changed to make merge easy
        removed charset field
      sql/table.h:
        removed charset field
        layout fixed
      f5485925
  3. 02 Sep, 2004 5 commits
    • unknown's avatar
      Fixed BUG#5307: Stored procedure allows statement after BEGIN ... END. · 4a795f11
      unknown authored
      
      mysql-test/r/sp.result:
        New test case for BUG#5307
      mysql-test/t/sp.test:
        New test case for BUG#5307
      sql/sp_head.cc:
        Use the correct end-of-query pointer when extracting the body in the case
        of a create procedure compound with another statement.
      4a795f11
    • unknown's avatar
      Fixed BUG#5287: Stored procedure crash if leave outside loop. · a8c27b03
      unknown authored
      Bug in diff_handlers and diff_cursors made it attempt to pop
      the wrong number at jumps sometimes.
      
      
      mysql-test/r/sp.result:
        New testcase for BUG#5287.
      mysql-test/t/sp.test:
        New testcase for BUG#5287.
      sql/sp_pcontext.cc:
        Fixed diff_handlers and diff_cursors methods, they miscounted.
      sql/sp_pcontext.h:
        Made m_handlers available for diff_handlers.
      a8c27b03
    • unknown's avatar
      checked INTO clause during view creation (BUG#5332) · 5505c3e2
      unknown authored
      
      include/mysqld_error.h:
        bug name and number of bugs fixed
      mysql-test/r/view.result:
        VIEW over SELECT with prohibited clauses
      mysql-test/t/view.test:
        VIEW over SELECT with prohibited clauses
      sql/share/czech/errmsg.txt:
        error message made more general
      sql/share/danish/errmsg.txt:
        error message made more general
      sql/share/dutch/errmsg.txt:
        error message made more general
      sql/share/english/errmsg.txt:
        error message made more general
      sql/share/estonian/errmsg.txt:
        error message made more general
      sql/share/french/errmsg.txt:
        error message made more general
      sql/share/german/errmsg.txt:
        error message made more general
      sql/share/greek/errmsg.txt:
        error message made more general
      sql/share/hungarian/errmsg.txt:
        error message made more general
      sql/share/italian/errmsg.txt:
        error message made more general
      sql/share/japanese/errmsg.txt:
        error message made more general
      sql/share/korean/errmsg.txt:
        error message made more general
      sql/share/norwegian-ny/errmsg.txt:
        error message made more general
      sql/share/norwegian/errmsg.txt:
        error message made more general
      sql/share/polish/errmsg.txt:
        error message made more general
      sql/share/portuguese/errmsg.txt:
        error message made more general
      sql/share/romanian/errmsg.txt:
        error message made more general
      sql/share/russian/errmsg.txt:
        error message made more general
      sql/share/serbian/errmsg.txt:
        error message made more general
      sql/share/slovak/errmsg.txt:
        error message made more general
      sql/share/spanish/errmsg.txt:
        error message made more general
      sql/share/swedish/errmsg.txt:
        error message made more general
      sql/share/ukrainian/errmsg.txt:
        error message made more general
      sql/sql_view.cc:
        checked INTO clause during view creation
      5505c3e2
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 4f94380a
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-5.0
      
      
      sql/item.cc:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      4f94380a
    • unknown's avatar
      fixed bug handling in views (BUG#5276) · be4cc16d
      unknown authored
      
      mysql-test/r/view.result:
        bug handlimg from VIEWs
      mysql-test/t/view.test:
        bug handlimg from VIEWs
      sql/sql_base.cc:
        fixed bug handling in views
      be4cc16d
  4. 01 Sep, 2004 5 commits
  5. 31 Aug, 2004 2 commits
    • unknown's avatar
      ORDER clause printing fixed (BUG#5156) · faf2e53e
      unknown authored
      
      mysql-test/r/subselect.result:
        ORDER clause printing fixed
      mysql-test/r/view.result:
        order by refers on integer field
      mysql-test/t/view.test:
        order by refers on integer field
      sql/sql_lex.cc:
        ORDER clause printing fixed
      sql/sql_parse.cc:
        fields for correct ORDER printing added
      sql/sql_select.cc:
        fields for correct ORDER printing added
      sql/table.h:
        fields for correct ORDER printing added
      faf2e53e
    • unknown's avatar
      fixed open_and_lock_tables result processing (all open_and_lock_tables revision) · a64a5637
      unknown authored
      fixed printing of COLLATE operation
      (BUG#5155)
      
      
      mysql-test/r/case.result:
        fixed printing of COLLATE operation
      mysql-test/r/func_if.result:
        fixed printing of COLLATE operation
      mysql-test/r/func_in.result:
        fixed printing of COLLATE operation
      mysql-test/r/func_str.result:
        fixed printing of COLLATE operation
      mysql-test/r/func_test.result:
        fixed printing of COLLATE operation
      mysql-test/r/view.result:
        VIEW with collation
      mysql-test/t/view.test:
        VIEW with collation
      sql/item_strfunc.cc:
        fixed printing of COLLATE operation
      sql/item_strfunc.h:
        fixed printing of COLLATE operation
      sql/sp_head.cc:
        fixed open_and_lock_tables result processing
      sql/sql_base.cc:
        fixed open_and_lock_tables result processing
      sql/sql_delete.cc:
        fixed open_and_lock_tables result processing
      sql/sql_help.cc:
        fixed open_and_lock_tables result processing
      sql/sql_load.cc:
        fixed open_and_lock_tables result processing
      sql/sql_parse.cc:
        fixed open_and_lock_tables result processing
      sql/sql_prepare.cc:
        fixed open_and_lock_tables result processing
      sql/sql_show.cc:
        fixed open_and_lock_tables result processing
      sql/sql_update.cc:
        fixed open_and_lock_tables result processing
      a64a5637
  6. 30 Aug, 2004 6 commits
  7. 28 Aug, 2004 1 commit
    • unknown's avatar
      Microsoft VC++ won't compile class C { static const int I=1; }. · cddb6522
      unknown authored
      Putting initialization into .cc will reduce compiler's abilities
      to optimize this constant away.
      Defines are not OK as they bloat global namespace.
      Looking for a way to declare an efficient named constant in reduced
      namespace (i. e. in  a class).
      Let's try enums: normally they should be implicitly casted to int.
      Let's see if we really have a compiler which won't do that.
      
      
      
      
      libmysqld/lib_sql.cc:
        Added explicit cast to int for Protocol::{SEND_DEFAULTS,SEND_NUM_ROWS,
        SEND_EOF}
        flags argument of send_fields() is now int.
      sql/protocol.cc:
        flags argument of send_fields is now int.
      sql/protocol.h:
        Catch22: Microsoft VC++ won't compile 
        class C { static const int I=1; }.
        Putting initialization into .cc will reduce compiler's abilities
        to optimize this constant away.
        Defines are not OK as they bloat global namespace.
        Looking for a way to declare an efficient named constant in reduced
        namespace (i. e. in  a class).
        Let's try enums: normally they should be implicitly casted to int.
        Let's see if we really have a compiler which won't do that.
      sql/protocol_cursor.cc:
        flags are now int.
      cddb6522
  8. 27 Aug, 2004 2 commits
  9. 26 Aug, 2004 5 commits
    • unknown's avatar
      Item name for VIEW added to find_field_in_table (BUG#5147) · 8048c282
      unknown authored
      
      mysql-test/r/view.result:
        VIEW of VIEW with column renaming
      mysql-test/t/view.test:
        VIEW of VIEW with column renaming
      sql/mysql_priv.h:
        Item name for VIEW added to find_field_in_table
      sql/sql_acl.cc:
        new parameter
      sql/sql_base.cc:
        Item name for VIEW added to find_field_in_table
      8048c282
    • unknown's avatar
      fixed updateability VIEW detection (Bug#5146) · b6dd6676
      unknown authored
      fixed other Item_ref methods where result_field involved
      
      
      mysql-test/r/view.result:
        statements added to distinct in temporary table with a VIEW test
        test of agggregate over aggregate with view
      mysql-test/t/view.test:
        statements added to distinct in temporary table with a VIEW test
        test of agggregate over aggregate with view
      sql/item.cc:
        fixed other Item_ref methods where result_field involved
      sql/item.h:
        fixed other Item_ref methods where result_field involved
      sql/sql_lex.cc:
        fixed updateability VIEW detection
      b6dd6676
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 1a24f41e
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0-merge
      
      1a24f41e
    • unknown's avatar
      Major rehacking and cleanup of sp_pcontext. · 6dd5a174
      unknown authored
      This finishes (almost) WL#2002: Implement stored procedure GOTO.
      Only the syntax issue for free labels remains ("label L;" vs "L:").
      
      
      include/mysqld_error.h:
        New error code for GOTO in SP handler.
      mysql-test/r/sp-error.result:
        New error test cases for GOTO.
      mysql-test/r/sp.result:
        New test cases for GOTO.
        Also removed some things that made it impossible to run the test in
        an external (debugged) mysqld.
      mysql-test/t/sp-error.test:
        New error test cases for GOTO.
      mysql-test/t/sp.test:
        New test cases for GOTO.
        Also removed some things that made it impossible to run the test in
        an external (debugged) mysqld.
      sql/share/czech/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/danish/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/dutch/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/english/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/estonian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/french/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/german/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/greek/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/hungarian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/italian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/japanese/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/korean/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/norwegian-ny/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/norwegian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/polish/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/portuguese/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/romanian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/russian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/serbian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/slovak/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/spanish/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/swedish/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/ukrainian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/sp_head.cc:
        Code cleanup (renaming of pcontext methods), support goto, and fixed bug
        in jump shortcutting in the optimizer (detect infinite loops).
      sql/sp_head.h:
        Code cleanup (renaming of pcontext methods), support goto, and fixed bug
        in jump shortcutting in the optimizer (detect infinite loops).
      sql/sp_pcontext.cc:
        Major rehack and cleanup:
        - We now push and pop a chain of contexts during parsing (instead of having
          a single one).
        - Makes error detection for GOTO easier and enables some optmizations and
          debugger support.
        - Makes it a little trickier to keep track on variable and cursor indexes instead.
        - Renamed things to get a more consistent naming scheme too.
      sql/sp_pcontext.h:
        Major rehack and cleanup:
        - We now push and pop a chain of contexts during parsing (instead of having
          a single one).
        - Makes error detection for GOTO easier and enables some optmizations and
          debugger support.
        - Makes it a little trickier to keep track on variable and cursor indexes instead.
        - Renamed things to get a more consistent naming scheme too.
      sql/sql_yacc.yy:
        Changes to reflect the rework and renamings in sp_pcontext, and fixed
        some GOTO error checking.
      6dd5a174
    • unknown's avatar
      fix of Item_ref with result_field (BUG#5104) · 60689138
      unknown authored
      
      mysql-test/r/view.result:
        distinct in temporary table with a VIEW
      mysql-test/t/view.test:
        distinct in temporary table with a VIEW
      sql/item.cc:
        fix of Item_ref with result_field
      sql/item.h:
        fix of Item_ref with result_field
      60689138
  10. 25 Aug, 2004 4 commits
  11. 24 Aug, 2004 4 commits
    • unknown's avatar
      fixes name outout for SHOW CREATE VIEW command (BUG#5162) · f766837f
      unknown authored
      
      mysql-test/r/view.result:
        SHOW CREATE VIEW output changed
        test of SHOW CREATE VIEW for view with spaces in the name
      mysql-test/t/view.test:
        test of SHOW CREATE VIEW for view with spaces in the name
      sql/sql_show.cc:
        fixes name outout for SHOW CREATE VIEW command
      f766837f
    • unknown's avatar
      new method to detect commands where all VIEWs should be temporary tables (BUG#4803) · 1aea9d8d
      unknown authored
      
      mysql-test/r/view.result:
        Showing VIEW with VIEWs in subquery
      mysql-test/t/view.test:
        Showing VIEW with VIEWs in subquery
      sql/sql_lex.cc:
        new method to detect commands where all VIEWs should be temporary tables
      sql/sql_lex.h:
        new method to detect commands where all VIEWs should be temporary tables
      sql/sql_view.cc:
        new method to detect commands where all VIEWs should be temporary tables
        debug output added
      1aea9d8d
    • unknown's avatar
      fixed aggregate function processing in VIEWs (BUG#4665) · c084e3be
      unknown authored
      
      mysql-test/r/view.result:
        Aggregate functions in view list
      mysql-test/t/view.test:
        Aggregate functions in view list
      sql/table.cc:
        fixed aggregate function processing in VIEWs
      c084e3be
    • unknown's avatar
      Fixed UNION support in view creation (BUG#4664) · 1d701b0f
      unknown authored
      
      mysql-test/r/view.result:
        added removing of table t2
        test of view built over union
      mysql-test/t/view.test:
        added removing of table t2
        test of view built over union
      sql/sql_view.cc:
        Fixed UNION support in view creation
      1d701b0f