1. 09 Aug, 2005 1 commit
    • unknown's avatar
      Clumsy but working fix for bug #11973 "SELECT .. INTO var_name; in trigger · 24895964
      unknown authored
      cause crash on update".
      
      Let us update "thd" pointer in LEX, all its units and in LEX::result before
      executing statement in trigger body, since triggers are associated with TABLE
      object and because of this can be used in different threads.
      
      
      mysql-test/r/trigger.result:
        Added test case for bug #11973 "SELECT .. INTO var_name; in trigger cause
        crash on update".
      mysql-test/t/trigger.test:
        Added test case for bug #11973 "SELECT .. INTO var_name; in trigger cause
        crash on update".
      sql/item_subselect.cc:
        subselect_engine:
          Moved implementation of set_thd() method to item_subselect.cc,
          since now it also sets "thd" for subselect_engine::result.
      sql/item_subselect.h:
        subselect_engine:
          Moved implementation of set_thd() method to item_subselect.cc,
          since now it also sets "thd" for subselect_engine::result.
      sql/sql_class.h:
        select_result:
          Added set_thd() method for updating select_result::thd value (we need this
          in cases when statement to which this select_result belongs will be used
          in different threads, as it happens for statements in trigger body).
        multi_delete/multi_update:
          Got rid of redundant "thd" member (we already have it in select_result).
      sql/sql_delete.cc:
        multi_delete:
          Got rid of redundant "thd" member (we already have it in select_result).
      sql/sql_lex.h:
        st_select_lex_unit:
          Added set_thd() method for updating st_select_lex_unit::thd value
          (we need this in cases when statement to which this unit belongs will
           be used in different threads, as it happens for statements in trigger body).
          We don't update thd of select_result pointed by st_select_lex_unit::result
          in this method, since it is either have too short lifetime (i.e. created for
          each execution) or is accessible via Item_subquery or LEX::result and thus
          already taken care of.
      sql/sql_parse.cc:
        multi_delete:
          Got rid of redundant "thd" member (we already have it in select_result).
      sql/sql_prepare.cc:
        reinit_stmt_before_use():
          We have to update "thd" pointer in LEX, all its units and in LEX::result,
          since statements which belong to trigger body are associated with TABLE
          object and because of this can be used in different threads.
      sql/sql_update.cc:
        multi_update:
          Got rid of redundant "thd" member (we already have it in select_result).
      24895964
  2. 05 Aug, 2005 19 commits
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · fa4525ca
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      fa4525ca
    • unknown's avatar
      mysql_priv.h: · 6d5d8c92
      unknown authored
        Fixed bug #12154: a query returned: Column <name> cannot be null.
        The problem was due to a bug in the function setup_table_map:
        the flag maybe_null was set up incorrectly for inner tables of
        nested outer joins.
      join_nested.result, join_nested.test:
        Added a test case for bug #12154.
      
      
      mysql-test/t/join_nested.test:
        Added a test case for bug #12154.
      mysql-test/r/join_nested.result:
        Added a test case for bug #12154.
      sql/mysql_priv.h:
        Fixed bug #12154: a query returned: Column <name> cannot be null.
        The problem was due to a bug in the function setup_table_map:
        the flag maybe_null was set up incorrectly for inner tables of
        nested outer joins.
      6d5d8c92
    • unknown's avatar
    • unknown's avatar
      567519f1
    • unknown's avatar
      Merge mysqldev@production.mysql.com:/data0/mysqldev/my/mysql-5.0-release · 81d09ccd
      unknown authored
      into mysql.com:/M50/clone-5.0
      
      81d09ccd
    • unknown's avatar
      New "Instance Manager" code: · 6ef3bf24
      unknown authored
      Rename "port.h" to "portability.h" to avoid conflict with system header file name,
      and include the file in "Makefile.am".
      
      
      server-tools/instance-manager/Makefile.am:
        Ensure that the (recently added) header "portability.h" (renamed from "port.h") gets included in the source packages.
      server-tools/instance-manager/guardian.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/instance.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/instance_options.h:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/listener.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/log.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/mysqlmanager.vcproj:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/options.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/parse_output.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/portability.h:
        Adapt the protective CPP symbol to the changed file name.
      server-tools/instance-manager/priv.cc:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      server-tools/instance-manager/priv.h:
        Rename "port.h" to "portability.h" to avoid conflict with system header file name.
      6ef3bf24
    • unknown's avatar
      Merge mysqldev@production.mysql.com:my/mysql-5.0-release · d95db730
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-release
      
      
      client/client_priv.h:
        Auto merged
      d95db730
    • unknown's avatar
      client_priv.h: · 8853c9f8
      unknown authored
        Removed ending comma in enum
      Makefile.am:
        config.cpp => ndb_config.cpp, solves link problems on case insensitive OS
      ndb_config.cpp:
        Rename: ndb/tools/config.cpp -> ndb/tools/ndb_config.cpp
      
      
      ndb/tools/ndb_config.cpp:
        Rename: ndb/tools/config.cpp -> ndb/tools/ndb_config.cpp
      ndb/tools/Makefile.am:
        config.cpp => ndb_config.cpp, solves link problems on case insensitive OS
      client/client_priv.h:
        Removed ending comma in enum
      8853c9f8
    • unknown's avatar
      testcase added to fix for bug #12281 (Geometry & trigger crash) · 3eb39935
      unknown authored
      
      mysql-test/r/gis.result:
        test result fixed
      mysql-test/t/gis.test:
        testcase added
      3eb39935
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 2f014d89
      unknown authored
      into deer.(none):/home/hf/work/mysql-5.0.12281
      
      2f014d89
    • unknown's avatar
      Fix for bug #12281 (Geometry: crash in trigger) · fe9eb03c
      unknown authored
      Field_geom lack size_of method
      
      
      sql/field.h:
        size_of implemented
      fe9eb03c
    • unknown's avatar
    • unknown's avatar
      post-review fix · 07ae5d15
      unknown authored
      
      server-tools/instance-manager/listener.cc:
        some more cleanup
      07ae5d15
    • unknown's avatar
      chmod -x new IM files · 7c3a37e9
      unknown authored
      
      server-tools/instance-manager/WindowsService.cpp:
        Change mode to -rw-rw-r--
      server-tools/instance-manager/WindowsService.h:
        Change mode to -rw-rw-r--
      server-tools/instance-manager/port.h:
        Change mode to -rw-rw-r--
      server-tools/instance-manager/mysqlmanager.vcproj:
        Change mode to -rw-rw-r--
      server-tools/instance-manager/IMService.cpp:
        Change mode to -rw-rw-r--
      server-tools/instance-manager/IMService.h:
        Change mode to -rw-rw-r--
      7c3a37e9
    • unknown's avatar
      IM port cleanup · 33f06e22
      unknown authored
      
      server-tools/instance-manager/IMService.cpp:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/WindowsService.cpp:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/WindowsService.h:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/instance.cc:
        cleanup & coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/listener.cc:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/manager.cc:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/options.cc:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/user_map.cc:
        simplify password file processing
      33f06e22
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.0 · c3d7a03f
      unknown authored
      into  mysql.com:/home/cps/mysql/trees/mysql-5.0
      
      c3d7a03f
    • unknown's avatar
      IM port fixes: fix crash on startup, add more error checking, get rid of unnecessary code. · 300e4c2a
      unknown authored
      
      server-tools/instance-manager/commands.cc:
        fix memory leak
      server-tools/instance-manager/guardian.cc:
        don't check pthread_mutex_lock/unlock return value, as it never returns error if properly
        used (no self deadlocks) and initialized
      server-tools/instance-manager/guardian.h:
        prototype fixed
      server-tools/instance-manager/instance_map.cc:
        don't check pthread_mutex_lock/unlock status, as it never returns error if
        properly used (no self deadlocks) and initialized
      server-tools/instance-manager/instance_map.h:
        prototype fixed
      server-tools/instance-manager/listener.cc:
        initialize highest-numbered descriptor to 0 for select before setting it with max(n, sockets[i]),
        ifdef unix-specific code
      server-tools/instance-manager/manager.cc:
        remove commented stuff
      server-tools/instance-manager/options.cc:
        fix crash in load_defaults, which happened on all Unix systems due to
        const char *Options::config_file= NULL. Check return value for GetModuleFileName.
        Get rid of obscure default_config_file[FN_REFLEN]= "/etc/my.cnf"; which was never used
      300e4c2a
    • unknown's avatar
      fix for bug #12315 - SHOW TABLE STATUS FROM `information_schema`; does not sort tablenames · 5efbe0a9
      unknown authored
      
      mysql-test/r/information_schema.result:
        fix the test case for fix for bug #12315 - SHOW TABLE STATUS FROM `information_schema`; does not sort tablenames
      mysql-test/r/information_schema_db.result:
        fix the test case for fix for bug #12315 - SHOW TABLE STATUS FROM `information_schema`; does not sort tablenames
      sql/sql_show.cc:
        reorder the structure
        fix for bug #12315 - SHOW TABLE STATUS FROM `information_schema`; does not sort tablenames
      sql/table.h:
        reorder the enum
        fix for bug #12315 - SHOW TABLE STATUS FROM `information_schema`; does not sort tablenames
      5efbe0a9
    • unknown's avatar
      Fix gcc -ansi -pedantic compilation failure. · f01ca726
      unknown authored
      
      client/client_priv.h:
        Fix a compile failure.
      f01ca726
  3. 04 Aug, 2005 20 commits