1. 09 Jul, 2007 10 commits
  2. 08 Jul, 2007 1 commit
  3. 07 Jul, 2007 9 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 3c2eb9ec
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug29417
      
      
      mysql-test/r/type_newdecimal.result:
        Manual merge.
      mysql-test/t/type_newdecimal.test:
        Manual merge.
      3c2eb9ec
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · bf28faf7
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      bf28faf7
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1-opt · cbc7749f
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      cbc7749f
    • unknown's avatar
      Fixed bug #29417. · 578d9721
      unknown authored
      An assertion abort could occur for some grouping queries that employed 
      decimal user variables with assignments to them.
      
      The problem appeared the constructors of the class Field_new_decimal
      because the function my_decimal_length_to_precision did not guarantee
      returning decimal precision not greater than DECIMAL_MAX_PRECISION.
      
      
      mysql-test/r/type_newdecimal.result:
        Added a test case for bug #29417.
      mysql-test/t/type_newdecimal.test:
        Added a test case for bug #29417.
      sql/field.cc:
        Fixed bug #29417.
        An assertion abort could occur for some grouping queries that employed 
        decimal user variables with assignments to them.
        
        The problem appeared the constructors of the class Field_new_decimal
        because the function my_decimal_length_to_precision did not guarantee
        returning decimal precision not greater than DECIMAL_MAX_PRECISION.
        
        Now if the precision returned by calls to my_decimal_length_to_precision
        in the constructors of the class Field_new_decimal is greater than 
        DECIMAL_MAX_PRECISION the precision is set to this value.
      578d9721
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · 6e24d4e6
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/t/innodb_mysql.test:
        Merge with 5.0 (main).
      6e24d4e6
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1 · fd4904e9
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/4.1-opt
      
      fd4904e9
    • unknown's avatar
      Fixed bug #29415. · 5e401735
      unknown authored
      The cast operation ignored the cases when the precision and/or the scale exceeded
      the limits, 65 and 30 respectively. No errors were reported in these cases.
      For some queries this may lead to an assertion abort.
      
      Fixed by throwing errors for such cases.
      
      
      mysql-test/r/type_newdecimal.result:
        Added a test case for bug #29415.
      mysql-test/t/type_newdecimal.test:
        Added a test case for bug #29415.
      5e401735
    • unknown's avatar
      Bug #29543 GCov information not written in case of crash. · 1ec3e7f4
      unknown authored
      For GCov builds, if the server crashes, the normal exit handler for writing
      coverage information is not executed due to the abnormal termination.
      
      Fix this by explicitly calling the __gcov_flush function in our crash handler.
      
      1ec3e7f4
    • unknown's avatar
      Merge sita.local:/Users/tsmith/m/bk/maint/41 · 360261b1
      unknown authored
      into  sita.local:/Users/tsmith/m/bk/maint/50
      
      360261b1
  4. 06 Jul, 2007 10 commits
  5. 05 Jul, 2007 8 commits
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · a22ddbf1
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      a22ddbf1
    • unknown's avatar
      Fixed bug #29442. · bed05531
      unknown authored
      The SELECT INTO OUTFILE FIELDS ENCLOSED BY digit or minus sign,
      followed by the same LOAD DATA INFILE statement, used wrond encoding
      of non-string fields contained the enclosed character in their text
      representation.
      
      Example:
        SELECT 15, 9 INTO OUTFILE 'text' FIELDS ENCLOSED BY '5';
      
      Old encoded result in the text file:
        5155 595
               ^ was decoded as the 1st enclosing character of the 2nd field;
              ^ was skipped as garbage;
        ^    ^ was decoded as a pair of englosing characters of the 1st field;
            ^   was decoded as traling space of the first field;
          ^^ was decoded as a doubled enclosed character.
      
      New encoded result in the text file:
        51\55 595
        ^   ^ pair of enclosing characters of the 1st field;
          ^^ escaped enclosed character.
      
      
      
      sql/sql_class.h:
        Fixed bug #29442.
        The NUMERIC_CHARS macro constant has been defined to enumerate
        all possible characters of a numeric value text representation.
        The select_export::is_unsafe_field_sep boolean flag has been added
        to apply the encoding algorithm to non-string values when it is
        necessary.
      sql/sql_class.cc:
        Fixed bug #29442.
        The select_export::send_data method has been modified to encode text
        representation of fields of all data types like string fields.
      mysql-test/t/loaddata.test:
        Updated test case for bug #29442.
      mysql-test/r/loaddata.result:
        Updated test case for bug #29442.
      bed05531
    • unknown's avatar
      Bug #29166: · 61d616dd
      unknown authored
      AsText() needs to know the maximum number of
      characters a IEEE double precision value can
      occupy to make sure there's enough buffer space.
      The number was too small to hold all possible
      values and this caused buffer overruns.
      Fixed by correcting the calculation of the 
      maximum digits in a string representation of an
      IEEE double precision value as printed by 
      String::qs_append(double).
      
      
      mysql-test/r/gis.result:
        Bug #29166: test case
      mysql-test/t/gis.test:
        Bug #29166: test case
      sql/spatial.cc:
        Bug #29166: correct calculation of the maximum digits in
        a string representation of a double
      61d616dd
    • unknown's avatar
      Fix for bug #28808: log_queries_not_using_indexes variable dynamic change is ignored · 614e0d29
      unknown authored
      Problem: logging queries not using indexes we check a special flag which 
      is set only at the server startup and is not changing with a corresponding
      server variable together.
      
      Fix: check the variable value instead of the flag.
      
      
      
      mysql-test/r/show_check.result:
        Fix for bug #28808: log_queries_not_using_indexes variable dynamic change is ignored
          - test result.
      mysql-test/t/show_check.test:
        Fix for bug #28808: log_queries_not_using_indexes variable dynamic change is ignored
          - test case.
      sql/mysqld.cc:
        Fix for bug #28808: log_queries_not_using_indexes variable dynamic change is ignored
          - SPECIAL_LOG_QUERIES_NOT_USING_INDEXES is not used anymore.
      sql/sql_parse.cc:
        Fix for bug #28808: log_queries_not_using_indexes variable dynamic change is ignored
          - check opt_log_queries_not_using_indexes instead of 
            SPECIAL_LOG_QUERIES_NOT_USING_INDEXES flag.
      sql/unireg.h:
        Fix for bug #28808: log_queries_not_using_indexes variable dynamic change is ignored
          - SPECIAL_LOG_QUERIES_NOT_USING_INDEXES is not used anymore.
      614e0d29
    • unknown's avatar
      Fix for bug #29420: crash with show and purge binlogs · 89f64dc0
      unknown authored
      Problem: in case of failed 'show binlog events...' we don't inform that 
      the log is not in use anymore. That may confuse following 'purge logs...'
      command as it takes into account logs in use.
      
      Fix: always notify that the log is not in use anymore.
      
      
      mysql-test/r/rpl_rotate_logs.result:
        Fix for bug #29420: crash with show and purge binlogs
          - test result.
      mysql-test/t/rpl_rotate_logs.test:
        Fix for bug #29420: crash with show and purge binlogs
          - test case.
      sql/sql_repl.cc:
        Fix for bug #29420: crash with show and purge binlogs
          - always zero thd->current_linfo at the end of the mysql_show_binlog_events().
      89f64dc0
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG27564/mysql-4.1-engines · 8e34c7e9
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG27564/mysql-5.0-engines
      
      
      mysys/hash.c:
        Auto merged
      8e34c7e9
    • unknown's avatar
      BUG#27564 - Valgrind: UDF does not cleanup correctly · 632ed804
      unknown authored
      Dropping an user defined function may cause server crash in
      case this function is still in use by another thread.
      
      The problem was that our hash implementation didn't update
      hash link list properly when hash_update() was called.
      
      
      mysys/hash.c:
        The following requirement wasn't met by hash_update() function
        causing corruption of hash links list:
        
        After a record was unlinked from the old chain during update, it
        holds random position. By the chance this position is equal to
        position for the first element in the new chain. That means
        updated record is the only record in the new chain.
      632ed804
    • unknown's avatar
      Fixed bug #29392. · b7f5b7b0
      unknown authored
      This bug may manifest itself for select queries over a multi-table view
      that includes an ORDER BY clause in its definition. If the select list of 
      the query contains references to the same view column with different
      aliases the names of the columns in the result output will be nevertheless
      the same, coinciding with one of the alias.
      
      The bug happened because the method Item_ref::get_tmp_table_item that
      was inherited by the class Item_direct_view_ref ignored the fact that
      the name of the view column reference must be inherited by the fields
      of the temporary table that was created in order to get the result rows
      sorted.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #29392.
      mysql-test/t/view.test:
        Added a test case for bug #29392.
      sql/item.h:
        Fixed bug #29392.
        This bug may manifest itself for select queries over a multi-table view
        that includes an ORDER BY clause in its definition. If the select list of 
        the query contains references to the same view column with different
        aliases the names of the columns in the result output will be nevertheless
        the same, coinciding with one of the alias.
        
        The bug happened because the method Item_ref::get_tmp_table_item that
        was inherited by the class Item_direct_view_ref ignored the fact that
        the name of the view column reference must be inherited by the fields
        of the temporary table that was created in order to get the result rows
        sorted.
        
        Fixed by providing a proper implementation of the get_tmp_table_item 
        method for the Item_direct_view_ref class.
      b7f5b7b0
  6. 04 Jul, 2007 2 commits