1. 24 Apr, 2021 1 commit
    • Marko Mäkelä's avatar
      MDEV-25459 MVCC read from index on CHAR or VARCHAR wrongly omits rows · 25ed665a
      Marko Mäkelä authored
      row_sel_sec_rec_is_for_clust_rec(): If the field in the
      clustered index record stored off page, always fetch it,
      also when the secondary index field has been built on the
      entire column. This was broken ever since the InnoDB Plugin
      for MySQL Server 5.1 introduced ROW_FORMAT=DYNAMIC and
      ROW_FORMAT=COMPRESSED for InnoDB tables. That code was first
      introduced in this tree in
      commit 3945d5e5.
      
      For the original ROW_FORMAT=REDUNDANT and the MySQL 5.0.3
      ROW_FORMAT=COMPRESSED, there was no problem, because for
      those tables we always stored at least a 768-byte prefix of
      each column in the clustered index record.
      
      row_sel_sec_rec_is_for_blob(): Allow prefix_len==0 for matching
      the full column.
      25ed665a
  2. 23 Apr, 2021 4 commits
  3. 22 Apr, 2021 4 commits
    • Igor Babaev's avatar
      MDEV-24823 Crash with invalid multi-table update of view in 2nd execution of SP · b3b5d57e
      Igor Babaev authored
      Before this patch mergeable derived tables / view used in a multi-table
      update / delete were merged before the preparation stage.
      When the merge of a derived table / view is performed the on expression
      attached to it is fixed and ANDed with the where condition of the select S
      containing this derived table / view. It happens after the specification of
      the derived table / view has been merged into S. If the ON expression refers
      to a non existing field an error is reported and some other mergeable derived
      tables / views remain unmerged. It's not a problem if the multi-table
      update / delete statement is standalone. Yet if it is used in a stored
      procedure the select with incompletely merged derived tables / views may
      cause a problem for the second call of the procedure. This does not happen
      for select queries using derived tables / views, because in this case their
      specifications are merged after the preparation stage at which all ON
      expressions are fixed.
      This patch makes sure that merging of the derived tables / views used in a
      multi-table update / delete statement is performed after the preparation
      stage.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      b3b5d57e
    • Vladislav Vaintroub's avatar
      5c5d24c7
    • Vladislav Vaintroub's avatar
      MDEV-25456 MariaBackup logs "[ERROR]" on Invalid log block checksum · 78bb9533
      Vladislav Vaintroub authored
      Fix is to changed message to be [WARNING] for backup
      78bb9533
    • Vladislav Vaintroub's avatar
      Update timezone data on Windows · f6542a7a
      Vladislav Vaintroub authored
      There is new Yukon Standard time Windows timezone.
      
      Also fix the powershell script that generates the Windows locale mapping,
      tell powershell to use TLSv1.2 to access the github (on some reason it is
      TLS1.1 that powershell is using by default, and it does no work)
      f6542a7a
  4. 21 Apr, 2021 5 commits
  5. 20 Apr, 2021 5 commits
  6. 17 Apr, 2021 2 commits
    • Igor Babaev's avatar
      MDEV-25362 Incorrect name resolution for subqueries in ON expressions · 635b5ce3
      Igor Babaev authored
      This patch sets the proper name resolution context for outer references
      used in a subquery from an ON clause. Usually this context is more narrow
      than the name resolution context of the parent select that were used before
      this fix.
      This fix revealed another problem that concerned ON expressions used in
      from clauses of specifications of derived tables / views / CTEs. The name
      resolution outer context for such ON expression must be set to NULL to
      prevent name resolution beyond the derived table where it is used.
      The solution to resolve this problem applied in sql_derived.cc was provided
      by Sergei Petrunia <sergey@mariadb.com>.
      
      The change in sql_parse.cc is not good for 10.4+. A corresponding diff for
      10.4+ will be provided in JIRA entry for this bug.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      635b5ce3
    • Rainer Orth's avatar
      MDEV-15064: IO_CACHE mysys read_pos, not libmaria rc_pos · 73bf6246
      Rainer Orth authored
      It seems some overly tolerant compilers (gcc) allow the structure
      of IO_CACHE that is defined differently in libmaria to have
      members equalivance to the iocache in mysys.
      
      More strict Solaris compilers recognise that rc_pos really
      isn't a structure member and won't compile.
      73bf6246
  7. 16 Apr, 2021 1 commit
  8. 15 Apr, 2021 4 commits
  9. 14 Apr, 2021 4 commits
  10. 13 Apr, 2021 2 commits
  11. 12 Apr, 2021 8 commits
    • Dmitriy Karpovskiy's avatar
      MDEV-24135: Print warnings in XML, save test retries in XML, save the... · f776fa96
      Dmitriy Karpovskiy authored
      MDEV-24135: Print warnings in XML, save test retries in XML, save the combinations in XML, replace the special symbols in the XML comment
      f776fa96
    • Oleksandr Byelkin's avatar
      MDEV-25182 Complex query in Store procedure corrupts results · 68e0defc
      Oleksandr Byelkin authored
      At the second execution of the PS
      1. mark_as_dependent() is called with the same parameters as at the first
         execution (select#4 and select#3)
      2. as outer_select (select#3) has been already merged at the first
         execution of PS it cannot be reached using the outer_select() function
         anymore (and so can not stop iteration).
      3. as a result all selects towards the top level select including the
         select for 'ca' are marked as uncacheable.
      4. Marked uncacheable it executed incorrectly triggering filling its
         temporary table several times and using freed memory at the end.
      
      To avoid the problem we use name resolution context to go "up".
      
      NOTE: problem also exists in 10.2 but has no visible effect on execution.
      That is why the problem is fixed in 10.2.
      
      The patch also add debug logging of important procedures and
      better specify parameters types of st_select_lex::mark_as_dependent.
      68e0defc
    • Dmitry Shulga's avatar
      MDEV-25108: Running of the EXPLAIN EXTENDED statement produces extra warning... · f8bf2a01
      Dmitry Shulga authored
      MDEV-25108: Running of the EXPLAIN EXTENDED statement produces extra warning in case it is executed in PS (prepared statement) mode
      
      The EXPLAIN EXTENDED statement run as a prepared statement can produce extra
      warning comparing with a case when EXPLAIN EXTENDED statement is run as
      a regular statement. For example, the following test case
        CREATE TABLE t1 (c int);
        CREATE TABLE t2 (d int);
        EXPLAIN EXTENDED SELECT (SELECT 1 FROM t2 WHERE d = c) FROM t1;
      
      produces the extra warning
        "Field or reference 'c' of SELECT #2 was resolved in SELECT #1"
      in case the above mentioned "EXPLAIN EXTENDED" statement is executed
      in PS mode, that is by submitting the following statements:
         PREPARE stmt FROM "EXPLAIN EXTENDED SELECT (SELECT 1 FROM t2 WHERE d = c) FROM t1";
         EXECUTE stmt;
      
      The reason of the extra warning emittion is in a way items
      are handled (being fixed) during execution of the JOIN::prepare() method.
      The method Item_field::fix_fields() calls the find_field_in_tables()
      function in case a field hasn't been associated yet with the item.
      Implementation of the find_field_in_tables() function first checks whether
      a table containing the required field was already opened and cached.
      It is done by checking the data member item->cached_table. This data member
      is set on handling the PRERARE FROM statement and checked on executing
      the EXECUTE statement. If the data member item->cached_table is set
      the find_field_in_tables() function invoked and the
      mark_select_range_as_dependent() function called if the field
      is an outer referencee. The mark_select_range_as_dependent() function
      calls the mark_as_dependent() function that finally invokes
      the push_warning_printf() function that produces extra warning.
      
      To fix the issue, calling of push_warning_printf() is elimited in case
      it was run indirectly in result of hanlding already opened table from
      the Item_field::fix_fields() method.
      f8bf2a01
    • Julius Goryavsky's avatar
      MDEV-21484: galera_sst_mariabackup_encrypt_with_key test failed · e95cdc45
      Julius Goryavsky authored
      This commit removes the mtr test galera_sst_mariabackup_encrypt_with_key
      from the list of disabled tests because the problem with it has already
      been fixed.
      e95cdc45
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-24971 InnoDB access freed virtual column after rollback of secondary index · cf2c6b7f
      Thirunarayanan Balathandayuthapani authored
      Problem:
      ========
       InnoDB fails to clean the index stub if it fails to add the
      virtual index which contains new virtual column. But it clears
      the newly virtual column from index in clear_added_indexes()
      during inplace_alter_table. On commit, InnoDB evicts and
      reload the table. In case of rollback, it doesn't happen.
      InnoDB clears the ABORTED index while opening the table
      or doing the DDL. In the mean time, InnoDB can access
      the dropped virtual index columns while creating prebuilt
      or rollback of concurrent DML.
      
      Solution:
      ==========
      (1) InnoDB should maintain newly added virtual column while
      rollbacking the newly added virtual index.
      (2) InnoDB must not defer the index removal
      if the alter table is executed with LOCK=EXCLUSIVE.
      (3) For LOCK=SHARED, InnoDB should check whether the table
      has any other transaction lock other than alter transaction
      before deferring the index stub.
      
      Replaced has_new_v_col with dict_add_vcol_info in dict_index_t to
      indicate whether the index has any new virtual column.
      
      dict_index_t::has_new_v_col(): Returns whether the index has
      newly added virtual column, it doesn't say which columns are
      newly added virtual column
      
      ha_innobase_inplace_ctx::is_new_vcol(): Return whether the
      given column is added as a part of the current alter.
      
      ha_innobase_inplace_ctx::clean_new_vcol_index(): Copy the newly
      added virtual column to new_vcol_info in dict_index_t. Replace
      the column in the index fields with virtual column stored
      in new_vcol_info.
      
      dict_index_t::assign_new_v_col(): Store the number of virtual
      column added in index as a part of alter table.
      
      dict_index_t::get_n_new_vcol(): Get the number of newly added
      virtual column
      
      dict_index_t::assign_drop_v_col(): Allocate the memory for
      adding new virtual column in new_vcol_info.
      
      dict_index_t::add_drop_v_col(): Add the newly added virtual
      column in new_vcol_info.
      
      dict_table_t::has_lock_for_other_trx(): Whether the table has
      any other transaction lock than given transaction.
      
      row_merge_drop_indexes(): Add parameter alter_trx and check
      whether the table has any other lock than alter transaction.
      cf2c6b7f
    • Marko Mäkelä's avatar
      MDEV-18802 Assertion table->stat_initialized failed in dict_stats_update_if_needed() · ea2d44d0
      Marko Mäkelä authored
      When a table has been evicted from dict_sys and reloaded internally by
      InnoDB for FOREIGN KEY processing, statistics may not be initialized,
      but nevertheless row_update_cascade_for_mysql() could invoke
      dict_stats_update_if_needed(). In that case, we cannot really update
      the statistics. For tables that have STATS_PERSISTENT=1 and
      STATS_AUTO_RECALC=1, ANALYZE TABLE might have to be executed later.
      
      dict_stats_update_if_needed(): Replace the assertion with
      a conditional early return.
      ea2d44d0
    • Marko Mäkelä's avatar
      MDEV-24434 Assertion trx->in_rw_trx_list... in trx_sys_any_active_transactions() · 75dd7a04
      Marko Mäkelä authored
      trx_sys_any_active_transactions(): Remove a bogus debug assertion.
      In trx_commit_in_memory() and trx_erase_lists(), we will remove
      the transaction from trx_sys->rw_trx_list and set the state to
      TRX_STATE_COMMITTED_IN_MEMORY.
      75dd7a04
    • Otto Kekäläinen's avatar
      Deb: Stop depending on empty transitional package dh-systemd · 058d93d4
      Otto Kekäläinen authored
      MariaDB Server still supports Ubuntu 16.04 "Xenial" until it goes EOL
      in April 30, 2021. Thus we need to include a customization for backwards
      compatibility.
      
      This change is intended to be applied for all MariaDB versions still
      supported, i.e. 10.2 to 10.6.
      058d93d4