1. 25 Mar, 2005 1 commit
    • unknown's avatar
      WWe now store the catalog in Query_log_event in binlog WITHOUT its end zero. · 26303a09
      unknown authored
      This saves one byte per Query_log_event on disk compared to 5.0.[0..3]. Compatibility problems with 5.0.x where x<4
      are explained in the comments in log_event.cc. Putting back s/my_open(O_TRUNC)/(my_delete+my_create) change which had
      been wiped away by somebody doing a wrong 4.1->5.0 merge (which happened just
      before 5.0.3 :( ). Applying it to new events for LOAD DATA INFILE.
      If slave fails in Execute_load_query_log_event::exec_event(),
      don't delete the file (so that it's re-usable at next START SLAVE).
      And (youpi!) fix for BUG#3247 "a partially completed LOAD DATA INFILE is not
      executed at all on the slave" (storing an Execute_load_query_log_event
      to binlog, with its error code, instead of Delete_file_log_event).
      
      
      mysql-test/r/mix_innodb_myisam_binlog.result:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/r/rpl_change_master.result:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/r/rpl_deadlock.result:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/r/rpl_error_ignored_table.result:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/r/rpl_flush_log_loop.result:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/r/rpl_loaddata.result:
        we now use one less byte when storing the catalog in binlog so positions change.
        Plus testing replication of LOAD DATA INFILE if duplicate key and non-transactional table.
      mysql-test/r/rpl_log.result:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/r/rpl_max_relay_size.result:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/r/rpl_relayrotate.result:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/r/rpl_replicate_do.result:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/r/rpl_rotate_logs.result:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/r/rpl_until.result:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/t/mysqlbinlog.test:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/t/mysqlbinlog2.test:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/t/rpl_deadlock.test:
        we now use one less byte when storing the catalog in binlog so positions change
      mysql-test/t/rpl_loaddata.test:
        we now use one less byte when storing the catalog in binlog so positions change.
        Plus testing replication of LOAD DATA INFILE if duplicate key and non-transactional table.
      mysql-test/t/rpl_until.test:
        we now use one less byte when storing the catalog in binlog so positions change
      sql/log_event.cc:
        a) We now store the catalog in Query_log_event in binlog WITHOUT its end zero.
        This saves one byte per Query_log_event on disk. Compatibility problems with 5.0.x where x<4
        are explained in the comments in this file.
        b) putting back s/my_open(O_TRUNC)/(my_delete+my_create) change which had
        been wiped away by somebody doing a wrong 4.1->5.0 merge (which happened just
        before 5.0.3 :( ). Applying it to new events for LOAD DATA INFILE.
        c) if slave fails in Execute_load_query_log_event::exec_event(),
        don't delete the file (so that it's re-usable at next START SLAVE).
      sql/log_event.h:
        We now store the catalog in Query_log_event in binlog WITHOUT its end zero.
        This saves one byte per Query_log_event on disk. This new storage for
        the catalog is denoted by Q_CATALOG_NZ_CODE (couldn't re-use Q_CATALOG_CODE
        as 5.0.3 slaves of this 5.0.4 master would segfault because it would
        expect a 0 when there is none.
        Renaming get_open_mode() to get_create_or_append() (see log_event.cc)
      sql/sql_load.cc:
        Fix for BUG#3247: if LOAD DATA INFILE fails but has permanently updated a table
        (i.e. has deleted/added/modified some rows in a non-transactional table),
        we must write an Execute_load_query_log_event to binlog (with the error code,
        as this class beautifully inherits from Query_log_event, it can store
        the error code - thanks Dmitri) and not a Delete_file_log_event (we use
        to write a Delete_file_log_event: no update happened on slave, bug).
      26303a09
  2. 24 Mar, 2005 10 commits
  3. 23 Mar, 2005 22 commits
    • unknown's avatar
      Add the test case for Bug#8722 "prepared statement with view crashes · b8982922
      unknown authored
      server" to the test suite, the bug is no longer repeatable.
      
      
      tests/mysql_client_test.c:
        The test case for Bug#8722 "prepared statement with view crashes server"
      b8982922
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 89c069dc
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-5.0
      
      89c069dc
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 2db56654
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      2db56654
    • unknown's avatar
      Fix a valgrind warning spotted while trying to repeat Bug#7166 · 9dee5712
      unknown authored
      "Server crashes when running out of connections"
      
      
      sql/sql_class.cc:
        thd->query_id is compared with thd->warn_id in push_warning, 
        THD::THD seems to be the best place to fix it.
      9dee5712
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · aa0970c2
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-5.0
      
      
      sql/ha_innodb.cc:
        Auto merged
      aa0970c2
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com://home/bk/mysql-4.1 · e289fa2e
      unknown authored
      into quadita2.mysql.com:/nfstmp1/guilhem/mysql-4.1-4ita
      
      e289fa2e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · f5c5ca74
      unknown authored
      into mysql.com:/media/sda1/mysql/mysql-5.0-6282
      
      f5c5ca74
    • unknown's avatar
      A test case for Bug#6282 "Packet error with SELECT INTO" · 8ef1c864
      unknown authored
      (the bug itself is no longer repeatable).
      
      
      mysql-test/r/variables.result:
        Results fixed (Bug#6282)
      mysql-test/t/variables.test:
        A test case for Bug#6282 "Packet error with SELECT INTO"
      8ef1c864
    • unknown's avatar
      "After Monty's review" changes to the fix for BUG#8325 "Deadlock in... · 832800cc
      unknown authored
      "After Monty's review" changes to the fix for BUG#8325 "Deadlock in replication thread stops replication":
      s/sleep/safe_sleep (thread safe); sleep 0/1/2/3/4/5/5/5 (get slave less late);
      no message on error log (deadlock is too common sometimes), a global counter
      instead (SHOW STATUS LIKE 'slave_retried_transactions').
      Plus a fix for libmysql/Makefile.shared
      
      
      libmysql/Makefile.shared:
        When we "make clean" in libmysql/ we remove the symlinks there, so we
        need to mark that they have to be recreated later: this is done by removing
        ../linked_libmysql_sources. If we don't do this, 'make' will fail after 'cd libmysql;make clean'.
        This Makefile.shared is used by libmysql_r too.
        No reason to remove linked_client_sources as we don't remove the links in client/.
      mysql-test/r/rpl_deadlock.result:
        result fix
      mysql-test/t/rpl_deadlock.test:
        small test addition
      sql/mysqld.cc:
        if active_mi could not be alloced, die. New SHOW STATUS LIKE "slave_retried_transactions".
      sql/slave.cc:
        If slave retries automatically a transaction, no message on error log
        (too common situation); sleep 0 secs at first retry, then 1, 2, 3, 4,
        5, 5, 5... Sleeping 0 is to get the least possible late, as deadlocks
        are usually resolved at first try. New global counter rli->retried_trans
        (for SHOW STATUS: total number of times the slave had to retry
        any transaction). safe_sleep() is thread-safe, sleep() was not.
        I change the rli->trans_retries counter to go from 0 to max instead
        of the other way (better for new sleep()).
      sql/slave.h:
        new global counter rli->retried_trans
      sql/sql_show.cc:
        SHOW STATUS LIKE "slave_retried_transactions"; needs replication mutexes.
        Can't be a simple SHOW_LONG, because active_mi is unset (not alloced yet)
        when the static global status_vars is created (active_mi is set
        in init_slave()).
      sql/structs.h:
        new SHOW_SLAVE_RETRIED_TRANS
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      832800cc
    • unknown's avatar
      sql/sql_acl.cc · 83df531d
      unknown authored
          report correct errror in MODE_NO_AUTO_CREATE_USER
          cleanup
      after merge fixes
      
      
      mysql-test/r/grant2.result:
        updated after merge
      mysql-test/r/grant3.result:
        updated after merge
      mysql-test/r/rpl_temporary.result:
        sqlstate fixed
      mysql-test/t/grant2.test:
        updated after merge
      mysql-test/t/grant3.test:
        updated after merge
      sql/share/errmsg.txt:
        sqlstate fixed
      sql/sql_acl.cc:
        report correct errror in MODE_NO_AUTO_CREATE_USER
        cleanup
      83df531d
    • unknown's avatar
      Merge paul@bk-internal.mysql.com:/home/bk/mysql-5.0 · 751f8802
      unknown authored
      into kite-hub.kitebird.com:/src/extern/MySQL/bk/mysql-5.0
      
      751f8802
    • unknown's avatar
      Merge kite-hub.kitebird.com:/src/extern/MySQL/bk/mysql-4.1 · eba178e9
      unknown authored
      into kite-hub.kitebird.com:/src/extern/MySQL/bk/merge-5.0
      
      eba178e9
    • unknown's avatar
      README: · 355cd2eb
      unknown authored
        Fix typo.
      
      
      mysql-test/README:
        Fix typo.
      355cd2eb
    • unknown's avatar
      ha_innodb.cc: · 466aef73
      unknown authored
        Fix bug #9314 in InnoDB true VARCHAR: InnoDB stored the 'position' of a row wrong in a column prefix primary key index; this could cause MySQL to complain 'ERROR 1032: Can't find record in ...' in an update of the primary key, and also some ORDER BY or DISTINCT queries
      
      
      sql/ha_innodb.cc:
        Fix bug #9314 in InnoDB true VARCHAR: InnoDB stored the 'position' of a row wrong in a column prefix primary key index; this could cause MySQL to complain 'ERROR 1032: Can't find record in ...' in an update of the primary key, and also some ORDER BY or DISTINCT queries
      466aef73
    • unknown's avatar
      A fix (bug #9309: Wrong order in INFORMATION_SCHEMA) · 4775c93a
      unknown authored
      
      
      strings/ctype-utf8.c:
        A fix (bug #9309: Wrong order in INFORMATION_SCHEMA)
        We should clear the last byte, not the next one.
      4775c93a
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1 · ad2cd3fa
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      mysql-test/r/warnings.result:
        Auto merged
      mysql-test/t/warnings.test:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      ad2cd3fa
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0 · 38504d42
      unknown authored
      into mysql.com:/usr/local/home/marty/MySQL/mysql-5.0
      
      
      mysql-test/mysql-test-run.sh:
        Auto merged
      38504d42
    • unknown's avatar
      added symbols mysql_server_init and mysql_server_end to allow windows · b88c15e9
      unknown authored
      applications with embedded server to connect to external servers too.
      (required for Connector/OO.org)
      
      b88c15e9
    • unknown's avatar
      merged · 0caa1f59
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      mysql-test/r/information_schema.result:
        Auto merged
      mysql-test/r/ndb_autodiscover.result:
        Auto merged
      mysql-test/r/ps_1general.result:
        Auto merged
      mysql-test/r/show_check.result:
        Auto merged
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      scripts/fill_func_tables.sh:
        Auto merged
      scripts/mysql_create_system_tables.sh:
        Auto merged
      scripts/mysql_fix_privilege_tables.sh:
        Auto merged
      scripts/mysql_fix_privilege_tables.sql:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_sum.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      0caa1f59
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 77426844
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      77426844
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 90f3e8ac
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-5.0
      
      90f3e8ac
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-5.0-5036 · 4b2a25f4
      unknown authored
      into mysql.com:/home/jimw/my/mysql-5.0-clean
      
      
      mysql-test/mysql-test-run.sh:
        Auto merged
      4b2a25f4
  4. 22 Mar, 2005 7 commits
    • unknown's avatar
      Merged · a52b6226
      unknown authored
      
      mysql-test/mysql-test-run.sh:
        Auto merged
      sql/ha_ndbcluster.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      a52b6226
    • unknown's avatar
      Simplified rounding up to nearest 64-bit boundry · cca588fa
      unknown authored
      cca588fa
    • unknown's avatar
      Merge mysql.com:/data0/mysqldev/my/mysql-5.0-build · 02089d0c
      unknown authored
      into mysql.com:/data0/mysqldev/jimw/mysql-5.0-build
      
      02089d0c
    • unknown's avatar
      Hack to ensure that CHAR's created in 5.0 are not converted to VARCHAR even if · 94056a48
      unknown authored
      the row type is dynamic (For 4.1 tables old 'VARCHAR' fields are converted to
      true VARCHAR in the next ALTER TABLE)
            
      This ensures that one can use MySQL 5.0 privilege tables with MySQL 4.1.
      
      (Fix imported from main 5.0 tree to 5.0.3 build tree.)
      
      
      mysql-test/r/information_schema.result:
        Update results (for .frm version number change)
      mysql-test/r/ndb_autodiscover.result:
        Update results (for .frm version number change)
      mysql-test/r/ps_1general.result:
        Update results (for .frm version number change)
      mysql-test/r/show_check.result:
        Update results (for .frm version number change)
      mysql-test/r/view.result:
        Update results (for .frm version number change)
      scripts/fill_func_tables.sh:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      scripts/mysql_create_system_tables.sh:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      sql/sql_table.cc:
        Only set create_info->varchar if we are using the new VARCHAR field
      scripts/mysql_fix_privilege_tables.sh:
        Fixed bug that made it impossible to run the script from the mysql source dist
      scripts/mysql_fix_privilege_tables.sql:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      sql/table.cc:
        Hack to ensure that CHAR's created in 5.0 are not converted to VARCHAR even if
        the row type is dynamic (For 4.1 tables old 'VARCHAR' fields are converted to
        true VARCHAR in the next ALTER TABLE)
      94056a48
    • unknown's avatar
      Merge mysql.com:/data0/mysqldev/my/mysql-5.0-build · c0570800
      unknown authored
      into mysql.com:/data0/mysqldev/serg/m50b
      
      c0570800
    • unknown's avatar
      BUG#9339 - Updating a column does not work if the table has a UTF-8 VARCHAR primary key · 3ff090eb
      unknown authored
      fixed my_charpos() call in Field_varstring::get_key_image
      
      
      mysql-test/t/type_varchar.test:
        BUG#9339 - Updating a column does not work if the table has a UTF-8 VARCHAR primary key
      mysql-test/r/type_varchar.result:
        BUG#9339 - Updating a column does not work if the table has a UTF-8 VARCHAR primary key
      3ff090eb
    • unknown's avatar
      Merge mysql.com:/data0/mysqldev/my/mysql-5.0-build · d3563bc3
      unknown authored
      into mysql.com:/data0/mysqldev/jimw/mysql-5.0-build
      
      d3563bc3