1. 21 Apr, 2010 1 commit
  2. 20 Apr, 2010 2 commits
    • Mats Kindahl's avatar
      WL#5030: Splitting mysql_priv.h · f96694f9
      Mats Kindahl authored
      Removing traces of mysql_priv.h from comments and other
      non-source files that were missed before.
      f96694f9
    • Alfranio Correia's avatar
      BUG#51894 Replication failure with SBR on DROP TEMPORARY TABLE inside a · 9ba731c2
      Alfranio Correia authored
                transaction
      BUG#52616 Temp table prevents switch binlog format from STATEMENT to ROW
      
      Before the WL#2687 and BUG#46364, every non-transactional change that happened
      after a transactional change was written to trx-cache and flushed upon
      committing the transaction. WL#2687 and BUG#46364 changed this behavior and
      non-transactional changes are now written to the binary log upon committing
      the statement.
      
      A binary log event is identified as transactional or non-transactional through
      a flag in the Log_event which is set taking into account the underlie storage
      engine on what it is stems from. In the current bug, this flag was not being
      set properly when the DROP TEMPORARY TABLE was executed.
      
      However, while fixing this bug we figured out that changes to temporary tables
      should be always written to the trx-cache if there is an on-going transaction.
      Otherwise, binlog events in the reversed order would be produced.
      
      Regarding concurrency, keeping changes to temporary tables in the trx-cache is
      also safe as temporary tables are only visible to the owner connection.
      
      In this patch, we classify the following statements as unsafe:
         1 - INSERT INTO t_myisam SELECT * FROM t_myisam_temp
      
         2 - INSERT INTO t_myisam_temp SELECT * FROM t_myisam
      
         3 - CREATE TEMPORARY TABLE t_myisam_temp SELECT * FROM t_myisam
      
      On the other hand, the following statements are classified as safe:
      
         1 - INSERT INTO t_innodb SELECT * FROM t_myisam_temp
      
         2 - INSERT INTO t_myisam_temp SELECT * FROM t_innodb
      
      The patch also guarantees that transactions that have a DROP TEMPORARY are
      always written to the binary log regardless of the mode and the outcome:
      commit or rollback. In particular, the DROP TEMPORARY is extended with the
      IF EXISTS clause when the current statement logging format is set to row.
      
      Finally, the patch allows to switch from STATEMENT to MIXED/ROW when there
      are temporary tables but the contrary is not possible.
      9ba731c2
  3. 19 Apr, 2010 4 commits
  4. 18 Apr, 2010 1 commit
  5. 16 Apr, 2010 1 commit
  6. 15 Apr, 2010 6 commits
  7. 14 Apr, 2010 1 commit
  8. 13 Apr, 2010 8 commits
    • Konstantin Osipov's avatar
      A fix for Bug#11918 "SP does not accept variables in LIMIT clause" · b8d014b8
      Konstantin Osipov authored
      Allow stored procedure variables in LIMIT clause.
      Only allow variables of INTEGER types. 
      Handle negative values by means of an implicit cast to UNSIGNED 
      (similarly to prepared statement placeholders).
      Add tests.
      Make sure replication works by not doing NAME_CONST substitution
      for variables in LIMIT clause.
      Add replication tests.
      b8d014b8
    • Vladislav Vaintroub's avatar
      merge · 03b1cdd0
      Vladislav Vaintroub authored
      03b1cdd0
    • Alexander Nozdrin's avatar
      Post-fix for Bug#13174. · fad9478e
      Alexander Nozdrin authored
      fad9478e
    • Vladislav Vaintroub's avatar
      merge · babfd0e7
      Vladislav Vaintroub authored
      babfd0e7
    • Konstantin Osipov's avatar
      Backport of: · 53fecff1
      Konstantin Osipov authored
      ChangeSet@1.2703, 2007-12-07 09:35:28-05:00, cmiller@zippy.cornsilk.net +40 -0
      Bug#13174: SHA2 function
      Patch contributed from Bill Karwin, paper unnumbered CLA in Seattle
      
      Implement SHA2 functions.
      
      Chad added code to make it work with YaSSL.  Also, he removed the 
      (probable) bug of embedded server never using SSL-dependent 
      functions.  (libmysqld/Makefile.am didn't read ANY autoconf defs.)
      
      Function specification:
        SHA2( string cleartext, integer hash_length ) 
          -> string hash, or NULL
      where hash_length is one of 224, 256, 384, or 512.  If either is 
      NULL or a length is unsupported, then the result is NULL.  The 
      resulting string is always the length of the hash_length parameter
      or is NULL.
      
      Include the canonical hash examples from the NIST in the test
      results.
      ---
      Polish and address concerns of reviewers.
      53fecff1
    • Vladislav Vaintroub's avatar
      merge · 23359f7f
      Vladislav Vaintroub authored
      23359f7f
    • Vladislav Vaintroub's avatar
      Fix perfschema unittests build on Windows · 04b601a7
      Vladislav Vaintroub authored
      pthread_t is not defined unless my_pthread.h is included.
      04b601a7
    • oystein.grovlen@sun.com's avatar
      Bug#51980 mysqld service crashes with a simple COUNT(DISTINCT) query over a view · 5af5bb2d
      oystein.grovlen@sun.com authored
      Problem: Segmentation fault in add_group_and_distinct_keys() when accessing
      field of what is assumed to be an Item_field object.
      
      Cause: In case of views, the item added to list by is_indexed_agg_distinct() 
      was not of type Item_field, but Item_ref.
      
      Resolution:  Add the real Item_field object, the one referred to by 
      Item_ref object, to the list, instead.
      5af5bb2d
  9. 12 Apr, 2010 4 commits
  10. 11 Apr, 2010 3 commits
  11. 10 Apr, 2010 3 commits
  12. 07 Apr, 2010 2 commits
    • Mats Kindahl's avatar
      WL#5030: Splitting mysql_priv.h · 0768deeb
      Mats Kindahl authored
      Adding my_global.h first in all files using
      NO_EMBEDDED_ACCESS_CHECKS.
      
      Correcting a merge problem resulting from a changed definition
      of check_some_access compared to the original patches.
      0768deeb
    • Alexey Kopytov's avatar
      Bug #52165: Assertion failed: file .\dtoa.c, line 465 · 5a274915
      Alexey Kopytov authored
      The failing assertion was written with the assumption that a NULL
      string can never be passed to my_strtod(). However, an empty string
      may be passed under some circumstances by passing str == NULL and
      *end == NULL.
      
      Fixed the assertion to take the above case into account.
      5a274915
  13. 06 Apr, 2010 4 commits