1. 09 May, 2008 3 commits
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug35997/my51-bug35997 · 27c2e740
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-bugteam
      
      27c2e740
    • unknown's avatar
      Bug#35997 Event scheduler seems to let the server crash, if it is embedded. · a2ff146f
      unknown authored
      The event scheduler was not designed to work in embedded mode. This
      patch disables and excludes the event scheduler when the server is
      compiled for embedded build.
      
      
      libmysqld/Makefile.am:
        Reduce the amount of event code in an embedded build.
      mysql-test/t/events_trans.test:
        Disable test if run in embedded mode.
      sql/Makefile.am:
        Introduce definition HAVE_EVENT_SCHEDULER and one new source file.
      sql/event_data_objects.cc:
        Refactor Event_parse_data to new file.
      sql/event_data_objects.h:
        Refactor Event_parse_data to new file.
        Move global definitions to new file.
      sql/event_queue.cc:
        Move all parsed items to Event_parse_data for easier modularization.
      sql/events.cc:
        Move all parsed items to Event_parse_data for easier modularization.
      sql/mysqld.cc:
        Disable the event schedular subsystem if the server is compiled in
        embedded mode.
      sql/set_var.cc:
        Disable the event schedular subsystem if the server is compiled in
        embedded mode.
      sql/set_var.h:
        Disable the event schedular subsystem if the server is compiled in
        embedded mode.
      sql/sql_db.cc:
        Disable the event schedular subsystem if the server is compiled in
        embedded mode.
      sql/sql_parse.cc:
        Disable the event schedular subsystem if the server is compiled in
        embedded mode.
      sql/sql_show.cc:
        Disable the event schedular subsystem if the server is compiled in
        embedded mode.
      sql/sql_test.cc:
        Disable the event schedular subsystem if the server is compiled in
        embedded mode.
      sql/sql_yacc.yy:
        Only include event-code needed for parsing to reduce impact on embedded
        build.
        Move all constants to Event_parse_data class.
      mysql-test/r/events_embedded.result:
        Add test case to make sure the 'event_scheduler' can't be activated
        in embedded mode.
      mysql-test/r/is_embedded.require:
        Add test case to make sure the 'event_scheduler' can't be activated
        in embedded mode.
      mysql-test/t/events_embedded.test:
        Add test case to make sure the 'event_scheduler' can't be activated
        in embedded mode.
      sql/event_parse_data.cc:
        New file. Extracted Event_parse data into a new file.
      sql/event_parse_data.h:
        New file. Extracted Event_parse data into a new file.
      a2ff146f
    • unknown's avatar
      Bug #34297: MySQL Server crashes when processing large table · 2d4619f4
      unknown authored
      Remove optimizations on innobase/mem/* to avoid apparent compiler bug which
      causes memory overruns.  See also bug 19424, and probably bug 36366.
      
      This is done in 5.1+; 5.0 already has this workaround in place.
      
      
      storage/innobase/CMakeLists.txt:
        Remove optimizations on innobase/mem/* to avoid apparent compiler bug which
        causes memory overruns.  See bug 34297, bug 19424, and probably bug 36366.
      2d4619f4
  2. 08 May, 2008 4 commits
    • unknown's avatar
      Bug#32575: Parse error of stmt with extended comments on slave side · c1c69d52
      unknown authored
      test change for 5.1+ (show create view adds two columns in 5.1)
      
      Patch only for 5.1+
      
      
      mysql-test/suite/rpl/r/rpl_sp.result:
        restored the original 5.1 test result
      mysql-test/suite/rpl/r/rpl_view.result:
        Bug#32575: Parse error of stmt with extended comments on slave side
        
        Updated test result for show create view in 5.0 to 5.1
      c1c69d52
    • unknown's avatar
      Merge client-10-129-10-147.upp.off.mysql.com:/Users/mattiasj/clones/topush-50-bugteam · 7d247133
      unknown authored
      into  client-10-129-10-147.upp.off.mysql.com:/Users/mattiasj/clones/topush-51-bugteam
      
      
      mysql-test/suite/rpl/r/rpl_sp.result:
        Auto merged
      mysql-test/suite/rpl/t/rpl_view.test:
        Auto merged
      sql/sql_view.cc:
        This was already fixed in 5.1
      mysql-test/suite/rpl/r/rpl_view.result:
        manual merge
      7d247133
    • unknown's avatar
      Merge client-10-129-10-147.upp.off.mysql.com:/Users/mattiasj/clones/bug32575-50-bugteam · e764865d
      unknown authored
      into  client-10-129-10-147.upp.off.mysql.com:/Users/mattiasj/clones/topush-50-bugteam
      
      e764865d
    • unknown's avatar
      Bug#32575 - Parse error of stmt with extended comments on slave side · 61c3310f
      unknown authored
      Problem was that mysql_create_view did not remove all comments characters
      when writing to binlog, resulting in parse error of stmt on slave side.
      
      Solution was to use the recreated select clause
      and add a generated CHECK OPTION clause if needed.
      
      
      mysql-test/r/rpl_sp.result:
        Bug#32575 - Parse error of stmt with extended comments on slave side
        
        Updated test result
      mysql-test/r/rpl_view.result:
        Bug#32575 - Parse error of stmt with extended comments on slave side
        
        Updated test result
      mysql-test/t/rpl_view.test:
        Bug#32575 - Parse error of stmt with extended comments on slave side
        
        Added test case
      sql/sql_view.cc:
        Bug#32575 - Parse error of stmt with extended comments on slave side
        
        Problem was that mysql_create_view did not remove all comments characters
        when writing to binlog, resulting in parse error of stmt on slave side.
        
        Solution was to use the recreated select clause and generate
        'WITH {LOCAL|CASCADED} CHECK OPTION'.
      61c3310f
  3. 07 May, 2008 6 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 820cf2d8
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-bugteam
      
      820cf2d8
    • unknown's avatar
      Merge riska.(none):/home/sven/bk/b36379-enable_test/gca · cadc574b
      unknown authored
      into  riska.(none):/home/sven/bkroot/5.1-bugteam
      
      
      mysql-test/suite/rpl/t/disabled.def:
        Auto merged
      cadc574b
    • unknown's avatar
      BUG#36398: 'DROP TEMPORARY TABLE' in ROLLBACK transaction causes transaction to be logged · e94ff35a
      unknown authored
      Temporarily checking in an incorrect test case. Rationale: the impact of
      this bug is negligible (it's almost a feature request). We need 5.1 to be
      stable, and making a real fix is a bit risky. So the fix is postponed
      to 6.0.
      
      
      mysql-test/suite/rpl/r/rpl_ddl.result:
        Updated result file.
      mysql-test/suite/rpl/t/disabled.def:
        Enabling test case rpl_ddl.test
      e94ff35a
    • unknown's avatar
      BUG#36379: please re-enable rpl_innodb_bug28430 · 68310db1
      unknown authored
      The test suite/rpl/t/rpl_innodb_bug28430.test was disabled because of
      BUG#32247, but not re-enabled when BUG#32247 was fixed. I've re-enabled
      it. The test and result file needed to be updated too.
      
      
      mysql-test/suite/rpl/r/rpl_innodb_bug28430.result:
        Updated result file.
      mysql-test/suite/rpl/t/disabled.def:
        Enabled the rpl_innodb_bug28430 test case.
      mysql-test/suite/rpl/t/rpl_innodb_bug28430.test:
        show slave status is not needed since we have select count(*)
      68310db1
    • unknown's avatar
      BUG#35850 "Performance regression in 5.1.23/5.1.24" · 4279dd85
      unknown authored
      - Disable the "prefer full scan on clustered primary key over full scan
        of any secondary key" rule introduced by BUG#35850.
      - Update test results accordingly 
      (bk trigger: file this for BUG#35850)
      
      
      mysql-test/r/innodb.result:
        BUG#35850 "Performance regression in 5.1.23/5.1.24"
        - Update test results
      mysql-test/r/innodb_mysql.result:
        BUG#35850 "Performance regression in 5.1.23/5.1.24"
        - Testcase
        - Update test results
      mysql-test/r/join_outer_innodb.result:
        BUG#35850 "Performance regression in 5.1.23/5.1.24"
        - Update test results
      mysql-test/t/innodb_mysql.test:
        BUG#35850 "Performance regression in 5.1.23/5.1.24"
        - Testcase
      sql/sql_select.cc:
        BUG#35850 "Performance regression in 5.1.23/5.1.24"
        - Disable the "prefer full scan on clustered primary key over full scan
          of any secondary key" rule introduced by BUG#35850.
      4279dd85
    • unknown's avatar
      Re-enable test case thread_cache_size_func as Bug 35988 · d8c89d37
      unknown authored
      has been fixed and closed.
      
      
      mysql-test/t/disabled.def:
        Re-enable test case as bug has been fixed.
      d8c89d37
  4. 06 May, 2008 10 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · f3e218ed
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-bugteam
      
      f3e218ed
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/bugs/34108-5.1 · bc90d984
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-bugteam
      
      bc90d984
    • unknown's avatar
      Bug#34108 "Drop function" (test "storedproc_06") returns different message (all handlers) · e90cb329
      unknown authored
      The problem is that the patch for Bug 33464 didn't update the
      results of the test cases which caused the problem.
      
      Dropping a stored routine also revoke privileges for all users
      on the stored routine and errors about missing grants are converted
      into warnings. Before Bug 33464 such errors could be incorrectly
      returned to the user, which would later trigger a assertion due to
      multiple errors being set.
      
      
      mysql-test/suite/funcs_1/r/innodb_storedproc_06.result:
        Update test case result, grants were already dropped.
      mysql-test/suite/funcs_1/r/memory_storedproc_06.result:
        Update test case result, grants were already dropped.
      mysql-test/suite/funcs_1/r/myisam_storedproc_06.result:
        Update test case result, grants were already dropped.
      mysql-test/suite/funcs_1/r/ndb_storedproc_06.result:
        Update test case result, grants were already dropped.
      mysql-test/suite/funcs_1/storedproc/storedproc_06.inc:
        Add comment regarding bug revealed by test case.
      mysql-test/suite/funcs_1/t/disabled.def:
        Re-enable test cases, bug has been fixed.
      e90cb329
    • unknown's avatar
      Merge kpettersson@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 46df6d92
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-bugteam
      
      46df6d92
    • unknown's avatar
      Adjusted a filaing test and re-enabled it. · 70540c8c
      unknown authored
      
      mysql-test/r/query_cache_wlock_invalidate_func.result:
        Adjusted test. Query cache doesn't support multiple statements and thus
        using a delimiter change won't work.
      mysql-test/t/disabled.def:
        Enabled the query_cache_wlock_invalidate_func test.
      mysql-test/t/query_cache_wlock_invalidate_func.test:
        Adjusted test. Query cache doesn't support multiple statements and thus
        using a delimiter change won't work.
      70540c8c
    • unknown's avatar
      Silence warning due to copying the address of a string constant · 2a2e2b5f
      unknown authored
      into a non-const string pointer.
      
      
      client/mysqltest.c:
        Don't use a constant string as val may be modified later.
      2a2e2b5f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 11b3e428
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-bugteam
      
      11b3e428
    • unknown's avatar
      Merge noir.wlan.koehntopp.de:/misc/mysql/mysql-5.0-bugteam · d15b1fbd
      unknown authored
      into  noir.wlan.koehntopp.de:/misc/mysql/mysql-5.1-bugteam
      
      
      mysys/my_static.c:
        Auto merged
      mysys/my_static.h:
        Auto merged
      d15b1fbd
    • unknown's avatar
      revert the push of bug 35616. · 2da382de
      unknown authored
      2da382de
    • unknown's avatar
      Bug#35616: memory overrun on 64-bit linux on setting large values for keybuffer-size · 496de028
      unknown authored
      We could allocate chunks larger than 4GB, but did our size-accounting in 32-bit
      values. This could lead to spurious warnings, inaccurate accounting, and, in
      theory, data loss.
      
      Affected: 64-bit platforms. Debug-build (with safemalloc). At least one buffer
      larger than 4GB. For potential data loss, a re-alloc on such a buffer would be
      necessary.
      
      
      mysys/my_static.c:
        Make memory-accounting 64-bit safe.
      mysys/my_static.h:
        Make memory-accounting 64-bit safe.
        Move in struct for better alignment when 64-bit.
      496de028
  5. 05 May, 2008 5 commits
  6. 02 May, 2008 8 commits
  7. 01 May, 2008 4 commits