1. 09 Aug, 2019 1 commit
    • Sachin's avatar
      MDEV-17614 INSERT on dup key update is replication unsafe · 284c72ea
      Sachin authored
      Problem:-
      When mysql executes INSERT ON DUPLICATE KEY INSERT, the storage engine checks
      if the inserted row would generate a duplicate key error. If yes, it returns
      the existing row to mysql, mysql updates it and sends it back to the storage
      engine.When the table has more than one unique or primary key, this statement
      is sensitive to the order in which the storage engines checks the keys.
      Depending on this order, the storage engine may determine different rows
      to mysql, and hence mysql can update different rows.The order that the
      storage engine checks keys is not deterministic. For example, InnoDB checks
      keys in an order that depends on the order in which indexes were added to
      the table. The first added index is checked first. So if master and slave
      have added indexes in different orders, then slave may go out of sync.
      
      Solution:-
      Make INSERT...ON DUPLICATE KEY UPDATE unsafe while using stmt or mixed format
      When there is more then one unique key.
      Although there is two exception.
        1. Auto Increment key is not counted because Innodb will get gap lock for
          failed Insert and concurrent insert will get a next increment value. But if
          user supplies auto inc value it can be unsafe.
        2. Count only unique keys for which insertion is performed.
      
      So this patch also addresses the bug id #72921
      284c72ea
  2. 07 Aug, 2019 1 commit
  3. 05 Aug, 2019 1 commit
    • Sujatha's avatar
      MDEV-18930: Failed CREATE OR REPLACE TEMPORARY not written into binary log... · eef75404
      Sujatha authored
      MDEV-18930: Failed CREATE OR REPLACE TEMPORARY not written into binary log makes data on master and slave diverge
      
      Problem:
      =======
      Failed CREATE OR REPLACE TEMPORARY TABLE statement which dropped the table but
      failed at a later stage of creation of temporary table is not written to
      binarylog in row based replication. This causes the slave to diverge.
      
      Analysis:
      ========
      CREATE OR REPLACE statements work as shown below.
      
      CREATE OR REPLACE TABLE table_name (a int);
      is basically the same as:
      
      DROP TABLE IF EXISTS table_name;
      CREATE TABLE table_name (a int);
      
      Hence every CREATE OR REPLACE TABLE command which dropped the table should be
      written to binary log, even when following CREATE TABLE part fails. In order
      to achieve this, during the execution of CREATE OR REPLACE command, when a
      table is dropped 'thd->log_current_statement' flag is set. When table creation
      results in an error within 'mysql_create_table' code, the error handling part
      looks for this flag. If it is set the failed CREATE OR REPLACE statement is
      written into the binary log inspite of error. This ensure that slave doesn't
      diverge from the master. In case of row based replication the error handling
      code returns very early, if the table is of type temporary. This is done based
      on the assumption that temporary tables are not replicated in row based
      replication.
      
      It fails to handle the cases where a temporary table was created as part of
      statement based replication at an earlier stage and the binary log format was
      changed to row because of an unsafe statement. In this case when a CREATE OR
      REPLACE statement is executed on this temporary table it will dropped but the
      query will not be written to binary log. Hence slave diverges.
      
      Fix:
      ===
      In error handling code check the return status of create table operation. If
      it is successful and replication mode is row based and table is of type
      temporary then return. Other wise proceed further to the code which checks for
      thd->log_current_statement flag and does appropriate logging.
      eef75404
  4. 01 Aug, 2019 1 commit
  5. 31 Jul, 2019 2 commits
  6. 26 Jul, 2019 6 commits
  7. 25 Jul, 2019 6 commits
    • Oleksandr Byelkin's avatar
      Merge branch '5.5' into 10.1 · 584d2132
      Oleksandr Byelkin authored
      584d2132
    • Oleksandr Byelkin's avatar
    • Oleksandr Byelkin's avatar
      Merge branch '5.5' into 10.1 · ae476868
      Oleksandr Byelkin authored
      ae476868
    • Sujatha's avatar
      MDEV-20091 DROP TEMPORARY table is logged despite no CREATE was logged · 8d0dabc5
      Sujatha authored
      Fixing post push test issues.
      
      Recorded the result files for following:
      rpl_stm_drop_create_temp_table.result
      rpl_mixed_drop_create_temp_table.result.
      8d0dabc5
    • Marko Mäkelä's avatar
      Replace ut_timer() with my_interval_timer() · f6ea0389
      Marko Mäkelä authored
      The function pointer ut_timer() was only used by the
      InnoDB defragmenting thread. Let InnoDB use a single monotonic
      high-precision timer, my_interval_timer() [in nanoseconds],
      occasionally wrapped by microsecond_interval_timer().
      
      srv_defragment_interval: Change from "timer" units to nanoseconds.
      
      This concludes the InnoDB time function cleanup that was
      motivated by MDEV-14154. Only ut_time_ms() will remain for now,
      wrapping my_interval_timer().
      f6ea0389
    • Sujatha's avatar
      MDEV-20091 DROP TEMPORARY table is logged despite no CREATE was logged · e32f29b7
      Sujatha authored
      MDEV-5589 commit set up a policy to skip DROP TEMPORARY TABLE binary logging
      in case the target table has not been "CREATEed" in binlog (no CREATE
      Query-log-event was logged into the binary log).
      
      It turns out that
      
      1. the rule did not cover non-existing table DROPped with IF-EXISTS clause.
         The logged-create knowledge for the non-existing one does not even need
         MDEV-5589 patch, and
      
      2. connection close disobeys it to trigger automatic DROP-IF-EXISTS
         binlogging.
      
      Either 1 or 2 or even both is/are also responsible for unexpected binlog
      records observed in MDEV-17863, actually rendering a referred
      @@global.read_only irrelevant as far as the described stored procedure
      definition *and* the ROW binlog-format are concerned.
      e32f29b7
  8. 24 Jul, 2019 15 commits
    • Marko Mäkelä's avatar
      0c7c6101
    • Marko Mäkelä's avatar
      MDEV-14154: Failing assertion: slot->last_run <= current_time in fts0opt.cc · c663a941
      Marko Mäkelä authored
      The FTS optimizer thread made a false assumption that time(NULL)
      is monotonic. The system clock can be adjusted to the past,
      for example if the hardware clock was drifting to the future,
      and it was adjusted by NTP.
      
      fts_slot_t::interval_time: Replace with the constant
      FTS_OPTIMIZE_INTERVAL_IN_SECS.
      
      fts_slot_t::last_run, fts_slot_t::completed: Clarify the
      documentation.
      
      fts_optimize_get_time_limit(): Remove a type cast, and
      add a FIXME comment about domain mismatch.
      
      fts_optimize_compact(), fts_optimize_words(): Limit the time
      also when the current time has been moved to the past.
      
      fts_optimize_table_bk(): Check for wrap-around.
      
      fts_optimize_how_many(): Check for wrap-around, and remove the
      failing assertions.
      
      fts_is_sync_needed(): Remove a redundant call to time(NULL).
      c663a941
    • Marko Mäkelä's avatar
      Reduce the amount of time(NULL) calls for lock processing · 9e5df967
      Marko Mäkelä authored
      lock_t::requested_time: Document what the field is used for.
      
      lock_t::wait_time: Document that the field is only used for
      diagnostics and may be garbage if the system time is being adjusted.
      
      srv_slot_t::suspend_time: Document that this is duplicating
      trx_lock_t::wait_started.
      
      lock_table_print(), lock_rec_print(): Declare in static scope.
      Add a parameter for the current time.
      
      lock_deadlock_check_and_resolve(), lock_deadlock_lock_print(),
      lock_deadlock_joining_trx_print():
      Add a parameter for the current time.
      9e5df967
    • Marko Mäkelä's avatar
      MDEV-14154: Document some time_t fields better · 2b5bc761
      Marko Mäkelä authored
      srv_slot_t::suspend_time, os_aio_slot_t::reservation_time,
      sync_cell_t::reservation_time: Explain what could happen
      if the system time has is being adjusted.
      
      fts_sync_t::start_time: Document that the field is mostly unused.
      2b5bc761
    • Marko Mäkelä's avatar
      Always initialize trx_t::start_time_micro · 10727b69
      Marko Mäkelä authored
      This affects the function has_higher_priority() for internal or
      recovered transactions.
      10727b69
    • Marko Mäkelä's avatar
      Remove ut_usectime(), ut_gettimeofday() · 10ee1b95
      Marko Mäkelä authored
      Replace ut_usectime() with my_interval_timer(),
      which is equivalent, but monotonically counting nanoseconds
      instead of counting the microseconds of real time.
      
      os_event_wait_time_low(): Use my_hrtime() instead of ut_usectime().
      
      FIXME: Set a clock attribute on the condition variable that allows
      a monotonic clock to be chosen as the time base, so that the wait
      is immune to adjustments of the system clock.
      10ee1b95
    • Marko Mäkelä's avatar
      Correct the type of a parameter · e764d5bc
      Marko Mäkelä authored
      e764d5bc
    • Marko Mäkelä's avatar
      MDEV-14154: Remove ut_time_us() · ab6dd774
      Marko Mäkelä authored
      Use microsecond_interval_timer()
      or my_interval_timer() [in nanoseconds] instead.
      ab6dd774
    • Marko Mäkelä's avatar
      Remove unused ut_get_year_month_day() · 86767f4a
      Marko Mäkelä authored
      86767f4a
    • Nisha Gopalakrishnan's avatar
      BUG#28642318: POINT IN TIME RECOVERY USING MYSQLBINLOG BROKEN WITH TEMPORARY TABLE -> ERRORS · 2536c0b1
      Nisha Gopalakrishnan authored
      Analysis
      ========
      Point in time recovery using mysqlbinlog containing queries
      operating on temporary tables results in an error.
      
      While writing the query log event in the binary log, the
      thread id used for execution of DROP TABLE and DELETE commands
      were incorrect. The thread variable 'thread_specific_used'
      is used to determine whether a specific thread id is to used
      while executing the statements i.e using 'SET
      @@session.pseudo_thread_id'. This variable was not set
      correctly for DROP TABLE query and was never set for DELETE
      query. The thread id is important for temporary tables
      since the tables are session specific. DROP TABLE and DELETE
      queries executed using a wrong thread id resulted in errors
      while applying the queries generated by mysqlbinlog utility.
      
      Fix
      ===
      Set the 'thread_specific_used' THD variable for DROP TABLE and
      DELETE queries.
      
      ReviewBoard: 21833
      2536c0b1
    • Gleb Shchepa's avatar
      Bug #29419820: MEMORY LEAK IN MY_YYOVERFLOW() · 7473a71a
      Gleb Shchepa authored
      Note: this patch is for 5.6.
      
      Detected by ASAN.
      
      The patch fixes the cleanup of parser stack pointers.
      Reviewed-by: default avatarGuilhem Bichot <guilhem.bichot@oracle.com>
      7473a71a
    • Sergei Golubchik's avatar
      Bug#27167197 USING ? IN INSTALL PLUGIN QUERY ABORTS DEBUG, AND HANGS OPTIMIZED SERVER · 8ddb7e3e
      Sergei Golubchik authored
      check_valid_path() uses my_strcspn() that cannot handle invalid characters
      properly. This is fixed by a big refactoring in 10.2 (MDEV-6353).
      
      For 5.5, let's simply swap tests, because check_string_char_length()
      rejects invalid characters just fine.
      8ddb7e3e
    • Sergei Golubchik's avatar
      Bug#27302459: EMPTY VALUE IN MYSQL.PLUGIN TABLE CAUSES SERVER TO EXIT ON STARTUP · 5e8ab9b7
      Sergei Golubchik authored
      Description:- During server startup, the server exits if
      the 'mysql.plugin' system table has any rows with empty
      value for the field 'name' (plugin name).
      5e8ab9b7
    • Georgi Kodinov's avatar
      Bug #27312862: ASAN: HEAP-USE-AFTER-FREE: UPDATEXML RB#21666 RB#21666 · c5e96743
      Georgi Kodinov authored
      The xpath parsing function was using a local string buffer that was
      deallocated when going out of scope. However references to it are
      preserved in the XPATH parse tree. This was causing read-after-free.
      
      Fixed by making the xpath buffer a local variable inside the Item
      class for the relevant xpath function, thus being preserved for the
      duration of the query.
      c5e96743
    • Anushree Prakash B's avatar
      Bug#27259654 - ISSUES FOUND BY PVS-STUDIO STATIC ANALYZER · 9c6777c0
      Anushree Prakash B authored
      DESCRIPTION
      ===========
      PVS-Studio static code analyzer found several suspicious
      fragments of code across various files.
      
      i)   sizeof() is using the pointer
      ii)  memcpy() doesn't copy the whole string.
      iii) enumeration constant 'wkb_multilinestring' is used as
           a variable of a Boolean-type.
      iv) 'throw' keyword is missing from std::runtime_error()
      
      FIX
      ===
      i)   Use sizeof({actual object/data type})
      ii)  Use strncpy() and set last char as '\0'
      iii) N/A (Issue has already been fixed)
      iv)  Add 'throw' before the exception.
      
      RB: 21502
      9c6777c0
  9. 23 Jul, 2019 7 commits