1. 12 Nov, 2007 12 commits
    • unknown's avatar
      Merge mattiasj-laptop.(none):/home/mattiasj/clones/mysql-5.1-main · 2877050b
      unknown authored
      into  mattiasj-laptop.(none):/home/mattiasj/clones/mysql-5.1-last_with_main
      
      
      libmysqld/lib_sql.cc:
        Auto merged
      mysql-test/include/mix1.inc:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      sql/event_scheduler.cc:
        Auto merged
      sql/events.cc:
        Auto merged
      sql/ha_ndbcluster_binlog.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_connect.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      2877050b
    • unknown's avatar
      Merge mattiasj-laptop.(none):/home/mattiasj/clones/mysql-5.1-fixtopush · 403d8dda
      unknown authored
      into  mattiasj-laptop.(none):/home/mattiasj/clones/mysql-5.1-lastfinaltopush
      
      403d8dda
    • unknown's avatar
      Merge mattiasj-laptop.(none):/home/mattiasj/clones/mysql-5.1-bug29368 · 008ab9c5
      unknown authored
      into  mattiasj-laptop.(none):/home/mattiasj/clones/mysql-5.1-lastfinaltopush
      
      
      mysql-test/r/partition.result:
        Auto merged
      008ab9c5
    • unknown's avatar
      Merge mattiasj-laptop.(none):/home/mattiasj/clones/mysql-5.1-bug31705 · bd7cc2c0
      unknown authored
      into  mattiasj-laptop.(none):/home/mattiasj/clones/mysql-5.1-lastfinaltopush
      
      bd7cc2c0
    • unknown's avatar
      Merge mattiasj-laptop.(none):/home/mattiasj/clones/mysql-5.1-bug32091 · db59df73
      unknown authored
      into  mattiasj-laptop.(none):/home/mattiasj/clones/mysql-5.1-lastfinaltopush
      
      db59df73
    • unknown's avatar
      Bug#31705 Partitions: crash if varchar length > 65530 · a78ee776
      unknown authored
      Buffer overflow due to wrong key length in partitioning
      
      Changed to the correct key_length function.
      
      
      sql/opt_range.cc:
        Bug#31705 Partitions: crash if varchar length > 65530
        Problem: buffer overflow due to wrong key-length
        
        Fix: Using correct key_length function
      mysql-test/r/partition_datatype.result:
        Bug#31705 Partitions: crash if varchar length > 65530
        New test-result case for testing all column types
        used in key-partitioning.
        
        (For verifying correct key-length use)
      mysql-test/t/partition_datatype.test:
        Bug#31705 Partitions: crash if varchar length > 65530 
        New test case for testing all column types
        used in key-partitioning.
        
        (For verifying correct key-length used)
      a78ee776
    • unknown's avatar
      Bug#32091: Security breach via directory changes · 4737de04
      unknown authored
      Merge fix
      
      partition_mgm did not require have_symlink.
      
      Moved the test case to partition_symlink, which
      require have_symlink, and should work on both *nix and
      Windows
      
      
      mysql-test/r/partition_mgm.result:
        Bug#32091: Security breach via directory changes
        
        Moved the test case to partition_symlink.
      mysql-test/t/partition_mgm.test:
        Bug#32091: Security breach via directory changes
        
        Moved the test case to partition_symlink.
      mysql-test/r/partition_symlink.result:
        Bug#32091: Security breach via directory changes
        
        Moved the test case to partition_symlink. It requires
        have_symlink.
      mysql-test/t/partition_symlink.test:
        Bug#32091: Security breach via directory changes
        
        Moved the test case to partition_symlink. It requires
        have_symlink.
      4737de04
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG32111/mysql-5.0-engines · c80c6ccf
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG32111/mysql-5.1-engines
      
      
      mysql-test/r/symlink.result:
        Auto merged
      mysql-test/t/symlink.test:
        Auto merged
      mysys/my_symlink2.c:
        Auto merged
      c80c6ccf
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG32111/mysql-4.1-engines · 7cc910a0
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG32111/mysql-5.0-engines
      
      
      mysql-test/r/symlink.result:
        Auto merged
      mysql-test/t/symlink.test:
        Auto merged
      mysys/my_symlink2.c:
        Auto merged
      7cc910a0
    • unknown's avatar
      After merge fix. · e8e897bc
      unknown authored
      e8e897bc
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG32111/mysql-4.0 · 0f7e921a
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG32111/mysql-4.1-engines
      
      
      mysys/my_symlink2.c:
        Auto merged
      mysql-test/r/symlink.result:
        SCCS merged
      mysql-test/t/symlink.test:
        SCCS merged
      0f7e921a
    • unknown's avatar
      BUG#31611 (Security risk with BINLOG statement): · 01d72106
      unknown authored
      Adding missing drop of user created for test case.
      
      
      mysql-test/r/mysqlbinlog.result:
        Result file change.
      mysql-test/t/mysqlbinlog.test:
        Dropping user that was added earlier in the test.
      01d72106
  2. 11 Nov, 2007 2 commits
    • unknown's avatar
      Bug#30695: An apostrophe ' in the comment of the ADD PARTITION · af3c09d7
      unknown authored
          causes the Server to crash.
      
      Post-pushbuild fix
      
      Pushbuild genereted valgrind warnings.
      
      Changed function to safer variant.
      
      
      sql/sql_partition.cc:
        Bug#30695: An apostrophe ' in the comment of the ADD PARTITION
            causes the Server to crash.
        
        Fix for valgrind warning in pushbuild.
        String.c_prt fcn is not as safe as comment says.
        (gives valgrind errors in this case)
      af3c09d7
    • unknown's avatar
      Bug#31210 - INSERT DELAYED crashes server when used on · c9e0ea59
      unknown authored
                    partitioned table
        
      Post-pushbuild fix
        
      Pushbuild detected a new need for lex initialization in
      embedded server.
      
      Fixed test for INSERT DELAYED in partitions_hash.test so that
      it works with embedded server.
      
      
      libmysqld/lib_sql.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                        partitioned table
        Initialized lex for later use in open_table().
      mysql-test/r/partition_hash.result:
        Bug#31210 - INSERT DELAYED crashes server when used on
                        partitioned table
        Fixed test result for embedded server.
      mysql-test/t/partition_hash.test:
        Bug#31210 - INSERT DELAYED crashes server when used on
                        partitioned table
        Fixed test for embedded server.
      c9e0ea59
  3. 10 Nov, 2007 5 commits
    • unknown's avatar
      Bug#32091: Security breach via directory changes · 5ffe36e2
      unknown authored
      Changed test case from GRANT to CREATE USER
      
      
      mysql-test/r/partition_mgm.result:
        Bug#32091: Security breach via directory changes
        test result
      mysql-test/t/partition_mgm.test:
        Bug#32091: Security breach via directory changes
        Changed test case from GRANT to CREATE USER
      5ffe36e2
    • unknown's avatar
      Bug#32091: Security breach via directory changes · 34f43689
      unknown authored
      small fix of test case (when running make test after
      merge, it did not substitute MYSQLTEST_VARDIR in
      the error)
      
      
      mysql-test/r/partition_mgm.result:
        Bug#32091: Security breach via directory changes
        small fix in test result
      mysql-test/t/partition_mgm.test:
        Bug#32091: Security breach via directory changes
        small fix in test case
      34f43689
    • unknown's avatar
      Bug#31210 - INSERT DELAYED crashes server when used on · 09e88154
      unknown authored
                  partitioned table
      
      Post-merge fix
      
      A new need for lex initialization arose.
      
      
      sql/ha_ndbcluster.cc:
        Bug#31210 - INSERT DELAYED crashes server when used on
                    partitioned table
        Initialized lex for later use in open_table().
      09e88154
    • unknown's avatar
      Bug#29368: Modified error messages · f97e1b97
      unknown authored
      Problem: there was no standard syntax error when
               creating partitions with syntax error in
               the partitioning clause.
      
      Solution: added "Syntax error: " to the error message
      
      
      mysql-test/r/partition.result:
        Bug#29368: Incorrect error for syntax error when createing
                   partition
        
        test result update
      mysql-test/r/partition_error.result:
        Bug#29368: Incorrect error for syntax error when createing
                   partition
        
        test result
      mysql-test/t/partition_error.test:
        Bug#29368: Incorrect error for syntax error when createing
                   partition
        
        test case
      sql/share/errmsg.txt:
        Bug#29368: Incorrect error for syntax error when createing
                   partition
        
        Modified error messages
      f97e1b97
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-engines · a883192f
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-bug31210
      
      
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_connect.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_servers.cc:
        Auto merged
      sql/sql_udf.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      a883192f
  4. 09 Nov, 2007 2 commits
    • unknown's avatar
      Bug#32091: Security breach via directory changes · 21d5aef8
      unknown authored
      Problem: the table's INDEX and DATA DIR was taken
        directly from the table's first partition.
        This allowed rename attack similar to
        bug#32111 when ALTER TABLE REMOVE PARTITIONING
      
      Solution: Silently ignore the INDEX/DATA DIR
        for the table. (Like some other storage engines
        do). 
        Partitioned tables do not support DATA/INDEX
        DIR on the table level, only on its partitions.
      
      
      mysql-test/r/partition_mgm.result:
        Bug#32091: Security breach via directory changes
        test result
      mysql-test/t/partition_mgm.test:
        Bug#32091: Security breach via directory changes
        test case
      sql/ha_partition.cc:
        Bug#32091: Security breach via directory changes
        
        Do not use the first partition's DATA/INDEX DIR
        as the table's DATA/INDEX DIR.
        (A partitioned table do not have support for DATA/
        INDEX DIR, only its partitions do)
      21d5aef8
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-engines · 232d42ae
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-bug22351
      
      
      sql/handler.cc:
        Auto merged
      232d42ae
  5. 08 Nov, 2007 1 commit
  6. 07 Nov, 2007 2 commits
    • unknown's avatar
      Merge pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/p1-bug30671.3 · c9d5909e
      unknown authored
      into  pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/p1-bug30671.3.merge-5.1
      
      c9d5909e
    • unknown's avatar
      Bug#22351 - handler::index_next_same() call to key_cmp_if_same() uses · 07c701ab
      unknown authored
                  the wrong buffer
      
      handler::index_next_same() did not take into account that the
      internally called function key_cmp_if_same() uses the fixed
      buffer table->record[0] for key comparison instead of the
      buffer provided by the caller of handler::index_next_same().
      
      Added code to temporarily redirect table->record[0] and the fields
      used for the key to the record buffer provided by the caller of
      handler::index_next_same().
      
      The test case is in partition.test already.
      
      
      sql/handler.cc:
        Bug#22351 - handler::index_next_same() call to key_cmp_if_same() uses
                    the wrong buffer
        Added code to temporarily redirect table->record[0] and the fields
        used for the key to the record buffer provided by the caller of
        handler::index_next_same().
      07c701ab
  7. 06 Nov, 2007 12 commits
    • unknown's avatar
      Merge malff@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · e95c116d
      unknown authored
      into  lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-runtime
      
      e95c116d
    • unknown's avatar
      BUG#32111 - Security Breach via DATA/INDEX DIRECORY and RENAME TABLE · a837ff41
      unknown authored
      RENAME TABLE against a table with DATA/INDEX DIRECTORY overwrites
      the file to which the symlink points.
      
      This is security issue, because it is possible to create a table with
      some name in some non-system database and set DATA/INDEX DIRECTORY
      to mysql system database. Renaming this table to one of mysql system
      tables (e.g. user, host) would overwrite the system table.
      
      Return an error when the file to which the symlink points exist.
      
      
      mysql-test/r/symlink.result:
        A test case for BUG#32111.
      mysql-test/t/symlink.test:
        A test case for BUG#32111.
      mysys/my_symlink2.c:
        Return an error when the file to which the symlink points exist.
      a837ff41
    • unknown's avatar
      Bug#4692 - DISABLE/ENABLE KEYS waste a space · e961f016
      unknown authored
      Post-merge fix. Moved test into 5.0 section.
      
      e961f016
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · d742cec6
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/t/ctype_uca.test:
        Auto merged
      mysql-test/r/myisam.result:
        Manual merge from 5.0.
      mysql-test/t/myisam.test:
        Manual merge from 5.0.
      mysql-test/t/subselect.test:
        Manual merge from 5.0.
      storage/myisam/mi_check.c:
        Manual merge from 5.0.
      d742cec6
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 86c550d4
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B31974-5.1-runtime
      
      86c550d4
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-amain · 9389a2a2
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      9389a2a2
    • unknown's avatar
      Bug #31974: additional commit (test case updates) · 8ced7dc3
      unknown authored
       loose index scan enabled for subqueries
      
      
      mysql-test/r/group_min_max.result:
        Bug #31974: test case updates
         loose index scan enabled for subqueries
      mysql-test/r/index_merge_myisam.result:
        Bug #31974: test case updates
         loose index scan enabled for subqueries
      8ced7dc3
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-amain · 69951a7f
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      69951a7f
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-ateam · d948921f
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      d948921f
    • unknown's avatar
      Bug#4692 - DISABLE/ENABLE KEYS waste a space · 6b50443b
      unknown authored
      Disabling and enabling indexes on a non-empty table grows the
      index file.
      
      Disabling indexes just sets a flag per non-unique index and does not
      free the index blocks of the affected indexes. Re-enabling indexes
      creates new indexes with new blocks. The old blocks remain unused
      in the index file.
      
      Fixed by dropping and re-creating all indexes if non-empty disabled
      indexes exist when enabling indexes. Dropping all indexes resets
      the internal end-of-file marker to the end of the index file header.
      It also clears the root block pointers of every index and clears the
      deleted blocks chains. This way all blocks are declared as free.
      
      
      myisam/mi_check.c:
        Bug#4692 - DISABLE/ENABLE KEYS waste a space
        Added function mi_drop_all_indexes() to support drop of all indexes
        in case we want to re-enable non-empty disabled indexes.
        Changed mi_repair(), mi_repair_by_sort(), and mi_repair_parallel()
        to use the new function instead of duplicate drop index code.
      mysql-test/r/myisam.result:
        Bug#4692 - DISABLE/ENABLE KEYS waste a space
        Added test result.
      mysql-test/t/myisam.test:
        Bug#4692 - DISABLE/ENABLE KEYS waste a space
        Added test.
      6b50443b
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG31950/mysql-5.0-engines · c7a26788
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG31950/mysql-5.1-engines
      
      
      storage/myisam/ft_parser.c:
        Use local.
      c7a26788
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.0-engines · 26c75106
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG31950/mysql-5.0-engines
      
      26c75106
  8. 05 Nov, 2007 4 commits