1. 13 Nov, 2019 1 commit
  2. 12 Nov, 2019 10 commits
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · 1fe6e5a1
      Marko Mäkelä authored
      1fe6e5a1
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 33cb10d4
      Marko Mäkelä authored
      33cb10d4
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 5098d708
      Marko Mäkelä authored
      5098d708
    • Marko Mäkelä's avatar
      MDEV-12353 preparation: Clean up mtr_t · 2570cb8b
      Marko Mäkelä authored
      mtr_t::Impl, mtr_t::Command: Merge to mtr_t.
      
      MTR_MAGIC_N: Remove.
      
      MTR_STATE_COMMITTING: Remove. This state was only being set
      internally during mtr_t::commit().
      
      mtr_t::Command::m_locks_released: Remove (set-and-never-read member).
      
      mtr_t::Command::m_start_lsn: Replaced with the return value of
      finish_write() and a parameter to release_blocks().
      
      mtr_t::Command::m_end_lsn: Removed as a duplicate of mtr_t::m_commit_lsn.
      
      mtr_t::Command::prepare_write(): Replace a switch () with a
      comparison against 0. Only 2 m_log_mode are allowed.
      2570cb8b
    • Alexander Barkov's avatar
    • Marko Mäkelä's avatar
      MDEV-14602: Cleanup recv_dblwr_t::find_page() · dc8380b6
      Marko Mäkelä authored
      Avoid creating std::vector, and use single instead of double traversal.
      dc8380b6
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · 2350066e
      Marko Mäkelä authored
      2350066e
    • Sergei Petrunia's avatar
      MDEV-20854: ANALYZE for statements: not clear where the time is spent · 68ed3a81
      Sergei Petrunia authored
      Count the "gap" time between table accesses and display it as
      r_other_time_ms in the "table" element.
      
      * The advantage of this approach is that it doesn't add any new
        my_timer_cycles() calls.
      * The disadvantage is that the definition of what is done during
        "other time" is not that clear: it includes checking the WHERE
        (for this table), constructing index lookup tuple (for the next table)
        writing to GROUP BY temporary table (as we dont account for that time
        separately [yet], etc)
      68ed3a81
    • Sujatha's avatar
      MDEV-20953: binlog_encryption.rpl_corruption failed in buildbot due to wrong error code · 7df07c76
      Sujatha authored
      Problem:
      ========
      CURRENT_TEST: binlog_encryption.rpl_corruption
      
      mysqltest: In included file "./include/wait_for_slave_io_error.inc":
      ...
      At line 72: Slave stopped with wrong error code
      **** Slave stopped with wrong error code: 1743 (expected 1595,1913) ****
      
      Analysis:
      ========
      The test emulates the corruption at the various stages of replication for
      example in binlog file, in network and in relay log etc. It verifies that all
      corruption cases are handled through appropriate error messages.
      
      The test cases which emulate network failure expect following errors.
      --ER_SLAVE_RELAY_LOG_WRITE_FAILURE (1595)
      --ER_NETWORK_READ_EVENT_CHECKSUM_FAILURE (1743)
      
      Ideally test should expect error codes as 1595 and 1743.
      But the test actually waits on incorrect error code 1595,1913
      
      Fix:
      ===
      Added appropriate error code for 'ER_NETWORK_READ_EVENT_CHECKSUM_FAILURE'.
      Replaced 1913 with 1743.
      7df07c76
    • Eugene Kosov's avatar
      MDEV-20297 Support C++11 range-based for loop for List<T> · e5f99a0c
      Eugene Kosov authored
      New iterator has the fastest possible implementation: just moves one pointer.
      It's faster that List_iterator and List_iterator_fast: both do more on increment.
      
      Overall patch brings:
      1) work compile times
      2) possibly(!) worse debug build performance
      3) definitely better optimized build performance
      4) ability to write less code
      5) ability to write less bug-prone code
      e5f99a0c
  3. 11 Nov, 2019 16 commits
  4. 10 Nov, 2019 1 commit
    • Andrei Elkin's avatar
      MDEV-19376 Repl_semi_sync_master::commit_trx assertion failure: ... ||... · 13db50fc
      Andrei Elkin authored
      MDEV-19376 Repl_semi_sync_master::commit_trx assertion failure: ... || !m_active_tranxs->is_tranx_end_pos(trx_wait_binlog_name, trx_wait_binlog_pos)
      
      The assert indicates that the current transaction got caught uncleaned from
      the semisync master's cache when it is signaled to proceed upon its
      ack receive.
      
      The reason of missed cleanup turns out to be a flaw in the gtid
      connect mode.
      A submitted by connecting slave value of its last received event's
      binlog file *name* was adopted into
      {{Repl_semi_sync_master::m_reply_file_name}} as a part of semisync
      initialization.
      
      Notice that the initialization still refines the position part of the
      submitted last received event's binlog coordinates.
      The master side binlog filename:pos refinement is
      specific to the gtid connect mode for purpose of computing the latest
      binlog file to resume slave feeding from.
      Effectively in the gtid connect mode the computed resumption filename:pos
      may appear smaller in which case a new post-connect time committing
      transaction may be logged with its filename:pos also less than the
      submitted coordinates and that triggers the assert.
      
      Fixed with making the semisync initialization to use the refined filename:pos.
      It is guaranteed to be less than any new generated transaction's binlog:pos.
      13db50fc
  5. 08 Nov, 2019 12 commits