1. 18 May, 2011 2 commits
  2. 13 May, 2011 3 commits
  3. 12 May, 2011 12 commits
    • unknown's avatar
      BUG#12549572 : CMake file does not include gcov option · a5352244
      unknown authored
      This patch inserts an 'ENABLE_GCOV' option for enabling gcov compilation
      on Linux machines. It modifies the CMakeLists.txt setting this option
      to 'OFF' by default.
      
      Note: The option requires a debug build. For example, 
            -DCMAKE_BUILD_TYPE:string="Debug" 
      a5352244
    • Mikael Ronström's avatar
      merge · 593a39a1
      Mikael Ronström authored
      593a39a1
    • Jon Olav Hauglid's avatar
      Bug#12346411 SQL/LOG.CC:6509: ASSERTION `PREPARED_XIDS > 0' FAILED · 99b53189
      Jon Olav Hauglid authored
      This assert could be triggered during two phase commit if binary
      log was used as transaction coordinator log. The triggered assert
      checks that the same number of transaction IDs are processed in
      the prepare and commit phases.
      
      The reason it was triggered, was that the transaction consisted
      of an INSERT/UPDATE IGNORE that had an ignorable error. Since it
      had an error, no row log events were made and therefore
      prepared_xids was 0. However, since it was an IGNORE statement,
      the statement started a read/write statement transaction, committed
      it and completed successfully.
      
      This patch fixes the problem by adjusting the assert to take
      this possibility into account.
      
      Test case added to binlog.binlog_innodb_row.test.
      99b53189
    • Tatjana Azundris Nuernberg's avatar
      auto-merge · 3cd699fa
      Tatjana Azundris Nuernberg authored
      3cd699fa
    • Mikael Ronström's avatar
      merge · 54a4263e
      Mikael Ronström authored
      54a4263e
    • Tatjana Azundris Nuernberg's avatar
      auto-merge · 5fc506f1
      Tatjana Azundris Nuernberg authored
      5fc506f1
    • Tatjana Azundris Nuernberg's avatar
      auto-merge · 64bc10d7
      Tatjana Azundris Nuernberg authored
      64bc10d7
    • Tatjana Azundris Nuernberg's avatar
      Bug#11902767/Bug#60580: Statement improperly replicated crashes slave SQL thread · 2ab84e49
      Tatjana Azundris Nuernberg authored
      If LOAD DATA INFILE featured a SET clause, the name=value pairs
      would be regenerated using item::print. Unfortunately, that code
      is mostly optimized for EXPLAIN EXTENDED output and such, and can
      not be relied on to return valid SQL.
      
      We now name each value its original, user-supplied form and use
      that to create LOAD DATA INFILE statements for statement-based
      replication.
      
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        minor change in syntactic sugar
      mysql-test/suite/rpl/r/rpl_loaddatalocal.result:
        add test case
      mysql-test/suite/rpl/t/rpl_loaddatalocal.test:
        add test case
      sql/sql_load.cc:
        Do not try to item::print values in LOAD DATA INFILE's
        SET clause; they might not even be valid SQL at this
        point. Use our saved version instead.
      sql/sql_yacc.yy:
        If LOAD DATA INFILE has SET name=val clauses, tag the
        individual val-parts with the user's version so we can
        later replicate that, rather than the smashed pieces
        we'd get from item::print once the optimizer's through
        with our poor values.
      2ab84e49
    • Tatjana Azundris Nuernberg's avatar
      auto-merge · 3dc790e0
      Tatjana Azundris Nuernberg authored
      3dc790e0
    • Tatjana Azundris Nuernberg's avatar
      auto-merge · 8670eed9
      Tatjana Azundris Nuernberg authored
      8670eed9
    • Tatjana Azundris Nuernberg's avatar
      e9e8e762
    • Tatjana Azundris Nuernberg's avatar
      f1486422
  4. 11 May, 2011 7 commits
    • Luis Soares's avatar
      BUG#12416700 · e2a135b0
      Luis Soares authored
      Automerged bzr bundle from bug report into latest mysql-5.5.
      e2a135b0
    • Magnus Blåudd's avatar
      Merge bug 12384993 · afdc90f4
      Magnus Blåudd authored
      afdc90f4
    • Alexander Nozdrin's avatar
      Ignore auto-generated files. · 95158d99
      Alexander Nozdrin authored
      95158d99
    • Georgi Kodinov's avatar
      merge from mysql-5.5 · c2606c8a
      Georgi Kodinov authored
      c2606c8a
    • MySQL Build Team's avatar
      Cloning of the 5.5.13 release from Mysql-5.5, · 1b413e45
      MySQL Build Team authored
      increase the version number by two
      1b413e45
    • Georgi Kodinov's avatar
      Bug #11744875: 4082: integer lengths cause truncation with distinct concat · b5ef16eb
      Georgi Kodinov authored
      and innodb
      
      The 5.5 version of the patch.
      
      The server doesn't restrict the data that can be inserted into integer columns 
      with explicitly specified length that's smaller than what the type can handle,
      e.g. 1234 can be inserted into an INT(2) column just fine.
      Thus, when calcualting the maximum width of expressions involving such 
      restricted integer columns we need to use the implicit maximum width of 
      the field instead of the explicitly speficied one.
      Fixed the server to use the implicit maximum in such cases and made sure 
      the implicit maximum is addjusted the same way as the explicit one wrt
      signedness.
      
      Fixed several test case results (ctype_*.result, metadata.result and 
      type_ranges.result) to reflect the extended column widths.
      
      Added a regression test case in distinct.test.
      
      Note : this is the behavior preserving fix that makes 5.5 behave as 5.1 and 
      earlier. In the mysql trunk we'll add a insert time check for the explict 
      maximum size.
      b5ef16eb
    • Magnus Blåudd's avatar
      Bug#12384993 EXTRA/RPL_TEST/CHECK_TYPE.INC NEED SUPPORT FOR SPECIFIC ENGINE · b3bb31c9
      Magnus Blåudd authored
       - add support for choosing the engine of test
          table(t1) with $engine_type
       - add primary key to the test table(t1) to support
         replication of BLOB/TEXT (also with ENGINE=ndb)
       - change the suppression since the warning printed to error log
        now says "Column 1"
      b3bb31c9
  5. 10 May, 2011 4 commits
  6. 09 May, 2011 3 commits
    • Serge Kozlov's avatar
      automerge 5.1->5.5 · dd43765c
      Serge Kozlov authored
      dd43765c
    • Serge Kozlov's avatar
      WL#5867 · 697d1596
      Serge Kozlov authored
      Replaced the error code by error name
      697d1596
    • Alexander Nozdrin's avatar
      Patch for Bug#12362125 (SP INOUT HANDLING IS BROKEN FOR TEXT TYPE). · 542c88c8
      Alexander Nozdrin authored
      Attempts to assign value to a table column from trigger by using
      NEW.column_name pseudo-variable might result in garbled data.
      That happened when:
        - the column had a BLOB-based type (e.g. TEXT)
          and
        - the value being assigned was retrieved from stored routine variable
          of the same type.
      
      The problem was that BLOB values were not copied correctly in this
      case. Instead of doing a copy of a real value, the value's representation
      in record buffer was copied. This representation is essentially a
      pointer to a buffer associated with the virtual table for routine
      variables where the real value is stored. Since this buffer got
      freed once trigger was left or could have changed its contents when
      new value was assigned to corresponding routine variable such a shallow
      copying resulted in garbled data in NEW.colum_name column.
      
      It worked in 5.1 due to a subtle bug in create_virtual_tmp_table():
        - in 5.1 create_virtual_tmp_table() returned a table which
          had db_low_byte_first == false.
        - in 5.5 and up create_virtual_tmp_table() returns a table which
          has db_low_byte_first == true.
      Actually, db_low_byte_first == false only for ISAM storage engine,
      which was deprecated and removed in 5.0.
      
      Having db_low_byte_first == false led to getting false in the
      complex condition for the 2nd "if" in field_conv(), which in turn
      led to copy-blob-behavior as a fall-back strategy:
        - to->table->s->db_low_byte_first was true (correct value)
        - from->table->s->db_low_byte_first was false (incorrect value)
      
      In 5.5 and up that condition is true, which means blob-values are
      not copied.
      542c88c8
  7. 06 May, 2011 8 commits
    • Alexander Nozdrin's avatar
      Patch for Bug#12374486 - SEVERE MEMORY LEAK IN PREPARED STATEMENTS · c4841133
      Alexander Nozdrin authored
      THAT CALL STORED PROCEDURES.
      
      The bug was introduced by WL#4435. The problem was that if a stored
      procedure generated a few result sets with different set of columns,
      a new memory would be allocated after every EXECUTE for every
      result set.
      
      The fix is to introduce a new memory root in scope of MYSQL_STMT,
      and to store result-set metadata in that memory root.
      c4841133
    • Alexander Nozdrin's avatar
      Patch for Bug#11848763 / 60025 · f9a86592
      Alexander Nozdrin authored
      (SUBSTRING inside a stored function works too slow).
      
      The user-visible problem was that the server started to consume memory if a
      stored-routine of some sort is executed subsequently. The memory was freed
      only after the corresponding connection was closed.
      
      Technically, the problem was that the memory needed for temporary string
      conversions was allocated on the connection ("persistent") memory root,
      instead of statement one.
      
      The root cause of this problem was the incorrect patch for Bug 55744.
      That patch wrongly fixed a crash in prepared-statement-mode introduced by
      another patch. The patch for Bug 55744 used wrong condition to check if
      prepared statement mode is active (or whether the connection-scoped or
      statement-scoped memory root should be used). The thing is that for
      prepared statements such conversions should be done in the connection
      memory root, so that that the transformations of item-tree were correctly
      remembered in the PREPARE-phase.
      
      The fix is to use proper condition to detect prepared-statement-mode and
      use proper memory root.
      f9a86592
    • Alexander Nozdrin's avatar
      Preliminary patch for Bug#11848763 / 60025 · 1df8afdc
      Alexander Nozdrin authored
      (SUBSTRING inside a stored function works too slow).
      
      Background:
        - THD classes derives from Query_arena, thus inherits the 'state'
          attribute and related operations (is_stmt_prepare() & co).
      
        - Although these operations are available in THD, they must not
          be used. THD has its own attribute to point to the active
          Query_arena -- stmt_arena.
      
        - So, instead of using thd->is_stmt_prepare(),
          thd->stmt_arena->is_stmt_prepare() must be used. This was the root
          cause of Bug 60025.
      
      This patch enforces the proper way of calling those operations.
      is_stmt_prepare() & co are declared as private operations
      in THD (thus, they are hidden from being called on THD instance).
      
      The patch tries to minimize changes in 5.5.
      1df8afdc
    • Magnus Blåudd's avatar
      Add --with-debug=full support to BUILD/* scripts, this option has been lost · c3a699d0
      Magnus Blåudd authored
      between 5.1 and 5.5, it's purpose is to set the compiler flags in a way that
      does not optimize away the call stack(i.e don't use any -OX flags at all)
      c3a699d0
    • Magnus Blåudd's avatar
      Merge in patch for bug 12380149 · e7aaef43
      Magnus Blåudd authored
      e7aaef43
    • Sunanda Menon's avatar
      Merge from mysql-5.0.93-release · 3dfd10ed
      Sunanda Menon authored
      3dfd10ed
    • unknown's avatar
      Merge from mysql-5.5.12-release · a4b5278a
      unknown authored
      a4b5278a
    • Karen Langford's avatar
      Merge from mysql-5.1.57-release · c2123ae0
      Karen Langford authored
      c2123ae0
  8. 05 May, 2011 1 commit