1. 02 Sep, 2004 2 commits
    • unknown's avatar
      Fixed BUG#5307: Stored procedure allows statement after BEGIN ... END. · 2c3f49a6
      unknown authored
      
      mysql-test/r/sp.result:
        New test case for BUG#5307
      mysql-test/t/sp.test:
        New test case for BUG#5307
      sql/sp_head.cc:
        Use the correct end-of-query pointer when extracting the body in the case
        of a create procedure compound with another statement.
      2c3f49a6
    • unknown's avatar
      Fixed BUG#5287: Stored procedure crash if leave outside loop. · 339859d2
      unknown authored
      Bug in diff_handlers and diff_cursors made it attempt to pop
      the wrong number at jumps sometimes.
      
      
      mysql-test/r/sp.result:
        New testcase for BUG#5287.
      mysql-test/t/sp.test:
        New testcase for BUG#5287.
      sql/sp_pcontext.cc:
        Fixed diff_handlers and diff_cursors methods, they miscounted.
      sql/sp_pcontext.h:
        Made m_handlers available for diff_handlers.
      339859d2
  2. 30 Aug, 2004 4 commits
  3. 28 Aug, 2004 1 commit
    • unknown's avatar
      Microsoft VC++ won't compile class C { static const int I=1; }. · ca37e1c3
      unknown authored
      Putting initialization into .cc will reduce compiler's abilities
      to optimize this constant away.
      Defines are not OK as they bloat global namespace.
      Looking for a way to declare an efficient named constant in reduced
      namespace (i. e. in  a class).
      Let's try enums: normally they should be implicitly casted to int.
      Let's see if we really have a compiler which won't do that.
      
      
      
      
      libmysqld/lib_sql.cc:
        Added explicit cast to int for Protocol::{SEND_DEFAULTS,SEND_NUM_ROWS,
        SEND_EOF}
        flags argument of send_fields() is now int.
      sql/protocol.cc:
        flags argument of send_fields is now int.
      sql/protocol.h:
        Catch22: Microsoft VC++ won't compile 
        class C { static const int I=1; }.
        Putting initialization into .cc will reduce compiler's abilities
        to optimize this constant away.
        Defines are not OK as they bloat global namespace.
        Looking for a way to declare an efficient named constant in reduced
        namespace (i. e. in  a class).
        Let's try enums: normally they should be implicitly casted to int.
        Let's see if we really have a compiler which won't do that.
      sql/protocol_cursor.cc:
        flags are now int.
      ca37e1c3
  4. 27 Aug, 2004 2 commits
  5. 26 Aug, 2004 5 commits
    • unknown's avatar
      Item name for VIEW added to find_field_in_table (BUG#5147) · 7a6f5cf1
      unknown authored
      
      mysql-test/r/view.result:
        VIEW of VIEW with column renaming
      mysql-test/t/view.test:
        VIEW of VIEW with column renaming
      sql/mysql_priv.h:
        Item name for VIEW added to find_field_in_table
      sql/sql_acl.cc:
        new parameter
      sql/sql_base.cc:
        Item name for VIEW added to find_field_in_table
      7a6f5cf1
    • unknown's avatar
      fixed updateability VIEW detection (Bug#5146) · 3b8c2da8
      unknown authored
      fixed other Item_ref methods where result_field involved
      
      
      mysql-test/r/view.result:
        statements added to distinct in temporary table with a VIEW test
        test of agggregate over aggregate with view
      mysql-test/t/view.test:
        statements added to distinct in temporary table with a VIEW test
        test of agggregate over aggregate with view
      sql/item.cc:
        fixed other Item_ref methods where result_field involved
      sql/item.h:
        fixed other Item_ref methods where result_field involved
      sql/sql_lex.cc:
        fixed updateability VIEW detection
      3b8c2da8
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 8fa394da
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0-merge
      
      
      8fa394da
    • unknown's avatar
      Major rehacking and cleanup of sp_pcontext. · 071651ef
      unknown authored
      This finishes (almost) WL#2002: Implement stored procedure GOTO.
      Only the syntax issue for free labels remains ("label L;" vs "L:").
      
      
      include/mysqld_error.h:
        New error code for GOTO in SP handler.
      mysql-test/r/sp-error.result:
        New error test cases for GOTO.
      mysql-test/r/sp.result:
        New test cases for GOTO.
        Also removed some things that made it impossible to run the test in
        an external (debugged) mysqld.
      mysql-test/t/sp-error.test:
        New error test cases for GOTO.
      mysql-test/t/sp.test:
        New test cases for GOTO.
        Also removed some things that made it impossible to run the test in
        an external (debugged) mysqld.
      sql/share/czech/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/danish/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/dutch/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/english/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/estonian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/french/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/german/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/greek/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/hungarian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/italian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/japanese/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/korean/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/norwegian-ny/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/norwegian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/polish/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/portuguese/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/romanian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/russian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/serbian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/slovak/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/spanish/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/swedish/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/share/ukrainian/errmsg.txt:
        New error message for GOTO in SP handler.
      sql/sp_head.cc:
        Code cleanup (renaming of pcontext methods), support goto, and fixed bug
        in jump shortcutting in the optimizer (detect infinite loops).
      sql/sp_head.h:
        Code cleanup (renaming of pcontext methods), support goto, and fixed bug
        in jump shortcutting in the optimizer (detect infinite loops).
      sql/sp_pcontext.cc:
        Major rehack and cleanup:
        - We now push and pop a chain of contexts during parsing (instead of having
          a single one).
        - Makes error detection for GOTO easier and enables some optmizations and
          debugger support.
        - Makes it a little trickier to keep track on variable and cursor indexes instead.
        - Renamed things to get a more consistent naming scheme too.
      sql/sp_pcontext.h:
        Major rehack and cleanup:
        - We now push and pop a chain of contexts during parsing (instead of having
          a single one).
        - Makes error detection for GOTO easier and enables some optmizations and
          debugger support.
        - Makes it a little trickier to keep track on variable and cursor indexes instead.
        - Renamed things to get a more consistent naming scheme too.
      sql/sql_yacc.yy:
        Changes to reflect the rework and renamings in sp_pcontext, and fixed
        some GOTO error checking.
      071651ef
    • unknown's avatar
      fix of Item_ref with result_field (BUG#5104) · ac0d94a9
      unknown authored
      
      mysql-test/r/view.result:
        distinct in temporary table with a VIEW
      mysql-test/t/view.test:
        distinct in temporary table with a VIEW
      sql/item.cc:
        fix of Item_ref with result_field
      sql/item.h:
        fix of Item_ref with result_field
      ac0d94a9
  6. 25 Aug, 2004 4 commits
  7. 24 Aug, 2004 10 commits
    • unknown's avatar
      fixes name outout for SHOW CREATE VIEW command (BUG#5162) · d8f599bc
      unknown authored
      
      mysql-test/r/view.result:
        SHOW CREATE VIEW output changed
        test of SHOW CREATE VIEW for view with spaces in the name
      mysql-test/t/view.test:
        test of SHOW CREATE VIEW for view with spaces in the name
      sql/sql_show.cc:
        fixes name outout for SHOW CREATE VIEW command
      d8f599bc
    • unknown's avatar
      new method to detect commands where all VIEWs should be temporary tables (BUG#4803) · b8785595
      unknown authored
      
      mysql-test/r/view.result:
        Showing VIEW with VIEWs in subquery
      mysql-test/t/view.test:
        Showing VIEW with VIEWs in subquery
      sql/sql_lex.cc:
        new method to detect commands where all VIEWs should be temporary tables
      sql/sql_lex.h:
        new method to detect commands where all VIEWs should be temporary tables
      sql/sql_view.cc:
        new method to detect commands where all VIEWs should be temporary tables
        debug output added
      b8785595
    • unknown's avatar
      fixed aggregate function processing in VIEWs (BUG#4665) · 52b735a1
      unknown authored
      
      mysql-test/r/view.result:
        Aggregate functions in view list
      mysql-test/t/view.test:
        Aggregate functions in view list
      sql/table.cc:
        fixed aggregate function processing in VIEWs
      52b735a1
    • unknown's avatar
      Fixed UNION support in view creation (BUG#4664) · 964955b1
      unknown authored
      
      mysql-test/r/view.result:
        added removing of table t2
        test of view built over union
      mysql-test/t/view.test:
        added removing of table t2
        test of view built over union
      sql/sql_view.cc:
        Fixed UNION support in view creation
      964955b1
    • unknown's avatar
      items for functions which is converted to constants internally to support its... · c688b7b8
      unknown authored
      items for functions which is converted to constants internally to support its correct printing added (BUG#4663)
      
      
      mysql-test/r/view.result:
        test of functions in VIEW which is converted to constants internally
      mysql-test/t/view.test:
        test of functions in VIEW which is converted to constants internally
      sql/item.h:
        items for functions which is converted to constants internally to support its correct printing
      sql/item_create.cc:
        items for functions which is converted to constants internally to support its correct printing
      c688b7b8
    • unknown's avatar
      Fixed BUG#3157: Crash if stored procedure contains IF EXISTS, · ac06195c
      unknown authored
      and BUG#336: Subselects with tables does not work as values for
      local SP variables (which was closed before with a temp. fix, but not
      actually fixed).
      
      
      mysql-test/r/sp-error.result:
        Moved test case for BUG#336 to sp.test, as it's not generating an error any longer.
      mysql-test/r/sp.result:
        Move test case for BUG#336 from sp-error.test and added new test case
        for BUG#3157.
      mysql-test/t/sp-error.test:
        Moved test case for BUG#336 to sp.test, as it's not generating an error any longer.
      mysql-test/t/sp.test:
        Move test case for BUG#336 from sp-error.test and added new test case
        for BUG#3157.
      sql/sp_head.cc:
        Open and close tables in set, jump-if[-not] and freturn instructions if
        the value expression is a subselect.
      sql/sp_head.h:
        Store tables in set, jump-if[-not] and freturn instructions if
        the value expression is a subselect.
      sql/sql_yacc.yy:
        Store tables in set, jump-if[-not] and freturn instructions if
        the value expression is a subselect.
      ac06195c
    • unknown's avatar
      sending right error message where VIEW is not expected (BUG#4606) · 46a0c8a7
      unknown authored
      
      mysql-test/r/view.result:
        using VIEW where table is required
      mysql-test/t/view.test:
        using VIEW where table is required
      sql/sql_base.cc:
        sending right error message where VIEW is not expected
      sql/sql_view.h:
        frm_type_enum moved to table.h becuae used in TABLE_LIST
      sql/table.h:
        frm_type_enum moved to table.h becuae used in TABLE_LIST
      46a0c8a7
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 94e995d7
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0-merge
      
      
      94e995d7
    • unknown's avatar
      Fixed a valgrind warning when creating stored procedures containing complex · 5a10f1ac
      unknown authored
      unions (crashed randomly), and made "label" not a reserved word.
      
      
      sql/sql_parse.cc:
        Fixed valgrind warning for certain complex unions (which sometime caused crash).
      sql/sql_yacc.yy:
        The temporary(?) "label" statement should not be a reserved word.
      5a10f1ac
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 2f16033f
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-5.0
      
      
      2f16033f
  8. 23 Aug, 2004 3 commits
    • unknown's avatar
      innodb.result, innodb.test: · 07a1c31a
      unknown authored
        Fix mysql-test failure in the 5.0 tree on Aug 23: label seems to be a reserved word in 5.0, and we to use it a s a column name we must but it inside backticks
      
      
      mysql-test/t/innodb.test:
        Fix mysql-test failure in the 5.0 tree on Aug 23: label seems to be a reserved word in 5.0, and we to use it a s a column name we must but it inside backticks
      mysql-test/r/innodb.result:
        Fix mysql-test failure in the 5.0 tree on Aug 23: label seems to be a reserved word in 5.0, and we to use it a s a column name we must but it inside backticks
      07a1c31a
    • unknown's avatar
      fixed LIMIT clause printing (BUG#4839) · 248d7108
      unknown authored
      
      mysql-test/r/view.result:
        EXISTS with UNION VIEW creation test
      mysql-test/t/view.test:
        EXISTS with UNION VIEW creation test
      sql/sql_lex.cc:
        fixed LIMIT clause printing
      248d7108
    • unknown's avatar
      fixed error processing of prepare in VIEW creation (BUG#4801) · 9ca63e55
      unknown authored
      
      mysql-test/r/view.result:
        test of error processing found in preparation phase
      mysql-test/t/view.test:
        test of error processing found in preparation phase
      sql/sql_view.cc:
        fixed error processing of prepare
      9ca63e55
  9. 19 Aug, 2004 1 commit
  10. 17 Aug, 2004 2 commits
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · d90c1ae6
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0-merge
      
      
      d90c1ae6
    • unknown's avatar
      WL#2002: Implement stored procedure GOTO. · 9b5a6f72
      unknown authored
      Mostly done, it works, but the temporary LABEL syntax still to be fixed.
      
      
      mysql-test/r/sp-error.result:
        New test case for WL#2002 (GOTO).
      mysql-test/r/sp.result:
        New test case for WL#2002 (GOTO).
        (Also corrected another test)
      mysql-test/t/sp-error.test:
        New test case for WL#2002 (GOTO).
      mysql-test/t/sp.test:
        New test case for WL#2002 (GOTO).
        (Also corrected another test)
      sql/lex.h:
        New symbol GOTO.
        Also a temporary symbol LABEL, which hopefully will go away soon.
      sql/sp_head.cc:
        Fixed backpatching to cope with free GOTO labels an hpop and cpop instructions.
        Also optimized away pointless jump instructions.
      sql/sp_head.h:
        Fixed backpatching to cope with free GOTO labels an hpop and cpop instructions.
        We now sometimes generate hpop/cpop 0 instructions but the optimizer removes them.
      sql/sp_pcontext.cc:
        Added free GOTO labels, and support for coping with jumps out of blocks
        with handlers or cursors.
      sql/sp_pcontext.h:
        Added free GOTO labels, and support for coping with jumps out of blocks
        with handlers or cursors.
      sql/sql_yacc.yy:
        Added GOTO and LABEL, and adjusted backpatching accordingly. Also fixed LEAVE
        out of blocks. The LABEL syntax will go away soon, hopefully.
      9b5a6f72
  11. 16 Aug, 2004 4 commits
  12. 15 Aug, 2004 1 commit
  13. 13 Aug, 2004 1 commit