1. 30 Jun, 2007 1 commit
  2. 29 Jun, 2007 3 commits
  3. 28 Jun, 2007 3 commits
    • unknown's avatar
      Bug #29157: UPDATE, changed rows incorrect · ba4682ae
      unknown authored
      Sometimes the number of really updated rows (with changed
      column values) cannot be determined at the server level
      alone (e.g. if the storage engine does not return enough
      column values to verify that). So the only dependable way
      in such cases is to let the storage engine return that
      information if possible.
      Fixed the bug at server level by providing a way for the 
      storage engine to return information about wether it 
      actually updated the row or the old and the new column 
      values are the same. It can do that by returning 
      HA_ERR_RECORD_IS_THE_SAME in ha_update_row().
      Note that each storage engine may choose not to try to
      return this status code, so this behaviour remains 
      storage engine specific.
      
      
      include/my_base.h:
        Bug #29157: handle the row not updated special return value
      sql/log_event.cc:
        Bug #29157: handle the row not updated special return value
      sql/sp.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_acl.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_insert.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_servers.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_update.cc:
        Bug #29157: handle the row not updated special return value
      ba4682ae
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 26bed2a6
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26564-5.1-opt
      
      
      26bed2a6
    • unknown's avatar
      events_bugs.test didn't remove all the objects it created · 3f9bf925
      unknown authored
      what caused some consequitive tests failures
      
      
      mysql-test/r/events_bugs.result:
        test result fixed
      mysql-test/t/events_bugs.test:
        typo fixed, event removed
      3f9bf925
  4. 27 Jun, 2007 3 commits
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 28187da7
      unknown authored
      into  mysql.com:/home/hf/work/29156/my51-29156
      
      
      28187da7
    • unknown's avatar
      Bug #29156 events crash server in test suite · 9ee3b4b7
      unknown authored
      don't free thd->lex->sphead if we didn't do lex_start(),
      as we can have garbage there
      
      
      mysql-test/r/events_bugs.result:
        Bug #29156 events crash server in test suite
        
        test result added
      mysql-test/t/events_bugs.test:
        Bug #29156 events crash server in test suite
        
        testcase
      9ee3b4b7
    • unknown's avatar
      rpl_partition.test fixed · f454990c
      unknown authored
      
      mysql-test/r/rpl_partition.result:
        result fixed
      mysql-test/t/rpl_partition.test:
        machine-depending lines hidden in result
      f454990c
  5. 26 Jun, 2007 3 commits
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · e2af383d
      unknown authored
      into  mysql.com:/home/hf/work/28430/my51-28430
      
      
      e2af383d
    • unknown's avatar
      Bug #28430 Failure in replication of innodb partitioned tables on row/mixed format. · f01095d1
      unknown authored
      In the ha_partition::position we don't calculate the number of
      the partition of the record. We use m_last_part_value instead relying on
      that it is set in other place like previous calls of ::write_row().
      In replication we do neither of these calls before ::position().
      Delete_row_log_event::do_exec_row calls find_and_fetch_row() where
      we used position() & rnd_pos() calls to find the record for the
      PARTITION/INNODB table as it posesses InnoDB table flags.
      Fixed by removing HA_PRIMARY_KEY_REQUIRED_FOR_POSITION flag from PARTITION
      
      
      sql/ha_partition.cc:
        Bug #28430 Failure in replication of innodb partitioned tables on row/mixed format.
        
        add HA_PRIMARY_KEY_REQUIRED_FOR_POSITION flag added to PRTITION engine
      mysql-test/r/rpl_partition.result:
        New BitKeeper file ``mysql-test/r/rpl_partition.result''
      mysql-test/t/rpl_partition.test:
        New BitKeeper file ``mysql-test/t/rpl_partition.test''
      f01095d1
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · b535307c
      unknown authored
      into  dl145s.mysql.com:/dev/shm/mhansson/my51-bug28677
      
      
      b535307c
  6. 25 Jun, 2007 15 commits
    • unknown's avatar
      Bug #26564: Windows implementation of pthread_join crashes · 76295d4b
      unknown authored
      MySQL uses _beginthread()/_endthread() instead of 
      _beginthreadex()/_endthreadex() to create/end its threads
      on Windows.
      According to MSDN  _endthread() does close the thread handle.
      So there's no need the handle to be closed explicitly.
      Besides : WaitForSingleObject(, INFINITE) != WAIT_OBJECT_0) is
      true for all practical cases as the other two possible return 
      codes (according to MSDN) cannot happen in that case the 
      CloseHandle() was actually a dead code.
      Fixed by removing the CloseHandle() call. No test case added
      because it's not possible to test for absence of dead code. 
      
      
      include/my_pthread.h:
        Bug #26564: Don't call CloseHandle since we use 
        beginthread/endthread instead of beginthreadex/endthreadex.
      76295d4b
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · a0fa27cf
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      a0fa27cf
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.1 · eb3c6257
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      eb3c6257
    • unknown's avatar
      Raise version number after cloning 5.1.20-beta · 36151ca3
      unknown authored
      36151ca3
    • unknown's avatar
      Bug #29247 Double free in libmysqlclient_r when mysql restarted. · 57444944
      unknown authored
      If one sets MYSQL_READ_DEFAULTS_FILE and MYSQL_READ_DEFAULT_GROUP options
      after mysql_real_connect() called with that MYSQL instance,
      these options will affect next mysql_reconnect then.
      As we use a copy of the original MYSQL object inside mysql_reconnect,
      and mysql_real_connect frees options.my_cnf_file and _group strings,
      we will free these twice when we execute mysql_reconnect with the
      same MYSQL for the second time.
      
      I don't think we should ever read defaults files handling mysql_reconnect.
      So i just set them to 0 for the temporary MYSQL object there/
      
      
      sql-common/client.c:
        Bug #29247 Double free in libmysqlclient_r when mysql restarted.
        
        we don't need mysql_real_connect to reread defaults file in this
        case, so set related parameters to zero
      57444944
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 25f08443
      unknown authored
      into  dl145s.mysql.com:/dev/shm/mhansson/my51-bug28677
      
      
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      25f08443
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 7a310d32
      unknown authored
      into  mysql.com:/home/hf/work/27084/my51-27084
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/sql_partition.h:
        Auto merged
      sql/table.cc:
        Auto merged
      mysql-test/r/partition.result:
        merging
      mysql-test/t/partition.test:
        merging
      sql/sql_partition.cc:
        SCCS merged
      7a310d32
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 475a08a2
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      475a08a2
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1-opt · 637d9f1c
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      637d9f1c
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · fb12c686
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      fb12c686
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.1 · 66d2d370
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      66d2d370
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1 · be684dc0
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/4.1-opt
      
      
      be684dc0
    • unknown's avatar
      Bug #29252 Assertion 'table->file || table->file->inited == handler::NONE' failed · eea61b18
      unknown authored
      when index_init() or rnd_init() return an error, we still set
      handler->inited to INDEX or RND in ha_index_init and ha_rnd_init.
      As caller doesn't call ha_*_end() in this case, we get DBUG_ASSERT
      failed.
      
      
      sql/handler.h:
        Bug #29252 Assertion 'table->file || table->file->inited == handler::NONE' failed.
        
        make sure that 'inited' is handler::NONE if index_init() or rnd_init()
        returned an error
      eea61b18
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 1dad2a0a
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.1-opt
      
      
      mysql-test/r/group_min_max.result:
        Auto merged
      mysql-test/t/group_min_max.test:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      1dad2a0a
    • unknown's avatar
      rpl_skip_error.result: · f90c0b0a
      unknown authored
        Merge with 5.1.
      
      
      mysql-test/r/rpl_skip_error.result:
        Merge with 5.1.
      f90c0b0a
  7. 24 Jun, 2007 4 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.1 · 362852ba
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      sql/item.h:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_trigger.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      mysql-test/r/rpl_change_master.result:
        Merge with 5.1.
      mysql-test/t/rpl_change_master.test:
        Merge with 5.1.
      sql/sql_acl.cc:
        Merge with 5.1.
      362852ba
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · f30db309
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug25602
      
      
      sql/sql_select.cc:
        Auto merged
      f30db309
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · fec835f1
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      sql/log_event.cc:
        Auto merged
      fec835f1
    • unknown's avatar
      Fixed bug #25602. A query with DISTINCT in the select list to which · e009b764
      unknown authored
      the loose scan optimization for grouping queries was applied returned 
      a wrong result set when the query was used with the SQL_BIG_RESULT
      option.
      
      The SQL_BIG_RESULT option forces to use sorting algorithm for grouping
      queries instead of employing a suitable index. The current loose scan
      optimization is applied only for one table queries when the suitable
      index is covering. It does not make sense to use sort algorithm in this
      case. However the create_sort_index function does not take into account
      the possible choice of the loose scan to implement the DISTINCT operator
      which makes sorting unnecessary. Moreover the current implementation of
      the loose scan for queries with distinct assumes that sorting will
      never happen. Thus in this case create_sort_index should not call
      the function filesort.
      
      
      mysql-test/r/group_min_max.result:
        Added a test case for bug #25602.
      mysql-test/t/group_min_max.test:
        Added a test case for bug #25602.
      e009b764
  8. 23 Jun, 2007 5 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 1ba9b0a9
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      1ba9b0a9
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1-opt · b462e06e
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      b462e06e
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 26b526dc
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      libmysql/libmysql.c:
        Merge with 5.0-opt.
      mysql-test/r/insert_select.result:
        Merge with 5.0-opt.
      mysql-test/r/mysqlbinlog.result:
        Merge with 5.0-opt.
      mysql-test/r/rpl_change_master.result:
        Merge with 5.0-opt.
      mysql-test/r/view.result:
        Merge with 5.0-opt.
      mysql-test/t/insert_select.test:
        Merge with 5.0-opt.
      mysql-test/t/mysqlbinlog.test:
        Merge with 5.0-opt.
      mysql-test/t/rpl_change_master.test:
        Merge with 5.0-opt.
      mysql-test/t/view.test:
        Merge with 5.0-opt.
      sql/item.cc:
        Merge with 5.0-opt.
      sql/item.h:
        Merge with 5.0-opt.
      sql/log_event.cc:
        Merge with 5.0-opt.
      sql/sql_select.cc:
        Merge with 5.0-opt.
      26b526dc
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29095 · d37471b4
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      d37471b4
    • unknown's avatar
      Fixed bug #29095. · 1bab1ddc
      unknown authored
      INSERT into table from SELECT from the same table
      with ORDER BY and LIMIT was inserting other data
      than sole SELECT ... ORDER BY ... LIMIT returns.
      
      One part of the patch for bug #9676 improperly pushed
      LIMIT to temporary table in the presence of the ORDER BY
      clause.
      That part has been removed.
      
      
      sql/sql_select.cc:
        Fixed bug #29095.
        One part of the patch for bug #9676 improperly pushed
        LIMIT to temporary table in the presence of the ORDER BY
        clause.
        That part has been removed.
      mysql-test/t/insert_select.test:
        Expanded the test case for bug #9676.
        Created a test case for bug #29095.
      mysql-test/r/insert_select.result:
        Expanded the test case for bug #9676.
        Created a test case for bug #29095.
      1bab1ddc
  9. 22 Jun, 2007 3 commits