1. 25 Apr, 2018 1 commit
  2. 24 Apr, 2018 3 commits
  3. 23 Apr, 2018 7 commits
  4. 21 Apr, 2018 1 commit
  5. 20 Apr, 2018 5 commits
  6. 19 Apr, 2018 7 commits
  7. 17 Apr, 2018 1 commit
  8. 16 Apr, 2018 2 commits
  9. 13 Apr, 2018 5 commits
    • Sergei Golubchik's avatar
    • Daniel Black's avatar
      defaults-group-suffix in print_defaults · 88ac368f
      Daniel Black authored
      Also clarify which --{no-,}default* options, must be first.
      
      Sample output:
      $  client/mysql --help
      client/mysql  Ver 15.1 Distrib 5.5.59-MariaDB, for Linux (x86_64) using readline 5.1
      Copyright (c) 2000, 2017, Oracle, MariaDB Corporation Ab and others.
      
      Usage: client/mysql [OPTIONS] [database]
      
      Default options are read from the following files in the given order:
      /etc/my.cnf /etc/mysql/my.cnf ~/.my.cnf
      The following groups are read: mysql client client-server client-mariadb
      The following options may be given as the first argument:
      --print-defaults          Print the program argument list and exit.
      --no-defaults             Don't read default options from any option file.
      The following specify which files/groups are read (specified before other options):
      --defaults-file=#         Only read default options from the given file #.
      --defaults-extra-file=#   Read this file after the global files are read.
      --defaults-group-suffix=# Additionally read default groups with # appended as a suffix.
      
      tests running from build directory:
      TEST: print defaults ignored as not first
      $ sql/mysqld  --no-defaults --print-defaults --lc-messages-dir=${PWD}/sql/share
      
      TEST: no startup occurs as --print-defaults specified
      $ sql/mysqld  --print-defaults --lc-messages-dir=${PWD}/sql/share
      sql/mysqld would have been started with the following arguments:
      --lc-messages-dir=/home/dan/repos/build-mariadb-5.5/sql/share
      
      TEST: default args can't be anywhere
      $ client/mysql --user=bob  --defaults-file=/etc/my.cnf
      client/mysql: unknown variable 'defaults-file=/etc/my.cnf'
      $ client/mysql --user=bob  --defaults-group-suffix=.group
      client/mysql: unknown variable 'defaults-group-suffix=.group'
      
      /etc/my.cnf:
      [client-server.group]
      socket=/var/lib/mysql-multi/group/mysqld.sock
      user=bob
      
      /etc/my.other.cnf:
      socket=/var/lib/mysql-other/mysqld.sock
      
      TEST: defaults file read and suffix also applied
      $  client/mysql  --defaults-file=/etc/my.other.cnf  --defaults-group-suffix=.group
      ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/lib/mysql-other/mysqld.sock' (2)
      
      TEST: defaults extra file
      $ client/mysql  --defaults-extra-file=/etc/my.other.cnf  --defaults-group-suffix=.group
      ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/lib/mysql-other/mysqld.sock' (2)
      88ac368f
    • Jan Lindström's avatar
      MDEV-15672: encryption.innodb_encryption_filekeys - typo in I_S column name: ENCRYPTION_SHCEME · 2bf355fa
      Jan Lindström authored
      Fixed typo on select that is executed only when something unexpected
      happens.
      2bf355fa
    • Jan Lindström's avatar
      MDEV-12632: Source and destination overlap in memcpy,... · 3855943f
      Jan Lindström authored
      MDEV-12632: Source and destination overlap in memcpy, encryption.innodb-discard-import-change fails in buildbot with valgrind
      
      Use block->page.offset for checking page number.
      3855943f
    • Jan Lindström's avatar
      MDEV-15580: Assertion `!lex->explain' failed in lex_start(THD*): · 82e96819
      Jan Lindström authored
      Problem was that we did not delete explain information
      when Galera must replay a query.
      
      Could not find easily repeatable test case that would not
      cause other problems.
      82e96819
  10. 12 Apr, 2018 4 commits
    • Vladislav Vaintroub's avatar
      MDEV-15779 - mariabackup incremental prepare fails on CIFS mount. · c2dc72c0
      Vladislav Vaintroub authored
      CIFS does not like O_DIRECT flag (it is set successfully, but pread would
      fail).
      
      The fix is not to use O_DIRECT, there is not need for it.
      posix_fadvise() was used already that should prevent buffer cache
      pollution on Linux.
      
      As recommended by documentation of posix_fadvise(), we'll also fsync()
      tablespaces after a batch of writes.
      c2dc72c0
    • Vladislav Vaintroub's avatar
      MDEV-15780 : Mariabackup with absolute paths in innodb_data_file_path · 15071226
      Vladislav Vaintroub authored
      System tablespace can be specified with absolute path, if innodb_data_home_dir
      is empty.
      
      This was not handled well  by mariabackup
      
      1. In backup phase, empty innodb_data_home_dir variable from server was
      not recognized. full paths were stored in backup-my.ini, even if
      it stored all files locally. thus prepare phase would not find the system
      tablespace files.
      
      2. In copy-back phase, copy would not be done to the absolute destination
      path, as path would be stripped with trim_dotslash
      
      This patch fixes the above defects.
      15071226
    • Jan Lindström's avatar
      MDEV-12632: Source and destination overlap in memcpy,... · 0ae13b51
      Jan Lindström authored
      MDEV-12632: Source and destination overlap in memcpy, encryption.innodb-discard-import-change fails in buildbot with valgrind
      
      Problem was that if tablespace was encrypted we try to copy
      also page 0 from read buffer to write buffer that are in
      that case the same memory area.
      
      fil_iterate
      	When tablespace is encrypted or compressed its
              first page (i.e. page 0) is not encrypted or
      	compressed and there is no need to copy buffer.
      0ae13b51
    • Jan Lindström's avatar
      MDEV-12903: encryption.innodb_encryption_discard_import fails in buildbot with FOUND vs NOT FOUND · 9518ddd1
      Jan Lindström authored
      Wait until rotation has ended and shutdown before grep to make sure
      that dirty pages are on datafiles.
      9518ddd1
  11. 11 Apr, 2018 4 commits