1. 30 Jan, 2022 3 commits
  2. 29 Jan, 2022 3 commits
  3. 28 Jan, 2022 3 commits
    • Sergei Golubchik's avatar
    • Monty's avatar
      Fixed result for embedded server · a1f630cc
      Monty authored
      - Revert wrongly record embedded result files. These were either
        recorded with normal server (not embedded) or an embedded server
        with not default compile option. This can be seen that the committed
        result file had replication variables which should never happen.
      
      - Reverted back change of include/is_embedded.inc. One cannot check for
        $MYSQL_EMBEDDED as this only tells if there exists an embedded
        server, not if the current server we are testing is the embedded
        server. This could easily be verified by doing
        'mtr sys_vars.sysvars_server_embedded'. This would fail with a wrong
        result instead of being marked as skipped as --embedded was not
        used.
      a1f630cc
    • Monty's avatar
      Fixed wrong function call in embedded server · 7045ec27
      Monty authored
      This happens when compiled with HAVE_EMBEDDED_PRIVILEGE_CONTROL.
      There is a lot of other problems with the above option that should
      be fixed at some point
      7045ec27
  4. 27 Jan, 2022 14 commits
  5. 26 Jan, 2022 12 commits
    • Daniel Black's avatar
      MDEV-27635: selinux: allow read of /proc/sys/kernel/core_pattern · 8b3b7380
      Daniel Black authored
      Prevent the error:
      
      setroubleshoot[23678]: SELinux is preventing /usr/libexec/mysqld from read access on the file core_pattern.
      
      Reading of the core pattern occurs on crash as added in MDEV-15051
      
      RHEL-7.7
      
      $  ls -laZ /proc/sys/kernel/core_pattern
      -rw-r--r--. root root system_u:object_r:usermodehelper_t:s0 /proc/sys/kernel/core_pattern
      8b3b7380
    • Daniel Black's avatar
      MDEV-27289: mtr test for WITH_SERVER_EMBEDDED=ON reenable · 68b3fa88
      Daniel Black authored
      mtr is checking the wrong path for the embedded executable
      on out of tree builds.
      
      The is_embedded.inc tests are also checking the version rather
      than the MTR MYSQL_EMBEDDED environment variable.
      
      As a result, a few tests are out of date in the result recordings.
      68b3fa88
    • Daniel Black's avatar
      MDEV-27607: mysql_install_db to install mysql_upgrade_info · 2e81eab2
      Daniel Black authored
      For compatibility this is under an extra option --upgrade-info
      
      The goal here is to install a data directory with the required
      info to let mysql_upgrade know that an upgrade isn't required.
      2e81eab2
    • Andrei's avatar
      MDEV-19555 assert Diagnostics_area::sql_errno() in ha_rollback_trans · c9356223
      Andrei authored
      Fixed the assert to restore pre-refactoring condition for
      calling set_error() equivalent.
      c9356223
    • Marko Mäkelä's avatar
      MDEV-25440: Indexed CHAR columns are broken with NO_PAD collations · e9aac091
      Marko Mäkelä authored
      cmp_data(): Compare different-length CHAR fields with
      the new strnncollsp_nchars function that will pad spaces if needed.
      
      Any InnoDB ROW_FORMAT except the original one that was named
      ROW_FORMAT=REDUNDANT in MySQL 5.0.3 will internally store
      CHAR(n) columns as variable-length if the character encoding is
      variable length. Spaces may be trimmed from the end.
      For NOT NULL values, the minimum length is always n*mbminlen.
      In cmp_data() we only know the lengths in bytes and we cannot
      easily know the ROW_FORMAT.
      
      is_strnncoll_compatible(): Refactored from innobase_mysql_cmp().
      
      innobase_mysql_cmp(): Merged to cmp_whole_field().
      
      cmp_whole_field(): Invoke strnncollsp_nchars for the DATA_MYSQL
      (the CHAR type with any other collation than latin1_swedish_ci).
      
      Reviewed by: Alexander Barkov
      Tested by: Roel Roel Van de Paar
      e9aac091
    • Marko Mäkelä's avatar
      Cleanup: Simplify cmp_geometry_field() and cmp_whole_field() · 37144afb
      Marko Mäkelä authored
      Let us always compare DATA_GEOMETRY with cmp_geometry_field().
      37144afb
    • Marko Mäkelä's avatar
    • Oleksandr Byelkin's avatar
      new CC · 7db489fc
      Oleksandr Byelkin authored
      7db489fc
    • Vladislav Vaintroub's avatar
    • Lena Startseva's avatar
      MDEV-8652: Partitioned table creation problem when creating from procedure... · b9623383
      Lena Startseva authored
      MDEV-8652: Partitioned table creation problem when creating from procedure context twice in same session
      
      The problem was solved in in MDEV-7990, this commit contains only test
      b9623383
    • Alexey Botchkov's avatar
      MDEV-20770 Server crashes in JOIN::transform_in_predicates_into_in_subq upon... · 020dc54d
      Alexey Botchkov authored
      MDEV-20770 Server crashes in JOIN::transform_in_predicates_into_in_subq upon 2nd execution of PS/SP comparing GEOMETRY with other types.
      
      The Item_in_subselect::in_strategy keeps the value and as the error
      happens the condition isn't modified. That leads to wrong ::fix_fields
      execution on second PS run. Also the select->table_list is merged
      but not restored if an error happens, which causes hanging loops on
      the third PS execution.
      020dc54d
    • Igor Babaev's avatar
      MDEV-27510 Query returns wrong result when using split optimization · 00412656
      Igor Babaev authored
      This bug may affect the queries that uses a grouping derived table with
      grouping list containing references to columns from different tables if
      the optimizer decides to employ the split optimization for the derived
      table. In some very specific cases it may affect queries with a grouping
      derived table that refers only one base table.
      This bug was caused by an improper fix for the bug MDEV-25128. The fix
      tried to get rid of the equality conditions pushed into the where clause
      of the grouping derived table T to which the split optimization had been
      applied. The fix erroneously assumed that only those pushed equalities
      that were used for ref access of the tables referenced by T were needed.
      In fact the function remove_const() that figures out what columns from the
      group list can be removed if the split optimization is applied can uses
      other pushed equalities as well.
      This patch actually provides a proper fix for MDEV-25128. Rather than
      trying to remove invalid pushed equalities referencing the fields of SJM
      tables with a look-up access the patch attempts not to push such equalities.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      00412656
  6. 25 Jan, 2022 5 commits
    • Brandon Nesterenko's avatar
      MDEV-16091: Seconds_Behind_Master spikes to millions of seconds · 8b15d0d4
      Brandon Nesterenko authored
      This patch addresses two problems with
      rpl.rpl_seconds_behind_master_spike
      
      First, --sync_slave_with_master / select master_pos_wait
      seems to have a bug where it will hang after all master
      events have been executed.
      
      This patch removes the sync_slave_with_master command from
      the test, where it not required anyway as it is used to
      declare explicit cleanup
      
      Second, the test uses timestamps to ensure that the
      Seconds_Behind_Master value does not point to a time too
      far in the past. The checks of these timestamps were
      too strict, because they could be slightly inconsistent
      with the master and the SBM would be counted as invalid
      when it was actually correct.
      
      To fix this, a slight buffer was added to the check
      to ensure the value is valid but still does not point
      too far in the past
      
      Reviewed By:
      ===========
      Andrei Elkin <andrei.elkin@mariadb.com>
      8b15d0d4
    • Vladislav Vaintroub's avatar
      MDEV-27373 wolfSSL 5.1.1 · be1d9653
      Vladislav Vaintroub authored
      - compile wolfcrypt with kdf.c, to avoid undefined symbols in tls13.c
      - define WOLFSSL_HAVE_ERROR_QUEUE to avoid endless loop SSL_get_error
      - Do not use SSL_CTX_set_tmp_dh/get_dh2048, this would require additional
        compilation options in WolfSSL. Disable it for WolfSSL build, it works
        without it anyway.
      - fix "macro already defined" Windows warning.
      be1d9653
    • Oleksandr Byelkin's avatar
      WolfSSL v5.1.1 · 8db47403
      Oleksandr Byelkin authored
      8db47403
    • Alexey Botchkov's avatar
      MDEV-25917 create table like fails if source table is partitioned and engine... · 50e66db0
      Alexey Botchkov authored
      MDEV-25917 create table like fails if source table is partitioned and engine is myisam or aria with data directory.
      
      Create table like removes data_file_path/index_file_path from the
      thd->work_partition_info.
      50e66db0
    • Jan Lindström's avatar
      Add have_debug.inc · 05717807
      Jan Lindström authored
      05717807