1. 15 Aug, 2006 5 commits
    • unknown's avatar
      Bug #21302: Result not properly sorted when using an ORDER BY · 2e110060
      unknown authored
                  on a second table in a join
      - undeterministic output of the test case removed.
      
      2e110060
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 23f822d1
      unknown authored
      into  rakia.(none):/home/kgeorge/mysql/autopush/B21159-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      23f822d1
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 9f374ab4
      unknown authored
      into  rakia.(none):/home/kgeorge/mysql/autopush/B21174-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      9f374ab4
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 4384f77e
      unknown authored
      into  rakia.(none):/home/kgeorge/mysql/autopush/B21159-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      4384f77e
    • unknown's avatar
      Bug #21159: Optimizer: wrong result after AND with different data types · 6c2c5ee1
      unknown authored
      Disable const propagation for Item_hex_string.
      This must be done because Item_hex_string->val_int() is not
      the same as (Item_hex_string->val_str() in BINARY column)->val_int().
      We cannot simply disable the replacement in a particular context (
      e.g. <bin_col> = <int_col> AND <bin_col> = <hex_string>) since
      Items don't know the context they are in and there are functions like 
      IF (<hex_string>, 'yes', 'no').
      Note that this will disable some valid cases as well 
      (e.g. : <bin_col> = <hex_string> AND <bin_col2> = <bin_col>) but 
      there's no way to distinguish the valid cases without having the
      Item's parent say something like : Item->set_context(Item::STRING_RESULT)
      and have all the Items that contain other Items do that consistently.
      
      
      mysql-test/r/compare.result:
        Bug #21159: Optimizer: wrong result after AND with different data types
         - test case
      mysql-test/t/compare.test:
        Bug #21159: Optimizer: wrong result after AND with different data types
         - test case
      sql/sql_select.cc:
        Bug #21159: Optimizer: wrong result after AND with different data types
         - disable const propagation for Item_hex_string.
      6c2c5ee1
  2. 14 Aug, 2006 3 commits
    • unknown's avatar
      Bug #21174: Index degrades sort performance and · 82145e11
      unknown authored
                   optimizer does not honor IGNORE INDEX
       - Allow an index to be used for sorting the table 
         instead of filesort only if it is not disabled by
         IGNORE INDEX.
      
      
      mysql-test/r/group_by.result:
        Bug #21174: Index degrades sort performance and 
                     optimizer does not honor IGNORE INDEX
         - test case
      mysql-test/t/group_by.test:
        Bug #21174: Index degrades sort performance and 
                     optimizer does not honor IGNORE INDEX
         - test case
      82145e11
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · b6fac663
      unknown authored
      into  rakia.(none):/home/kgeorge/mysql/autopush/B21302-5.0-opt
      
      
      mysql-test/r/join_outer.result:
        Auto merged
      mysql-test/r/order_by.result:
        Auto merged
      b6fac663
    • unknown's avatar
      Bug #21302: Result not properly sorted when using an ORDER BY on a second · f087e2c1
      unknown authored
                   table in a join
       The optimizer removes redundant columns in ORDER BY. It is considering 
      redundant every reference to const table column, e.g b in :
      create table t1 (a int, b int, primary key(a)); 
      select 1 from t1 order by b where a = 1
      
      But it must not remove references to const table columns if the 
      const table is an outer table because there still can be 2 values :
      the const value and NULL. e.g.:
      create table t1 (a int, b int, primary key(a));
      select t2.b c from t1 left join t1 t2 on (t1.a = t2.a and t2.a = 5) 
        order by c;
      
      
      mysql-test/r/join_outer.result:
        Bug #21302: Result not properly sorted when using an ORDER BY on a second 
                    table in a join
         - don't remove columns of const tables in ORDER BY if the const table 
           is an outer table.
      mysql-test/r/order_by.result:
        Bug #21302: Result not properly sorted when using an ORDER BY on a second 
                    table in a join
         - test case
      mysql-test/t/order_by.test:
        Bug #21302: Result not properly sorted when using an ORDER BY on a second 
                    table in a join
         - test case
      sql/sql_select.cc:
        Bug #21302: Result not properly sorted when using an ORDER BY on a second 
                    table in a join
         - don't remove columns of const tables in ORDER BY if the const table 
           is an outer table.
      f087e2c1
  3. 11 Aug, 2006 3 commits
  4. 10 Aug, 2006 4 commits
    • unknown's avatar
      Merge updates. · 79e8b4dc
      unknown authored
      
      mysql-test/r/grant2.result:
        Merge update:  Change between versions, it appears.
      mysql-test/r/heap_btree.result:
        Merge update:  Add deterministic ordering of data, as the order is different 
        between versions.
      mysql-test/r/mysql_client.result:
        Merge update: Help options changed between versions.
      mysql-test/t/heap_btree.test:
        Merge update:  Add deterministic ordering of data, as the order is different 
        between versions.
      BitKeeper/deleted/.del-bug20328.test~c76d766fe3e1eb5:
        Delete: mysql-test/t/bug20328.test
      BitKeeper/deleted/.del-bug20328.result~4fee68989442c2a3:
        Delete: mysql-test/r/bug20328.result
      79e8b4dc
    • unknown's avatar
      4354527a
    • unknown's avatar
      Removed Iggy's accidentally-added files. · 5cc9a39d
      unknown authored
      5cc9a39d
    • unknown's avatar
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-4.1 · 60201f0d
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0
      
      
      client/mysql.cc:
        Auto merged
      heap/hp_delete.c:
        Auto merged
      mysql-test/t/mysqlbinlog.test:
        Auto merged
      scripts/fill_func_tables.sh:
        Auto merged
      scripts/mysql_install_db.sh:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      mysql-test/r/grant2.result:
        Manual merge
      mysql-test/r/heap_btree.result:
        Manual merge
      mysql-test/r/mysql_client.result:
        Manual merge
      mysql-test/t/grant2.test:
        Manual merge
      mysql-test/t/heap_btree.test:
        Manual merge
      mysql-test/t/mysql_client.test:
        Manual merge
      60201f0d
  5. 09 Aug, 2006 3 commits
    • unknown's avatar
      Merge may.pils.ru:/home/svoj/devel/mysql/BUG20060/mysql-4.1 · 899f24e0
      unknown authored
      into  may.pils.ru:/home/svoj/devel/mysql/BUG20060/mysql-5.0
      
      
      myisam/mi_update.c:
        Auto merged
      899f24e0
    • unknown's avatar
      BUG#20060 - mysqld option "--flush " doesn't work for update statement · de7f8c67
      unknown authored
      Problem described in this bug report affects MyISAM tables only.
      
      Running mysqld --flush instructs mysqld to sync all changes to disk
      after each SQL statement. It worked well for INSERT and DELETE
      statements, but it did sync for UPDATE only in case if there was
      index change (change of colum that has an index). If no updated column
      has an index, data wasn't synced to disk.
      
      This fix makes UPDATE statement to sync data to disk even if there is
      no index change (that is only data change) and mysqld is run with
      --flush option.
      
      
      myisam/mi_update.c:
        Every myisam function that updates myisam table must end with
        call to _mi_writeinfo(). If operation (second param of
        _mi_writeinfo()) is not 0 it sets share->changed to 1, that is
        flags that data has changed. If operation is 0, this function
        equals to no-op in this case.
        
        mi_update() must always pass !0 value as operation, since even if
        there is no index change there could be data change.
      de7f8c67
    • unknown's avatar
      sql_view.cc: · 06f67179
      unknown authored
        After merge fix
      
      
      sql/sql_view.cc:
        After merge fix
      06f67179
  6. 08 Aug, 2006 3 commits
  7. 07 Aug, 2006 1 commit
    • unknown's avatar
      sql_view.cc: · fcdcb2c9
      unknown authored
        Memory leak fix
      
      
      sql/sql_view.cc:
        Memory leak fix
      fcdcb2c9
  8. 06 Aug, 2006 3 commits
  9. 03 Aug, 2006 15 commits
    • unknown's avatar
      636cfcca
    • unknown's avatar
      Fix a bug in the .dsp file. Ignore a symlink. · b0f5a4bb
      unknown authored
      
      BitKeeper/etc/ignore:
        Added ndb/src/common/util/testBitmask.cpp to the ignore list
      VC++Files/sql/mysqld.dsp:
        Fix a bug in the .dsp file.
      b0f5a4bb
    • unknown's avatar
    • unknown's avatar
      Update result after merge, since the function Item::tmp_table_field_from_field_type() · b4dfe6e2
      unknown authored
      now takes mbmaxlen into account when calculating max_length of new field. 
      
      b4dfe6e2
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-4.1 · 71f53be3
      unknown authored
      into  may.pils.ru:/home/svoj/devel/mysql/BUG7391/mysql-4.1
      
      71f53be3
    • unknown's avatar
      Bug#21419 test case lowercase_fs_off fails on Windows · cc127576
      unknown authored
       - Backport patch from 5.0
      
      
      sql/mysqld.cc:
        Add else case to set "lower_case_file_system" also when lower_case_table_names are 1
      cc127576
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0 · e02afca5
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      client/mysql.cc:
        Auto merged
      client/mysqldump.c:
        Auto merged
      configure.in:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      e02afca5
    • unknown's avatar
      Remove double error printout in mysqldump · 4ed6d44f
      unknown authored
      
      client/mysqldump.c:
        Remove double error printout, mysql_query_with_error_report will do that. And set the exit code for us.
      mysql-test/r/mysqldump.result:
        Update test result after merge
      4ed6d44f
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/my41-bug21218 · b5bac47f
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/t/mysqlbinlog.test:
        Null merge
      b5bac47f
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/my41-bug21218 · 5a901250
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      mysql-test/t/mysqlbinlog.test:
        Auto merged
      5a901250
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/my50-m-bug21215 · 347e9a28
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      client/mysql.cc:
        Auto merged
      configure.in:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      client/mysqldump.c:
        Manual merge
      mysql-test/r/mysqldump.result:
        Manual merge
      mysql-test/t/mysqldump.test:
        Manual merge
      347e9a28
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-4.1 · 466faf80
      unknown authored
      into  may.pils.ru:/home/svoj/devel/mysql/BUG7391/mysql-4.1
      
      466faf80
    • unknown's avatar
      BUG#7391 - Cross-database multi-table UPDATE uses active database · ae419374
      unknown authored
                 privileges
      
      This problem is 4.1 specific. It doesn't affect 4.0 and was fixed
      in 5.x before.
      
      Having any mysql user who is allowed to issue multi table update
      statement and any column/table grants, allows this user to update
      any table on a server (mysql grant tables are not exception).
      
      check_grant() accepts number of tables (in table list) to be checked
      in 5-th param. While checking grants for multi table update, number
      of tables must be 1. It must never be 0 (actually we have
      DBUG_ASSERT(number > 0) in 5.x in grant_check() function).
      
      
      mysql-test/r/grant.result:
        Addition to test case for bug#7391:
        - Added grant statement to trigger this problem in 4.1.
        - Fixed error messages.
      mysql-test/t/grant.test:
        Addition to test case for bug#7391:
        - Added grant statement to trigger this problem in 4.1.
        - Fixed error messages.
      sql/sql_update.cc:
        check_grant() accepts number of tables (in table list) to be checked
        in 5-th param. For this particular check number of tables must be 1.
        It must never be 0 (actually we have DBUG_ASSERT(number > 0) in 5.x
        in grant_check() function).
      ae419374
    • unknown's avatar
      Removing disabling of lowercase_fs_off · f83d7121
      unknown authored
      f83d7121
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0 · 4ef68339
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      client/mysql.cc:
        Auto merged
      client/mysqltest.c:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/date_formats.result:
        Auto merged
      mysql-test/r/union.result:
        Auto merged
      mysql-test/t/union.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/r/func_group.result:
        Merge manually
      mysql-test/t/func_group.test:
        Merge manually
      4ef68339