1. 06 May, 2020 2 commits
  2. 05 May, 2020 2 commits
    • Varun Gupta's avatar
      MDEV-13266: Race condition in ANALYZE TABLE / statistics collection · 06b245f7
      Varun Gupta authored
      Fixing a race condition while collecting the engine independent statistics.
      
      Thread1>
      1) start running "ANALYZE TABLE t PERISTENT FOR COLUMNS (..) INDEXES ($list)"
      2) Walk through $list and save it in TABLE::keys_in_use_for_query
      3) Close/re-open tables
      
      Thread2>
      1) Make some use of table t. This involves taking table t from
         the table cache, and putting it back (with TABLE::keys_in_use_for_query reset to 0)
      
      Thread1>
      continue collecting EITS stats. Since TABLE::keys_in_use_for_query is set to 0 we
      will not collect statistics for indexes in $list.
      06b245f7
    • Marko Mäkelä's avatar
      MDEV-11254 cleanup: Remove buf_page_t::write_size · b9f177f6
      Marko Mäkelä authored
      commit 6495806e removed all reads
      of buf_page_t::write_size. Let us remove the field altogether.
      b9f177f6
  3. 04 May, 2020 6 commits
  4. 02 May, 2020 2 commits
  5. 30 Apr, 2020 12 commits
  6. 29 Apr, 2020 12 commits
    • Vladislav Vaintroub's avatar
      MDEV-22419 update windows timezone data from using newest ICU source · 9b744ea0
      Vladislav Vaintroub authored
      Also fix the link to unicode.org repo, it is now on github.
      9b744ea0
    • Vladislav Vaintroub's avatar
      mysql-test-run.pl - show remaining test count and estimated time on Windows · e3f5789a
      Vladislav Vaintroub authored
      Port this functionality from to Windows.
      It requires Win32::Console module, which is already included into
      Strawberry perl
      e3f5789a
    • Eugene Kosov's avatar
      add WITH_DBUG_TRACE CMake variable · 28325b08
      Eugene Kosov authored
      This is a way do disable DBUG_ENTER()/DBUG_EXIT() stuff which is
      needed to dbug trace. Those who doesn't need it may avoid tests
      slowdown with -DWITH_DBUG_TRACE=OFF
      
      dbug/tests.c: add define which is neede always in this test
      
      innodb.log_file_name_debug.test: do not depend on DBUG trace stuff
      in test
      
      Benchmark results: each test eats less CPU and you can have more
      parallel jobs in MTR.
      
      patched:
      ./mtr -mem -par=8 -suite=innodb  185.34s user 86.85s system 133% cpu 3:23.27 total
      ./mtr -mem -par=8 -suite=main    80.96s  user 36.01s system 182% cpu 1:04.07 total
      
      main.select                              [ pass ]   1660
      main.select                              [ pass ]   1513
      main.select                              [ pass ]   1543
      main.select                              [ pass ]   1660
      main.select                              [ pass ]   1521
      main.select                              [ pass ]   1511
      main.select                              [ pass ]   1508
      main.select                              [ pass ]   1520
      main.select                              [ pass ]   1514
      main.select                              [ pass ]   1522
      
      vanilla:
      ./mtr -mem -par=8 -suite=innodb  203.61s user 92.16s system 140% cpu 3:30.16 total
      ./mtr -mem -par=8 -suite=main    94.11s  user 35.51s system 206% cpu 1:02.69 total
      
      main.select                              [ pass ]   2032
      main.select                              [ pass ]   2017
      main.select                              [ pass ]   2040
      main.select                              [ pass ]   2183
      main.select                              [ pass ]   2253
      main.select                              [ pass ]   2075
      main.select                              [ pass ]   2109
      main.select                              [ pass ]   2080
      main.select                              [ pass ]   2098
      main.select                              [ pass ]   2114
      28325b08
    • Sergei Golubchik's avatar
      8c534bde
    • Jan Lindström's avatar
      MDEV-20916: Galera test failure on galera.galera_parallel_autoinc_largetrx: Result content mismatch · 7a546650
      Jan Lindström authored
      Add wait_condition to make sure that node contains all the rows
      expected.
      7a546650
    • Sergei Golubchik's avatar
    • Maheedhar PV's avatar
      Bug#28388217 - SERVER CAN FAIL WHILE REPLICATING CONDITIONAL COMMENTS · 4d1de554
      Maheedhar PV authored
      Cause:
      In case of version based condtional comments, if the condition evaluates
      to false, it is converted to a regular comment for replication by
      replacing "!"  by " ".
      
      Nested comment in a conditional comment is replicated as is. Nested
      comments are supported only in case of conditional comments and when a
      the comment on slave is no more a conditional comment, the statement
      execution fails on the slave.
      
      Fix:
      Convert the nested comment, start from "/*" to "(*" and comment end from
      "*/" to "*)" for replication.
      
      Change-Id: I1a8e385a267b2370529eade094f0258fa96886c0
      4d1de554
    • Sergei Golubchik's avatar
      don't enable -Werror in ft-index · a13157a5
      Sergei Golubchik authored
      a13157a5
    • Daniel Black's avatar
      MDEV-21595: innodb offset_t rename to rec_offs · ba2061da
      Daniel Black authored
      thanks to:
      
      perl -i -pe 's/\boffset_t\b/rec_offs/g' $(git grep -lw offset_t storage/innobase)
      ba2061da
    • Daniel Black's avatar
      MDEV-20685: compile fixes for Solaris/OSX/AIX · c238e9b9
      Daniel Black authored
      sig_return: Solaris/OSX returns different function ptr
      Move defination to my_alarm.h as its the only use.
      
      prevents compile warnings (copied from 10.3 branch)
      
      mysys/my_sync.c:136:19: error: 'cur_dir_name' defined but not used [-Werror=unused-const-variable=]
        136 | static const char cur_dir_name[]= {FN_CURLIB, 0};
            |                   ^~~~~~~~~~~~
      
      fix compile error (DEPRECATED) leaked from ssl headers.
      
      In file included from /export/home/dan/mariadb-server-10.4/sql/sys_vars.cc:37:
      /export/home/dan/mariadb-server-10.4/sql/sys_vars.ic:69: error: "DEPRECATED" redefined [-Werror]
         69 | #define DEPRECATED(X) X
            |
      In file included from /export/home/dan/mariadb-server-10.4/include/violite.h:150,
                       from /export/home/dan/mariadb-server-10.4/sql/sql_class.h:38,
                       from /export/home/dan/mariadb-server-10.4/sql/sys_vars.cc:36:
      /usr/include/openssl/ssl.h:2356: note: this is the location of the previous definition
       2356 | # define DEPRECATED __attribute__((deprecated))
            |
      
      Avoid Werror condition on non-Linux:
      
      plugin/server_audit/server_audit.c:2267:7: error: variable 'db_len_off' set but not used [-Werror=unused-but-set-variable]
       2267 |   int db_len_off;
            |       ^~~~~~~~~~
      plugin/server_audit/server_audit.c:2266:7: error: variable 'db_off' set but not used [-Werror=unused-but-set-variable]
       2266 |   int db_off;
            |       ^~~~~~
      
      auth_gssapi fix include path for Solaris
      
      Consistent with the upstream packaged patch:
      https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/database/mariadb-103/patches/06-gssapi.h.patch
      
      compile warnings on Solaris
      
      [ 91%] Building C object plugin/server_audit/CMakeFiles/server_audit.dir/server_audit.c.o
      /plugin/server_audit/server_audit.c: In function 'auditing_v8':
      /plugin/server_audit/server_audit.c:2194:20: error: unused variable 'db_len_off' [-Werror=unused-variable]
       2194 |   static const int db_len_off= 128;
            |                    ^~~~~~~~~~
      /plugin/server_audit/server_audit.c:2193:20: error: unused variable 'db_off' [-Werror=unused-variable]
       2193 |   static const int db_off= 120;
            |                    ^~~~~~
      /plugin/server_audit/server_audit.c:2192:20: error: unused variable 'cmd_off' [-Werror=unused-variable]
       2192 |   static const int cmd_off= 4432;
            |                    ^~~~~~~
      At top level:
      /plugin/server_audit/server_audit.c:2192:20: error: 'cmd_off' defined but not used [-Werror=unused-const-variable=]
      /plugin/server_audit/server_audit.c:2193:20: error: 'db_off' defined but not used [-Werror=unused-const-variable=]
       2193 |   static const int db_off= 120;
            |                    ^~~~~~
      /plugin/server_audit/server_audit.c:2194:20: error: 'db_len_off' defined but not used [-Werror=unused-const-variable=]
       2194 |   static const int db_len_off= 128;
            |                    ^~~~~~~~~~
      cc1: all warnings being treated as errors
      
      tested on:
      $ uname -a
      SunOS openindiana 5.11 illumos-b97b1727bc i86pc i386 i86pc
      c238e9b9
    • Daniel Black's avatar
      vio: typo on sock{et}_errno in comment · 946c8795
      Daniel Black authored
      946c8795
    • Alexey Botchkov's avatar
      MDEV-22337 Assertion `Alloced_length >= (str_length + length +... · 4af4284b
      Alexey Botchkov authored
      Fix pointer calculations in the Session_tracker::store.
      Most of the fix for this bug goes to the 10.5, but this part should be also fixed
      earlier.
      4af4284b
  7. 28 Apr, 2020 4 commits