1. 19 Jul, 2007 1 commit
    • unknown's avatar
      Fixed bug #29338. · 2ececf4e
      unknown authored
      Optimization of queries with DETERMINISTIC functions in the
      WHERE clause was not effective: sequential scan was always
      used.
      Now a SF with the DETERMINISTIC flags is treated as constant
      when it's arguments are constants (or a SF doesn't has arguments).
      
      
      sql/item_func.h:
        Fixed bug #29338.
        The Item_func_sp::used_tables has been removed
        (virtual Item_func::used_tables function is enough).
        The virtual Item_func_sp::update_used_tables function
        has been added.
      sql/item_func.cc:
        Fixed bug #29338.
        The Item_func_sp::update_used_tables and the
        Item_func_sp::fix_field functions have been modified
        to take into account the DETERMINISTIC flag of SF definition.
      mysql-test/r/sp.result:
        Updated test case for bug #29338.
      mysql-test/t/sp.test:
        Updated test case for bug #29338.
      2ececf4e
  2. 13 Jul, 2007 3 commits
  3. 12 Jul, 2007 4 commits
    • unknown's avatar
      Bug#29739: Incorrect time comparison in BETWEEN. · 793e4442
      unknown authored
      Time values were compared by the BETWEEN function as strings. This led to a
      wrong result in cases when some of arguments are less than 100 hours and other
      are greater.
      
      Now if all 3 arguments of the BETWEEN function are of the TIME type then
      they are compared as integers.
      
      
      mysql-test/t/type_time.test:
        Added a tes tcase for the bug#29739: Incorrect time comparison in BETWEEN.
      mysql-test/r/type_time.result:
        Added a tes tcase for the bug#29739: Incorrect time comparison in BETWEEN.
      sql/item_cmpfunc.cc:
        Bug#29739: Incorrect time comparison in BETWEEN.
        Now if all 3 arguments of the BETWEEN function are of the TIME type then
        they are compared as integers.
      793e4442
    • unknown's avatar
      e4d6b9e5
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · eaba3341
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug29604
      
      eaba3341
    • unknown's avatar
      Fixed bug #29604. · 07c0e6af
      unknown authored
      A bug in the restore_prev_nj_state function allowed interleaving 
      inner tables of outer join operations with outer tables. With the
      current implementation of the nested loops algorithm it could lead
      to wrong result sets for queries with nested outer joins.
      Another bug in this procedure effectively blocked evaluation of some
      valid execution plans for queries with nested outer joins. 
      
      
      mysql-test/r/join_nested.result:
        Added a test case for bug #29604.
      mysql-test/t/join_nested.test:
        Added a test case for bug #29604.
      07c0e6af
  4. 11 Jul, 2007 11 commits
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 4e98d043
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      4e98d043
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 3cc4928f
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt-29360
      
      3cc4928f
    • unknown's avatar
      field_conv.cc: · 0d4add75
      unknown authored
        Additional fix for bug #29360.
      
      
      sql/field_conv.cc:
        Additional fix for bug #29360.
      0d4add75
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c6b64d5c
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29555-bug-5.0-opt-mysql
      
      c6b64d5c
    • unknown's avatar
      Bug#29555: Comparing time values as strings may lead to a wrong result. · b0a5febe
      unknown authored
      Time values were compared as strings. This led to a wrong comparison
      result when comparing values one of which is under 100 hours and another is
      over 100 hours.
      
      Now when the Arg_comparator::set_cmp_func function sees that both items to
      compare are of the TIME type it sets the comparator to the
      Arg_comparator::compare_e_int or the Arg_comparator::compare_int_unsigned
      functions.
      
      
      sql/item_cmpfunc.cc:
        Bug#29555: Comparing time values as strings may lead to a wrong result.
        Now when the Arg_comparator::set_cmp_func function sees that both items to
        compare are of the TIME type it sets the comparator to the
        Arg_comparator::compare_e_int or the Arg_comparator::compare_int_unsigned
        functions.
      mysql-test/r/type_time.result:
        Added a test case for the bug#29555: Comparing time values as strings may
        lead to a wrong result.
      mysql-test/t/type_time.test:
        Added a test case for the bug#29555: Comparing time values as strings may
        lead to a wrong result.
      b0a5febe
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29360 · b796bddf
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      b796bddf
    • unknown's avatar
      Fixed bug #29360. · 54286cd5
      unknown authored
      The special `zero' enum value was coerced to the normal
      empty string enum value during a field-to-field copy.
      This bug affected CREATE ... SELECT statements and
      SELECT aggregate GROUP BY enum field statements.
      
      Also this bug made unnecessary warnings during
      the execution of CREATE ... SELECT statements:
      Warning       1265    Data truncated for column...
      
      
      sql/field_conv.cc:
        Fixed bug #29360.
        The field_conv function has been modified to properly convert
        the special `zero' enum value between enum fields.
      mysql-test/t/type_enum.test:
        Updated test case for bug #29360.
      mysql-test/r/type_enum.result:
        Updated test case for bug #29360.
      mysql-test/r/type_ranges.result:
        Updated test case for bug #29360.
      54286cd5
    • unknown's avatar
      Addendum to bug 29325: · 768db64b
      unknown authored
      test if TRUNCATE TABLE works with keep_files_on_create
      
      768db64b
    • unknown's avatar
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 7efab26b
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B29325-5.0-opt
      
      
      include/my_base.h:
        Auto merged
      7efab26b
    • unknown's avatar
      Bug #29325: · 41bbdb8d
      unknown authored
      By default MyISAM overwrites .MYD and .MYI files no 
      DATA DIRECTORY option is used. This can lead to two tables
      using the same .MYD and .MYI files (that can't be dropped).
      
      To prevent CREATE TABLE from overwriting a file a new option
      is introduced : keep_files_on_create
      When this is on the CREATE TABLE throws an error if either
      the .MYD or .MYI exists for a MyISAM table.
      The option is off by default (resulting in compatible behavior).
      
      
      include/my_base.h:
        Bug #29325: introduce keep_files_on_create
      myisam/mi_create.c:
        Bug #29325: introduce keep_files_on_create
      mysql-test/r/create.result:
        Bug #29325: test case
      mysql-test/t/create.test:
        Bug #29325: test case
      sql/ha_myisam.cc:
        Bug #29325: introduce keep_files_on_create
      sql/set_var.cc:
        Bug #29325: introduce keep_files_on_create
      sql/sql_class.h:
        Bug #29325: introduce keep_files_on_create
      sql/sql_table.cc:
        Bug #29325: introduce keep_files_on_create
      sql/unireg.cc:
        Bug #29325: introduce keep_files_on_create
      41bbdb8d
  5. 10 Jul, 2007 3 commits
  6. 09 Jul, 2007 11 commits
  7. 08 Jul, 2007 3 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 3993ad1c
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29461-bug-5.0-opt-mysql
      
      3993ad1c
    • unknown's avatar
      Bug#29461: Sort order of the collation wasn't used when comparing characters · b0497925
      unknown authored
      with the space character.
      
      When the my_strnncollsp_simple function compares two strings and one is a prefix
      of another then this function compares characters in the rest of longer key
      with the space character to find whether the longer key is greater or less.
      But the sort order of the collation isn't used in this comparison. This may
      lead to a wrong comparison result, wrongly created index or wrong order of the
      result set of a query with the ORDER BY clause.
      
      Now the my_strnncollsp_simple function uses collation sort order to compare
      the characters in the rest of longer key with the space character.
      
      
      mysql-test/t/ctype_collate.test:
        Added a test case for the bug#29461: Sort order of the collation wasn't used when
        comparing characters with the space character.
      mysql-test/r/ctype_collate.result:
        Added a test case for the bug#29461: Sort order of the collation wasn't used when
        comparing characters with the space character.
      strings/ctype-simple.c:
        Bug#29461: Sort order of the collation wasn't used when comparing characters
        with the space character.Now the my_strnncollsp_simple function uses collation sort order to compare
        the characters in the rest of longer key with the space character.
      b0497925
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 6d39ccf1
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      6d39ccf1
  8. 07 Jul, 2007 4 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 3c2eb9ec
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug29417
      
      
      mysql-test/r/type_newdecimal.result:
        Manual merge.
      mysql-test/t/type_newdecimal.test:
        Manual merge.
      3c2eb9ec
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · bf28faf7
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      bf28faf7
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1-opt · cbc7749f
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      cbc7749f
    • unknown's avatar
      Fixed bug #29417. · 578d9721
      unknown authored
      An assertion abort could occur for some grouping queries that employed 
      decimal user variables with assignments to them.
      
      The problem appeared the constructors of the class Field_new_decimal
      because the function my_decimal_length_to_precision did not guarantee
      returning decimal precision not greater than DECIMAL_MAX_PRECISION.
      
      
      mysql-test/r/type_newdecimal.result:
        Added a test case for bug #29417.
      mysql-test/t/type_newdecimal.test:
        Added a test case for bug #29417.
      sql/field.cc:
        Fixed bug #29417.
        An assertion abort could occur for some grouping queries that employed 
        decimal user variables with assignments to them.
        
        The problem appeared the constructors of the class Field_new_decimal
        because the function my_decimal_length_to_precision did not guarantee
        returning decimal precision not greater than DECIMAL_MAX_PRECISION.
        
        Now if the precision returned by calls to my_decimal_length_to_precision
        in the constructors of the class Field_new_decimal is greater than 
        DECIMAL_MAX_PRECISION the precision is set to this value.
      578d9721