1. 10 Nov, 2005 14 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 2ee2747b
      unknown authored
      into  mysql.com:/home/alik/MySQL/devel/5.0-wl2818
      
      
      mysql-test/r/mysqldump.result:
        Auto merged
      mysql-test/t/mysqldump.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_trigger.cc:
        Auto merged
      mysql-test/r/rpl_sp.result:
        Manual merge.
      2ee2747b
    • unknown's avatar
      WL#2818 (Add creator to the trigger definition for privilege · 7dbea7df
      unknown authored
      checks on trigger activation)
      
      
      mysql-test/r/information_schema.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/mysqldump.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/rpl_ddl.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/rpl_sp.result:
        Update result file: a new clause DEFINER has been added to
        CREATE TRIGGER statement.
      mysql-test/r/rpl_trigger.result:
        Results for new test cases were added.
      mysql-test/r/skip_grants.result:
        Error message has been changed.
      mysql-test/r/trigger.result:
        Added DEFINER column.
      mysql-test/r/view.result:
        Error messages have been changed.
      mysql-test/r/view_grant.result:
        Error messages have been changed.
      mysql-test/t/mysqldump.test:
        Drop created procedure to not affect further tests.
      mysql-test/t/rpl_trigger.test:
        Add tests for new column in information schema.
      mysql-test/t/skip_grants.test:
        Error tag has been renamed.
      mysql-test/t/view.test:
        Error tag has been renamed.
      mysql-test/t/view_grant.test:
        Error tag has been changed.
      sql/item_func.cc:
        Fix typo in comments.
      sql/mysql_priv.h:
        A try to minimize copy&paste:
          - introduce operations to be used from sql_yacc.yy;
          - introduce an operation to be used from trigger and
            view processing code.
      sql/share/errmsg.txt:
        - Rename ER_NO_VIEW_USER to ER_MALFORMED_DEFINER in order to
          be shared for view and trigger implementations;
        - Fix a typo;
        - Add a new error code for trigger warning.
      sql/sp.cc:
        set_info() was split into set_info() and set_definer().
      sql/sp_head.cc:
        set_info() was split into set_info() and set_definer().
      sql/sp_head.h:
        set_info() was split into set_info() and set_definer().
      sql/sql_acl.cc:
        Add a new check: exit from the cycle if the table is NULL.
      sql/sql_lex.h:
        - Rename create_view_definer to definer, since it is used for views
          and triggers;
        - Change st_lex_user to LEX_USER, since st_lex_user is a structure.
          So, formally, it should be "struct st_lex_user", which is longer
          than just LEX_USER;
        - Add trigger_definition_begin.
      sql/sql_parse.cc:
        - Add a new check: exit from the cycle if the table is NULL;
        - Implement definer-related functions.
      sql/sql_show.cc:
        Add DEFINER column.
      sql/sql_trigger.cc:
        Add DEFINER support for triggers.
      sql/sql_trigger.h:
        Add DEFINER support for triggers.
      sql/sql_view.cc:
        Rename create_view_definer to definer.
      sql/sql_yacc.yy:
        Add support for DEFINER-clause in CREATE TRIGGER statement.
        
        Since CREATE TRIGGER and CREATE VIEW can be similar at the start,
        yacc is unable to distinguish between them. So, had to modify both
        statements in order to make it parsable by yacc.
      mysql-test/r/trigger-compat.result:
        Result file for triggers backward compatibility test.
      mysql-test/r/trigger-grant.result:
        Result file of the test for WL#2818.
      mysql-test/t/trigger-compat.test:
        Triggers backward compatibility test: check that the server
        still can load triggers w/o definer attribute and modify
        tables with such triggers (add a new trigger, etc).
      mysql-test/t/trigger-grant.test:
        Test for WL#2818 -- check that DEFINER support in triggers
        works properly
      7dbea7df
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-5.0 · 3d42cd8d
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0
      
      
      3d42cd8d
    • unknown's avatar
      Merge mysql.com:/home/mysql_src/mysql-5.0-release · 74914637
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0
      
      
      74914637
    • unknown's avatar
      Merge mysqldev@production.mysql.com:my/mysql-5.0-release · 3bb367f2
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0-release
      
      
      3bb367f2
    • unknown's avatar
      WL#2971 "change log-bin-trust-routine-creators=0 to apply only to functions". · 5d9c8e95
      unknown authored
      Indeed now that stored procedures CALL is not binlogged, but instead the invoked substatements are,
      the restrictions applied by log-bin-trust-routine-creators=0 are superfluous for procedures.
      They still need to apply to functions where function calls are written to the binlog (for example as "DO myfunc(3)").
      We rename the variable to log-bin-trust-function-creators but allow the old name until some future version (and issue a warning if old name is used).
      
      
      mysql-test/mysql-test-run.pl:
        update to new option name
      mysql-test/mysql-test-run.sh:
        update to new option name
      mysql-test/mysql_test_run_new.c:
        update to new option name
      mysql-test/r/rpl_sp.result:
        result update
      mysql-test/t/rpl_sp-slave.opt:
        we need to skip this error to not hit BUG#14769
      mysql-test/t/rpl_sp.test:
        Test update:
        1) as log-bin-trust-routine-creators now affects only functions, the testing of this option, which was
        mainly done on procedures, is moved to functions
        2) cleanup is simplified; and instead of many SHOW BINLOG EVENTS we do a big one in the end, which is more
        maintainable.
        3) we test a few more function and procedures cases to see how they replicate.
        4) removing out-of-date comments
      sql/item_func.cc:
        This warning is wrong since binlogging of functions was changed in August. If a function fails
        in the middle, it will be binlogged with its error code (i.e. properly).
      sql/mysql_priv.h:
        variable name changed
      sql/mysqld.cc:
        option name changes. A precision about --read-only.
      sql/set_var.cc:
        a new class sys_var_trust_routine_creators to be able to issue a "this is a deprecated variable" warning if used.
      sql/set_var.h:
        new class to be able to issue a "this is a deprecated variable" warning if used.
      sql/share/errmsg.txt:
        routine -> function
      sql/sp.cc:
        log-bin-trust-routine-creators now applies only to functions.
      sql/sql_parse.cc:
        1) sending ER_FAILED_ROUTINE_BREAK_BINLOG is wrong since August as we don't binlog CALL anymore but instead binlog the substatements;
        the clear_error() goes away too as it was necessary only when we created a binlog event from the "CALL" statement.
        2) log-bin-trust-routine-creators now applies only to functions.
      sql/sql_trigger.cc:
        comments.
      5d9c8e95
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0 · 33956088
      unknown authored
      into mysql.com:/home/hf/work/mysql-5.0.14268
      
      
      33956088
    • unknown's avatar
      Fix for bug #14822: Test "mysqldump" fails, "result" protocol seems wrong. · 0c97fbef
      unknown authored
      
      mysql-test/t/mysqldump.test:
        Fix for bug #14822: Test "mysqldump" fails, "result" protocol seems wrong.
        2>&1 added to be able to see error messages.
      0c97fbef
    • unknown's avatar
      Merge mysql.com:/home/mysql_src/mysql-4.1-gca · 93607e35
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0-release
      
      
      sql/item_func.h:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      93607e35
    • unknown's avatar
      Declaring some class members public for BUG#12377: · 6e56f7e0
      unknown authored
      "Item_date_add_interval needs to have the int_type member as Public".
      As explained in the bug report, this change is is to help http://search.cpan.org/~philips/DBIx-MyParse-0.20/
      So please keep those members public.
      
      
      sql/item_func.h:
        declaring some class members public for BUG#12377
      sql/item_strfunc.h:
        declaring some class members public for BUG#12377
      sql/item_timefunc.h:
        declaring some class members public for BUG#12377
      6e56f7e0
    • unknown's avatar
      Fix a comment. · 96ae0b92
      unknown authored
      
      sql/sql_cursor.cc:
        A post-review fix for Bug#13488
      96ae0b92
    • unknown's avatar
      Provide a default "minimum thread stack size" PTHREAD_STACK_MIN where it is missing. · d295807e
      unknown authored
      (Currently, affects only BSD with Linuxthreads)
      
      
      d295807e
    • unknown's avatar
      merging · 25758b41
      unknown authored
      
      strings/decimal.c:
        Auto merged
      25758b41
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · ad1254fb
      unknown authored
      into  mysql.com:/usr/home/pem/bug14719/mysql-5.0
      
      
      ad1254fb
  2. 09 Nov, 2005 13 commits
  3. 08 Nov, 2005 6 commits
  4. 07 Nov, 2005 7 commits
    • unknown's avatar
      Merge mysql.com:/home/cps/mysql/trees/mysql-4.1 · ce648a30
      unknown authored
      into  mysql.com:/home/cps/mysql/trees/mysql-5.0-virgin
      
      
      sql/examples/ha_tina.cc:
        Auto merged
      support-files/mysql.spec.sh:
        SCCS merged
      ce648a30
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.0 · b8e4fa6f
      unknown authored
      into mysql.com:/M50/mysql-5.0
      
      
      b8e4fa6f
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 01cad639
      unknown authored
      into  mysql.com:/home/cps/mysql/trees/mysql-4.1
      
      
      01cad639
    • unknown's avatar
      mysql-test/r/connect.result + mysql-test/t/connect.test · af2e0dc4
      unknown authored
      Replace the full socket path name, not just a directory component. bug#14720
      
      
      mysql-test/r/connect.result:
        In cases where "--tmpdir=" is given to the test run, the socket file is not created below
        "$MYSQL_TEST_DIR" but rather within this directory. So the "--replace_result" should not 
        be done to a directory in the path but rather to the complete path name of the socket file. 
        bug#14720
      mysql-test/t/connect.test:
        In cases where "--tmpdir=" is given to the test run, the socket file is not created below
        "$MYSQL_TEST_DIR" but rather within this directory. So the "--replace_result" should not
        be done to a directory in the path but rather to the complete path name of the socket file.
        bug#14720
      af2e0dc4
    • unknown's avatar
      Bug#13707 - Server crash with INSERT DELAYED on MyISAM table · 9725d32b
      unknown authored
      Initialized 'ptr' for a newly instantiated varstring field.
      This is required by INSERT DELAYED.
      
      No test case. This is a migration issue. There are two shell
      scripts attached to the bug report. They can be used for testing.
      
      
      sql/field.cc:
        Bug#13707 - Server crash with INSERT DELAYED on MyISAM table
        Initialized 'ptr' for a newly instantiated varstring field.
        This is required by INSERT DELAYED.
      9725d32b
    • unknown's avatar
      Fix for BUG#14703 "Valgrind error when inserting 0 into a BIT column (like in type_bit.test)": · 50f48187
      unknown authored
      test "length" first (otherwise when "length" is 0, the *from invalid access still triggers a Valgrind warning).
      I wrote to the Valgrind authors in case this is something fixable in Valgrind (normally the
      decision to issue a warning is based on the simulated CPU condition code, which should not be undefined here).
      
      
      BUILD/compile-pentium64-valgrind-max:
        putting this script in sync with compile-pentium-valgrind-max, otherwise we didn't have the federated engine compiled in.
      mysql-test/r/read_only.result:
        result update
      sql/field.cc:
        To avoid a Valgrind warning running the type_bit test: test "length" first (otherwise when "length" is 0, the *from invalid access still triggers a Valgrind warning).
      50f48187
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-5.0 · 21447f17
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0
      
      
      21447f17