1. 07 Jun, 2005 2 commits
    • unknown's avatar
      Bug#10253: compound index length and utf8 char set · 309ed4c5
      unknown authored
      produces invalid query results
      
      mi_key.c:
        well_formed_length should be executed before space trimming, not after.
      ctype_utf8.test:
      ctype_utf8.result:
        adding test.
      
      
      myisam/mi_key.c:
        Bug#10253: ompound index length and utf8 char set produces invalid query results
        well_formed_length should be executed before space trimming, not after.
      mysql-test/r/ctype_utf8.result:
        adding test.
        adding test.
      mysql-test/t/ctype_utf8.test:
        adding test.
      309ed4c5
    • unknown's avatar
      Merge ssmith@bk-internal.mysql.com:/home/bk/mysql-4.1 · e2b6613a
      unknown authored
      into mysql.com:/home/stewart/Documents/MySQL/4.1/main
      
      e2b6613a
  2. 06 Jun, 2005 3 commits
  3. 05 Jun, 2005 2 commits
    • unknown's avatar
      mtr_misc.pl, mtr_report.pl: · c95d6b66
      unknown authored
        Try kill all children to the mysql-test-run process when exiting
      mtr_process.pl:
        Added new function mtr_exit() that try kill all children to the mysql-test-run process when exiting
      mysql-test-run.pl:
        Try kill all children to the mysql-test-run process when exiting
        New --vardir caused problems on Windows
        Changed faulty calls to error() to mtr_error()
      
      
      mysql-test/mysql-test-run.pl:
        Try kill all children to the mysql-test-run process when exiting
        New --vardir caused problems on Windows
        Changed faulty calls to error() to mtr_error()
      mysql-test/lib/mtr_report.pl:
        Try kill all children to the mysql-test-run process when exiting
      mysql-test/lib/mtr_process.pl:
        Added new function mtr_exit() that try kill all children to the mysql-test-run process when exiting
      mysql-test/lib/mtr_misc.pl:
        Try kill all children to the mysql-test-run process when exiting
      c95d6b66
    • unknown's avatar
      a compiler must see '#pragma implementation' *before* · 7ceda6b2
      unknown authored
      '#pragma interface' (that comes with the #include'd header file)
      
      7ceda6b2
  4. 04 Jun, 2005 4 commits
    • unknown's avatar
      Fix show warnings limit 0 and show warnings limit 0, 0. · 0d3de54b
      unknown authored
      Add test coverage for SHOW WARNINGS LIMIT a, b;
      
      
      mysql-test/r/warnings.result:
        Add test coverage for SHOW WARNINGS LIMIT a,b
      mysql-test/t/warnings.test:
        Add test coverage for SHOW WARNINGS LIMIT a,b
      sql/sql_error.cc:
        Fix show warnings limit 0 and show warnings limit 0, 0
      0d3de54b
    • unknown's avatar
      BUG#10948 NDB Replication: Race condition with ALTER/DROP table · c980a157
      unknown authored
      BUG#9826  Server crash on schema change ("drop table", "alter table") with NDB
      
      See note on 10948 for detailed explanation.
      
      struct a { void* a; long long b[1]; };
      
      on PPC32 (and 32bit pa risc): 16
      on x86: 12
      
      so a malloc(sizeof(void*)+extra_bits) is wrong.
      
      Assuming that the long long is 64 bit aligned as non-aligned 64bit accesses
      are rather expensive on ppc.
      
      Thanks to paulus for doing the PPC port of valgrind.
      Without which I would no doubt still be trying to find this.
      
      
      ndb/src/ndbapi/DictCache.cpp:
        Fix allocation size for Ndb_local_table_info for architectures such as PPC and PA-RISC (32bit)
        where
        struct a { void* a; long long b;};
        is 64 bit aligned (i.e. sizeof(struct a)==16)
      ndb/src/ndbapi/DictCache.hpp:
        Add warning about having to be the last member in the structure
      c980a157
    • unknown's avatar
      mergemerged · f853e971
      unknown authored
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      f853e971
    • unknown's avatar
      after mergemerge · 785d3599
      unknown authored
      785d3599
  5. 03 Jun, 2005 12 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 016a26bc
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      016a26bc
    • unknown's avatar
      Move USE_PRAGMA_IMPLEMENTATION to proper place · 90931c2e
      unknown authored
      Ensure that 'null_value' is not accessed before val() is called in FIELD() functions
      Fixed initialization of key maps. This fixes some problems with keys when you have more than 64 keys
      Fixed that ROLLUP don't always create a temporary table. This fix ensures that func_gconcat.test results are now predictable
      
      
      mysql-test/r/func_gconcat.result:
        Move innodb specific test to innodb.test
        Changed table name r2 -> t2
        More test to see how ROLLUP was optimized
      mysql-test/r/innodb.result:
        Moved test here form func_gconcat
      mysql-test/r/olap.result:
        New test results after optimization
      mysql-test/t/func_gconcat.test:
        Move innodb specific test to innodb.test
        Changed table name r2 -> t2
        More test to see how ROLLUP was optimized
      mysql-test/t/innodb.test:
        Moved test here form func_gconcat
      sql/field.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_berkeley.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_blackhole.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_heap.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_innodb.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_isam.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_isammrg.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_myisam.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_myisammrg.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_ndbcluster.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/handler.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/hash_filo.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_cmpfunc.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_func.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
        Ensure that 'null_value' is not accessed before val() is called
      sql/item_geofunc.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_strfunc.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_subselect.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_sum.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_timefunc.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_uniq.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/log_event.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/mysql_priv.h:
        Change key_map_full to not be const as we are giving it a proper value on startup
      sql/mysqld.cc:
        Move key_map variables here and initialize key_map_full properly
      sql/opt_range.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/opt_range.h:
        Fix that test_quick_select() works with any ammount of keys
      sql/procedure.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/protocol.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/protocol_cursor.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/set_var.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_analyse.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_class.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_crypt.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_insert.cc:
        Fixed that max_rows is ulong
      sql/sql_list.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_map.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_olap.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_select.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
        Fixed that ROLLUP don't have to always create a temporary table
        Added new argument to remove_const() to make above possible
        Fixed some errors that creapt up when we don't always do a temporary table for ROLLUP
      sql/sql_string.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_table.cc:
        Simple optimizations
        Fixed wrong checking of build_table_path() in undef-ed code
      sql/sql_udf.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_yacc.yy:
        removed extra {}
      90931c2e
    • unknown's avatar
      mergemerged · d8947762
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      configure.in:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql/lock.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_handler.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      d8947762
    • unknown's avatar
      after merge fixes · d7946bb3
      unknown authored
      d7946bb3
    • unknown's avatar
      merged · 2826245b
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      configure.in:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql/lock.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_handler.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      mysql-test/r/create.result:
        merged, need fixing
      sql/sql_parse.cc:
        merged (perhaps wrong)
      2826245b
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.0/ · cf0f4a63
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.0
      
      cf0f4a63
    • unknown's avatar
      *don't* mess with kernel defines, boy. · 54f236d6
      unknown authored
      and HAVE_ATOMIC_ADD/HAVE_ATOMIC_SUB is tested in configure
      
      54f236d6
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 23093b08
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      23093b08
    • unknown's avatar
      check-cpu fixes/improvements (Bug #11065) · 4e56fcb2
      unknown authored
          
          - support additional platforms (OpenBSD, Darwin)
          - make use of /proc/cpuinfo CPU flag information
            (needed to distinguish EMT64 Xeons from normal ones)
          - chose the right CPU related options depending on 
            GCC version and target architecture
          - check if the chosen CPU type is actually supported
            by the GCC version , fallback to CPUs predecessor
            until test compile succeeds
      
      4e56fcb2
    • unknown's avatar
      sql_repl.cc: · 28c58b05
      unknown authored
        Bug #11064  	some read error not detected in replication on 64-bit platform
      
      
      sql/sql_repl.cc:
        Bug #11064  	some read error not detected in replication on 64-bit platform
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      28c58b05
    • unknown's avatar
      bundle the check-cpu helper script with source packages. · c8c71714
      unknown authored
      BUG#10696
      
      c8c71714
    • unknown's avatar
      ctype_utf8.result, ctype_utf8.test: · d89397a8
      unknown authored
        adding test
      field.cc:
        bug#10714 Inserting double value into utf8 column crashes server:
        sprintf was executed with too big length, which caused
        crash on some Windows platforms.
      
      
      sql/field.cc:
        bug#10714 Inserting double value into utf8 column crashes server
        sprintf was executed with too long length, which cau
        crashe on Windows.
      mysql-test/t/ctype_utf8.test:
        adding test
      mysql-test/r/ctype_utf8.result:
        adding test
      d89397a8
  6. 02 Jun, 2005 11 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · b9c5554b
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      
      sql/sql_parse.cc:
        Auto merged
      b9c5554b
    • unknown's avatar
      Removed duplicated and wrong merged code · 165f04cb
      unknown authored
      
      sql/sql_base.cc:
        Fixed wrong comment
      165f04cb
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · a370d165
      unknown authored
      into dl145b.mysql.com:/home/ndbdev/tomas/tmp
      
      a370d165
    • unknown's avatar
      CommandInterpreter.cpp: · 5eb57650
      unknown authored
        Bug #11050  	ndb_mgm "show" prints incorrectly after master data node fails
      
      
      ndb/src/mgmclient/CommandInterpreter.cpp:
        Bug #11050  	ndb_mgm "show" prints incorrectly after master data node fails
      5eb57650
    • unknown's avatar
      fixed compile problem by replacing W_OK with F_OK · 1887e42d
      unknown authored
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      1887e42d
    • unknown's avatar
      item_func.cc: · 2bf8c6c9
      unknown authored
      set_var.cc:
      variables.result
      variables.test
      
        Bug #10904 Illegal mix of collations between a system variable and a constant
        Changing coercibility of system variables to SYSCONST,
        to be the same with USER(), DATABASE(), etc.
      
      
      sql/item_func.cc:
        Bug #10904 Illegal mix of collations between a system variable and a constant
        Changing coercibility of system variables to SYSCONST
        To be the same with USER(), DATABASE(), etc.
      2bf8c6c9
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.1 · 1968e8ee
      unknown authored
      into mysql.com:/home/mydev/mysql-4.1-4100
      
      1968e8ee
    • unknown's avatar
      Merge · aefdd29e
      unknown authored
      
      sql/ha_heap.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/examples/ha_archive.cc:
        Auto merged
      sql/examples/ha_example.cc:
        Auto merged
      sql/examples/ha_tina.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_repl.cc:
        SCCS merged
      aefdd29e
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · dede1d4c
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1
      
      
      sql/item_func.cc:
        Auto merged
      dede1d4c
    • unknown's avatar
      tztime.cc: · 504d71aa
      unknown authored
        Set #pragma implementation" earlier
      Many files:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      
      
      client/sql_string.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      mysys/raid.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/field.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/ha_berkeley.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/ha_blackhole.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/ha_heap.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/ha_innodb.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/ha_isam.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/ha_isammrg.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/ha_myisam.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/ha_myisammrg.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/ha_ndbcluster.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/handler.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/hash_filo.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/item.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/item_cmpfunc.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/item_func.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/item_geofunc.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/item_strfunc.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/item_subselect.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/item_sum.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/item_timefunc.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/item_uniq.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/log_event.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/opt_range.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/procedure.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/protocol.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/protocol_cursor.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/set_var.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/sql_analyse.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/sql_class.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/sql_crypt.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/sql_list.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/sql_map.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/sql_olap.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/examples/ha_archive.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/sql_select.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/sql_string.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/sql_udf.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/examples/ha_example.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/examples/ha_tina.cc:
        Need to include <my_global.h> before #ifdef USE_PRAGMA_IMPLEMENTATION
      sql/tztime.cc:
        Set #pragma implementation" earlier
      504d71aa
    • unknown's avatar
      Mainly cleanups for gcc 4.0. Some small pieces from looking at -Wall. Removed... · 7566990d
      unknown authored
      Mainly cleanups for gcc 4.0. Some small pieces from looking at -Wall. Removed a number of dumb things in ha_tina.
      
      
      client/mysqladmin.cc:
        gcc 4.0 fix
      sql/examples/ha_archive.cc:
        Bunch of little cleanups from -Wall and gcc 4.0 fixes
      sql/examples/ha_example.cc:
        Noticed that the error call was not quite right.
      sql/examples/ha_tina.cc:
        Bunch of cleanups (many of which were quite dumb of me... and I have no earthly idea how they missed everyone's notice).
      sql/ha_heap.cc:
        Removed unused variable (-Wall find)
      sql/item_subselect.cc:
        Removed unused label.
      sql/mysqld.cc:
        Cleanup of unused function and gcc 4.0 bit.
      sql/opt_range.h:
        Cleanup for gcc 4.0
      sql/repl_failsafe.cc:
        Cleanup for gcc 4.0
      sql/slave.cc:
        Cleanup for gcc 4.0
      sql/sql_acl.cc:
        Cleanup for gcc 4.0
      sql/sql_insert.cc:
        Cleanedup for gcc 4.0
      sql/sql_parse.cc:
        Cleanedup for gcc 4.0
      sql/sql_repl.cc:
        Removed unused variable
      sql/sql_select.cc:
        Cleanedup for gcc 4.0
      7566990d
  7. 01 Jun, 2005 6 commits