1. 08 Jun, 2005 1 commit
    • unknown's avatar
      bug#11166 - ndb · 30e72968
      unknown authored
        Fix potential inconsistency when running ndb_restore due to faulty parsing
          of backup log wrt inserts
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Make sure that entire stopGCP is in log
      ndb/tools/restore/Restore.cpp:
        
          Notice: this will not group and commit the deltas listed below
          into a ChangeSet, because there are no ChangeSet comments.
          Click [Checkin] again to check in only the commented deltas,
          or type Control-l to go back and provide ChangeSet comments.
      ndb/tools/restore/Restore.hpp:
        Keep track of last gci to next iteration
      ndb/tools/restore/consumer_restore.cpp:
        Handle insert in log
        Only allow certain errors
      30e72968
  2. 07 Jun, 2005 13 commits
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-4.1 · 13a8ac5d
      unknown authored
      into mysql.com:/home/jonas/src/mysql-4.1
      
      13a8ac5d
    • unknown's avatar
      bug#11133 - ndb · 4771d371
      unknown authored
        incorrect handling of writeTuple with multi op transaction
      
      
      ndb/src/kernel/blocks/dbacc/DbaccMain.cpp:
        1) Pass operation instead of insertIsDone to LQH
        2) transform operation correctly when in parallell que
           (multi op within same trans)
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Let ACC decide what operation was performed when WRITE
      ndb/test/ndbapi/testNdbApi.cpp:
        Add testcase for bug 11133
      ndb/test/run-test/daily-basic-tests.txt:
        Add testcase for bug 11133
      4771d371
    • unknown's avatar
      item_buff.cc: · 43b51a98
      unknown authored
        Removed an extra space char.
      
      
      sql/item_buff.cc:
        Removed an extra space char.
      43b51a98
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-4.1 · 1c0b3b65
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-4.1-0
      
      1c0b3b65
    • unknown's avatar
      sql_select.cc, item_buff.cc, item.h: · 931e78ec
      unknown authored
        Fixed bug #11088: a crash for queries with GROUP BY a BLOB column
        + COUNT(DISTINCT...) due to an attempt to allocate a too large
        buffer for the BLOB field.
        Now the size of the buffer is limited by max_sort_length.
      group_by.test, group_by.result:
        Added a test case for bug #11088.
      
      
      mysql-test/r/group_by.result:
        Added a test case for bug #11088.
      mysql-test/t/group_by.test:
        Added a test case for bug #11088.
      sql/item.h:
        Fixed bug #11088: a crash for queries with GROUP BY a BLOB column
        + COUNT(DISTINCT...) due to an attempt to allocate a too large
        buffer for the BLOB fields.
        Now the size of the buffer is limited by max_sort_length.
      sql/item_buff.cc:
        Fixed bug #11088: a crash for queries with GROUP BY a BLOB column
        + COUNT(DISTINCT...) due to an attempt to allocate a too large
        buffer for the BLOB fields.
        Now the size of the buffer is limited by max_sort_length.
      sql/sql_select.cc:
        Fixed bug #11088: a crash for queries with GROUP BY a BLOB column
        + COUNT(DISTINCT...) due to an attempt to allocate a too large
        buffer for the BLOB fields.
        Now the size of the buffer is limited by max_sort_length.
      931e78ec
    • unknown's avatar
      Merge lgrimmer@bk-internal.mysql.com:/home/bk/mysql-4.1 · 1fd1fbc6
      unknown authored
      into mysql.com:/space/my/mysql-4.1
      
      1fd1fbc6
    • unknown's avatar
      Merge mysql.com:/Users/emurphy/src/bk-clean/mysql-4.1 · 125970ea
      unknown authored
      into  mysql.com:/Users/emurphy/src/work/mysql-4.1
      
      125970ea
    • unknown's avatar
      Accepted openlogging · 6c0f1351
      unknown authored
      6c0f1351
    • unknown's avatar
      Merge mysql.com:/space/my/mysql-4.1 · b251f84f
      unknown authored
      into mysql.com:/space/my/mysql-4.1-build
      
      b251f84f
    • unknown's avatar
      Bug#10253: compound index length and utf8 char set · 309ed4c5
      unknown authored
      produces invalid query results
      
      mi_key.c:
        well_formed_length should be executed before space trimming, not after.
      ctype_utf8.test:
      ctype_utf8.result:
        adding test.
      
      
      myisam/mi_key.c:
        Bug#10253: ompound index length and utf8 char set produces invalid query results
        well_formed_length should be executed before space trimming, not after.
      mysql-test/r/ctype_utf8.result:
        adding test.
        adding test.
      mysql-test/t/ctype_utf8.test:
        adding test.
      309ed4c5
    • unknown's avatar
      - BUG#10676: don't install "make_win_src_distribution" and "make_win_binary_distribution" · 420a1b5d
      unknown authored
        when doing "make install" (they are not needed/useful) outside the build tree. Added
        "mysql_client_test" to the "MySQL-bench" RPM.
      - some small RPM spec file improvements (more variables than hard-coded values, cleanups)
      
      
      scripts/Makefile.am:
        - no need to install "make_win_src_distribution" and "make_win_binary_distribution"
          in "make install" (BUG#10676)
      support-files/mysql.spec.sh:
        - added mysql_client_test to the "bench" subpackage (BUG 10676)
        - use "mysqldatadir" variable instead of hard-coding the path multiple times
        - use the "mysqld_user" variable on all occasions a user name is referenced
        - removed (incomplete) Brazilian translations
        - removed redundant release tags from the subpackage descriptions
      420a1b5d
    • unknown's avatar
      Merge ssmith@bk-internal.mysql.com:/home/bk/mysql-4.1 · e2b6613a
      unknown authored
      into mysql.com:/home/stewart/Documents/MySQL/4.1/main
      
      e2b6613a
    • unknown's avatar
      BUG#7967 Fix mysqlhotcopy --record-log-position · 72192c2a
      unknown authored
      
      BitKeeper/etc/ignore:
        Added scripts/mysqlhotcopy.sh.rej to the ignore list
      scripts/mysqlhotcopy.sh:
        BUG#7967 Use fetchrow_hashref() when parsing SHOW SLAVE STATUS so
        that --record-log-pos option will work with all versions from 3.23
        forward and will not break again in the future if additional columns
        are added.
      72192c2a
  3. 06 Jun, 2005 3 commits
  4. 05 Jun, 2005 2 commits
    • unknown's avatar
      mtr_misc.pl, mtr_report.pl: · c95d6b66
      unknown authored
        Try kill all children to the mysql-test-run process when exiting
      mtr_process.pl:
        Added new function mtr_exit() that try kill all children to the mysql-test-run process when exiting
      mysql-test-run.pl:
        Try kill all children to the mysql-test-run process when exiting
        New --vardir caused problems on Windows
        Changed faulty calls to error() to mtr_error()
      
      
      mysql-test/mysql-test-run.pl:
        Try kill all children to the mysql-test-run process when exiting
        New --vardir caused problems on Windows
        Changed faulty calls to error() to mtr_error()
      mysql-test/lib/mtr_report.pl:
        Try kill all children to the mysql-test-run process when exiting
      mysql-test/lib/mtr_process.pl:
        Added new function mtr_exit() that try kill all children to the mysql-test-run process when exiting
      mysql-test/lib/mtr_misc.pl:
        Try kill all children to the mysql-test-run process when exiting
      c95d6b66
    • unknown's avatar
      a compiler must see '#pragma implementation' *before* · 7ceda6b2
      unknown authored
      '#pragma interface' (that comes with the #include'd header file)
      
      7ceda6b2
  5. 04 Jun, 2005 4 commits
    • unknown's avatar
      Fix show warnings limit 0 and show warnings limit 0, 0. · 0d3de54b
      unknown authored
      Add test coverage for SHOW WARNINGS LIMIT a, b;
      
      
      mysql-test/r/warnings.result:
        Add test coverage for SHOW WARNINGS LIMIT a,b
      mysql-test/t/warnings.test:
        Add test coverage for SHOW WARNINGS LIMIT a,b
      sql/sql_error.cc:
        Fix show warnings limit 0 and show warnings limit 0, 0
      0d3de54b
    • unknown's avatar
      BUG#10948 NDB Replication: Race condition with ALTER/DROP table · c980a157
      unknown authored
      BUG#9826  Server crash on schema change ("drop table", "alter table") with NDB
      
      See note on 10948 for detailed explanation.
      
      struct a { void* a; long long b[1]; };
      
      on PPC32 (and 32bit pa risc): 16
      on x86: 12
      
      so a malloc(sizeof(void*)+extra_bits) is wrong.
      
      Assuming that the long long is 64 bit aligned as non-aligned 64bit accesses
      are rather expensive on ppc.
      
      Thanks to paulus for doing the PPC port of valgrind.
      Without which I would no doubt still be trying to find this.
      
      
      ndb/src/ndbapi/DictCache.cpp:
        Fix allocation size for Ndb_local_table_info for architectures such as PPC and PA-RISC (32bit)
        where
        struct a { void* a; long long b;};
        is 64 bit aligned (i.e. sizeof(struct a)==16)
      ndb/src/ndbapi/DictCache.hpp:
        Add warning about having to be the last member in the structure
      c980a157
    • unknown's avatar
      mergemerged · f853e971
      unknown authored
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      f853e971
    • unknown's avatar
      after mergemerge · 785d3599
      unknown authored
      785d3599
  6. 03 Jun, 2005 12 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 016a26bc
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      016a26bc
    • unknown's avatar
      Move USE_PRAGMA_IMPLEMENTATION to proper place · 90931c2e
      unknown authored
      Ensure that 'null_value' is not accessed before val() is called in FIELD() functions
      Fixed initialization of key maps. This fixes some problems with keys when you have more than 64 keys
      Fixed that ROLLUP don't always create a temporary table. This fix ensures that func_gconcat.test results are now predictable
      
      
      mysql-test/r/func_gconcat.result:
        Move innodb specific test to innodb.test
        Changed table name r2 -> t2
        More test to see how ROLLUP was optimized
      mysql-test/r/innodb.result:
        Moved test here form func_gconcat
      mysql-test/r/olap.result:
        New test results after optimization
      mysql-test/t/func_gconcat.test:
        Move innodb specific test to innodb.test
        Changed table name r2 -> t2
        More test to see how ROLLUP was optimized
      mysql-test/t/innodb.test:
        Moved test here form func_gconcat
      sql/field.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_berkeley.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_blackhole.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_heap.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_innodb.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_isam.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_isammrg.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_myisam.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_myisammrg.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_ndbcluster.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/handler.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/hash_filo.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_cmpfunc.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_func.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
        Ensure that 'null_value' is not accessed before val() is called
      sql/item_geofunc.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_strfunc.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_subselect.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_sum.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_timefunc.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_uniq.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/log_event.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/mysql_priv.h:
        Change key_map_full to not be const as we are giving it a proper value on startup
      sql/mysqld.cc:
        Move key_map variables here and initialize key_map_full properly
      sql/opt_range.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/opt_range.h:
        Fix that test_quick_select() works with any ammount of keys
      sql/procedure.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/protocol.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/protocol_cursor.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/set_var.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_analyse.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_class.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_crypt.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_insert.cc:
        Fixed that max_rows is ulong
      sql/sql_list.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_map.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_olap.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_select.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
        Fixed that ROLLUP don't have to always create a temporary table
        Added new argument to remove_const() to make above possible
        Fixed some errors that creapt up when we don't always do a temporary table for ROLLUP
      sql/sql_string.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_table.cc:
        Simple optimizations
        Fixed wrong checking of build_table_path() in undef-ed code
      sql/sql_udf.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_yacc.yy:
        removed extra {}
      90931c2e
    • unknown's avatar
      mergemerged · d8947762
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      configure.in:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql/lock.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_handler.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      d8947762
    • unknown's avatar
      after merge fixes · d7946bb3
      unknown authored
      d7946bb3
    • unknown's avatar
      merged · 2826245b
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      configure.in:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql/lock.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_handler.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      mysql-test/r/create.result:
        merged, need fixing
      sql/sql_parse.cc:
        merged (perhaps wrong)
      2826245b
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.0/ · cf0f4a63
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.0
      
      cf0f4a63
    • unknown's avatar
      *don't* mess with kernel defines, boy. · 54f236d6
      unknown authored
      and HAVE_ATOMIC_ADD/HAVE_ATOMIC_SUB is tested in configure
      
      54f236d6
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 23093b08
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      23093b08
    • unknown's avatar
      check-cpu fixes/improvements (Bug #11065) · 4e56fcb2
      unknown authored
          
          - support additional platforms (OpenBSD, Darwin)
          - make use of /proc/cpuinfo CPU flag information
            (needed to distinguish EMT64 Xeons from normal ones)
          - chose the right CPU related options depending on 
            GCC version and target architecture
          - check if the chosen CPU type is actually supported
            by the GCC version , fallback to CPUs predecessor
            until test compile succeeds
      
      4e56fcb2
    • unknown's avatar
      sql_repl.cc: · 28c58b05
      unknown authored
        Bug #11064  	some read error not detected in replication on 64-bit platform
      
      
      sql/sql_repl.cc:
        Bug #11064  	some read error not detected in replication on 64-bit platform
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      28c58b05
    • unknown's avatar
      bundle the check-cpu helper script with source packages. · c8c71714
      unknown authored
      BUG#10696
      
      c8c71714
    • unknown's avatar
      ctype_utf8.result, ctype_utf8.test: · d89397a8
      unknown authored
        adding test
      field.cc:
        bug#10714 Inserting double value into utf8 column crashes server:
        sprintf was executed with too big length, which caused
        crash on some Windows platforms.
      
      
      sql/field.cc:
        bug#10714 Inserting double value into utf8 column crashes server
        sprintf was executed with too long length, which cau
        crashe on Windows.
      mysql-test/t/ctype_utf8.test:
        adding test
      mysql-test/r/ctype_utf8.result:
        adding test
      d89397a8
  7. 02 Jun, 2005 5 commits