1. 19 Mar, 2018 3 commits
  2. 16 Mar, 2018 4 commits
  3. 15 Mar, 2018 15 commits
  4. 14 Mar, 2018 5 commits
  5. 13 Mar, 2018 3 commits
    • Daniele Sciascia's avatar
      MDEV-13549 Fix and re-enable MTR test galera.MW-366 · 9953588a
      Daniele Sciascia authored
      Test galera.MW-366 is not deterministic and depends on timing assumptions.
      The test occasionally fails after checking the number of 'system user'
      processes in processlist after changing the value of variable global
      wsrep_slave_threads, like this:
      ```
      SET GLOBAL wsrep_slave_threads = x;
      --sleep 0.5
      SELECT COUNT(*) = x FROM INFORMATION_SCHEMA.PROCESSLIST WHERE USER = 'system user';
      ```
      
      The problem is that the number of slave threads is internally adjusted
      'asynchronously', and it may take some time to spawn/kill new threads,
      especially in a heavily loaded system.
      
      This patch removes the '--sleep 0.5' statements from the test and replaces
      those with appropriate wait conditions, like this:
      ```
      SET GLOBAL wsrep_slave_threads = x;
      let $wait_condition = SLECT COUNT(*) = x FROM ...;
      --source include/wait_condition.inc
      ```
      9953588a
    • Daniele Sciascia's avatar
      MDEV-13549 Fix for test galera.galera_var_max_ws_rows · 9ee39d2b
      Daniele Sciascia authored
      This patch re-enables test galera.galera_var_max_ws_rows.
      The test did not work because there were two distinct places where
      the server was incrementing member THD::wsrep_affected_rows before
      enforcing wsrep_max_ws_rows. Essentially, the test would fail because
      every inserted row was counted twice.
      The patch removes the extra code.
      9ee39d2b
    • Alexander Barkov's avatar
  6. 12 Mar, 2018 6 commits
  7. 11 Mar, 2018 1 commit
  8. 09 Mar, 2018 2 commits
  9. 08 Mar, 2018 1 commit
    • Daniele Sciascia's avatar
      MDEV-13549 Wrong usage of mutex 'LOCK_wsrep_thd' and 'LOCK_thd_kill' test galera.MW-286 · a3ba3aab
      Daniele Sciascia authored
      Test MW-286 occasionally failed with error the following message:
      
      ```
      safe_mutex: Found wrong usage of mutex 'LOCK_wsrep_thd' and 'LOCK_thd_kill'
      Mutex currently locked (in reverse order):
      LOCK_thd_kill                     mariadb-server/sql/sql_class.h  line 3535
      LOCK_wsrep_thd                    mariadb-server/sql/wsrep_thd.cc  line 88
      ```
      
      The fix consists in calling thd->reset_killed() in wsrep_mysql_parse() after
      LOCK_wsrep_thd is unlocked. Which avoids the taking locks LOCK_wsrep_thd and
      LOCK_thd_kill in reverse order.
      a3ba3aab