- 13 Feb, 2017 3 commits
-
-
Marko Mäkelä authored
log_crypt_101_read_checkpoint(): Read the encryption information from a MariaDB 10.1 checkpoint page. log_crypt_101_read_block(): Attempt to decrypt a MariaDB 10.1 redo log page. recv_log_format_0_recover(): Only attempt decryption on checksum mismatch. NOTE: With the MariaDB 10.1 innodb_encrypt_log format, we can actually determine from the cleartext portion of the redo log whether the redo log is empty. We do not really have to decrypt the redo log here, if we did not want to determine if the checksum is valid.
-
Marko Mäkelä authored
We can use log_sys->buf instead of recv_sys->last_block during crash recovery. Remove the redundant buffer.
-
Marko Mäkelä authored
innodb_shutdown(), trx_sys_close(): Startup may be aborted between purge_sys and trx_sys creation. Therefore, purge_sys must be freed independently of trx_sys. innobase_start_or_create_for_mysql(): Remember to free purge_queue if it was not yet attached to purge_sys.
-
- 12 Feb, 2017 1 commit
-
-
Igor Babaev authored
These are different bugs, but the fixing code is the same: if window functions are used over implicit grouping then now the execution should follow the general path calling the function set in JOIN::first_select.
-
- 11 Feb, 2017 3 commits
-
-
Nirbhay Choubey authored
-
Sergei Golubchik authored
-
Igor Babaev authored
Corrected an assertion in JOIN::create_postjoin_aggr_table(): JOIN::join_tab[0] can be the first aggregation table if the query uses window functions.
-
- 10 Feb, 2017 18 commits
-
-
Sergei Golubchik authored
-
Vladislav Vaintroub authored
main thread may destroy mutexes that bootstrap is using in THD destructor.
-
Nirbhay Choubey authored
-
Elena Stepanova authored
-
Nirbhay Choubey authored
Print the message as a note instead of warning.
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
New default sql_mode includes: * STRICT_TRANS_TABLES * ERROR_FOR_DIVISION_BY_ZERO * NO_ENGINE_SUBSTITUTION * NO_AUTO_CREATE_USER
-
Nirbhay Choubey authored
The supplied sql_mode(s) should be converted to ASCII first, before comparing it with the sql_mode set.
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
innodb_autoinc_lock_mode = 2 innodb_buffer_pool_dump_at_shutdown = ON innodb_buffer_pool_dump_pct = 25 innodb_buffer_pool_load_at_startup = ON innodb_checksum_algorithm = CRC32 innodb_file_format = Barracuda innodb_large_prefix = ON innodb_log_compressed_pages = ON innodb_purge_threads = 4 innodb_strict_mode = ON binlog_annotate_row_events = ON binlog_format = MIXED binlog-row-event-max-size = 8192 group_concat_max_len = 1M lock_wait_timeout = 86400 log_slow_admin_statements = ON log_slow_slave_statements = ON log_warnings = 2 max_allowed_packet = 16M replicate_annotate_row_events = ON slave_net_timeout = 60 sync_binlog = 1 aria_recover = BACKUP,QUICK myisam_recover_options = BACKUP,QUICK
-
Nirbhay Choubey authored
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
MDEV-10554: Assertion `!derived->first_select()->exclude_from_table_unique_test || derived->outer_select()-> exclude_from_table_unique_test' failed in TABLE_LIST::set_check_merged() Mark and check excluded because of merging derived tables and views.
-
Oleksandr Byelkin authored
-
Igor Babaev authored
Due to this bug many queries that contained a window function with MIN/MAX aggregation returned wrong results. Calculation of a MIN/MAX aggregate function uses cache objects and a comparator object that are created and set up in Item_sum_hybrid::fix_fields () by a call of Item_sum_hybrid::setup_hybrid(). The latter binds the objects to the first argument of the MIN/MAX function. Meanwhile window function perform aggregation over fields of a temporary table. So binding must be done rather to these fields. The earliest moment when setup the objects used in MIN/max functions can be done is after all calls of the method split_sum_func(). This patch introduces this late setup, but only for aggregate functions used in window functions. Probably it makes sense to use this late setup for all MIN/MAX objects.
-
- 09 Feb, 2017 8 commits
-
-
Alexey Botchkov authored
Test fixed.
-
Alexey Botchkov authored
Fix json_merge implementation.
-
Alexey Botchkov authored
Test result updated.
-
Marko Mäkelä authored
This is follow-up to commit 1293e5e5.
-
Sergei Golubchik authored
in Item_partition_func_safe_string(THD *thd, const char *name_arg, uint length, CHARSET_INFO *cs= NULL), the 'name_arg' is the value of the string constant and 'length' is the length of this constant, so length == strlen(name_arg).
-
Marko Mäkelä authored
-
Alexey Botchkov authored
We should be ready for an empty key.
-
Marko Mäkelä authored
A proper InnoDB shutdown after aborted startup was introduced in commit 81b7fe9d. Also related to this is MDEV-11985, making read-only shutdown more robust. If startup was aborted, there may exist recovered transactions that were not rolled back. Relax the assertions accordingly.
-
- 08 Feb, 2017 7 commits
-
-
Marko Mäkelä authored
recv_writer_thread(): Do not assign recv_writer_thread_active=true in order to avoid a race condition with recv_recovery_from_checkpoint_finish(). recv_init_crash_recovery_spaces(): Assign recv_writer_thread_active=true before creating recv_writer_thread.
-
Vladislav Vaintroub authored
This is an attempt to workaround buildbot "1200 seconds without output, killing process"
-
Marko Mäkelä authored
Before killing the server, ensure that the redo log for the incomplete transaction is flushed, so that the AUTO_INCREMENT sequence will always be updated. Usually the INSERT transaction would not have persisted the sequence before the server was killed, but sometimes it could happen, causing result mismatch. Note: This test used to be called innodb_fts.innodb_fts_misc_debug.
-
Marko Mäkelä authored
Do not effectively set DEBUG_DBUG='d' by setting DEBUG_DBUG='-d,...'. Instead, restore the saved value of DEBUG_DBUG. Also, split the test innodb_fts.innodb_fts_misc_debug into innodb_fts.crash_recovery and innodb_fts.misc_debug, and enable these tests for --valgrind, the latter test for --embedded, and the former tests for the non-debug server.
-
Oleksandr Byelkin authored
MDEV-11681: PARTITION BY LIST COLUMNS with default partition: Assertion `part_info->num_list_values' failed in get_part_iter_for_interval_cols_via_map process adge case with only default partition
-
Jan Lindström authored
Encryption stores used key_version to FIL_PAGE_FILE_FLUSH_LSN_OR_KEY_VERSION (offset 26) field. Spatial indexes store RTREE Split Sequence Number (FIL_RTREE_SPLIT_SEQ_NUM) in the same field. Both values can't be stored in same field. Thus, current encryption implementation does not support encrypting spatial indexes. fil_space_encrypt(): Do not encrypt page if page type is FIL_PAGE_RTREE (this is required for background encryption innodb-encrypt-tables=ON). create_table_info_t::check_table_options() Do not allow creating table with ENCRYPTED=YES if table contains spatial index.
-
Alexander Barkov authored
-