1. 26 Feb, 2008 11 commits
    • unknown's avatar
      Merge quad.:/mnt/raid/alik/MySQL/devel/5.1 · 336f2c7e
      unknown authored
      into  quad.:/mnt/raid/alik/MySQL/devel/5.1-rt-merged
      
      
      client/mysqltest.c:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/ha_ndbcluster_binlog.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_connect.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Manually merged.
      mysql-test/t/disabled.def:
        Manually merged.
      336f2c7e
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/bugs/34424-5.1 · fb3f8bdb
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-runtime
      
      
      fb3f8bdb
    • unknown's avatar
      Fix the remaining memory leaks (mysql_client_test). · 2aa0927d
      unknown authored
      
      tests/mysql_client_test.c:
        Fix the remaining memory leaks.
      2aa0927d
    • unknown's avatar
      Bug#34424 query_cache_debug.test leads to valgrind warnings · bf9bb656
      unknown authored
      Bug#34678 @@debug variable's incremental mode
      
      The problem is that the per-thread debugging settings stack wasn't
      being deallocated before the thread termination, leaking the stack
      memory. The chosen solution is to push a new state if the current
      is set to the initial settings and pop it (free) once the thread
      finishes.
      
      
      dbug/dbug.c:
        Move dbug parser out of _db_set_ to a separate function and
        make _db_set_ push a new stack if the corrent one is set to
        the initial settings.
      dbug/user.r:
        Update DBUG_SET description.
      mysql-test/t/disabled.def:
        Re-enable test case which triggered the leak.
      mysys/my_thr_init.c:
        Pop a pushed state, nop if stack is empty.
      sql/set_var.cc:
        Handle incremental debug settings.
      mysql-test/r/variables_debug.result:
        Add new test case result for Bug#34678
      mysql-test/t/variables_debug.test:
        Add new test case for Bug#34678
      bf9bb656
    • unknown's avatar
      Valgrind errors in mysql_client_test. · 6b9db6d2
      unknown authored
      
      tests/mysql_client_test.c:
        Fix a memory leak.
        Run the test for Bug#28386 only if logging to tables is enabled.
      6b9db6d2
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 0a1c0059
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.1-runtime
      
      
      0a1c0059
    • unknown's avatar
      We never check the return value of mysql_frm_type for an error. Do · 226e6821
      unknown authored
      not try to push an error into the error stack as it will be ignored anyway.
      
      
      226e6821
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · fd317533
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-runtime
      
      
      tests/mysql_client_test.c:
        Auto merged
      fd317533
    • unknown's avatar
      Merge dipika.(none):/opt/local/work/mysql-5.0-runtime · 1f3c1706
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.1-runtime
      
      
      tests/mysql_client_test.c:
        Manual merge.
      1f3c1706
    • unknown's avatar
      Fix memory leaks (valgrind) · 24039016
      unknown authored
      24039016
    • unknown's avatar
      Use an API instead of looking into stmt internals to fetch fields · 2967e4e1
      unknown authored
      (Test for Bug#32265)
      
      
      tests/mysql_client_test.c:
        Use an API instead of looking into stmt internals to fetch fields.
      2967e4e1
  2. 25 Feb, 2008 1 commit
    • unknown's avatar
      Bug#28386 the general log is incomplete · b2e879cb
      unknown authored
      The problem is that the commands COM_STMT_CLOSE, COM_STMT_RESET,
      COM_STMT_SEND_LONG_DATA weren't being logged to the general log.
      
      The solution is to log the general log the aforementioned commands.
      
      
      mysql-test/t/mysql_client_test-master.opt:
        Also log to table.
      sql/sql_prepare.cc:
        Log COM_STMT_CLOSE, COM_STMT_RESET and COM_STMT_SEND_LONG_DATA.
      tests/mysql_client_test.c:
        Add test case for Bug#28386
      b2e879cb
  3. 23 Feb, 2008 2 commits
  4. 22 Feb, 2008 26 commits
    • unknown's avatar
      Bug #34053: normal users can enable innodb_monitor logging · 482d6008
      unknown authored
      The check_global_access() function was made available to InnoDB, but
      was not defined in the embedded server library.  InnoDB, as a plugin,
      is not recompiled when the embedded server is built.  This caused a
      link failure when compiling applications which use the embedded server.
      
      The fix here is to always define check_global_access() externally; in
      the embedded server case, it is defined to just return OK.
      
      Also, don't run the test case for this bug in embedded server.
      
      
      mysql-test/t/innodb_bug34053.test:
        Disable this test on embedded server - it tests privilege
        checks which are not in place there.
      sql/mysql_priv.h:
        Since check_global_access() may be used from some storage engine plugins
        (InnoDB, currently), and the plugins are not recompiled for the embedded
        server, it must be defined externally even for NO_EMBEDDED_ACCESS_CHECKS.
      sql/sql_parse.cc:
        Since check_global_access() may be used from some storage engine plugins
        (InnoDB, currently), and the plugins are not recompiled for the embedded
        server, it must be defined externally even for NO_EMBEDDED_ACCESS_CHECKS.
      482d6008
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-build · d7cf77ee
      unknown authored
      into  hh-nb.hungers:/work/trees/mysql-5.1-build-src-clean
      
      
      d7cf77ee
    • unknown's avatar
      Merge hh-nb.hungers:/work/trees/mysql-5.1-build-src-clean · aa8a5539
      unknown authored
      into  hh-nb.hungers:/work/merge/mysql-5.1-build
      
      
      aa8a5539
    • unknown's avatar
      Inserted changes from the review of bug#32664. · ca508c8f
      unknown authored
      ca508c8f
    • unknown's avatar
      Merge hh-nb.hungers:/work/merge/mysql-5.1-build · d2c34ded
      unknown authored
      into  hh-nb.hungers:/work/merge/mysql-5.1-bug32664
      
      
      d2c34ded
    • unknown's avatar
      Merge ahristov@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 98e7d709
      unknown authored
      into  whirlpool.hristov.com:/work/mysql-5.1-runtime
      
      
      98e7d709
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · e70944d4
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.1-runtime
      
      
      e70944d4
    • unknown's avatar
      Update new test results after merge (Bug#12713) · d6989496
      unknown authored
      d6989496
    • unknown's avatar
      mysql-test/mysql-test-run.pl · d41af7ad
      unknown authored
          Disable extra team trees.
          Temporary fix for entry 34761 in the bugs DB.
          (Patch by Magnus Svensson, 2008-02-22 17:40:14+01:00, msvensson@pilot.mysql.com +1 -0)
      
      
      mysql-test/mysql-test-run.pl:
        Disable extra team trees.
        Temporary fix for entry 34761 in the bugs DB.
        (Patch by Magnus Svensson, 2008-02-22 17:40:14+01:00, msvensson@pilot.mysql.com +1 -0)
      d41af7ad
    • unknown's avatar
      Fix for Bug#29605 · 233143fd
      unknown authored
      --local-infile=0 checks can be bypassed by sending a FETCH LOCAL FILE response
        
      Add a check for CLIENT_LOCAL_FILES before sending a local file.
      Beware, that all binary distributions enable sending of local files and it's up
      to the programs which use libmysql to disable it, if they don't use this functionality.
      Otherwise they are not safe.
      
      
      client/mysqltest.c:
        Enable LOAD DATA LOCAL INFILE for the test suite, like some rpl and ndb test.
      sql-common/client.c:
        Check if the client has LOAD DATA LOCAL INFILE disabled and
        don't serve such requests from the server. This is not 100% proof,
        as if the client has this enabled, in all binary builds for BC,
        the check won't work and the client can be tricked into sending a
        local file.
      tests/mysql_client_test.c:
        Switch on LOCAL INFILE in client test. If one day there
        is a test which uses it, then it will work out of the box.
      233143fd
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · f9789423
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      storage/ndb/src/kernel/blocks/dbtux/DbtuxScan.cpp:
        Auto merged
      f9789423
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 1bee6a3c
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      ndb/src/kernel/blocks/dbtux/DbtuxScan.cpp:
        Auto merged
      1bee6a3c
    • unknown's avatar
      Merge ahristov@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 0dedada2
      unknown authored
      into  whirlpool.hristov.com:/work/mysql-5.1-runtime
      
      
      sql/events.cc:
        Auto merged
      0dedada2
    • unknown's avatar
      Fix for bug#22738 Events: After stop and start disabled events could reside in the queue · 5d6ca9c2
      unknown authored
      Disabled events weren't removed from the memory queue after the scheduler has been
      re-enabled. After recalculation of next execution time of an event, it might get disabled.
      
      
      sql/event_queue.cc:
        Sort the event queue in a way that the disabled events will always be
        at the end. We will use this for cleaning it, starting from the end.
        
        After recalculating times in the queue, after the scheduler has been enabled
        after disabled state, the queue should be cleaned from DISABLED events.
        The queue is sorted in a way such that the disabled events are at the end.
        Thus, we can start from the end of the queue and remove all DISABLED till we
        find the first with different state.
      sql/events.cc:
        Add a comment about possible problem with replication of events,
        disabled events and server restarts.
      5d6ca9c2
    • unknown's avatar
      Merge trift2.:/MySQL/M51/mysql-5.1 · 50ba314c
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      configure.in:
        Auto merged
      extra/yassl/src/handshake.cpp:
        Auto merged
      extra/yassl/src/template_instnt.cpp:
        Auto merged
      extra/yassl/src/yassl_imp.cpp:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql/ha_ndbcluster_binlog.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      storage/ndb/src/common/util/OutputStream.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbtux/DbtuxScan.cpp:
        Auto merged
      storage/ndb/tools/waiter.cpp:
        Auto merged
      50ba314c
    • unknown's avatar
      Update new tests after merge. · 5990242f
      unknown authored
      5990242f
    • unknown's avatar
      An unused variable (compile-time warning). · 5d26f63c
      unknown authored
      
      sql/sql_view.cc:
        An unused variable.
      5d26f63c
    • unknown's avatar
      Disable concurrent inserts for the kill.test · c9be87d0
      unknown authored
      
      mysql-test/r/kill.result:
        Update test case result.
      mysql-test/t/disabled.def:
        Re-enable kill test, bug was closed.
      mysql-test/t/kill.test:
        Disable concurrent inserts for the kill test.
      c9be87d0
    • unknown's avatar
      5bb60f8a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 6f044970
      unknown authored
      into  buzz.(none):/home/davi/mysql-5.1-runtime
      
      
      6f044970
    • unknown's avatar
      Fix lock_multi test case failure related to · c3801d96
      unknown authored
      concurrent inserts.
      
      
      mysql-test/t/lock_multi.test:
        Wait for the concurrent insert to finish.
      c3801d96
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 00ff33cf
      unknown authored
      into  quad.:/mnt/raid/alik/MySQL/devel/bug-30217/5.1-rt-bug30217
      
      
      sql/item.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      00ff33cf
    • unknown's avatar
      Fix for Bug#30217: Views: changes in metadata behaviour · a3e83048
      unknown authored
      between 5.0 and 5.1.
        
      The problem was that in the patch for Bug#11986 it was decided
      to store original query in UTF8 encoding for the INFORMATION_SCHEMA.
      This approach however turned out to be quite difficult to implement
      properly. The main problem is to preserve the same IS-output after
      dump/restore.
        
      So, the fix is to rollback to the previous functionality, but also
      to fix it to support multi-character-set-queries properly. The idea
      is to generate INFORMATION_SCHEMA-query from the item-tree after
      parsing view declaration. The IS-query should:
        - be completely in UTF8;
        - not contain character set introducers.
        
      For more information, see WL4052.
      
      
      mysql-test/include/ddl_i18n.check_views.inc:
        Add a test case for Bug#30217.
      mysql-test/r/ddl_i18n_koi8r.result:
        Update result file.
      mysql-test/r/ddl_i18n_utf8.result:
        Update result file.
      mysql-test/r/information_schema.result:
        Update result file.
      mysql-test/r/information_schema_db.result:
        Update result file.
      mysql-test/r/mysqldump.result:
        Update result file.
      mysql-test/r/show_check.result:
        Update result file.
      mysql-test/t/ddl_i18n_koi8r.test:
        Add a test case for Bug#30217.
      mysql-test/t/ddl_i18n_utf8.test:
        Add a test case for Bug#30217.
      mysql-test/t/mysqldump.test:
        Add a test case for Bug#30217.
      sql/ha_ndbcluster.cc:
        Add a parameter to print().
      sql/item.cc:
        1. Add a parameter to print().
        2. Item_string::print():
              - Do not append character set introducer to the text literal
                if we're building a query for INFORMATION_SCHEMA;
              - Convert text literal to UTF8 if we're building a query
                for INFORMATION_SCHEMA.
      sql/item.h:
        Add a parameter to print().
      sql/item_cmpfunc.cc:
        Add a parameter to print().
      sql/item_cmpfunc.h:
        Add a parameter to print().
      sql/item_func.cc:
        Add a parameter to print().
      sql/item_func.h:
        Add a parameter to print().
      sql/item_geofunc.h:
        Add a parameter to print().
      sql/item_row.cc:
        Add a parameter to print().
      sql/item_row.h:
        Add a parameter to print().
      sql/item_strfunc.cc:
        Add a parameter to print().
      sql/item_strfunc.h:
        Add a parameter to print().
      sql/item_subselect.cc:
        Add a parameter to print().
      sql/item_subselect.h:
        Add a parameter to print().
      sql/item_sum.cc:
        Add a parameter to print().
      sql/item_sum.h:
        Add a parameter to print().
      sql/item_timefunc.cc:
        Add a parameter to print().
      sql/item_timefunc.h:
        Add a parameter to print().
      sql/mysql_priv.h:
        Add a parameter to print().
      sql/sp_head.cc:
        Add a parameter to print().
      sql/sql_lex.cc:
        Add a parameter to print().
      sql/sql_lex.h:
        Add a parameter to print().
      sql/sql_parse.cc:
        Add a parameter to print().
      sql/sql_select.cc:
        Add a parameter to print().
      sql/sql_show.cc:
        Add a parameter to print().
      sql/sql_test.cc:
        Add a parameter to print().
      sql/sql_view.cc:
        Build INFORMATION_SCHEMA query from Item-tree.
      sql/sql_yacc.yy:
        Build INFORMATION_SCHEMA query from Item-tree.
      sql/table.h:
        Add a parameter to print().
      a3e83048
    • unknown's avatar
      Post-merge fixes for bug 32890 · 3676f518
      unknown authored
      
      mysql-test/r/ps.result:
        Update test case results
      sql/item.h:
        Manual merge
      sql/sql_view.cc:
        Manual merge
      3676f518
    • unknown's avatar
      Merge buzz.(none):/home/davi/mysql-5.0-runtime · 955b3e3d
      unknown authored
      into  buzz.(none):/home/davi/mysql-5.1-runtime
      
      
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      sql/sql_view.h:
        Auto merged
      sql/item.h:
        Manual merge
      sql/sql_prepare.cc:
        Manual merge
      sql/sql_view.cc:
        Manual merge
      955b3e3d
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-build · a7341383
      unknown authored
      into  alf.(none):/src/mysql-5.1-build_31929
      
      
      sql/CMakeLists.txt:
        Auto merged
      storage/myisam/CMakeLists.txt:
        Auto merged
      a7341383