1. 11 Apr, 2007 1 commit
  2. 10 Apr, 2007 5 commits
    • unknown's avatar
      Bug #19372: · 0b6979bb
      unknown authored
      Added a test case.
      The problem was fixed by the fix for bug #17379.
      The problem was that because of some conditions 
      the optimizer always preferred range or full index
      scan access methods to lookup access methods even
      when the latter were much cheaper.
      
      
      mysql-test/r/select.result:
        Bug #19372: test case.
        The problem was fixed by the patch for bug #17379
      mysql-test/t/select.test:
        Bug #19372: test case.
        The problem was fixed by the patch for bug #17379
      0b6979bb
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 0f7b02d0
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27659-5.0-opt
      
      0f7b02d0
    • unknown's avatar
      Bug #27659: · 7f8fd5c0
      unknown authored
      The optimizer transforms DISTINCT into a GROUP BY
      when possible.
      It does that by constructing the same structure
      (a list of ORDER instances) the parser makes when
      parsing GROUP BY.
      While doing that it also eliminates duplicates.
      But if a duplicate is found it doesn't advance the
      pointer to ref_pointer array, so the next 
      (and subsequent) ORDER structures point to the wrong
      element in the SELECT list.
      Fixed by advancing the pointer in ref_pointer_array
      even in the case of a duplicate.
      
      
      mysql-test/r/distinct.result:
        Bug #27659: test case
      mysql-test/t/distinct.test:
        Bug #27659: test case
      sql/sql_select.cc:
        Bug #27659: use correct ref_pointer_array element
      7f8fd5c0
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · aafd7564
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Bugs/5.0.27069
      
      
      sql/sql_table.cc:
        Auto merged
      aafd7564
    • unknown's avatar
      Bug#27069 set with identical elements are created(additional fix) · 32c7e3bf
      unknown authored
      issue an error in strict mode
      if enum|set column has duplicates members in 'create table'
      
      
      mysql-test/r/strict.result:
        test case
      mysql-test/t/strict.test:
        test case
      sql/sql_table.cc:
        issue an error in strict mode
        if enum|set has duplicates members
      32c7e3bf
  3. 09 Apr, 2007 2 commits
  4. 08 Apr, 2007 1 commit
  5. 07 Apr, 2007 4 commits
  6. 06 Apr, 2007 6 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e7283b6b
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/27586-bug-5.0-opt-mysql
      
      e7283b6b
    • unknown's avatar
      Bug#27586: Wrong autoinc value assigned by LOAD DATA in the · 398b21a3
      unknown authored
      NO_AUTO_VALUE_ON_ZERO mode.
      
      The table->auto_increment_field_not_null variable wasn't reset after
      reading a row which may lead to inserting a wrong value to the auto-increment
      field to the following row.
      
      The table->auto_increment_field_not_null variable is reset now right after a
      row is being written in the read_fixed_length() and the read_sep_field()
      functions.
      Removed wrong setting of the table->auto_increment_field_not_null variable in
      the read_sep_field() function.
      
      
      mysql-test/t/loaddata.test:
        Added a test case for the bug#27586: Wrong autoinc value assigned by LOAD DATA in the
        NO_AUTO_VALUE_ON_ZERO mode.
      mysql-test/r/loaddata.result:
        Added a test case for the bug#27586: Wrong autoinc value assigned by LOAD DATA in the
        NO_AUTO_VALUE_ON_ZERO mode.
      sql/sql_load.cc:
        Bug#27586: Wrong autoinc value assigned by LOAD DATA in the
        NO_AUTO_VALUE_ON_ZERO mode.
        The table->auto_increment_field_not_null variable is reset now right after a
        row is being written in the read_fixed_length() and the read_sep_field()
        functions.
        Remove wrong setting of the table->auto_increment_field_not_null variable in
        the read_sep_field() function.
      398b21a3
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 934275af
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb
      
      934275af
    • unknown's avatar
      Merge acurtis@bk-internal:/home/bk/mysql-5.0-engines · c9a72fd8
      unknown authored
      into  xiphis.org:/home/antony/work2/mysql-5.0-engines.merge
      
      
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      c9a72fd8
    • unknown's avatar
      Polishing: note added. · 133bf1fd
      unknown authored
      133bf1fd
    • unknown's avatar
      Polishing: add comments. · 350f76ed
      unknown authored
      
      sql/parse_file.cc:
        Add comments.
      350f76ed
  7. 05 Apr, 2007 11 commits
  8. 04 Apr, 2007 9 commits
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · f826bf0c
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb
      
      f826bf0c
    • unknown's avatar
      Bug #26242 UPDATE with subquery and triggers failing with cluster tables · 6a351318
      unknown authored
      In certain cases AFTER UPDATE/DELETE triggers on NDB tables that referenced
      subject table didn't see the results of operation which caused invocation
      of those triggers. In other words AFTER trigger invoked as result of update
      (or deletion) of particular row saw version of this row before update (or
      deletion).
      
      The problem occured because NDB handler in those cases postponed actual
      update/delete operations to be able to perform them later as one batch.
      
      This fix solves the problem by disabling this optimization for particular
      operation if subject table has AFTER trigger for this operation defined.
      To achieve this we introduce two new flags for handler::extra() method:
      HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH.
      These are called if there exists AFTER DELETE/UPDATE triggers during a
      statement that potentially can generate calls to delete_row()/update_row().
      This includes multi_delete/multi_update statements as well as insert statements
      that do delete/update as part of an ON DUPLICATE statement.
      
      
      include/my_base.h:
        Added HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH to inform handler when batching of delete/update is not possible.
      mysql-test/r/ndb_trigger.result:
        Bug #26242  UPDATE with subquery and triggers failing with cluster tables
        ---
        Added new test cases
      mysql-test/t/ndb_trigger.test:
        Bug #26242  UPDATE with subquery and triggers failing with cluster tables
        ---
        Added new test cases
      sql/ha_ndbcluster.cc:
        Bug #26242  UPDATE with subquery and triggers failing with cluster tables: Use HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH to inform handler when batching of delete/update is not possible
      sql/ha_ndbcluster.h:
        Bug #26242  UPDATE with subquery and triggers failing with cluster tables: Added member variables for handling of HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH to inform handler when batching of delete/update is not possible
      sql/mysql_priv.h:
        Added new method prepare_triggers_for_insert_stmt to check if batching of delete/update must be disallowed.
      sql/sql_delete.cc:
        Use HA_EXTRA_DELETE_CANNOT_BATCH to inform handler when batching of delete is not possible
      sql/sql_insert.cc:
        Added method prepare_triggers_for_insert_stmt to check if batching of delete/update must be dissallowed.
        Use HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH to inform handler
         when batching of delete/update is not possible
      sql/sql_load.cc:
        Call prepare_triggers_for_insert_stmt to check if batching of delete/update must be dissallowed and
        mark fields used by triggers for the insert statement.
      sql/sql_trigger.h:
        Added has_triggers to support what particular triggers exist on a table.
      sql/sql_update.cc:
        Use HA_EXTRA_UPDATE_CANNOT_BATCH to inform handler when batching of update is not possible
      6a351318
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B27513-5.0-opt · 84e1943a
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27513-5.0-opt
      
      84e1943a
    • unknown's avatar
      2fb5b8f7
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0 · 9e1777a8
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/mrg04/50
      
      
      sql/item_func.cc:
        Auto merged
      9e1777a8
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 83050c65
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27513-5.0-opt
      
      83050c65
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-4.1-opt · bfd92de9
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/order_by.result:
        Manual merge
      mysql-test/t/order_by.test:
        Manual merge
      bfd92de9
    • unknown's avatar
      64632979
    • unknown's avatar
      Fix after manual merge · 487c09f1
      unknown authored
      487c09f1
  9. 03 Apr, 2007 1 commit
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-4.1-opt · 2440d8ea
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      mysql-test/r/order_by.result:
        Manual merge
      mysql-test/t/order_by.test:
        Manual merge
      sql/item_cmpfunc.h:
        Manual merge
      2440d8ea