1. 02 Nov, 2004 1 commit
    • unknown's avatar
      post-review fixes · 35884802
      unknown authored
      
      server-tools/instance-manager/Makefile.am:
        Removed entry for deleted file
      server-tools/instance-manager/buffer.cc:
        cleanup
      server-tools/instance-manager/commands.cc:
        cleanup, added missing error handling
      server-tools/instance-manager/instance.cc:
        added waitpid in instance_start, added few checks
      server-tools/instance-manager/instance_map.cc:
        error handling for hash_init added
      server-tools/instance-manager/instance_map.h:
        Extended constructor
      server-tools/instance-manager/instance_options.cc:
        made add_option less bulky
      server-tools/instance-manager/instance_options.h:
        -
      server-tools/instance-manager/listener.cc:
        added missing close, fixed typo
      server-tools/instance-manager/manager.cc:
        moved some Instance_map initialization to costructor
      server-tools/instance-manager/protocol.cc:
        error handling added
      server-tools/instance-manager/protocol.h:
        store_to_string fixed to return a value
      server-tools/instance-manager/user_map.cc:
        error handling for hash_init added
      server-tools/instance-manager/user_map.h:
        added init() for User map (becouse of the hash_init check)
      35884802
  2. 27 Oct, 2004 3 commits
    • unknown's avatar
      comment fixed to reflect the current state of things · c77560bf
      unknown authored
      
      server-tools/instance-manager/guardian.cc:
        comment fixed
      c77560bf
    • unknown's avatar
      Merge mysql.com:/home/cps/mysql/trees/mysql-5.0 · 573f1bb8
      unknown authored
      into mysql.com:/home/cps/mysql/devel/im/prereview/mysql-5.0
      
      573f1bb8
    • unknown's avatar
      more review fixes · 825f58e9
      unknown authored
      
      server-tools/instance-manager/command.cc:
        member rename
      server-tools/instance-manager/commands.cc:
        rename
      server-tools/instance-manager/commands.h:
        member rename
      server-tools/instance-manager/guardian.cc:
        guardian fixed to use Instance_map::Iterator intead of Imap
      server-tools/instance-manager/instance_map.cc:
        removed get_instance method from Instance_map as it is needed only by
        Iterator which is made a friend class
      server-tools/instance-manager/instance_map.h:
        use Instance_map::Iterator instead if Imap_iterator (no need to add more
        names to the global namespace)
      825f58e9
  3. 26 Oct, 2004 2 commits
    • unknown's avatar
      Various post-review fixes · 62f4dbd9
      unknown authored
      
      server-tools/instance-manager/buffer.cc:
        simplified buffer interface
      server-tools/instance-manager/buffer.h:
        simplified buffer interface
      server-tools/instance-manager/command.cc:
        Command class now uses instance_map directly
      server-tools/instance-manager/command.h:
        Made Command to use instance_map directly (not through the factory,
        which is not needed here in fact)
      server-tools/instance-manager/commands.cc:
        Moved mysql client/server protocol-specific functions to the commands
      server-tools/instance-manager/commands.h:
        Added a comment for Syntax_error command, fixed classes to use instance
        map instead of the factory
      server-tools/instance-manager/factory.cc:
        Fixed factory to give appropriate class to the commands
      server-tools/instance-manager/guardian.cc:
        Fixed guardian to delay start of new instances monitoring.
        Moved guardian initialization to the class from Instance map.
      server-tools/instance-manager/guardian.h:
        interface fixed
      server-tools/instance-manager/instance.cc:
        added some loging
      server-tools/instance-manager/instance_map.cc:
        All non-instance map specific functions moved from the class. Added
        iterator for instance_map
      server-tools/instance-manager/instance_map.h:
        All non-instance map related functions moved from the class. Added
        iterator for instance_map.
      server-tools/instance-manager/listener.cc:
        Added FD_CLOEXEC flag to sockets, as we don't want instances to inherit
        them after exec.
      server-tools/instance-manager/manager.cc:
        use guardian method moved from the instance map
      server-tools/instance-manager/mysql_connection.cc:
        cleanup
      server-tools/instance-manager/protocol.cc:
        fix according to the changes in the Buffer class
      62f4dbd9
    • unknown's avatar
      item_cmpfunc.h: · 0a52a675
      unknown authored
        COND_EQUAL must be derived from Sql_alloc to simplify memory
        management for objects of this class.
        This fixes a leak in mysql-test-run noticed by PEM.
      opt_range.cc:
        Fixed uninitialized min_max_range member the QUICK_GROUP_MIN_MAX_SELECT class.
      
      
      sql/opt_range.cc:
        Fixed uninitialized min_max_range member the QUICK_GROUP_MIN_MAX_SELECT class.
      sql/item_cmpfunc.h:
        COND_EQUAL must be derived from Sql_alloc to simplify memory
        management for objects of this class.
        This fixes a leak in mysql-test-run noticed by PEM.
      0a52a675
  4. 25 Oct, 2004 1 commit
    • unknown's avatar
      minor post review fixes · 60889280
      unknown authored
      
      server-tools/instance-manager/buffer.cc:
        function renames
      server-tools/instance-manager/buffer.h:
        function renames
      server-tools/instance-manager/command.cc:
        unecessary headers removed
      server-tools/instance-manager/command.h:
        cleanup
      server-tools/instance-manager/commands.cc:
        cleanup
      server-tools/instance-manager/commands.h:
        cleanup
      server-tools/instance-manager/guardian.cc:
        cleanup
      server-tools/instance-manager/instance.cc:
        cleanup
      server-tools/instance-manager/instance_options.cc:
        cleanup
      server-tools/instance-manager/instance_options.h:
        cleanup
      server-tools/instance-manager/listener.cc:
        cleanup
      server-tools/instance-manager/manager.cc:
        cleanup
      server-tools/instance-manager/protocol.cc:
        cleanup
      60889280
  5. 23 Oct, 2004 3 commits
    • unknown's avatar
      Fixed BUG#6029: Stored procedure specific handlers should have priority. · d9c12f82
      unknown authored
      
      mysql-test/r/sp.result:
        New test case for BUG#6022.
      mysql-test/t/sp.test:
        New test case for BUG#6022.
      sql/sp_rcontext.cc:
        Find the most specific condition handler, not just the first one.
        (And corrected the return type for find_handler)
      sql/sp_rcontext.h:
        Corrected return type for find_handler.
      d9c12f82
    • unknown's avatar
      Fixed BUG#6022: Stored procedure shutdown problem with self-calling function. · 5174a837
      unknown authored
        Fixed the pre-caching of functions. It now gives the expected stack overrun
        error for functions recursing too deep.
      
      
      mysql-test/r/sp.result:
        New test case for BUG#6022.
      mysql-test/t/sp.test:
        New test case for BUG#6022.
      sql/sp.cc:
        Cache function first, then recurse, or the pre-caching loops infinitely
        for recursive functions.
      5174a837
    • unknown's avatar
      Intermediate commit - just to make new files visible to bk in the new · ddb415d0
      unknown authored
      tree
      
      
      server-tools/instance-manager/Makefile.am:
        Fixed IM linking to avoid using both mysys and libmysql as the define the
        same symbols and therefore conflict
      server-tools/instance-manager/listener.cc:
        Added ability to listen network ports
      server-tools/instance-manager/listener.h:
        Various additions to the Listener_thread_args
      server-tools/instance-manager/log.cc:
        merge
      server-tools/instance-manager/log.h:
        merge
      server-tools/instance-manager/manager.cc:
        Fixes and additions to enable guardian functionality
      server-tools/instance-manager/manager.h:
        Changed manager() signature
      server-tools/instance-manager/mysqlmanager.cc:
        Various fixes
      server-tools/instance-manager/options.cc:
        Added handling of default values for new options in the Options struct. (such
        as default_user, default_password, monitoring_interval e.t.c)
      server-tools/instance-manager/options.h:
        Added new options to the Options struct
      sql/net_serv.cc:
        Added MYSQL_INSTANCE_MANAGER defines to enable alarm handling in the IM
      server-tools/instance-manager/buffer.cc:
        Simple implementation of variable-length buffer
      server-tools/instance-manager/command.cc:
        Abstract command. All commands are derived from Command class
      server-tools/instance-manager/commands.h:
        Interfaces for all commands we have
      server-tools/instance-manager/factory.cc:
        Commands factory. This class hides command instantiation. The idea is to
        handle various protocols this way. (different commands for different
        protocols
      server-tools/instance-manager/guardian.cc:
        Guardian thread implementation (monitor and restart instances in case of a
        failure
      server-tools/instance-manager/guardian.h:
        Guardian_thread and Guardian_thread_args class interface. The
        Guardian_thread is responsible for monitoring and restarting instances
      server-tools/instance-manager/instance.cc:
        Instance class contains methods and data to manage a single instance
      server-tools/instance-manager/instance.h:
        This file contains class an instance class interface. The class is
        responsible for starting/stopping an instance
      server-tools/instance-manager/instance_map.cc:
        The instance repository. This class is also responsible for initialization
        of Instance class objects.
      server-tools/instance-manager/instance_options.cc:
        The Instance_options class contains all methods to get and  handle options
        of an instance
      server-tools/instance-manager/mysql_connection.cc:
        The class responsible for handling MySQL client/server protocol connections
      server-tools/instance-manager/mysql_manager_error.h:
        The list of Instance Manger-specific errors
      server-tools/instance-manager/parse.cc:
        Simple query parser
      server-tools/instance-manager/parse.h:
        Parser interface
      server-tools/instance-manager/protocol.cc:
        Here implemented functions used to handle mysql client/server protocol
      server-tools/instance-manager/protocol.h:
        Interface for MySQL client/server protocol
      server-tools/instance-manager/thread_registry.cc:
        Thread registry stores information about every thread. It's main function is
        to provide graceful shutdown for all threads.
      server-tools/instance-manager/user_map.h:
        User map contains hash with user names and passwords
      ddb415d0
  6. 22 Oct, 2004 7 commits
    • unknown's avatar
      Updated view test result (after a warning's been removed). · 25c45fd1
      unknown authored
      
      mysql-test/r/view.result:
        Updated test result (after a warning's been removed).
      25c45fd1
    • unknown's avatar
      Fixed BUG#6030: Stored procedure has no appropriate DROP privilege. · 1239d3e6
      unknown authored
        ...and no ALTER privilege either.
        For now, only the definer and root can drop or alter an SP.
      
      
      include/mysqld_error.h:
        New access denied error code when dropping/altering stored procedures.
      include/sql_state.h:
        New access denied error code when dropping/altering stored procedures.
      mysql-test/r/sp-error.result:
        Removed warning for "unitialized variable", as this popped up in unexpected
        places after the access control for drop/alter SPs was added. (And the warning
        was wrong and planned to be removed anyway.)
      mysql-test/r/sp-security.result:
        Added tests for access control on who's allowed to drop and alter SPs.
      mysql-test/r/sp.result:
        Updated results. (Warning removed.)
      mysql-test/t/sp-error.test:
        Removed warning for "unitialized variable", as this popped up in unexpected
        places after the access control for drop/alter SPs was added. (And the warning
        was wrong and planned to be removed anyway.)
      mysql-test/t/sp-security.test:
        Added tests for access control on who's allowed to drop and alter SPs.
      sql/share/czech/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/danish/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/dutch/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/english/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/estonian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/french/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/german/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/greek/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/hungarian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/italian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/japanese/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/korean/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/norwegian-ny/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/norwegian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/polish/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/portuguese/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/romanian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/russian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/serbian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/slovak/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/spanish/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/swedish/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/ukrainian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/sql_parse.cc:
        Added minimal access control for DROP/ALTER PROCEDURE/FUNCTION. Only the definer
        and root are allowed to do this.
      sql/sql_yacc.yy:
        Removed warning for "unitialized variable", as this popped up in unexpected
        places after the access control for drop/alter SPs was added. (And the warning
        was wrong and planned to be removed anyway.)
      1239d3e6
    • unknown's avatar
      Fixed BUG#6027: Stored procedures can be renamed. · a1c76866
      unknown authored
      Removed the support for renaming SPs. It's non-standard, conflicted with a standard
      syntax, and was a bit broken anyway.
      
      
      mysql-test/r/sp-error.result:
        Removed test for renaming procedures with alter.
      mysql-test/r/sp.result:
        Removed test for renaming procedures with alter.
      mysql-test/t/sp-error.test:
        Removed test for renaming procedures with alter.
      mysql-test/t/sp.test:
        Removed test for renaming procedures with alter.
      sql/sp.cc:
        Removed support for renaming SPs. It's non-standard, conflicted with a standard
        syntax, and was a bit broken anyway.
      sql/sp.h:
        Removed support for renaming SPs. It's non-standard, conflicted with a standard
        syntax, and was a bit broken anyway.
      sql/sql_parse.cc:
        Removed support for renaming SPs. It's non-standard, conflicted with a standard
        syntax, and was a bit broken anyway.
      sql/sql_yacc.yy:
        Removed support for renaming SPs. It's non-standard, conflicted with a standard
        syntax, and was a bit broken anyway.
      a1c76866
    • unknown's avatar
      handler.cc: · 8c17290e
      unknown authored
        Typos in comments.
      
      
      sql/handler.cc:
        Typos in comments.
      8c17290e
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 03c487b5
      unknown authored
      into gw.mysql.r18.ru:/usr/home/ram/work/5.0
      
      03c487b5
    • unknown's avatar
      A fix (bug #5999 Typo in code, wrong config variable naming). · 52d9e429
      unknown authored
      
      mysql-test/r/rpl_auto_increment.result:
        A fix (bug #5999 Typo in code, wrong config variable naming).
        Typo fixed.
      sql/set_var.cc:
        A fix (bug #5999 Typo in code, wrong config variable naming).
        Typo fixed.
      52d9e429
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 224ada87
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-view-5.0
      
      
      sql/item_strfunc.h:
        Auto merged
      sql/table.h:
        Auto merged
      224ada87
  7. 21 Oct, 2004 10 commits
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · 899d5e9f
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      899d5e9f
    • unknown's avatar
      ps.result: · e2fb7395
      unknown authored
        Post-merge fixes.
      sql_select.cc:
        Post-merge cleanup.
      
      
      sql/sql_select.cc:
        Post-merge cleanup.
      mysql-test/r/ps.result:
        Post-merge fixes.
      e2fb7395
    • unknown's avatar
      added support of view and CHECK OPTION of view to LOAD DATA (BUG#5996) · d83b8d32
      unknown authored
      
      mysql-test/r/view.result:
        LOAD DATA with view and CHECK OPTION
      mysql-test/t/view.test:
        LOAD DATA with view and CHECK OPTION
      sql/log_event.cc:
        new parameter for load data
      sql/mysql_priv.h:
        new parameter for load data
      sql/sql_lex.cc:
        LOAD DATA supported by view
      sql/sql_load.cc:
        added support of view and CHECK OPTION of view to LOAD DATA
      sql/sql_parse.cc:
        new parameter for CHECK OPTION
      d83b8d32
    • unknown's avatar
      new behaviour of CHECK option build, for mor efficience and more correct: · 11d8bf16
      unknown authored
      check option build only according most top VIEW  CHECK OPTION TYPE  (BUG#5993)
      
      
      mysql-test/r/view.result:
        CASCADED should be used for all underlaying VIEWs
      mysql-test/t/view.test:
        CASCADED should be used for all underlaying VIEWs
      sql/sql_base.cc:
        new behaviour of CHECK option build, for mor efficience and more correct.
      sql/table.cc:
        new behaviour of CHECK option build, for mor efficience and more correct.
      sql/table.h:
        new behaviour of CHECK option build, for mor efficience and more correct.
      11d8bf16
    • unknown's avatar
      ha_innodb.cc: · 2194aac1
      unknown authored
        Remove compiler warning 'skip_auto_inc_decr' : unreferenced local variable in Visual C++; of course, I still have to check Monty's auto-inc patch in whole
      
      
      sql/ha_innodb.cc:
        Remove compiler warning 'skip_auto_inc_decr' : unreferenced local variable in Visual C++; of course, I still have to check Monty's auto-inc patch in whole
      2194aac1
    • unknown's avatar
      value should be checked after 'before' trigger work (BUG#5992) · 3653ecb0
      unknown authored
      
      mysql-test/r/view.result:
        changing value by trigger and CHECK OPTION
      mysql-test/t/view.test:
        changing value by trigger and CHECK OPTION
      sql/sql_insert.cc:
        value should be checked after 'before' trigger work
      3653ecb0
    • unknown's avatar
      inserting single value with check option failed always get error (part of BUG#5995) · 19671bd9
      unknown authored
      
      mysql-test/r/view.result:
        inserting single value with check option failed always get error
      mysql-test/t/view.test:
        inserting single value with check option failed always get error
      sql/sql_insert.cc:
        inserting single value with check option failed always get error
      19671bd9
    • unknown's avatar
      fixed default behaviour of WITH CHECK OPTIONS according to standard (BUG#5989) · 5f1c9cca
      unknown authored
      
      mysql-test/r/view.result:
        fixed default behaviour of WITH CHECK OPTIONS according to standard
      sql/sql_yacc.yy:
        fixed default behaviour of WITH CHECK OPTIONS according to standard
      5f1c9cca
    • unknown's avatar
      Allow inheriting check options if view have not WHERE clause (BUG#5988) · 2c8aa3bb
      unknown authored
      
      mysql-test/r/view.result:
        test of cascaded check option for whiew without WHERE clause
      mysql-test/t/view.test:
        test of cascaded check option for whiew without WHERE clause
      sql/table.cc:
        Allow inheriting check options if view have not WHERE clause
      2c8aa3bb
    • unknown's avatar
      fixed printing of substring_index (BUG#5911) · 55f12a29
      unknown authored
      
      mysql-test/r/func_str.result:
        fixed printing of substring_index
      mysql-test/r/view.result:
        test of substring_index with view
      mysql-test/t/view.test:
        test of substring_index with view
      sql/item_strfunc.h:
        fixed printing of substring_index
      55f12a29
  8. 20 Oct, 2004 9 commits
  9. 19 Oct, 2004 3 commits
    • unknown's avatar
      Merge for post-merge fixes for Item_equal patch. · a9da1869
      unknown authored
      
      BitKeeper/etc/ignore:
        auto-union
      mysql-test/r/range.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/range.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/opt_sum.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/item.h:
        Manual merge
      sql/sql_select.cc:
        Manual merge
      a9da1869
    • unknown's avatar
      table.h, sql_select.h: · fcab6583
      unknown authored
        Added the code processing on expressions for applying
        multiple equalities.
      sql_select.cc:
        Post-merge fixes for Item_equal patch.
        Added the code processing on expressions for applying
        multiple equalities.
      Many files:
        Post-merge fixes for Item_equal patch.
      item_cmpfunc.cc:
        Post-merge fixes for Item_equal patch.
        Fixed a problem when an equality field=const cannot be applied to
        the predicate P(field,c) for constant propagation as a conversion
        of field is needed.
      item.h, item.cc:
        Fixed a problem when an equality field=const cannot be applied to
        the predicate P(field,c) for constant propagation as a conversion
        of field is needed.
      
      
      mysql-test/r/func_test.result:
        Post-merge fixes for Item_equal patch.
      mysql-test/r/index_merge.result:
        Post-merge fixes for Item_equal patch.
      mysql-test/r/join_nested.result:
        Post-merge fixes for Item_equal patch.
      mysql-test/r/range.result:
        Post-merge fixes for Item_equal patch.
      sql/item.cc:
        Fixed a problem when an equality field=const cannot be applied to
        the predicate P(field,c) for constant propagation as a conversion
        of field is needed.
      sql/item.h:
        Fixed a problem when an equality field=const cannot be applied to
        the predicate P(field,c) for constant propagation as a conversion
        of field is needed.
      sql/item_cmpfunc.cc:
        Post-merge fixes for Item_equal patch.
        Fixed a problem when an equality field=const cannot be applied to
        the predicate P(field,c) for constant propagation as a conversion
        of field is needed.
      sql/opt_range.cc:
        Post-merge fixes for Item_equal patch.
      sql/sql_select.cc:
        Post-merge fixes for Item_equal patch.
        Added the code processing on expressions for applying
        multiple equalities.
      sql/sql_select.h:
        Added the code processing on expressions for applying
        multiple equalities.
      sql/table.h:
        Added the code processing on expressions for applying
        multiple equalities.
      fcab6583
    • unknown's avatar
      decimal to/from bin, and utility functions · b86a19bc
      unknown authored
      
      strings/Makefile.am:
        cleanup
      b86a19bc
  10. 18 Oct, 2004 1 commit
    • unknown's avatar
      compatibility fix · c5ded716
      unknown authored
      test results corrected
      
      
      mysql-test/r/range.result:
        test results corrected
      mysql-test/t/range.test:
        test results corrected
      sql/opt_range.cc:
        compatibility fix
      c5ded716