1. 28 Feb, 2007 1 commit
    • unknown's avatar
      Remove dead code: flush_version was never increased in the server, · 368f1859
      unknown authored
      therefore the logic associated with it never worked.
      
      
      sql/ha_partition.cc:
        Remove dead code. Update comments.
      sql/mysql_priv.h:
        Remove dead code (flush_version).
      sql/mysqld.cc:
        Remove dead code (flush_version).
      sql/sql_base.cc:
        Remove dead code.
      sql/table.cc:
        Remove dead code.
      sql/table.h:
        Remove dead code.
      368f1859
  2. 24 Feb, 2007 6 commits
    • unknown's avatar
      Remove DBUG_ASSERT() -- essential functionality can not be · da80d823
      unknown authored
      wrapped by DBUG_ASSERT().
      
      da80d823
    • unknown's avatar
      Fix merge. · ffce7ece
      unknown authored
      ffce7ece
    • unknown's avatar
      Merge booka.opbmk:/home/alik/Documents/MySQL/devel/5.0-rt-im · feda3f06
      unknown authored
      into  booka.opbmk:/home/alik/Documents/MySQL/devel/5.1-rt-im
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      server-tools/instance-manager/instance_options.cc:
        Manual merge
      server-tools/instance-manager/mysqlmanager.cc:
        Manual merge.
      feda3f06
    • unknown's avatar
      Fix for BUG#22511: IM does not remove angel-pid-file on clean shutdown · 6876054f
      unknown authored
      
      server-tools/instance-manager/mysqlmanager.cc:
        Delete IM-angel pid file on exit.
      6876054f
    • unknown's avatar
      IM test suite fix. · e58e97c9
      unknown authored
      Log messages from shell-scripts were put to var/log/<test id>.log
      file. Now, this file is used by mysql-test-run.pl. So, move log
      messages to var/log/<test id>.script.log.
      
      
      mysql-test/t/kill_n_check.sh:
        Log messages from shell-scripts were put to var/log/<test id>.log
        file. Now, this file is used by mysql-test-run.pl. So, move log
        messages to var/log/<test id>.script.log.
      mysql-test/t/log.sh:
        Log messages from shell-scripts were put to var/log/<test id>.log
        file. Now, this file is used by mysql-test-run.pl. So, move log
        messages to var/log/<test id>.script.log.
      mysql-test/t/wait_for_process.sh:
        Log messages from shell-scripts were put to var/log/<test id>.log
        file. Now, this file is used by mysql-test-run.pl. So, move log
        messages to var/log/<test id>.script.log.
      mysql-test/t/wait_for_socket.sh:
        Log messages from shell-scripts were put to var/log/<test id>.log
        file. Now, this file is used by mysql-test-run.pl. So, move log
        messages to var/log/<test id>.script.log.
      e58e97c9
    • unknown's avatar
      d4d9b7ef
  3. 23 Feb, 2007 8 commits
  4. 22 Feb, 2007 4 commits
    • unknown's avatar
      Merge fix. · d12ba31c
      unknown authored
      d12ba31c
    • unknown's avatar
      Merge alik.opbmk:/mnt/raid/alik/MySQL/devel/5.0-rt · 3645bbe7
      unknown authored
      into  alik.opbmk:/mnt/raid/alik/MySQL/devel/5.1-rt-merge
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_subselect.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/t/disabled.def:
        Merge: enabled im_daemon_life_cycle.imtest
      mysql-test/t/view.test:
        Manual merge.
      server-tools/instance-manager/listener.cc:
        Manual merge.
      server-tools/instance-manager/manager.cc:
        Manual merge.
      server-tools/instance-manager/manager.h:
        Manual merge.
      server-tools/instance-manager/mysqlmanager.cc:
        Manual merge.
      server-tools/instance-manager/thread_registry.cc:
        Manual merge.
      server-tools/instance-manager/thread_registry.h:
        Manual merge.
      3645bbe7
    • unknown's avatar
      Fix powermacg5 build failure. · e64c9d68
      unknown authored
      
      server-tools/instance-manager/angel.cc:
        Include my_dir.h because MacOS defines mode constants
        (S_IRUSR, S_IWUSR, ...) in sys/stat.h.
      e64c9d68
    • unknown's avatar
      07228ca2
  5. 21 Feb, 2007 1 commit
  6. 20 Feb, 2007 5 commits
    • unknown's avatar
      Fix for BUG#24415: Instance manager test im_daemon_life_cycle fails randomly. · 17a71072
      unknown authored
      The cause of im_daemon_life_cycle.imtest random failures was the following
      behaviour of some implementations of LINUX threads: let's suppose that a
      process has several threads (in LINUX threads, there is a separate process for
      each thread). When the main process gets killed, the parent receives SIGCHLD
      before all threads (child processes) die. In other words, the parent receives
      SIGCHLD, when its child is not completely dead.
      
      In terms of IM, that means that IM-angel receives SIGCHLD when IM-main is not dead
      and still holds some resources. After receiving SIGCHLD, IM-angel restarts
      IM-main, but IM-main failed to initialize, because previous instance (copy) of
      IM-main still holds server socket (TCP-port).
      
      Another problem here was that IM-angel restarted IM-main only if it was killed
      by signal. If it exited with error, IM-angel thought it's intended / graceful
      shutdown and exited itself.
      
      So, when the second instance of IM-main failed to initialize, IM-angel thought
      it's intended shutdown and quit.
      
      The fix is
        1. to change IM-angel so that it restarts IM-main if it exited with error code;
        2. to change IM-main so that it returns proper exit code in case of failure.
      
      
      mysql-test/t/disabled.def:
        Enable im_daemon_life_cycle.
      server-tools/instance-manager/listener.cc:
        Set error status if Listener failed to initialize.
      server-tools/instance-manager/manager.cc:
        Return exit code from the manager.
      server-tools/instance-manager/manager.h:
        Return exit code from the manager.
      server-tools/instance-manager/mysqlmanager.cc:
        1. Restart IM-main if exit code is not EXIT_SUCCESS (0).
        2. Log IM-main exit code in case of failure.
      server-tools/instance-manager/thread_registry.cc:
        Add support for exit code.
      server-tools/instance-manager/thread_registry.h:
        Add support for exit code.
      17a71072
    • unknown's avatar
      Polishing: · 62c2ae53
      unknown authored
        1. use MySQL headers instead of system ones;
        2. move logical part of code into a separate function.
      
      
      server-tools/instance-manager/angel.cc:
        Polishing: try not to use system headers.
        Use headers from include/ directory when it is possible.
      server-tools/instance-manager/manager.cc:
        Polishing: move logical part of code into a separate function.
      server-tools/instance-manager/manager.h:
        Polishing: move logical part of code into a separate function.
      server-tools/instance-manager/mysqlmanager.cc:
        Polishing: rollback rename.
      62c2ae53
    • unknown's avatar
      Fix Windows build. · 7098fa0c
      unknown authored
      7098fa0c
    • unknown's avatar
      Fix build failures on Windows and Mac. · 9d9ba649
      unknown authored
      
      server-tools/instance-manager/WindowsService.cpp:
        Include my_global.h for DBUG_ASSERT.
      server-tools/instance-manager/mysqlmanager.cc:
        Include my_dir.h for umask().
      9d9ba649
    • unknown's avatar
      Merge kpettersson@bk-internal:/home/bk/mysql-5.1-runtime · 43847cca
      unknown authored
      into  kpdesk.mysql.com:/home/thek/dev/mysql-5.1-runtime
      
      
      sql/sql_parse.cc:
        SCCS merged
      43847cca
  7. 19 Feb, 2007 8 commits
  8. 18 Feb, 2007 1 commit
    • unknown's avatar
      Patch for IM in scope of working on BUG#24415: Instance manager test · 14ffc9ba
      unknown authored
      im_daemon_life_cycle fails randomly.
      
      1. Move IM-angel functionality into a separate file, create Angel class.
      2. Be more verbose;
      3. Fix typo in FLUSH INSTANCES implementation;
      4. Polishing.
      
      
      mysql-test/r/im_options.result:
        Updated result file.
      mysql-test/t/im_cmd_line.imtest:
        Updated test.
      server-tools/instance-manager/IMService.cpp:
        Move HandleServiceOptions() into IMService::main().
      server-tools/instance-manager/IMService.h:
        Move HandleServiceOptions() into IMService::main().
      server-tools/instance-manager/Makefile.am:
        Added angel.cc and angel.h.
      server-tools/instance-manager/WindowsService.cpp:
        Initialize class-members in constructor.
      server-tools/instance-manager/WindowsService.h:
        Initialize class-members in constructor.
      server-tools/instance-manager/commands.cc:
        Return actual error code (ER_OUT_OF_RESOURCES or ER_THERE_IS_ACTIVE_INSTANCE)
        from FLUSH INSTANCES.
      server-tools/instance-manager/manager.cc:
        1. Return actual error code from Manager::flush_instances().
        2. Be more verbose.
      server-tools/instance-manager/manager.h:
        Return actual error code from Manager::flush_instances().
      server-tools/instance-manager/mysqlmanager.cc:
        Move IM-angel functionality into separate file (angel.cc).
      server-tools/instance-manager/priv.cc:
        Use return bool datatype instead int{ 0, 1 }.
      server-tools/instance-manager/priv.h:
        Use return bool datatype instead int{ 0, 1 }.
      server-tools/instance-manager/angel.cc:
        IM-angel functionality.
      server-tools/instance-manager/angel.h:
        IM-angel functionality.
      14ffc9ba
  9. 16 Feb, 2007 3 commits
    • unknown's avatar
      Manual merge · b80bd854
      unknown authored
      b80bd854
    • unknown's avatar
      Merge weblab.(none):/home/marcsql/TREE/mysql-5.0-base · e4c2ffcb
      unknown authored
      into  weblab.(none):/home/marcsql/TREE/mysql-5.0-rt-merge
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_subselect.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      e4c2ffcb
    • unknown's avatar
      Manual merge · b7853de7
      unknown authored
      b7853de7
  10. 15 Feb, 2007 2 commits
    • unknown's avatar
      Merge weblab.(none):/home/marcsql/TREE/mysql-5.1-base · 5ebeadf4
      unknown authored
      into  weblab.(none):/home/marcsql/TREE/mysql-5.1-rt-merge
      
      
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/ps_1general.test:
        Auto merged
      mysql-test/t/subselect.test:
        Auto merged
      sql/event_data_objects.cc:
        Auto merged
      sql/event_queue.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_subselect.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      5ebeadf4
    • unknown's avatar
      Bug#25042 OPTIMIZE TABLE cause race condition in IO CACHE SHARE · e8dc3e48
      unknown authored
      - The condition variable implementation "lost" a signal to
        WaitOnSingleObject when a semaphore was released.
      - The signal could be consumed by a new call to pthread_cond_wait
        before all waiting threads had awoken.
      - The new implementation of pthread_cond_* uses events
        instead of semaphores. It also uses an extra lock to protect entry
        into new cond wait before the broadcast has finished.
      
      
      include/my_pthread.h:
        - New implementatin of pthread_cond_init. This version uses events
          instead of semaphores
      mysys/my_wincond.c:
        - New implementatin of pthread_cond_init. This version uses events
          instead of semaphores
      e8dc3e48
  11. 14 Feb, 2007 1 commit