- 12 Apr, 2018 3 commits
-
-
Jan Lindström authored
MDEV-12632: Source and destination overlap in memcpy, encryption.innodb-discard-import-change fails in buildbot with valgrind Problem was that if tablespace was encrypted we try to copy also page 0 from read buffer to write buffer that are in that case the same memory area. fil_iterate When tablespace is encrypted or compressed its first page (i.e. page 0) is not encrypted or compressed and there is no need to copy buffer.
-
Jan Lindström authored
Wait until rotation has ended and shutdown before grep to make sure that dirty pages are on datafiles.
-
Vicențiu Ciorbaru authored
If we use hostnames, it will fail during name resolution on UNIX systems
-
- 11 Apr, 2018 3 commits
-
-
Vicentiu Ciorbaru authored
Also fix perfschema.hostcache_ipv6_max_con. The test case makes use of a debug switch to execute some special code. The code does hostname replacement. Every hostname sent during connect phase becomes santa.claus.ipv4.example.com (or ipv6). This causes a connection from root@localhost to fail, as root is not registered as santa claus user. The failure is only apparent on Windows as Unix systems make use of sockets, which bypass the name resolution check entirely.
-
Vladislav Vaintroub authored
Fix 10.2-specific bug - copy-back is not prepared to handle system tablespaces with absolute path.
-
Igor Babaev authored
The implementations of the convert_to_basic_const_item() virtual function for the Item_cache classes should call cache_value() when value_cached == NULL.
-
- 10 Apr, 2018 7 commits
-
-
Vicențiu Ciorbaru authored
-
Vicențiu Ciorbaru authored
There was a missing argument to service_manager_extend_timeout call and the signness of arguments did not match.
-
Alexander Barkov authored
-
Jan Lindström authored
Wait drop table to be replicated before continuing.
-
Alexander Barkov authored
The code in Type_handler_blob****::make_conversion_table_field() erroneously assumed that row format replication uses MYSQL_TYPE_TINYBLOB, MYSQL_TYPE_BLOB, MYSQL_TYPE_MEDIUMBLOB, MYSQL_TYPE_LONGBLOB type codes to tranfer BLOB variations. In fact, all BLOB variations use MYSQL_TYPE_BLOB as the type code, while the BLOB packlength (1,2,3 or 4) it tranferred in metadata. The bug was introduced by aee06808 (MDEV-9238 Wrap create_virtual_tmp_table() into a class, split into different steps)
-
Marko Mäkelä authored
If innodb_fast_shutdown<2, all transactions of active connections will be rolled back on shutdown. This can take a long time, and the systemd shutdown timeout should be extended during the wait. logs_empty_and_mark_files_at_shutdown(): Extend the timeout when waiting for other threads to complete.
-
Marko Mäkelä authored
This reverts commit 76ec37f5. This behaviour change will be done separately in: MDEV-15832 With innodb_fast_shutdown=3, skip the rollback of connected transactions
-
- 09 Apr, 2018 7 commits
-
-
Marko Mäkelä authored
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
-
Vicențiu Ciorbaru authored
Table_open_cache gets adjusted on server startup to prevent an out of file descriptor error. However this means that when we reset its value to default, it does not get re-adjusted. This leads to the mtr consistency check to fail with different server status at the end of the test case as opposed to when it started. To fix the problem, do not make use of the DEFAULT keyword to set the variable back, instead save the value before any modifications and restore it from there.
-
Jan Lindström authored
Disable occasionally failing test case galera.galera_var_slave_threads.
-
Jan Lindström authored
Wait until create table is replicated before continuing.
-
Jan Lindström authored
Wait until create tables are replicated to the slave before trying lock table.
-
- 08 Apr, 2018 4 commits
-
-
Vladislav Vaintroub authored
In async IO completion code, after reading a page,Innodb can wait for completion of other bufferpool reads. This is for example what happens if change-buffering is active. Innodb on Windows could deadlock, as it did not have dedicated threads for processing change buffer asynchronous reads. The fix for that is to have windows now has the same background threads, including dedicated thread for ibuf, and log AIOs. The ibuf/read completions are now dispatched to their threads with PostQueuedCompletionStatus(), the write and log completions are processed in thread where they arrive.
-
Jan Lindström authored
Disable more occasionally failing test cases. galera.galera_lock_table galera.galera_gra_log galera.MW-44 galera.lp1376747 galera.lp1376747-2 galera.galera_pc_ignore_sb
-
Jan Lindström authored
Make sure DDL's (create tables) are replicated before continuing to lock table.
-
Jan Lindström authored
Disable occasionally failing test cases pxc-421 query_cache galera_parallel_simple
-
- 07 Apr, 2018 6 commits
-
-
Marko Mäkelä authored
fil_crypt_read_crypt_data(): Do not attempt to read the tablespace if the file is unaccessible due to a pending DDL operation, such as renaming the file or DROP TABLE or TRUNCATE TABLE. This is only reducing the probability of the race condition, not completely preventing it.
-
Vicențiu Ciorbaru authored
-
Sergei Petrunia authored
Adjust the fix for MDEV-15472: In close_cached_tables(), locked_tables_list.reopen_tables(...) call might be made when a previous call to some function has already returned error. In this scenario, the function should return 0, even if reopen_tables(...) call has succeeded.
-
Sergei Petrunia authored
When "FLUSH TABLE ... FOR EXPORT" fails, the SQL layer should rollback the statement. Otherwise we hit an assert when we try to close the tables while having a non-empty list of statement transaction participants.
-
Jan Lindström authored
-
Jan Lindström authored
MDEV-13549 Fix test galera.galera_wsrep_desync_wsrep_on
-
- 06 Apr, 2018 10 commits
-
-
Jan Lindström authored
-
Daniele Sciascia authored
The test tends to fail if many parallel instances of it are executed: ``` mysqltest: At line 23: query 'ALTER TABLE t1 ADD PRIMARY KEY (f1)' failed: 1317: Query execution was interrupted ``` The `ALTER` fails because it is BF aborted due to an earlier `INSERT SELECT` that is being applied: ``` INSERT INTO t1 (f1) SELECT ... --connection node_2 SET GLOBAL wsrep_desync = TRUE; SET SESSION wsrep_on = FALSE; ALTER TABLE t1 ADD PRIMARY KEY (f1); SET SESSION wsrep_on = TRUE; SET GLOBAL wsrep_desync = FALSE; ``` And because the `ALTER` is executed with `wsrep_on = OFF`, it does not run in total order isolation. To avoid the problem it must be ensured that the `ALTER` only after the large `INSERT SELECT` is done. To do so it is sufficient to issue `SELECT COUNT(*) FROM t1;` from `node_2` before turning off wsrep. The `SELECT` will trigger `wsrep_sync_wait` and proceed only after the `INSERT SELECT` from node_1 is done.
-
Marko Mäkelä authored
-
Jan Lindström authored
Problem was that key rotation from encrypted to unecrypted was skipped when encryption is disabled (i.e. set global innodb-encrypt-tables=OFF). fil_crypt_needs_rotation If encryption is disabled (i.e. innodb-encrypt-tables=off) and there is tablespaces using default encryption (e.g. system tablespace) that are still encrypted state we need to rotate them from encrypted state to unencrypted state.
-
Jan Lindström authored
Fix test case galera_toi_ddl_nonconflicting as we need to wait until both alter tables are finished on that Galera node.
-
Sergey Vojtovich authored
Boost includes sys/param.h on FreeBSD, which in turn defines setbit() macro. This macro is conflicting with open_query::judy_bitset::setbit(). Reordered includes such that oqgraph_judy.h never sees this macro. Also removed duplicate includes of graphcore-config.h, which is included by graphcore-graph.h/oqgraph_shim.h/oqgraph_thunk.h.
-
Marko Mäkelä authored
buf_flush_remove(): Disable the output for now, because we certainly do not want this after every page flush on shutdown. It must be rate-limited somehow. There already is a timeout extension for waiting the page cleaner to exit in logs_empty_and_mark_files_at_shutdown(). log_write_up_to(): Use correct format. srv_purge_should_exit(): Move the timeout extension to the appropriate place, from one of the callers.
-
Jan Lindström authored
Fix test case galera.pxc-421 to reset auto_increment_offset correctly.
-
Daniel Black authored
Use systemd EXTEND_TIMEOUT_USEC to advise systemd of progress Move towards progress measures rather than pure time based measures. Progress reporting at numberious shutdown/startup locations incuding: * For innodb_fast_shutdown=0 trx_roll_must_shutdown() for rolling back incomplete transactions. * For merging the change buffer (in srv_shutdown(bool ibuf_merge)) * For purging history, srv_do_purge Thanks Marko for feedback and suggestions.
-
Daniel Black authored
Suggested by Marko on github pr #576 buf_all_freed only needs to be called once, not 3 times. buf_all_freed will always return TRUE if it returns. It will crash if any page was not flushed so its effectively an assert anyway. The following calls are likely redundant and could be removed: fil_flush_file_spaces(FIL_TYPE_TABLESPACE); fil_flush_file_spaces(FIL_TYPE_LOG);
-