1. 11 May, 2007 12 commits
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27957/my50-27957 · 373f587a
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      sql/item_func.cc:
        Auto merged
      mysql-test/r/type_datetime.result:
        merging
      mysql-test/t/type_datetime.test:
        merging
      sql/my_decimal.h:
        merging
      373f587a
    • unknown's avatar
      merging fixes · 87f7d168
      unknown authored
      
      mysql-test/r/type_datetime.result:
        result fixed
      mysql-test/t/type_datetime.test:
        testcase fixed
      sql/item_func.cc:
        my_decimal_length_to_precision used
      sql/my_decimal.h:
        merging fix
      87f7d168
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27921/my51-27921 · ef7a4e57
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      sql/item_create.cc:
        Auto merged
      sql/my_decimal.h:
        Auto merged
      ef7a4e57
    • unknown's avatar
      merging fixes · 845a9b0c
      unknown authored
      
      mysql-test/t/view.test:
        merging fix
      sql/item_create.cc:
        merging fix
      sql/my_decimal.cc:
        merging fix
      sql/my_decimal.h:
        merging fix
      845a9b0c
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27957/my50-27957 · e4b08dca
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      mysql-test/r/cast.result:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/my_decimal.h:
        merging
      e4b08dca
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27921/my51-27921 · f6a06aeb
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      mysql-test/r/cast.result:
        Auto merged
      sql/item_create.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/my_decimal.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      f6a06aeb
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27921/my50-27921 · 3838978e
      unknown authored
      into  mysql.com:/home/hf/work/27957/my50-27957
      
      
      mysql-test/r/cast.result:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/my_decimal.h:
        merging
      3838978e
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27957/my50-27957 · bbd47630
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      mysql-test/r/insert_update.result:
        Auto merged
      mysql-test/t/insert_update.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      mysql-test/include/mix1.inc:
        merging
      mysql-test/r/innodb_mysql.result:
        SCCS merged
      sql/sql_select.cc:
        merging
      bbd47630
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 143dc680
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      sql/item_func.cc:
        Auto merged
      143dc680
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 684a43aa
      unknown authored
      into  mysql.com:/home/hf/work/27957/my50-27957
      
      
      sql/item_func.cc:
        Auto merged
      684a43aa
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27957/my50-27957 · 1cb3c93c
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      include/decimal.h:
        Auto merged
      mysql-test/r/type_newdecimal.result:
        Auto merged
      mysql-test/t/type_newdecimal.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      strings/decimal.c:
        Auto merged
      mysql-test/r/cast.result:
        merging
      sql/my_decimal.h:
        merging
      1cb3c93c
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27921/my50-27921 · 7c0244ff
      unknown authored
      into  mysql.com:/home/hf/work/27921/my51-27921
      
      
      mysql-test/r/cast.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_create.h:
        merging
      sql/my_decimal.h:
        merging
      sql/sql_yacc.yy:
        merging
      7c0244ff
  2. 10 May, 2007 6 commits
    • unknown's avatar
      Fixed bug #28000. · 8f159772
      unknown authored
      Bug occurs in INSERT IGNORE ... SELECT ... ON DUPLICATE KEY UPDATE
      statements, when SELECT returns duplicated values and UPDATE clause
      tries to assign NULL values to NOT NULL fields.
      NOTE: By current design MySQL server treats INSERT IGNORE ... ON
      DUPLICATE statements as INSERT ... ON DUPLICATE with update of
      duplicated records, but MySQL manual lacks this information.
      After this fix such behaviour becomes legalized.
      
      The write_record() function was returning error values even within
      INSERT IGNORE, because ignore_errors parameter of
      the fill_record_n_invoke_before_triggers() function call was
      always set to FALSE. FALSE is replaced by info->ignore.
      
      
      sql/sql_insert.cc:
        Fixed bug #28000:
        The write_record() function was returning error values even within
        INSERT IGNORE, because ignore_errors parameter of
        the fill_record_n_invoke_before_triggers() function call was
        always set to FALSE. FALSE is replaced by info->ignore.
      mysql-test/t/insert_update.test:
        Added test case for bug #28000.
      mysql-test/r/insert_update.result:
        Added test case for bug #28000.
      8f159772
    • unknown's avatar
      bigint.test made ps-protocol consistent · 4ec9b955
      unknown authored
      
      mysql-test/r/bigint.result:
        test result fixed
      mysql-test/t/bigint.test:
        testcase made ps-protocol consistent
      4ec9b955
    • unknown's avatar
      Fixed bug #28189: in some rare cases optimizer preferred a more expensive · aef98789
      unknown authored
      ref access to a less expensive range access. 
      This occurred only with InnoDB tables.
      
      
      mysql-test/r/innodb_mysql.result:
        Added a test case for bug #28189.
      mysql-test/t/innodb_mysql.test:
        Added a test case for bug #28189.
      aef98789
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 83e559db
      unknown authored
      into  mysql.com:/home/hf/work/28005/my51-28005
      
      
      sql/item_func.cc:
        Auto merged
      83e559db
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 5e1d49be
      unknown authored
      into  mysql.com:/home/hf/work/28005/my51-28005
      
      
      sql/item_func.cc:
        Auto merged
      5e1d49be
    • unknown's avatar
      bug 27921 (Views ignore precision for CAST) · 6187c15d
      unknown authored
      test result fixed
      
      6187c15d
  3. 09 May, 2007 6 commits
    • unknown's avatar
      Bug #27921 View ignores precision for CAST() · eb0d604c
      unknown authored
      Item_decimal_typecast::print properly implemented
      
      
      mysql-test/r/view.result:
        Bug #27921 View ignores precision for CAST()
        test result
      mysql-test/t/view.test:
        Bug #27921 View ignores precision for CAST()
        test case
      sql/field.cc:
        zero decimals handling unified
      sql/item_create.cc:
        Bug #27921 View ignores precision for CAST()
        create_func_cast parameters changed, zero precision handling unified
      sql/item_create.h:
        Bug #27921 View ignores precision for CAST()
        create_func_cast parameters changed
      sql/item_func.cc:
        Bug #27921 View ignores precision for CAST() 
        Item_decimal_typecast::print properly implemented
      sql/item_func.h:
        Bug #27921 View ignores precision for CAST()
        max_length counting fixed
      sql/my_decimal.h:
        Bug #27921 View ignores precision for CAST()
        my_decimal_trim() implemented to unify zero precision handling
      sql/sql_yacc.yy:
        Bug #27921 View ignores precision for CAST()
        create_func_cast calls simplified
      eb0d604c
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.1 · 4d447e79
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-opt
      
      
      sql/handler.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      4d447e79
    • unknown's avatar
      Bug #27957 cast as decimal does not check overflow, also inconsistent with group, subselect · a271c7dc
      unknown authored
      Missing check for overflow added to the Item_decimal_typecast::val_decimal
      
      
      include/decimal.h:
        Bug #27957 cast as decimal does not check overflow, also inconsistent with group, subselect
        decimal_intg() declaration
      mysql-test/r/cast.result:
        Bug #27957 cast as decimal does not check overflow, also inconsistent with group, subselect
        result fixed
      mysql-test/r/type_newdecimal.result:
        Bug #27957 cast as decimal does not check overflow, also inconsistent with group, subselect
        test result
      mysql-test/t/type_newdecimal.test:
        Bug #27957 cast as decimal does not check overflow, also inconsistent with group, subselect
        test case added
      sql/item_func.cc:
        Bug #27957 cast as decimal does not check overflow, also inconsistent with group, subselect
        now we check for possible ovreflow in Item_decimal_typecast::val_decimal
      sql/my_decimal.h:
        Bug #27957 cast as decimal does not check overflow, also inconsistent with group, subselect
        my_decimal_intg() implemented
      strings/decimal.c:
        Bug #27957 cast as decimal does not check overflow, also inconsistent with group, subselect
        decimal_intg() implemented
      a271c7dc
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.0-opt · 68290a1e
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-opt
      
      
      mysql-test/r/loaddata.result:
        Auto merged
      mysql-test/t/loaddata.test:
        Auto merged
      68290a1e
    • unknown's avatar
      loaddata.result, loaddata.test: · bc8d9473
      unknown authored
        A test case is corrected.
      
      
      mysql-test/t/loaddata.test:
        A test case is corrected.
      mysql-test/r/loaddata.result:
        A test case is corrected.
      bc8d9473
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 743995e6
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.1-opt
      
      
      mysql-test/t/loaddata.test:
        Auto merged
      sql/sql_load.cc:
        Auto merged
      mysql-test/r/loaddata.result:
        SCCS merged
      743995e6
  4. 08 May, 2007 6 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 18cfcd76
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/27670-bug-5.0-opt-mysql
      
      18cfcd76
    • unknown's avatar
      Bug#27670: LOAD DATA does not set CURRENT_TIMESTAMP default value for a · dcede16e
      unknown authored
      TIMESTAMP field when no value has been provided.
      
      The LOAD DATA sets the current time in the TIMESTAMP field with
      CURRENT_TIMESTAMP default value when the field is detected as a null.
      But when the LOAD DATA command loads data from a file that doesn't contain
      enough data for all fields then the rest of fields are simply set to null
      without any check. This leads to no value being inserted to such TIMESTAMP
      field.
      
      Now the read_sep_field() and the read_fixed_length() functions set current
      time to the TIMESTAMP field with CURRENT_TIMESTAMP default value in all cases
      when a NULL value is loaded to the field.
      
      
      mysql-test/t/loaddata.test:
        Added a test case for the bug#27670: LOAD DATA does not set CURRENT_TIMESTAMP
        default value for a TIMESTAMP field when no value has been provided.
      mysql-test/r/loaddata.result:
        Added a test case for the bug#27670: LOAD DATA does not set CURRENT_TIMESTAMP
        default value for a TIMESTAMP field when no value has been provided.
      sql/sql_load.cc:
        Bug#27670: LOAD DATA does not set CURRENT_TIMESTAMP default value for a
        TIMESTAMP field when no value has been provided.
        Now the read_sep_field() and the read_fixed_length() functions set current
        time to the TIMESTAMP field with CURRENT_TIMESTAMP default value in all cases
        when a NULL value is loaded to the field.
      dcede16e
    • unknown's avatar
      item_cmpfunc.cc, type_datetime.result, type_datetime.test, item_cmpfunc.h: · 759ebc25
      unknown authored
        After merge fix.
      
      
      sql/item_cmpfunc.cc:
        After merge fix.
      sql/item_cmpfunc.h:
        After merge fix.
      mysql-test/r/type_datetime.result:
        After merge fix.
      mysql-test/t/type_datetime.test:
        After merge fix.
      759ebc25
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/bk-trees/mysql-5.0-opt · 26938810
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      mysql-test/r/func_in.result:
        Auto merged
      mysql-test/r/insert_update.result:
        Auto merged
      mysql-test/r/type_datetime.result:
        Auto merged
      mysql-test/t/insert_update.test:
        Auto merged
      mysql-test/t/type_datetime.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/handler.cc:
        Manual merge
      sql/item_cmpfunc.cc:
        Manual merge
      sql/item_cmpfunc.h:
        Manual merge
      sql/item_func.h:
        Manual merge
      sql/sql_class.h:
        Manual merge
      26938810
    • unknown's avatar
      Raise version number after cloning 5.1.18-beta · 4613a2ab
      unknown authored
      4613a2ab
    • unknown's avatar
      warning eliminated · dacd0f51
      unknown authored
      dacd0f51
  5. 07 May, 2007 10 commits
    • unknown's avatar
      475b8ee9
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 68b1b66b
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/27759-bug-5.0-opt-mysql
      
      68b1b66b
    • unknown's avatar
      Additional fix for the bug#27759: Wrong DATE/DATETIME comparison in LEAST()/GREATEST() functions. · b49ab780
      unknown authored
      
      mysql-test/t/type_datetime.test:
        Additional test case for the bug#27759.
      sql/item_func.h:
        Bug#27759: Wrong DATE/DATETIME comparison in LEAST()/GREATEST() functions.
        Now the Item_func_min_max::result_as_longlong() returns TRUE when LEAST()
        compares DATE/DATETIME values. This allows caller to obtain correct integer
        values through the val_int() function.
      b49ab780
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/mysql-5.0-opt · 64409658
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/mysql-5.0-opt-27954
      
      64409658
    • unknown's avatar
      Merge xiphis.org:/home/antony/work2/mysql-5.1-engines · 1bfcd5b6
      unknown authored
      into  xiphis.org:/home/antony/work2/mysql-5.1-merge
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      1bfcd5b6
    • unknown's avatar
      Fixed bug #27954. · 72142bbe
      unknown authored
      This bug affects multi-row INSERT ... ON DUPLICATE into table
      with PRIMARY KEY of AUTO_INCREMENT field and some additional UNIQUE indices.
      If the first row in multi-row INSERT contains duplicated values of UNIQUE
      indices, then following rows of multi-row INSERT (with either duplicated or
      unique key field values) may me applied to _arbitrary_ records of table as
      updates.
      This bug was introduced in 5.0. Related code was widely rewritten in 5.1, and
      5.1 is already free of this problem. 4.1 was not affected too.
      
      When updating the row during INSERT ON DUPLICATE KEY UPDATE, we called
      restore_auto_increment(), which set next_insert_id back to 0, but we
      forgot to set clear_next_insert_id back to 0.
      restore_auto_increment() function has been fixed.
      
      
      sql/sql_class.h:
        Fixed bug #27954.
        Added commentary for THD::clear_next_insert_id variable.
      sql/handler.cc:
        Fixed bug #27954.
        When updating the row during INSERT ON DUPLICATE KEY UPDATE, we called
        restore_auto_increment(), which set next_insert_id back to 0, but we
        forgot to set clear_next_insert_id back to 0.
        restore_auto_increment() function has been fixed.
      mysql-test/t/insert_update.test:
        Added test case for bug #27954.
      mysql-test/r/insert_update.result:
        Added test case for bug #27954.
      72142bbe
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 3dbf6079
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/28133-bug-5.0-opt-mysql
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      mysql-test/r/type_datetime.result:
        SCCS merged
      mysql-test/t/type_datetime.test:
        SCCS merged
      3dbf6079
    • unknown's avatar
      Bug#28133: Wrong DATE/DATETIME comparison in IN() function. · 2d9c93ce
      unknown authored
      The IN function was comparing DATE/DATETIME values either as ints or as
      strings. Both methods have their disadvantages and may lead to a wrong
      result.
      
      Now IN function checks whether all of its arguments has the STRING result
      types and at least one of them is a DATE/DATETIME item. If so it uses either
      an object of the in_datetime class or an object of the cmp_item_datetime
      class to perform its work. If the IN() function arguments are rows then
      row columns are checked whether the DATE/DATETIME comparator should be used
      to compare them.
      The in_datetime class is used to find occurence of the item to be checked
      in the vector of the constant DATE/DATETIME values. The cmp_item_datetime
      class is used to compare items one by one in the DATE/DATETIME context.
      Both classes obtain values from items with help of the get_datetime_value()
      function and cache the left item if it is a constant one.
      
      
      
      mysql-test/t/type_datetime.test:
        Added a test case for the bug#28133: Wrong DATE/DATETIME comparison in IN() function.
      mysql-test/r/type_datetime.result:
        Added a test case for the bug#28133: Wrong DATE/DATETIME comparison in IN() function.
      mysql-test/r/func_in.result:
        A test case result is corrected after the fix for the bug#28133.
      sql/item_cmpfunc.h:
        Bug#28133: Wrong DATE/DATETIME comparison in IN() function.
        Two DATE/DATETIME comparison classes are added.
        The in_datetime class is used to find occurence of the item to be checked
        in the vector of the constant DATE/DATETIME values. The cmp_item_datetime
        class is used to compare items one by one in the DATE/DATETIME context.
        Both classes obtain values from items with help of the get_datetime_value()
        function and cache the left item if it is a constant one.
      sql/item_cmpfunc.cc:
        Bug#28133: Wrong DATE/DATETIME comparison in IN() function.
        Now IN function checks whether all of its arguments has the STRING result
        types and at least one of them is a DATE/DATETIME item. If so it uses either
        an object of the in_datetime class or an object of the cmp_item_datetime
        class to perform its work. If the IN() function arguments are rows then
        row columns are checked whether the DATE/DATETIME comparator should be used
        to compare them.
      2d9c93ce
    • unknown's avatar
      item_func.cc: · bfe9139b
      unknown authored
        Fixed compiler warnings.
      
      
      sql/item_func.cc:
        Fixed compiler warnings.
      bfe9139b
    • unknown's avatar
      merging fix · 218af4b7
      unknown authored
      
      mysql-test/r/sp-vars.result:
        merging
      218af4b7