1. 03 Aug, 2006 1 commit
    • unknown's avatar
      Bug#18775 - Temporary table from alter table visible to other threads · 37569297
      unknown authored
      New test cases. Names with umlauts don't compare well on Windows.
      
      
      mysql-test/r/alter_table.result:
        Bug#18775 - Temporary table from alter table visible to other threads
        New test results
      mysql-test/r/backup.result:
        Bug#18775 - Temporary table from alter table visible to other threads
        New test results
      mysql-test/t/alter_table.test:
        Bug#18775 - Temporary table from alter table visible to other threads
        New test case. Names with umlauts don't compare well on Windows.
      mysql-test/t/backup.test:
        Bug#18775 - Temporary table from alter table visible to other threads
        New test case. Names with umlauts don't compare well on Windows.
      37569297
  2. 02 Aug, 2006 3 commits
    • unknown's avatar
      Bug#18775 - Temporary table from alter table visible to other threads · 423fdfa2
      unknown authored
      Reverting part of the patch. NDB has unencoded names in their
      data dictionary.
      
      423fdfa2
    • unknown's avatar
      Merge istruewing@bk-internal.mysql.com:/home/bk/mysql-5.1-engines · d06a2ed5
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.1-bug18775
      
      
      sql/ha_myisam.cc:
        Auto merged
      sql/ha_myisammrg.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_partition.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_trigger.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      sql/sql_db.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Manual merge
      d06a2ed5
    • unknown's avatar
      Bug#18775 - Temporary table from alter table visible to other threads · 4cf97d4a
      unknown authored
      Continued implementation of WL#1324 (table name to filename encoding)
      
      The intermediate (not temporary) files of the new table
      during ALTER TABLE was visible for SHOW TABLES. These
      intermediate files are copies of the original table with
      the changes done by ALTER TABLE. After all the data is
      copied over from the original table, these files are renamed 
      to the original tables file names. So they are not temporary 
      files. They persist after ALTER TABLE, but just with another 
      name.
      
      In 5.0 the intermediate files are invisible for SHOW TABLES
      because all file names beginning with "#sql" were suppressed.
      
      This failed since 5.1.6 because even temporary table names were
      converted when making file names from them. The prefix became
      converted to "@0023sql". Converting the prefix during SHOW TABLES
      would suppress the listing of user tables that start with "#sql".
      
      The solution of the problem is to continue the implementation of
      the table name to file name conversion feature. One requirement
      is to suppress the conversion for temporary table names.
      
      This change is straightforward for real temporary tables as there
      is a function that creates temporary file names.
      
      But the generated path names are located in TMPDIR and have no
      relation to the internal table name. This cannot be used for
      ALTER TABLE. Its intermediate files need to be in the same
      directory as the old table files. And it is necessary to be
      able to deduce the same path from the same table name repeatedly.
      
      Consequently the intermediate table files must be handled like normal
      tables. Their internal names shall start with tmp_file_prefix
      (#sql) and they shall not be converted like normal table names.
      
      I added a flags parameter to all relevant functions that are
      called from ALTER TABLE. It is used to suppress the conversion
      for the intermediate table files.
      
      The outcome is that the suppression of #sql in SHOW TABLES
      works again. It does not suppress user tables as these are
      converted to @0023sql on file level.
      
      This patch does also fix ALTER TABLE ... RENAME, which could not 
      rename a table with non-ASCII characters in its name.
      
      It does also fix the problem that a user could create a table like
      `#sql-xxxx-yyyy`, where xxxx is mysqld's pid and yyyy is the thread
      ID of some other thread, which prevented this thread from running 
      ALTER TABLE.
      
      Some of the above problems are mentioned in Bug 1405, which can
      be closed with this patch.
      
      This patch does also contain some minor fixes for other forgotten
      conversions. Still known problems are reported as bugs 21370,
      21373, and 21387.
      
      
      mysql-test/r/alter_table.result:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added test results.
      mysql-test/r/backup.result:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added test results.
      mysql-test/r/repair.result:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added test results.
      mysql-test/t/alter_table.test:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added test cases.
      mysql-test/t/backup.test:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added test cases.
      mysql-test/t/repair.test:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added a test case.
      sql/ha_myisam.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added missing table name mapping calls to backup() and restore().
      sql/ha_myisammrg.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added an zero argument for the new 'flags' parameter.
      sql/ha_ndbcluster.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added an zero argument for the new 'flags' parameter.
      sql/ha_ndbcluster_binlog.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added an zero argument for the new 'flags' parameter.
      sql/ha_ndbcluster_binlog.h:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Removed unnecessary check for wrong temp file prefix.
      sql/mysql_priv.h:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Extended quick_rm_table(), mysql_rename_table(), and
        build_table_filename() by an flags argument, which can indicate
        temporary table names that should not be converted.
        Added symbolic flag values.
      sql/sql_acl.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added an zero argument for the new 'flags' parameter.
      sql/sql_base.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Fixed a comment.
        Added DBUG calls.
      sql/sql_db.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added an zero argument for the new 'flags' parameter.
      sql/sql_delete.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added an zero argument for the new 'flags' parameter.
      sql/sql_insert.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added an zero argument for the new 'flags' parameter.
      sql/sql_partition.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added an zero argument for the new 'flags' parameter.
      sql/sql_rename.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added an zero argument for the new 'flags' parameter.
      sql/sql_show.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Reverted the former fix for this bug. tmp_file_prefix is now used
        verbatim in the comparison of file names.
      sql/sql_table.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added a check for a tmp_file_prefix file name to
        filename_to_tablename(). These names are now accepted without
        conversion.
        Extended quick_rm_table(), mysql_rename_table(), and
        build_table_filename() by an flags argument, which can indicate
        temporary table names that should not be converted.
        Removed the table to file name conversion from
        build_tmptable_filename().
        Disabled REPAIR TABLE ... USE_FRM for temporary tables.
        Added the forgotten conversion to mysql_alter_table() for the case
        of ALTER TABLE ... RENAME.
        Added comments and DBUG calls.
      sql/sql_trigger.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added an zero argument for the new 'flags' parameter.
      sql/sql_view.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Added an zero argument for the new 'flags' parameter.
      sql/table.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Replaced a literal ".frm" by reg_ext.
        Added DBUG calls.
      storage/innobase/row/row0mysql.c:
        Bug#18775 - Temporary table from alter table visible to other threads
        Continued implementation of WL#1324 (table name to filename encoding)
        Changed back the encoded temp file prefix to #sql.
      4cf97d4a
  3. 30 Jul, 2006 2 commits
  4. 29 Jul, 2006 3 commits
  5. 27 Jul, 2006 2 commits
    • unknown's avatar
      BUG #21118 "Federated Transaction test needs to have BDB switched to InnoDB" · c91846ec
      unknown authored
      recommented the uncommented have_innodb.inc line
      
      federated_transactions.test:
         BUG #21118 "Federated Transaction test needs to have BDB switched to InnoDB"
        slight ommission fixed
      
      
      mysql-test/t/federated_transactions.test:
         BUG #21118 "Federated Transaction test needs to have BDB switched to InnoDB"
        slight ommission fixed
      c91846ec
    • unknown's avatar
      BUG #21118 "Federated Transaction test needs to have BDB switched to InnoDB" · 8c8c6ac0
      unknown authored
      Changed federated_transactions.test to use InnoDB instead of BDB
      
      federated_transactions-slave.opt:
        BitKeeper file /home/patg/mysql-build/mysql-5.1-engines-bug21118/mysql-test/t/federated_transactions-slave.opt
      federated_transactions.result:
        BUG #21118 "Federated Transaction test needs to have BDB switched to InnoDB"
        New test results for InnoDB being remote transactional table
      federated_transactions.test:
        BUG #21118 "Federated Transaction test needs to have BDB switched to InnoDB"
        Changed remote transactional table from BDB to InnoDB
      
      
      mysql-test/t/federated_transactions.test:
        BUG #21118 "Federated Transaction test needs to have BDB switched to InnoDB"
        Changed remote transactional table from BDB to InnoDB
      mysql-test/r/federated_transactions.result:
        BUG #21118 "Federated Transaction test needs to have BDB switched to InnoDB"
        New test results for InnoDB being remote transactional table
      mysql-test/t/federated_transactions-slave.opt:
        BitKeeper file /home/patg/mysql-build/mysql-5.1-engines-bug21118/mysql-test/t/federated_transactions-slave.opt
      8c8c6ac0
  6. 26 Jul, 2006 4 commits
  7. 25 Jul, 2006 1 commit
  8. 24 Jul, 2006 4 commits
    • unknown's avatar
      After merge fix · 7a043e00
      unknown authored
      7a043e00
    • unknown's avatar
      After merge fix · 6fac20e9
      unknown authored
      6fac20e9
    • unknown's avatar
      After merge fix · f74c4a06
      unknown authored
      f74c4a06
    • unknown's avatar
      Merge istruewing@bk-internal.mysql.com:/home/bk/mysql-5.0 · 050aa61e
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.1-amerge
      
      
      mysql-test/r/merge.result:
        Auto merged
      mysql-test/t/merge.test:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      storage/ndb/include/kernel/GlobalSignalNumbers.h:
        Auto merged
      storage/ndb/src/common/debugger/signaldata/SignalNames.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        Auto merged
      storage/ndb/test/run-test/daily-basic-tests.txt:
        Auto merged
      configure.in:
        Manual merge
      mysql-test/extra/binlog_tests/blackhole.test:
        Manual merge
      mysql-test/r/binlog_stm_blackhole.result:
        Manual merge
      sql/ha_myisammrg.cc:
        Manual merge
      sql/handler.h:
        Manual merge
      storage/blackhole/ha_blackhole.cc:
        Manual merge
      support-files/mysql.spec.sh:
        Manual merge
      050aa61e
  9. 23 Jul, 2006 2 commits
    • unknown's avatar
      BUG#20294 Instance manager test im_instance_conf fails randomly · 599df8dc
      unknown authored
      (well, im_options in this case, but using existing bug report)
      
      
      mysql-test/t/disabled.def:
        disable im_options test as it's non-deterministic. reopen bug
      599df8dc
    • unknown's avatar
      Merge willster.(none):/home/stewart/Documents/MySQL/5.0/main · f20a8c91
      unknown authored
      into  willster.(none):/home/stewart/Documents/MySQL/5.1/main
      
      
      BitKeeper/etc/config:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      storage/ndb/src/kernel/blocks/ERROR_codes.txt:
        Auto merged
      storage/ndb/src/kernel/blocks/dbtup/Dbtup.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbtup/DbtupTabDesMan.cpp:
        Auto merged
      storage/ndb/test/ndbapi/testDict.cpp:
        Auto merged
      storage/ndb/test/run-test/daily-basic-tests.txt:
        Auto merged
      mysql-test/Makefile.am:
        manual merge
      storage/ndb/src/kernel/blocks/dbtup/DbtupMeta.cpp:
        manual merge
      f20a8c91
  10. 22 Jul, 2006 4 commits
  11. 21 Jul, 2006 4 commits
    • unknown's avatar
      Merge istruewing@bk-internal.mysql.com:/home/bk/mysql-4.1 · b90cb0f4
      unknown authored
      into  chilla.local:/home/mydev/mysql-4.1
      
      b90cb0f4
    • unknown's avatar
      Merge istruewing@bk-internal.mysql.com:/home/bk/mysql-5.0-engines · 972f9945
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0
      
      972f9945
    • unknown's avatar
      Bug#20719 - Reading dynamic records with write buffer could fail · 11cee384
      unknown authored
      Fixed a possible problem with reading of dynamic records
      when a write cache is active. The cache must be flushed
      whenever a part of the file in the write cache is to be 
      read.
      
      Added a read optimization to _mi_read_dynamic_record().
      
      No test case. This was a hypothetical but existing problem.
      
      
      myisam/mi_dynrec.c:
        Bug#20719 - Reading dynamic records with write buffer could fail
        
        Fixed a possible problem with reading of dynamic records
        when a write cache is active. The cache must be flushed
        whenever a part of the file in the write cache is to be 
        read. This must be done before the read of the header
        and before the read of the rest block.
        
        Renamed the 'flag' and 'skipp_deleted_blocks' variables.
        
        Added a read optimization to _mi_read_dynamic_record()
        that was present in _mi_read_rnd_dynamic_record() already.
        After _mi_get_block_info() we have some bytes of the record
        in the header buffer already. No need to read them again.
      11cee384
    • unknown's avatar
      After merge fixes. · 7197ed35
      unknown authored
      7197ed35
  12. 20 Jul, 2006 4 commits
    • unknown's avatar
      Bug#19939 · d035cc46
      unknown authored
        AUTHORS and CONTRIBUTORS are not reserved keywords.
      
      
      mysql-test/r/keywords.result:
        Bug#19939
          Test for bug
      mysql-test/t/keywords.test:
        Bug#19939
          Test for bug
      d035cc46
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-mmerge · eae506f1
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.1-amain
      
      
      configure.in:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      libmysqld/libmysqld.c:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/r/federated.result:
        Auto merged
      mysql-test/r/func_sapdb.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/gis-rtree.result:
        Auto merged
      mysql-test/r/gis.result:
        Auto merged
      mysql-test/r/key.result:
        Auto merged
      mysql-test/r/myisam.result:
        Auto merged
      mysql-test/r/symlink.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      mysql-test/t/func_sapdb.test:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/gis.test:
        Auto merged
      mysql-test/t/key.test:
        Auto merged
      mysql-test/t/myisam.test:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_geofunc.h:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/opt_sum.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_trigger.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      storage/myisam/mi_check.c:
        Auto merged
      storage/myisam/mi_create.c:
        Auto merged
      storage/myisam/mi_dynrec.c:
        Auto merged
      storage/myisam/mi_key.c:
        Auto merged
      storage/ndb/include/kernel/GlobalSignalNumbers.h:
        Auto merged
      storage/ndb/src/common/debugger/signaldata/SignalNames.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/qmgr/QmgrMain.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        Auto merged
      support-files/mysql.spec.sh:
        Auto merged
      BitKeeper/deleted/.del-mysqld.vcproj~6aa7b3f9c3e28fcb:
        Manual merge
      include/my_sys.h:
        Manual merge
      mysql-test/t/federated.test:
        Manual merge
      sql/ha_federated.cc:
        Manual merge
      tests/Makefile.am:
        Manual merge
      eae506f1
    • unknown's avatar
      Merge orca.ndb.mysql.com:/space_old/pekka/ndb/version/my50-mrg · d7322da3
      unknown authored
      into  orca.ndb.mysql.com:/space_old/pekka/ndb/version/my51-mrg
      
      
      sql/ha_ndbcluster.cc:
        SCCS merged
      sql/handler.h:
        SCCS merged
      sql/sql_update.cc:
        SCCS merged
      storage/ndb/include/ndbapi/NdbIndexScanOperation.hpp:
        SCCS merged
      storage/ndb/include/ndbapi/NdbScanOperation.hpp:
        SCCS merged
      storage/ndb/src/kernel/blocks/dblqh/Dblqh.hpp:
        SCCS merged
      storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        SCCS merged
      storage/ndb/src/mgmsrv/ConfigInfo.cpp:
        SCCS merged
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        SCCS merged
      d7322da3
    • unknown's avatar
      BUG20733: Bug in partition pruning with zerofill field · 8592305b
      unknown authored
      Problem was with handling NULL values in ranges
      
      
      mysql-test/r/partition_hash.result:
        New partition pruning test cases
      mysql-test/r/partition_list.result:
        New partition pruning test cases
      mysql-test/r/partition_pruning.result:
        New partition pruning test cases
      mysql-test/r/partition_range.result:
        New partition pruning test cases
      mysql-test/t/partition_hash.test:
        New partition pruning test cases
      mysql-test/t/partition_list.test:
        New partition pruning test cases
      mysql-test/t/partition_pruning.test:
        New partition pruning test cases
      mysql-test/t/partition_range.test:
        New partition pruning test cases
      sql/opt_range.cc:
        Added comment
      sql/sql_partition.cc:
        Partition pruning didn't handle ranges with NULL values in a proper manner
      8592305b
  13. 18 Jul, 2006 5 commits
    • unknown's avatar
      Merge lmy004.:/work/mysql-5.1-runtime · 2b7227c1
      unknown authored
      into  lmy004.:/work/mysql-5.1-clean
      
      2b7227c1
    • unknown's avatar
      Fix windows build of libmysqld. Curious why pushbuild did not · bb5bbc8f
      unknown authored
      catch that.
      Stale CMakeLists.txt
      
      
      libmysqld/CMakeLists.txt:
        event_executor.cc is no more since a lot of time. it has
        been superseeded by event_scheduler.cc
      bb5bbc8f
    • unknown's avatar
      after merge fix · 714c9ad3
      unknown authored
      714c9ad3
    • unknown's avatar
      Merge myoffice.izhnet.ru:/usr/home/gluh/MySQL/tmp_merge · e26729d9
      unknown authored
      into  myoffice.izhnet.ru:/usr/home/gluh/MySQL/5.1
      
      
      mysql-test/r/sp_notembedded.result:
        Auto merged
      mysql-test/r/strict.result:
        Auto merged
      mysql-test/t/strict.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/table.h:
        Auto merged
      sql/handler.h:
        manual merge
      sql/table.cc:
        manual merge
      sql/unireg.cc:
        manual merge
      tests/mysql_client_test.c:
        SCCS merged
      e26729d9
    • unknown's avatar
      BUG#20340: NODEGROUP in information_schema.partitions integer => · 7bc8deab
      unknown authored
      error in error log when "default is put into it
      NODEGROUP string to cater for "default" in it
      
      
      mysql-test/r/ndb_partition_key.result:
        New test case
      mysql-test/t/ndb_partition_key.test:
        New test case
      sql/sql_show.cc:
        NODEGROUP string to cater for "default" in it
      7bc8deab
  14. 17 Jul, 2006 1 commit