1. 11 Jun, 2003 1 commit
    • unknown's avatar
      Bugfix for #614 · 376c509e
      unknown authored
      Item_extract needs special implementation for eq().
      Item_func::eq doesn't work correctly because we have to compare 
      Item_extract::int_type parameters also
      
      We need to propagate this to 4.1
      
      
      sql/item_timefunc.cc:
        Item_extract::eq implementation added
      sql/item_timefunc.h:
        Item_extract::eq definition added
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      376c509e
  2. 10 Jun, 2003 1 commit
    • unknown's avatar
      Don't install signal handler for SIGINT by default · 079a9a08
      unknown authored
      Added option --gdb
      Free memory used by replicate_xxx and binglog_xxx options
      
      
      mysql-test/mysql-test-run.sh:
        Added --gdb when using gdb
      mysys/thr_alarm.c:
        Safety check
      sql/mysql_priv.h:
        Don't install signal handler for SIGINT by default
      sql/mysqld.cc:
        Don't install signal handler for SIGINT by default
        Added option --gdb
        Free memory used by replicate_xxx and binglog_xxx options.
        Add statistics variable for killed threads
      sql/repl_failsafe.cc:
        Incremented aborted_connects on failure
      sql/sql_list.cc:
        Added free_list() to free memory on shutdown.
      079a9a08
  3. 06 Jun, 2003 3 commits
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.0 · f933dddf
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      f933dddf
    • unknown's avatar
      Fix for bug 254 : · 720138b6
      unknown authored
      we now make a distinction between if the master is < 3.23.57, 3.23 && >=57, and 4.x
      (before the 2 3.23 were one). This is because in 3.23.57 we have a way to distinguish between
      a Start_log_event written at server startup and one written at FLUSH LOGS, so we
      have a way to know if the slave must drop old temp tables or not.
      Change: mi->old_format was bool, now it's enum (to handle 3 cases). However, functions
      which had 'bool old_format' as an argument have their prototypes unchanged, because
      the old old_format == 0 now corresponds to the enum value BINLOG_FORMAT_CURRENT which
      is equal to 0, so boolean tests are left untouched. The only case were we use mi->old_format
      as an enum instead of casting it implicitly to a bool, is in Start_log_event::exec_event,
      where we want to distinguish between the 3 possible enum values.
      
      
      sql/log_event.cc:
        Fix for bug 254 :
        we now make a distinction between if the master is < 3.23.57, 3.23 && >=57, and 4.x
        (before the 2 3.23 were one), to know if the slave must drop old temp tables or not.
      sql/slave.cc:
        Fix for bug 254 : mi->old_format is now enum.
        An unrelated comment.
      sql/slave.h:
        fix for bug 254 : mi->old_format is now enum.
      720138b6
    • unknown's avatar
      sql_yacc.yy, sql_parse.cc, sql_lex.h, mysqld.cc, lex.h: · 7ef8b915
      unknown authored
        Add syntax SAVEPOINT id and ROLLBACK TO SAVEPOINT id. This is compatible with DB2 and Oracle but not with SQL Server. Savepoints do not do anything yet, this is just parsing.
      
      
      sql/lex.h:
        Add syntax SAVEPOINT id and ROLLBACK TO SAVEPOINT id. This is compatible with DB2 and Oracle but not with SQL Server. Savepoints do not do anything yet, this is just parsing.
      sql/mysqld.cc:
        Add syntax SAVEPOINT id and ROLLBACK TO SAVEPOINT id. This is compatible with DB2 and Oracle but not with SQL Server. Savepoints do not do anything yet, this is just parsing.
      sql/sql_lex.h:
        Add syntax SAVEPOINT id and ROLLBACK TO SAVEPOINT id. This is compatible with DB2 and Oracle but not with SQL Server. Savepoints do not do anything yet, this is just parsing.
      sql/sql_parse.cc:
        Add syntax SAVEPOINT id and ROLLBACK TO SAVEPOINT id. This is compatible with DB2 and Oracle but not with SQL Server. Savepoints do not do anything yet, this is just parsing.
      sql/sql_yacc.yy:
        Add syntax SAVEPOINT id and ROLLBACK TO SAVEPOINT id. This is compatible with DB2 and Oracle but not with SQL Server. Savepoints do not do anything yet, this is just parsing.
      7ef8b915
  4. 05 Jun, 2003 14 commits
  5. 04 Jun, 2003 7 commits
  6. 03 Jun, 2003 3 commits
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.0 · 2ef40ed8
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      2ef40ed8
    • unknown's avatar
      One-line fix for bug 576 (DBUG_ASSERT failure when using CHANGE MASTER TO RELAY_LOG_POS=4). · af96483f
      unknown authored
      Plus a changeset which I had committed but forgot to push (and this changeset is lost on
      another computer, so I recreate it here). This changeset is "user-friendly SHOW BINLOG EVENTS
      and CHANGE MASTER TO when log positions < 4 are used.
      
      
      sql/slave.cc:
        fix for bug 576 (DBUG_ASSERT failure when using CHANGE MASTER TO RELAY_LOG_POS=4).
      sql/sql_repl.cc:
        User-friendly SHOW BINLOG EVENTS:
        SHOW BINLOG EVENTS FROM 0: currently one gets
            MASTER> show binlog events from 0;
            ERROR 1220: Error when executing command SHOW BINLOG EVENTS: Invalid log position
        so we silently convert <4 to 4.
      sql/sql_yacc.yy:
        User-friendly CHANGE MASTER TO:
        presently when one does CHANGE MASTER TO MASTER_LOG_POS=0 he gets
            030425 10:12:41  Slave I/O thread: connected to master 'root@localhost:3306',  r
            eplication started in log 'gbichot-bin.013' at position 151
            030425 10:12:41  Error reading packet from server: Client requested master to st
            art replication from impossible position (server_errno=1236)
            030425 10:12:41  Got fatal error 1236: 'Client requested master to start replica
            tion from impossible position' from master when reading data from binary log
            030425 10:12:41  Slave I/O thread exiting, read up to log 'gbichot-bin.013', pos
            ition 151
            
        while she/he probably just wanted to start at the beginning of the
        binlog, which is 4. So we silently convert <4 to 4 in sql_yacc.yy
        (i.e. in the slave code; fortunately all versions have the same
        BIN_LOG_HEADER_SIZE=4 and we should not change this). See comments
        for an explaination of why we have to do this in sql_yacc.yy,
        not in sql_repl.cc.
        Same thing for CHANGE MASTER TO RELAY_LOG_POS.
      sql/unireg.h:
        warning comment
      af96483f
    • unknown's avatar
      -- Waiting for Monty's approval before push -- · cbc7a860
      unknown authored
      Bug 571: play LOAD DATA INFILE the same way on the slave as it was on the master: 
      if it was with IGNORE, do it with IGNORE,
      if it was with REPLACE, do it with REPLACE,
      and (the change) if it was with nothing, do it with nothing (not with IGNORE !!).
      Bug 573: print a proper error message in case of duplicate entry in LOAD DATA INFILE
      on the slave, i.e. a message where the keyname and key value appear :
      'Duplicate entry '1' for key 1' and not 'Duplicate entry '%-.64s' for key %d'
      
      
      mysql-test/r/rpl_loaddata.result:
        result update
      mysql-test/t/rpl_loaddata.test:
        check if duplicate entries on the slave trigger an error 
        when the slave replicates LOAD DATA INFILE (without IGNORE or REPLACE)
        (bug 571).
      sql/log_event.cc:
        Bug 571: play LOAD DATA INFILE the same way on the slave as it was on the master: 
        if it was with IGNORE, do it with IGNORE,
        if it was with REPLACE, do it with REPLACE,
        and (the change) if it was with nothing, do it with nothing (not with IGNORE !!).
        Bug 573: print a proper error message in case of duplicate entry in LOAD DATA INFILE
        on the slave, i.e. a message where the keyname and key value appear :
        'Duplicate entry '1' for key 1' and not 'Duplicate entry '%-.64s' for key %d'
      cbc7a860
  7. 02 Jun, 2003 8 commits
    • unknown's avatar
      Merge lgrimmer@build.mysql.com:/home/bk/mysql-4.0 · 1363f91b
      unknown authored
      into mysql.com:/space/my/mysql-4.0
      
      1363f91b
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.0 · 1cc80579
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      1cc80579
    • unknown's avatar
      Clearer error message (in the customer's case, the relay log was corrupted, · 45838a27
      unknown authored
      not the master's binlog) (SW 1571).
      
      
      sql/slave.cc:
        Clearer error message (in the customer's case, the relay log was corrupted,
        not the master's binlog).
      45838a27
    • unknown's avatar
      os0sync.c: · 35ce8465
      unknown authored
        Do not try to reserve os_sync_mutex in shutdown after it has been freed
      
      
      innobase/os/os0sync.c:
        Do not try to reserve os_sync_mutex in shutdown after it has been freed
      35ce8465
    • unknown's avatar
      com0shm.c: · a1a4903b
      unknown authored
        Removed auto event creation because it is not needed in any MySQL/InnoDB code
      
      
      innobase/com/com0shm.c:
        Removed auto event creation because it is not needed in any MySQL/InnoDB code
      a1a4903b
    • unknown's avatar
      os0file.c: · 81b2b726
      unknown authored
        Put back Monty's patch which the previous push accidentally erased: print also operation type in os_file_handle_error()
      
      
      innobase/os/os0file.c:
        Put back Monty's patch which the previous push accidentally erased: print also operation type in os_file_handle_error()
      81b2b726
    • unknown's avatar
      os0thread.h, os0sync.ic, os0sync.h, os0thread.c, os0sync.c, os0file.c: · 919cec43
      unknown authored
        Release all event semaphores at shutdown also in Windows
      srv0start.c, srv0srv.c:
        make test sometimes failed because lock timeout thread exited without decrementing the InnoDB thread counter
      
      
      innobase/srv/srv0srv.c:
        make test sometimes failed because lock timeout thread exited without decrementing the InnoDB thread counter
      innobase/srv/srv0start.c:
        make test sometimes failed because lock timeout thread exited without decrementing the InnoDB thread counter
      innobase/os/os0file.c:
        Release all event semaphores at shutdown also in Windows
      innobase/os/os0sync.c:
        Release all event semaphores at shutdown also in Windows
      innobase/os/os0thread.c:
        Release all event semaphores at shutdown also in Windows
      innobase/include/os0sync.h:
        Release all event semaphores at shutdown also in Windows
      innobase/include/os0sync.ic:
        Release all event semaphores at shutdown also in Windows
      innobase/include/os0thread.h:
        Release all event semaphores at shutdown also in Windows
      919cec43
    • unknown's avatar
      Merge lgrimmer@build.mysql.com:/home/bk/mysql-4.0 · 876ff024
      unknown authored
      into mysql.com:/space/my/mysql-4.0
      
      
      BitKeeper/deleted/.del-internals.texi~62b6f580a41c2a43:
        Auto merged
      876ff024
  8. 01 Jun, 2003 3 commits
    • unknown's avatar
      Small fixes (nothing nameworthy) · cd5fb92c
      unknown authored
      
      mysql-test/r/errors.result:
        Rename: mysql-test/r/err000001.result -> mysql-test/r/errors.result
      include/my_global.h:
        typedef for future functions that needs string length as an argument
      innobase/os/os0file.c:
        Added operation to error messages
      mysql-test/t/errors.test:
        Cleaned up file to new error number standard
      mysys/thr_alarm.c:
        Made end_thr_alarm() work also with internal alarm thread.
        (Not critical for MySQL)
      sql/mysqld.cc:
        Added sigemptyset() (bug found by valgrind)
        Removed some wrong usage of thd when writing variable values
      cd5fb92c
    • unknown's avatar
      Merge · 9d9bd91d
      unknown authored
      
      BitKeeper/deleted/.del-global.h~e80d28157acfdcb5:
        Auto merged
      BitKeeper/deleted/.del-internals.texi~62b6f580a41c2a43:
        Auto merged
      innobase/srv/srv0srv.c:
        Use local version. Heikki needs to check if the os_thread_sleep() should go to 4.0 or not
      9d9bd91d
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · c1166bb9
      unknown authored
      into narttu.mysql.fi:/my/mysql-4.0
      
      
      sql/mysql_priv.h:
        Auto merged
      c1166bb9