1. 11 Feb, 2008 7 commits
  2. 09 Feb, 2008 4 commits
  3. 08 Feb, 2008 16 commits
    • unknown's avatar
      BUG#33247: mysqlbinlog does not clean up after itself on abnormal termination · 5db7ee3e
      unknown authored
      Problem: mysqlbinlog does not free memory if an error happens.
      Fix: binlog-processing functions do not call exit() anymore. Instead, they
      print an error and return an error code. Error codes are propagated all
      the way back to main, and all allocated memory is freed on the way.
      
      
      client/mysqlbinlog.cc:
        - New error handling policy: functions processing binlogs don't just
          exit() anymore. Instead, they print a message and return an error
          status.
        - New policy for the global `mysql' and `glob_description_event': these
          are not passed as parameters anymore. The global pointer is used
          instead.
        - More error situations are detected and reported.
        - Better error messages: the program never terminates with exit status 1
          without explanation any more. Fixed spelling errors. Use consistent
          format of messages (a single line beginning with "ERROR: " or
          "WARNING: " and ending with "." is printed to stderr.)
        - New memory handling: memory is always freed on program termination.
        - Better comments: more functions are explained, doxygen is used, and
          more precise formulations in some existing comments.
      mysql-test/suite/binlog/r/binlog_base64_flag.result:
        Result file updated since output format of mysqlbinlog changed while the
        test was disabled.
      mysql-test/suite/binlog/t/binlog_killed.test:
        Mysqlbinlog now works as described when the binlog is open. Hence, the
        --force-if-open flag must be passed
      mysql-test/suite/binlog/t/binlog_killed_simulate.test:
        Mysqlbinlog now works as described when the binlog is open. Hence, the
        --force-if-open flag must be passed
      mysql-test/suite/binlog/t/disabled.def:
        Now that mysqlbinlog cleans up after itself on abnormal termination, we
        can enable this test again.
      5db7ee3e
    • unknown's avatar
      Bug#34424: query_cache_debug.test leads to valgrind warnings · 1e2a9caf
      unknown authored
      Disable the test case.
      
      
      mysql-test/t/disabled.def:
        Disable query_cache_debug.test.
      1e2a9caf
    • unknown's avatar
      Fix create.test: use latin1 instead ucs2. · d84f322a
      unknown authored
      d84f322a
    • unknown's avatar
      Fix -ansi -pedantic compilation error · 13e44e30
      unknown authored
      13e44e30
    • unknown's avatar
      Merge dipika.(none):/opt/local/work/mysql-5.0-runtime · cb603541
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.1-runtime
      
      
      configure.in:
        Manual merge.
      cb603541
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 81ac684b
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.1-runtime
      
      
      include/my_sys.h:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/suite/binlog/r/binlog_row_binlog.result:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/set_var.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      81ac684b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 65c7d300
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.0-runtime
      
      
      65c7d300
    • unknown's avatar
      Don't complain about a failure to write a log message if we were · d157f5fd
      unknown authored
      simply killed.
      
      
      sql/log.cc:
        Don't complain if were simply killed.
      d157f5fd
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · d6391bec
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.1-runtime
      
      
      d6391bec
    • unknown's avatar
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 25888fe3
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-runtime
      
      
      25888fe3
    • unknown's avatar
      Manual merge of Bug 33798 · 0c551b72
      unknown authored
      
      mysql-test/extra/binlog_tests/binlog.test:
        Manual merge of binlog test case for Bug#33798
      mysql-test/suite/binlog/r/binlog_row_binlog.result:
        Add test case result for Bug#33798
      mysql-test/suite/binlog/r/binlog_stm_binlog.result:
        Add test case result for Bug#33798
      sql/item.cc:
        Use new method which accepts a unsigned flag.
      0c551b72
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/mysql-5.0-runtime · 57c180c1
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-runtime
      
      
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      sql/item.cc:
        Auto merged
      mysql-test/extra/binlog_tests/binlog.test:
        Manual merge.
      mysql-test/suite/binlog/r/binlog_stm_binlog.result:
        Manual merge.
      57c180c1
    • unknown's avatar
      Bug#33798 prepared statements improperly handle large unsigned ints · 7d98c21c
      unknown authored
      The unsignedness of large integer user variables was not being
      properly preserved when feeded to prepared statements. This was
      happening because the unsigned flags wasn't being updated when
      converting the user variable is converted to a parameter.
      
      The solution is to copy the unsigned flag when converting the
      user variable to a parameter and take the unsigned flag into
      account when converting the integer to a string.
      
      
      mysql-test/r/binlog.result:
        Add test case result for Bug#33798
      mysql-test/r/ps.result:
        Add test case result for Bug#33798
      mysql-test/t/binlog.test:
        Add test case for Bug#33798
      mysql-test/t/ps.test:
        Add test case for Bug#33798
      sql/item.cc:
        Take the unsigned flag into account when converting the
        user variable.
      7d98c21c
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · fa842127
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.1-runtime
      
      
      fa842127
    • unknown's avatar
  4. 07 Feb, 2008 13 commits
    • unknown's avatar
      Bug#31891 Meaningful stack trace · d9831ae5
      unknown authored
      On crashes generate a user-friendly resolved and demangled stack
      trace when libc provides the necessary functions (newer libc on i386,
      x86_64, powerpc, ia64, alpha and s390). Otherwise print a numeric
      stack trace as before, relying on resolve_stack_dump utility.
      
      
      configure.in:
        Add check for backtrace headers, backtrace functions and if
        __cxa_demangle (libstdc++) is available at link time.
      sql/mysqld.cc:
        Print the value of the THD::killed variable when dumping. In
        some circumstances knowing if the thread was killed makes
        debugging easier.
      sql/stacktrace.c:
        Use the glibc backtrace function when available and demangle
        C++ function names if the __cxa_demangle function is available.
      sql/stacktrace.h:
        Locally export and wrap in C linkage the C++ function __cxa_demangle
        if available.
      d9831ae5
    • unknown's avatar
      Merge dipika.(none):/opt/local/work/mysql-5.0-runtime · ee0b7f38
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.1-runtime
      
      
      client/mysqltest.c:
        Auto merged
      ee0b7f38
    • unknown's avatar
      32ae4aef
    • unknown's avatar
      test update · 6c97f05f
      unknown authored
      6c97f05f
    • unknown's avatar
      WL#4078: Document binary format of binlog entries · 187e5c5f
      unknown authored
      Documented Table_map_log_event and packed integer format. Improved
      other documentation. No change outside comments.
      
      
      sql/log_event.h:
        Documented Table_map_log_event and packed integer format. Improved
        other documentation. No change outside comments.
      187e5c5f
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/bugs/32633-5.1 · 7b59d1e6
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-runtime
      
      
      sql/sp.cc:
        Auto merged
      7b59d1e6
    • unknown's avatar
      Merge pilot.mysql.com:/data/msvensson/mysql/mysql-5.0-runtime · df75b255
      unknown authored
      into  pilot.mysql.com:/data/msvensson/mysql/mysql-5.1-runtime
      
      
      client/mysqltest.c:
        Auto merged
      df75b255
    • unknown's avatar
      Merge pilot.mysql.com:/data/msvensson/mysql/bug31004/my51-bug31004 · 464245c9
      unknown authored
      into  pilot.mysql.com:/data/msvensson/mysql/mysql-5.1-runtime
      
      
      client/CMakeLists.txt:
        Auto merged
      client/mysqltest.c:
        Auto merged
      464245c9
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-runtime · 0ae3d194
      unknown authored
      into  pilot.mysql.com:/data/msvensson/mysql/mysql-5.1-runtime
      
      
      sql-common/client.c:
        Auto merged
      0ae3d194
    • unknown's avatar
      Merge pilot.mysql.com:/data/msvensson/mysql/bug31004/my50-bug31004 · 178f33e0
      unknown authored
      into  pilot.mysql.com:/data/msvensson/mysql/mysql-5.0-runtime
      
      
      client/mysqltest.c:
        Auto merged
      178f33e0
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1 · 1c48bea2
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      mysql-test/suite/binlog/t/binlog_old_versions.test:
        Auto merged
      1c48bea2
    • unknown's avatar
      Renaming some saved binary log files to avoid 99 characters · 2a482933
      unknown authored
      limit for v7 tar.
      
      
      mysql-test/suite/binlog/std_data/ver_5_1_17.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1_17.000001 -> mysql-test/suite/binlog/std_data/ver_5_1_17.001
      mysql-test/suite/binlog/std_data/ver_5_1_23.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1_23.000001 -> mysql-test/suite/binlog/std_data/ver_5_1_23.001
      mysql-test/suite/binlog/std_data/ver_5_1-telco.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1-telco.000001 -> mysql-test/suite/binlog/std_data/ver_5_1-telco.001
      mysql-test/suite/binlog/std_data/ver_5_1-wl2325_r.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1-wl2325_row.000001 -> mysql-test/suite/binlog/std_data/ver_5_1-wl2325_r.001
      mysql-test/suite/binlog/std_data/ver_5_1-wl2325_s.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1-wl2325_stm.000001 -> mysql-test/suite/binlog/std_data/ver_5_1-wl2325_s.001
      mysql-test/suite/binlog/std_data/bug32407.001:
        Rename: mysql-test/suite/binlog/std_data/binlog-bug32407.000001 -> mysql-test/suite/binlog/std_data/bug32407.001
      2a482933
    • unknown's avatar
      Bug#32633 Can not create any routine if SQL_MODE=no_engine_substitution · 1b6b7010
      unknown authored
      The problem is that one can not create a stored routine if sql_mode
      contains NO_ENGINE_SUBSTITUTION or PAD_CHAR_TO_FULL_LENGTH. Also when
      a event is created, the mode is silently lost if sql_mode contains one
      of the aforementioned.  This was happening because the table definitions
      which stored sql_mode values weren't being updated to accept new values
      of sql_mode.
      
      The solution is to update, in a backwards compatible manner, the various
      table definitions (columns) that store the sql_mode value to take into
      account the new possible values. One incompatible change is that if a event
      that is being created can't be stored to the mysql.event table, an error
      will be raised.
      
      The tests case also ensure that new SQL modes will be added to the mysql.proc
      and mysql.event tables, otherwise the tests will fail.
      
      
      mysql-test/r/events_bugs.result:
        Add test case result for Bug#32633
      mysql-test/r/information_schema.result:
        Update the sql_mode column definition.
      mysql-test/r/sp.result:
        Add test case result for Bug#32633
      mysql-test/r/system_mysql_db.result:
        Update the sql_mode column definition.
      mysql-test/t/events_bugs.test:
        Add test case for Bug#32633
      mysql-test/t/sp.test:
        Add test case for Bug#32633
      mysql-test/t/system_mysql_db_fix50117.test:
        Update the sql_mode column definition.
      scripts/mysql_system_tables.sql:
        Update the sql_mode column definition.
      scripts/mysql_system_tables_fix.sql:
        Update the sql_mode column definition.
      sql/event_db_repository.cc:
        Reset and restore SQL modes when storing and loading a
        event from the data dictionary. Also throw out a error
        if a store fails.
      sql/mysqld.cc:
        Add warning to avoid this problem in the future.
      sql-common/my_user.c:
        Truncate length if user name or host name does not fit
        in the buffer.
      sql/sp.cc:
        SQL mode of the thread must not effect data dictionary operations.
      1b6b7010