1. 26 Sep, 2022 1 commit
  2. 23 Sep, 2022 1 commit
  3. 21 Sep, 2022 2 commits
  4. 20 Sep, 2022 5 commits
  5. 19 Sep, 2022 13 commits
    • Vlad Lesin's avatar
      MDEV-29515 innodb.deadlock_victim_race is unstable · 5ab78cf3
      Vlad Lesin authored
      The test is unstable because 'UPDATE t SET b = 100' latches a page and
      waits for 'upd_cont' signal in lock_trx_handle_wait_enter sync point, then
      purge requests RW_X_LATCH on the same page, and then 'SELECT * FROM t
      WHERE a = 10 FOR UPDATE' requests RW_S_LATCH, waiting for RW_X_LATCH
      requested by purge. 'UPDATE t SET b = 100' can't release page latch as
      it waits for upd_cont signal, which must be emitted after 'SELECT * FROM
      t WHERE a = 10 FOR UPDATE' acquired RW_S_LATCH. So we have a deadlock,
      which is resolved by finishing the debug sync point wait by timeout, and
      the 'UPDATE t SET b = 100' releases it's record locks rolling back the
      transaction, and 'SELECT * FROM t WHERE a = 10 FOR UPDATE' is finished
      successfully instead of finishing by lock wait timeout.
      
      The fix is to forbid purging during the test by opening read view in a
      separate connection before the first insert into the table.
      
      Besides, 'lock_wait_end' syncpoint is not needed, as it enough to wait
      the end of the SELECT execution to let the UPDATE to continue.
      5ab78cf3
    • Daniel Bartholomew's avatar
      bump the VERSION · a762dad4
      Daniel Bartholomew authored
      a762dad4
    • Andrew Hutchings's avatar
      MDEV-29426 Fix memory leak in CONNECT JSON/BSON (#2255) · 65b4a2af
      Andrew Hutchings authored
      * MDEV-29426 Fix memory leak in CONNECT JSON/BSON
      
      If information is being gathered on JSON/BSON tables we leak the heap
      allocated to the table class. With this fix we close and cleanup
      instead, just as we do for XML tables.
      65b4a2af
    • Marko Mäkelä's avatar
      Fix clang -Wunused-but-set-variable · 5e959bc3
      Marko Mäkelä authored
      5e959bc3
    • Marko Mäkelä's avatar
      Merge innodb.cmake to CMakeLists.txt · 3ab4b260
      Marko Mäkelä authored
      The reason why mysql/mysql-server@8020cfac20c55a870a874446870d5e90bdc181ed
      split the files was some unit tests that never existed in the
      MariaDB Server code base. The storage/innobase/unittest/ works just fine
      with this file.
      
      This is reverting part of 2e814d47
      which applied InnoDB changes from MySQL 5.7.9.
      3ab4b260
    • Marko Mäkelä's avatar
      Cleanup: Remove HAVE_IB_LINUX_FUTEX · 73658ede
      Marko Mäkelä authored
      The futex system calls were introduced in Linux 2.6.0,
      which was released in December 2003. It should be safe to assume
      that the system calls are always available on the Linux kernels
      that MariaDB Server 10.3 would run on.
      73658ede
    • Marko Mäkelä's avatar
      Cleanup: Remove INNODB_COMPILER_HINTS · 4c8b65db
      Marko Mäkelä authored
      There should be no point to disable branch prediction hints or prefetch.
      4c8b65db
    • Marko Mäkelä's avatar
      InnoDB cleanup: Replace UNIV_LINUX, UNIV_SOLARIS, UNIV_AIX · c22dff21
      Marko Mäkelä authored
      Let us use the normal platform-specific preprocessor symbols
      __linux__, __sun__, _AIX instead of some homebrew ones.
      
      The preprocessor symbol UNIV_HPUX must have lost its meaning
      by f6deb00a (note: the symbol
      UNIV_HPUX10 is being checked for, but only UNIV_HPUX is defined).
      c22dff21
    • Marko Mäkelä's avatar
      MDEV-29559 Recovery of INSERT_HEAP_DYNAMIC into secondary index fails · fed0d85d
      Marko Mäkelä authored
      log_phys_t::apply(): When parsing an INSERT_HEAP_DYNAMIC record,
      allow ll==rlen to hold for the last part. A secondary index record
      may inherit all preceding bytes from the infimum pseudo-record.
      
      For INSERT_HEAP_REDUNDANT, some header bytes will always be present
      because the header will never be copied from the page infimum.
      We will tolerate ll==rlen also in that case to be consistent with
      the parsing of INSERT_HEAP_DYNAMIC.
      fed0d85d
    • Marko Mäkelä's avatar
      Correct typos in a function comment · bbf81b51
      Marko Mäkelä authored
      Thanks to Thirunarayanan Balathandayuthapani for spotting this.
      bbf81b51
    • Daniel Black's avatar
      Merge 10.4 into 10.5 · 3c8674ed
      Daniel Black authored
      3c8674ed
    • Ian Gilfillan's avatar
      Update 10.5 HELP contents · 01d78d31
      Ian Gilfillan authored
      01d78d31
    • Ian Gilfillan's avatar
      Update 10.4 HELP contents · ef784c4e
      Ian Gilfillan authored
      ef784c4e
  6. 15 Sep, 2022 4 commits
    • Daniel Black's avatar
      MDEV-16708: ps_missed_cmds test - HELP deconflict · 5e270ca2
      Daniel Black authored
      To make it possible to update the HELP text of UPDATE without
      changing this test every time, the test is changed to look
      for a faked help topic. A non-existant help topic generates
      different metadata and wasn't suitable as a test.
      
      Requested by Ian Gilfillan.
      
      Reviewed by Dmitry Shulga
      5e270ca2
    • Alexander Barkov's avatar
      A cleanup for MDEV-29446 Change SHOW CREATE TABLE to display default collation · 23a8654c
      Alexander Barkov authored
      Recording test results according to MDEV-29446 changes:
      
        mysql-test/suite/galera/r/galera_rsu_wsrep_desync.result
        mysql-test/suite/galera/r/galera_sync_wait_show.result
        mysql-test/suite/galera/r/lp1376747-4.result
        mysql-test/suite/s3/replication_partition.result
        mysql-test/suite/s3/replication_stmt.result
      23a8654c
    • Vladislav Vaintroub's avatar
      MDEV-29543 Windows: Unreadable dlerror() message on localized OS · 32bab2ce
      Vladislav Vaintroub authored
      Force using english for error messages (i.e ASCII) to avoid encoding
      mixup.
      32bab2ce
    • Alexander Barkov's avatar
      A cleanup for MDEV-29446 Change SHOW CREATE TABLE to display default collation · 2fd4d25d
      Alexander Barkov authored
      Recording test results according to MDEV-29446 changes:
      
        mysql-test/suite/galera/r/galera-features#117.result
        mysql-test/suite/galera/r/galera_can_run_toi.result
        mysql-test/suite/galera/r/wsrep_strict_ddl.result
        mysql-test/suite/s3/alter.result
        mysql-test/suite/s3/arguments.result
        mysql-test/suite/s3/basic.result
        mysql-test/suite/s3/encryption.result
        mysql-test/suite/s3/innodb.result
        mysql-test/suite/s3/mysqldump.result
        mysql-test/suite/s3/partition.result
        mysql-test/suite/s3/partition_move.result
        mysql-test/suite/s3/replication_delayed.result
        mysql-test/suite/s3/replication_mixed.result
      2fd4d25d
  7. 14 Sep, 2022 12 commits
    • Sergei Golubchik's avatar
      race condition in the test · 35e18c24
      Sergei Golubchik authored
      this test loads sql_errlog plugin. then in a second connection
      it triggers an error, this locks the plugin in that thd.
      then the plugin is uninstalled in the default connection.
      but that doesn't unload the plugin, as it's still locked. it'll
      auto-unload after the foo connection is closed. without an explicit
      disconnect it is closed after mysqltest exits and the post-test check
      might still see sql_errlog not fully unoaded.
      35e18c24
    • Sergei Golubchik's avatar
      MDEV-22647 Assertion `!check_audit_mask(mysql_global_audit_mask, event_class_mask)' · beffef9f
      Sergei Golubchik authored
      
      check_audit_mask(mysql_global_audit_mask, event_class_mask) is tested in
      mysql_audit_general_log() and then assert in mysql_audit_acquire_plugins()
      verifies that the condition still holds.
      But this code path is not protected by LOCK_audit_mask, so
      mysql_global_audit_mask can change its value between the if() and the
      assert. That is, the assert is invalid and will fire if the
      audit plugin is unloaded concurrently with mysql_audit_general_log().
      
      Nothing bad will happen in this case though, we'll just do a useless
      loop over all remaining installed audit plugins.
      
      That is, the fix is simply to remove the assert.
      beffef9f
    • Alexander Barkov's avatar
      A cleanup for MDEV-29446 Change SHOW CREATE TABLE to display default collation · b65ffe15
      Alexander Barkov authored
      Recording test results according to MDEV-29446 changes:
      
        mysql-test/suite/maria/max_length.result
      b65ffe15
    • Anel Husakovic's avatar
      Add missing comment and remove unnecessary initialization · b7928f75
      Anel Husakovic authored
      - Commit c8948b0d introduced `get_one_variable()` - updating missing argument.
      - Remove caller setting of empty string in `rpl_filter`, since underlying functions will do the same
        (commit 9584cbe7 introduced).
      
      Reviewed by: <brandon.nesterenko@mariadb.com>
      b7928f75
    • Alexander Barkov's avatar
      fe844c16
    • Vicențiu Ciorbaru's avatar
      MDEV-29509 execute granted indirectly (via roles) doesn't always work · 16b2bb90
      Vicențiu Ciorbaru authored
      The issue manifests due to a bug in mysql_routine_grant. This was a side
      effect of e46eea86 which fixed the problem of not giving appropriate error
      message (ER_NONEXISTING_PROC_GRANT) when a routine grant existed due to role
      inheritance.
      
      When granting a routine privilege, it is possible to have a GRANT_NAME
      entry already created from an inherited role, but with it's init_privs
      set to 0.
      
      In this case we must not create a *new* grant entry, but we must edit
      this grant entry to set its init_privs.
      
      Note that this case was already covered by MDEV-29458, however due to a
      forgotten "flush privileges;" the actual code path never got hit.
      Remove the flush privilege command as it was never intended to be there
      in the first place.
      16b2bb90
    • Vicențiu Ciorbaru's avatar
      5ad8cd93
    • Vicențiu Ciorbaru's avatar
      MDEV-29458: Role grant commands do not propagate all grants · 7735ba76
      Vicențiu Ciorbaru authored
      There was an issue in updating in-memory role datastructures when
      propagating role grants.
      
      The issue is that changing a particular role's privilege (on any
      privilege level, global, database, etc.)
      was done such that it overwrote the entire set of bits for that
      particular level of privileges.
      
      For example:
      grant select on *.* to r1 -> sets the access bits to r1 to select,
      regardless of what bits were present for role r1 (inherited from any
      other roles).
      
      Before this fix, the rights of role r1 were propagated to any roles r1
      was granted to, however the propagated rights did *not* include the
      complete rights r1 inherited from its own grants.
      
      For example:
        grant r2 to r1;
        grant select on *.* to r2;
        grant insert on *.* to r1; # This command completely disregards the
                                   # select privilege from r2.
      
      In order to correct this, ensure that before rights are propagated
      onwards, that the current's role rights have been updated from its
      grants.
      
      Additionally, the patch exposed a flaw in the DROP ROLE code.
      When deleting a role we removed all its previous grants, but what
      remained was the actual links of roles granted to the dropped role.
      Having these links present when propagating grants meant that we would
      have leftover ACL_xxx entries.
      
      Ensure that the links are removed before propagating grants.
      7735ba76
    • Vicențiu Ciorbaru's avatar
      MDEV-29465: Inherited columns privs for roles wrongly set mysql.tables_priv column · 145932a5
      Vicențiu Ciorbaru authored
      There was a bug in the ACL internal data structures GRANT_TABLE and
      GRANT_COLUMN. The semantics are: GRANT_TABLE::init_cols and
      GRANT_COLUMN::init_privs represent the bits that correspond to the
      privilege bits stored in the physical tables. The other struct members
      GRANT_TABLE::cols and GRANT_COLUMN::privs represent the actual access
      bits, as they may be modified through role grants.
      
      The error in logic was mixing the two fields and thus we ended up
      storing the logical access bits in the physical tables, instead of the
      physical (init_xxx) bits.
      
      This caused subsequent DBUG_ASSERT failures when dropping the involved
      roles.
      145932a5
    • Marko Mäkelä's avatar
      MDEV-18589 Assertion on info.page_size failed in xb_delta_open_matching_space · 3e3cfa89
      Marko Mäkelä authored
      xb_read_delta_metadata(): For ROW_FORMAT=COMPRESSED tables, initialize
      the info.zip_size with the physical page size and let info.page_size
      remain the logical page size, like xb_delta_open_matching_space()
      expects it to be ever since
      commit 0a1c3477 (MDEV-18493).
      3e3cfa89
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-29479 I_S.INNODB_SYS_TABLESPACES doesn't have temporary tablespace information · d7aefc0f
      Thirunarayanan Balathandayuthapani authored
      - innodb_sys_tablespaces view in information schema displays temporary
      tablespace information too.
      d7aefc0f
    • Alexander Barkov's avatar
      A cleanup for MDEV-29446 Change SHOW CREATE TABLE to display default collation · 289105e2
      Alexander Barkov authored
      Recording test results according to MDEV-29446 changes:
      
        mysql-test/suite/galera/r/MDEV-25494.result
        mysql-test/suite/galera/r/galera_ctas.result
        mysql-test/suite/galera/r/galera_schema.result
        mysql-test/suite/galera_3nodes/r/galera_wsrep_schema.result
        mysql-test/suite/galera_sr/r/galera_sr_create_drop.result
      289105e2
  8. 13 Sep, 2022 2 commits