1. 18 Oct, 2018 1 commit
  2. 17 Oct, 2018 5 commits
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · f454189c
      Marko Mäkelä authored
      f454189c
    • Marko Mäkelä's avatar
      MDEV-17483 Insert on delete-marked record can wrongly inherit old values for instantly added column · 2fa4ed03
      Marko Mäkelä authored
      row_ins_clust_index_entry_low(): Do not call dtuple_t::trim()
      before row_ins_clust_index_entry_by_modify(), so that the values
      of all columns will be available in row_upd_build_difference_binary().
      If applicable, the tuple can be trimmed in btr_cur_optimistic_update()
      or btr_cur_pessimistic_update(), which will be called by
      row_ins_clust_index_entry_by_modify().
      2fa4ed03
    • Marko Mäkelä's avatar
      MDEV-13564: Set innodb_safe_truncate=ON by default · 853a0a43
      Marko Mäkelä authored
      The setting innodb_safe_truncate=ON reduces compatibility with older
      versions of MariaDB and backup tools in two ways.
      
      First, we will be writing TRX_UNDO_RENAME_TABLE records, which older
      versions do not know about. These records could be misinterpreted if
      a DDL transaction was recovered and would be rolled back.
      Such rollback is only possible if the server was killed while
      an incomplete DDL transaction was persisted. On transaction completion,
      the insert_undo log pages would only be repurposed for new undo log
      allocations, and their contents would not matter. So, older versions
      will not have a problem with innodb_safe_truncate=ON if the server was
      shut down cleanly.
      
      Second, to prevent such recovery failure, innodb_safe_truncate=ON will
      cause a modification of the redo log format identifier, which will
      prevent older versions from starting up after a crash. MariaDB Server
      versions older than 10.2.13 will refuse to start up altogether, even
      after clean shutdown.
      
      A server restart with innodb_safe_truncate=OFF will restore compatibility
      with older server and backup versions.
      853a0a43
    • Igor Babaev's avatar
      MDEV-17419 Subquery with group by returns wrong results · c2c1550f
      Igor Babaev authored
      Added only test case because the bug was fixed by the patch for mdev-17382.
      c2c1550f
    • Igor Babaev's avatar
      MDEV-17107 Assertion `table_list->table' failed in find_field_in_table_ref · dc3f5594
      Igor Babaev authored
      Added only test case because the bug was fixed by the patch for mdev-16992.
      dc3f5594
  3. 16 Oct, 2018 3 commits
    • Varun Gupta's avatar
      MDEV-17137: Syntax errors with VIEW using MEDIAN · 97a37edc
      Varun Gupta authored
      The syntax error happened because we had not implemented a different print for
      percentile functions. The syntax is a bit different when we use percentile functions
      as window functions in comparision to normal window functions.
      Implemented a seperate print function for percentile functions
      97a37edc
    • Andrei Elkin's avatar
      MDEV-17098 DATE -> DATETIME replication conversion not working, even in ALL_NON_LOSSY mode · 2308b9af
      Andrei Elkin authored
      Opened up MYSQL_TYPE _DATETIME{,2} <-> _NEWDATE conversions for replication.
      2308b9af
    • Marko Mäkelä's avatar
      MDEV-17466 Virtual column value not available during purge · 2d4075e1
      Marko Mäkelä authored
      row_build_index_entry_low(): Assert that when the value of a
      virtual column is not available, this can only happen when
      the index creation was completed but not committed yet.
      
      This change is not fixing any bug, making a debug assertion
      stricter, so that bugs can be caught in the future.
      
      Ultimately, we should change the InnoDB undo log format so that
      all actual secondary index keys are stored there, also for
      virtual or spatial indexes. In that way, purge and rollback would
      be more straightforward.
      2d4075e1
  4. 14 Oct, 2018 2 commits
    • Igor Babaev's avatar
      MDEV-17222 Reproducible server crash in String_list::append_str or · 103b1df5
      Igor Babaev authored
                 in Field_iterator_table::create_item
      
      When IN predicate is converted to IN subquery we have to ensure that
      any item from the select list of the subquery has some name and this name
      is unique across the select list.
      This was not guaranteed by the code before the patch for MDEV-17222.
      If the name of an item of the select list was not set, and this happened
      for binary constants, then the server crashed. If the first row in the IN
      list contained the same constant in two different positions then the server
      returned an error message.
      This was fixed by providing all constants in the first row of the IN list
      with generated names.
      103b1df5
    • Varun Gupta's avatar
      MDEV-16990:server crashes in base_list_iterator::next · af6077b5
      Varun Gupta authored
      When we have a query which has implicit_grouping then we are sure that we would end up with only one
      row so there is no point to do DISTINCT computation
      af6077b5
  5. 13 Oct, 2018 4 commits
  6. 12 Oct, 2018 5 commits
  7. 11 Oct, 2018 10 commits
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 7e869a27
      Marko Mäkelä authored
      7e869a27
    • Marko Mäkelä's avatar
      MDEV-17433 Allow InnoDB start up with empty ib_logfile0 from mariabackup --prepare · 81a5b6cc
      Marko Mäkelä authored
      A prepared backup from Mariabackup does not really need to contain any
      redo log file, because all log will have been applied to the data files.
      
      When the user copies a prepared backup to a data directory (overwriting
      existing files), it could happen that the data directory already contained
      redo log files from the past. mariabackup --copy-back) would delete the
      old redo log files, but a user’s own copying script might not do that.
      To prevent corruption caused by mixing an old redo log file with data
      files from a backup, starting with MDEV-13311, Mariabackup would create
      a zero-length ib_logfile0 that would prevent startup.
      
      Actually, there is no need to prevent InnoDB from starting up when a
      single zero-length file ib_logfile0 is present. Only if there exist
      multiple data files of different lengths, then we should refuse to
      start up due to inconsistency. A single zero-length ib_logfile0 should
      be treated as if the log files were missing: create new log files
      according to the configuration.
      
      open_log_file(): Remove. There is no need to open the log files
      at this point, because os_file_get_status() already determined
      the size of the file.
      
      innobase_start_or_create_for_mysql(): Move the creation of new
      log files a little later, not when finding out that the first log
      file does not exist, but after finding out that it does not exist
      or it exists as a zero-length file.
      81a5b6cc
    • Marko Mäkelä's avatar
      Fix a sign mismatch · b8944e89
      Marko Mäkelä authored
      b8944e89
    • Marko Mäkelä's avatar
      MDEV-13564: Replace innodb_unsafe_truncate with innodb_safe_truncate · 6319c0b5
      Marko Mäkelä authored
      Rename the 10.2-specific configuration option innodb_unsafe_truncate
      to innodb_safe_truncate, and invert its value.
      
      The default (for now) is innodb_safe_truncate=OFF, to avoid
      disrupting users with an undo and redo log format change within
      a Generally Available (GA) release series.
      6319c0b5
    • Alexander Barkov's avatar
    • Marko Mäkelä's avatar
      MDEV-13564: Null-merge 10.2 into 10.3 · 30629e19
      Marko Mäkelä authored
      We keep the MySQL 5.7 backup-incompatible TRUNCATE TABLE
      only in MariaDB Server 10.2. In 10.3 and later releases,
      only the backup-friendly TRUNCATE will be available.
      30629e19
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · ae9d82c9
      Marko Mäkelä authored
      ae9d82c9
    • Marko Mäkelä's avatar
      MDEV-13564: Implement innodb_unsafe_truncate=ON for compatibility · 3448ceb0
      Marko Mäkelä authored
      While MariaDB Server 10.2 is not really guaranteed to be compatible
      with Percona XtraBackup 2.4 (for example, the MySQL 5.7 undo log format
      change that could be present in XtraBackup, but was reverted from
      MariaDB in MDEV-12289), we do not want to disrupt users who have
      deployed xtrabackup and MariaDB Server 10.2 in their environments.
      
      With this change, MariaDB 10.2 will continue to use the backup-unsafe
      TRUNCATE TABLE code, so that neither the undo log nor the redo log
      formats will change in an incompatible way.
      
      Undo tablespace truncation will keep using the redo log only. Recovery
      or backup with old code will fail to shrink the undo tablespace files,
      but the contents will be recovered just fine.
      
      In the MariaDB Server 10.2 series only, we introduce the configuration
      parameter innodb_unsafe_truncate and make it ON by default. To allow
      MariaDB Backup (mariabackup) to work properly with TRUNCATE TABLE
      operations, use loose_innodb_unsafe_truncate=OFF.
      
      MariaDB Server 10.3.10 and later releases will always use the
      backup-safe TRUNCATE TABLE, and this parameter will not be
      added there.
      
      recv_recovery_rollback_active(): Skip row_mysql_drop_garbage_tables()
      unless innodb_unsafe_truncate=OFF. It is too unsafe to drop orphan
      tables if RENAME operations are not transactional within InnoDB.
      
      LOG_HEADER_FORMAT_10_3: Replaces LOG_HEADER_FORMAT_CURRENT.
      
      log_init(), log_group_file_header_flush(),
      srv_prepare_to_delete_redo_log_files(),
      innobase_start_or_create_for_mysql(): Choose the redo log format
      and subformat based on the value of innodb_unsafe_truncate.
      3448ceb0
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · 07815d95
      Marko Mäkelä authored
      07815d95
    • Marko Mäkelä's avatar
      940f0c78
  8. 10 Oct, 2018 5 commits
  9. 09 Oct, 2018 3 commits
  10. 08 Oct, 2018 2 commits
    • Andrei Elkin's avatar
      MDEV-17346 parallel slave start and stop races to workers disappeared · f517d8c7
      Andrei Elkin authored
      The bug appears as a slave SQL thread hanging in
      rpl_parallel_thread_pool::get_thread() while there are no slave worker
      threads to awake it.
      
      The reason of the hang is that at the parallel slave worker pool
      activation the being stared SQL thread could read the worker pool size
      concurrently with pool deactivation. At reading the SQL thread did not
      employ necessary protection from a race.
      
      Fixed with making the SQL thread at the pool activation first
      to grab the same lock as potential deactivator also does prior
      to access the pool size.
      f517d8c7
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-16980 Wrongly set tablename len while opening the · e9d9ca8c
      Thirunarayanan Balathandayuthapani authored
      			table for purge thread
      
      Problem:
      =======
      	Purge tries to fetch mdl lock for the whole table even though it tries
      to open one of the partition. But table name length was wrongly set to indicate
      the partition name too.
      
      Solution:
      ========
      - Table name length should identify the table name only not the partition name.
      e9d9ca8c